From unknown Sat Jul 12 18:46:14 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#59661] [PATCH 0/3] Add e2fsprogs to %base-packages-utils. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 28 Nov 2022 19:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 59661 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 59661@debbugs.gnu.org Cc: Maxim Cournoyer X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16696631215113 (code B ref -1); Mon, 28 Nov 2022 19:19:01 +0000 Received: (at submit) by debbugs.gnu.org; 28 Nov 2022 19:18:41 +0000 Received: from localhost ([127.0.0.1]:50397 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozjeL-0001KP-H1 for submit@debbugs.gnu.org; Mon, 28 Nov 2022 14:18:41 -0500 Received: from lists.gnu.org ([209.51.188.17]:49090) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozjeK-0001KJ-1I for submit@debbugs.gnu.org; Mon, 28 Nov 2022 14:18:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozjeJ-0002RS-Rm for guix-patches@gnu.org; Mon, 28 Nov 2022 14:18:39 -0500 Received: from mail-qt1-x82b.google.com ([2607:f8b0:4864:20::82b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ozjeI-0007nl-EK for guix-patches@gnu.org; Mon, 28 Nov 2022 14:18:39 -0500 Received: by mail-qt1-x82b.google.com with SMTP id jr19so7402491qtb.7 for ; Mon, 28 Nov 2022 11:18:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=mmBXCMJjudMbqbjrYw/1hHHM/87iMf49qEBTHht02gs=; b=pFmkfv2aLCm4Wz0XO5bP0s4OFd355UvqXoKTe6knpXOk0iIM26py2CZ8K1fk26loS8 c6yEgZ6VGSeWjGOdgwf5hoUsAjkfV0TKLTxilQ3vkSS1UNCnEk0mmsuj5vnvjxG7Z4IH 3SqpNyBVP2abQIyZ2u4gz5unEcRftuvrp9Trn73TrWSWaffLx2WiWwsRO3olR44XZN1X StA8fMU2kHwtrjiup7Oun/e/iHeo/hIF7NT2zsWk5pKVZo0Py7q0Yy0O7J+aPqZYvx6p j3myMgJPd4QNnDjnrUJbOkKOAgHquPWvv9ObpeZRrxEa1DkA0osIPotyIorHme7YDeQa khCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mmBXCMJjudMbqbjrYw/1hHHM/87iMf49qEBTHht02gs=; b=cDKUQ8AGw+9tcHWroDxEmIi81+6ThQU/0ulxjYFge7WsRBCmFIXWdj1aeMuqe5X8VQ PFslKR5dNNpGCn8FgnAY00T4YRlU/QLFHgmBjBvR/xz2NytvEw73vw2SI8v5/4wmDhX6 oi2I6MsUVTIcew9ppMv49uSuQ5jnFT5IHaNrmem56G9xSjvMmv0jBrbppvoQ6PoVap7Z TDEa6bdcOOjji2rec9vGzp9++8UC2hLEyHNL6JCgErFu2gzb13RSISKJQhgzFbP3oxww 6bUJb9q9CCw0zIRJ4KKnJDaeqlhB2EA7Zgb3Dei5b+MC1v3xm5Pmc6KHgJQ2ZAIwocT2 raGw== X-Gm-Message-State: ANoB5pn8nI3Jk+UblwOBvu/YQ6ZxU6vRFk9AZd2QNRduSexkv8ufAQuk EQ/p1qKwHdZRHUlkGIT4vbEW1rwCKAc= X-Google-Smtp-Source: AA0mqf5rEUmir1ihiXrPAbQoD2hW3Js2+VqKSA11lmmQ0u35r2xjLKhnQ/hj1mBvqopKWYt/T6CNwg== X-Received: by 2002:ac8:5296:0:b0:3a5:ab2c:38d6 with SMTP id s22-20020ac85296000000b003a5ab2c38d6mr34204169qtn.341.1669663116045; Mon, 28 Nov 2022 11:18:36 -0800 (PST) Received: from localhost.localdomain ([2607:fad8:4:3::1004]) by smtp.gmail.com with ESMTPSA id d16-20020a376810000000b006b640efe6dasm8659727qkc.132.2022.11.28.11.18.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Nov 2022 11:18:35 -0800 (PST) From: Maxim Cournoyer Date: Mon, 28 Nov 2022 14:18:31 -0500 Message-Id: <20221128191831.1325-1-maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::82b; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qt1-x82b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi Guix, Here's a simple series adjusting some annoyance noticed by someone on guix-help (no e2fsprogs in installer) and by myself (no lsattr/chattr on my system). Thank you, Maxim Cournoyer (3): system: Rename and move %base-packages-disk-utilities. install: Add missing e2fsprogs utility. system: Add e2fsprogs to %base-packages-utils. gnu/system.scm | 18 ++---------------- gnu/system/install.scm | 17 ++++++++++++++++- 2 files changed, 18 insertions(+), 17 deletions(-) base-commit: 059d38dc3f8b087f4a42df586daeb05761ee18d7 -- 2.38.1 From unknown Sat Jul 12 18:46:14 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#59661] [PATCH 1/3] system: Rename and move %base-packages-disk-utilities. References: <20221128191831.1325-1-maxim.cournoyer@gmail.com> In-Reply-To: <20221128191831.1325-1-maxim.cournoyer@gmail.com> Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 28 Nov 2022 20:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59661 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 59661@debbugs.gnu.org Cc: Maxim Cournoyer Received: via spool by 59661-submit@debbugs.gnu.org id=B59661.16696657197063 (code B ref 59661); Mon, 28 Nov 2022 20:02:02 +0000 Received: (at 59661) by debbugs.gnu.org; 28 Nov 2022 20:01:59 +0000 Received: from localhost ([127.0.0.1]:50588 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozkKF-0001pr-9d for submit@debbugs.gnu.org; Mon, 28 Nov 2022 15:01:59 -0500 Received: from mail-qk1-f178.google.com ([209.85.222.178]:38574) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozkKD-0001pi-OA for 59661@debbugs.gnu.org; Mon, 28 Nov 2022 15:01:58 -0500 Received: by mail-qk1-f178.google.com with SMTP id i9so8170094qkl.5 for <59661@debbugs.gnu.org>; Mon, 28 Nov 2022 12:01:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=qqn0QKbLK1uVyXq778hka5Ae8v7q41ZYfSAq9xBllTQ=; b=O/+psHTO0pxp/mt4S4dZ1lD2cbSqT9UEcB67iRXQMpTZn8v9Wb7fRjvDRuAQivZRyA C517+k+dvni//+dNyx+79oLM+Xk1b5B52OWvXXIJBES1kKBr17m4tj4HOuDzM6nm6vpZ sfn64Y2BIhSSk5u2dKskKi8CDzGElUMl9ymSqSFHAZbY8lSC4e+j3nBl0wbw7DT0VOO+ KcJ7FvNyrNm0MHwopAzZBMsPDuvhj4k5q6UtsOKUPykvlvHJuWcfzbzdPEJoprikwcLA Hmxafgul5n+3mH4clAMo+hs5AFxE+Zjyzm59pjqrdBHXKL/K7+qSyaa3C6ElBg97lWLo QgnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qqn0QKbLK1uVyXq778hka5Ae8v7q41ZYfSAq9xBllTQ=; b=2v6U2y2nJL5OM8cAAXUmrrpt7/2yIg0zEYKCVnuq+gLIYTfZMrFNS+pVbBqUK5TWYz Ef02Js90xeJ+r5uowgpZSA7VUyjnsO3uzm0WCl1ZAHF+XSpv5x1aDDaIug1u9si++Zly ragD/RJsigccJDCLAtHvz7DE9bMVuiGlXLjXXBBMdHASHj8twTQ+u83CFXLIUM8lNIMR q90t4Ewip+DxASK1LZnACQtoMWP5VyAwoeKdBZFqjFLel6CAZpySyHubpfbBbbP+xgw/ wmxxLNQzUvaKQhNf+sw4c3Eh2qh61pyyZ0o7/xVDqKZS580jHNmlx/cWB1CYVtDPJiYf x8zw== X-Gm-Message-State: ANoB5pkL4sufgFl4eoeGPo8NDtP5pXKRbikDugkDtYcNX7K5lr88/Ziz paQmP944HomdW3JtKZY95p83rYB44DmMfA== X-Google-Smtp-Source: AA0mqf56aYrtGEI5T12yTuu0My9b29uNyhfqb9Qrovt/vAcd27BaIcPBAA5rlaYbkaxxGF+NO1qpnQ== X-Received: by 2002:a05:620a:150c:b0:6f8:aafe:27e7 with SMTP id i12-20020a05620a150c00b006f8aafe27e7mr29688448qkk.590.1669665711958; Mon, 28 Nov 2022 12:01:51 -0800 (PST) Received: from localhost.localdomain ([2607:fad8:4:3::1004]) by smtp.gmail.com with ESMTPSA id fy15-20020a05622a5a0f00b0039cc64bcb53sm7431518qtb.27.2022.11.28.12.01.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Nov 2022 12:01:51 -0800 (PST) From: Maxim Cournoyer Date: Mon, 28 Nov 2022 15:01:43 -0500 Message-Id: <20221128200145.9078-1-maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Rationale: It is only used in INSTALLATION-OS and doesn't make sense to be used in another context, given that file systems now automatically pull their dependencies since commit 45eac6cdf5c8d9d7b0c564b105c790d2d2007799 (services: Add file system utilities to profile). * gnu/system.scm (%base-packages-disk-utilities): Rename to... * gnu/system/install.scm (%installer-disk-utilities): ... this. (installation-os) [packages]: Adjust accordingly. --- gnu/system.scm | 19 ------------------- gnu/system/install.scm | 19 ++++++++++++++++++- 2 files changed, 18 insertions(+), 20 deletions(-) diff --git a/gnu/system.scm b/gnu/system.scm index 3478afcec4..3241a18288 100644 --- a/gnu/system.scm +++ b/gnu/system.scm @@ -49,9 +49,6 @@ (define-module (gnu system) #:use-module (gnu packages bash) #:use-module (gnu packages compression) #:use-module (gnu packages cross-base) - #:use-module (gnu packages cryptsetup) - #:use-module (gnu packages disk) - #:use-module (gnu packages file-systems) #:use-module (gnu packages firmware) #:use-module (gnu packages gawk) #:use-module (gnu packages guile) @@ -180,7 +177,6 @@ (define-module (gnu system) %base-packages-interactive %base-packages-linux %base-packages-networking - %base-packages-disk-utilities %base-packages-utils %base-firmware %default-kernel-arguments)) @@ -896,21 +892,6 @@ (define %base-packages-networking ;; many people are familiar with, so keep it around. iw wireless-tools)) -(define %base-packages-disk-utilities - ;; A well-rounded set of packages for interacting with disks, - ;; partitions and filesystems, included with the Guix installation - ;; image. - (list parted gptfdisk ddrescue - ;; We used to provide fdisk from GNU fdisk, but as of version 2.0.0a - ;; it pulls Guile 1.8, which takes unreasonable space; furthermore - ;; util-linux's fdisk is already available, in %base-packages-linux. - cryptsetup mdadm - dosfstools - btrfs-progs - f2fs-tools - jfsutils - xfsprogs)) - (define %base-packages ;; Default set of packages globally visible. It should include anything ;; required for basic administrator tasks. diff --git a/gnu/system/install.scm b/gnu/system/install.scm index 003c49a3e7..d34d974338 100644 --- a/gnu/system/install.scm +++ b/gnu/system/install.scm @@ -48,6 +48,9 @@ (define-module (gnu system install) #:use-module (gnu packages bootloaders) #:use-module (gnu packages certs) #:use-module (gnu packages compression) + #:use-module (gnu packages cryptsetup) + #:use-module (gnu packages disk) + #:use-module (gnu packages file-systems) #:use-module (gnu packages fonts) #:use-module (gnu packages fontutils) #:use-module (gnu packages guile) @@ -458,6 +461,20 @@ (define %issue \x1b[1;33mUse Alt-F2 for documentation.\x1b[0m ") +(define %installer-disk-utilities + ;; A well-rounded set of packages for interacting with disks, partitions and + ;; file systems, included with the Guix installation image. + (list parted gptfdisk ddrescue + ;; We used to provide fdisk from GNU fdisk, but as of version 2.0.0a + ;; it pulls Guile 1.8, which takes unreasonable space; furthermore + ;; util-linux's fdisk is already available, in %base-packages-linux. + cryptsetup mdadm + dosfstools + btrfs-progs + f2fs-tools + jfsutils + xfsprogs)) + (define installation-os ;; The operating system used on installation images for USB sticks etc. (operating-system @@ -530,7 +547,7 @@ (define installation-os font-dejavu font-gnu-unifont grub ; mostly so xrefs to its manual work nss-certs) ; To access HTTPS, use git, etc. - %base-packages-disk-utilities + %installer-disk-utilities %base-packages)))) (define* (os-with-u-boot os board #:key (bootloader-target "/dev/mmcblk0") base-commit: 059d38dc3f8b087f4a42df586daeb05761ee18d7 -- 2.38.1 From unknown Sat Jul 12 18:46:14 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#59661] [PATCH 3/3] system: Add e2fsprogs to %base-packages-utils. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 28 Nov 2022 20:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59661 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 59661@debbugs.gnu.org Cc: Maxim Cournoyer Received: via spool by 59661-submit@debbugs.gnu.org id=B59661.16696657387114 (code B ref 59661); Mon, 28 Nov 2022 20:03:01 +0000 Received: (at 59661) by debbugs.gnu.org; 28 Nov 2022 20:02:18 +0000 Received: from localhost ([127.0.0.1]:50594 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozkKK-0001qd-Oo for submit@debbugs.gnu.org; Mon, 28 Nov 2022 15:02:18 -0500 Received: from mail-qk1-f172.google.com ([209.85.222.172]:43939) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozkKF-0001pk-92 for 59661@debbugs.gnu.org; Mon, 28 Nov 2022 15:02:00 -0500 Received: by mail-qk1-f172.google.com with SMTP id j26so8145426qki.10 for <59661@debbugs.gnu.org>; Mon, 28 Nov 2022 12:01:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NSylCTibZjp7m1hE3XvtbWlUB2TvaBdEmJZrqfjM63k=; b=aTpWgTn2aLgpUINgKEsfu4XnDCwICKDj3RCO5jWzduAGUyGPl57B2owTwrVQ9gWkJe KV5bw4cn9bliPcyN5UG+SvolHLgTO9kaVvW5g8d5X4fjYLawwXgndGU2NzOpd0MjdYL0 CMixDwp8Ox4I1BbK1sjR/MFYLrJUrG7KYZRnem7NwQYwMPu5zMu5nGlUtuV0AE7XajXa W+t4K6dBPKm20mAOLjn/6Rdo/CKkPwTZkobwXtryTwfHzqNOKrPXr9KJuyG6+N4+E3PR PC8xLM6ej+7wmIfdFHOucgGxYELlFzUDgJgzqCztb0DeEcmFXeGb9BOwuugeXoF0IqTe Ciaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NSylCTibZjp7m1hE3XvtbWlUB2TvaBdEmJZrqfjM63k=; b=0DIsJLzyH2LPqEpTu6YgwW7Q1T4lwajQZ7RjGNQ/KneXD4Bf7KMJMfCzH3JuYVF8oc shV/hppEak9SiZMHgIEsow+cxOCXsLpg0S0T4c4YpcWum6U+lGVx9l3syHpiy5+5bY/J PmJaKuDGFITjceZjPEOt49GEfnSbbniCO3peR4zLAyjlRRKviJiE74+Eol2NSfg37/BG btQMRY3G23EEwijdlXLc1C4N5PUMl8uTHq6OhVVQ1Q8DPKAaCtpf/M2iMbaMkwyHvnoI zga4hDdR58J9eNzdZaofUvNMbUKCos4Gd6EalIYtpD7QKiD234d1CBfdP17TMAMuo+6K Gy/w== X-Gm-Message-State: ANoB5pnq3sofECc+qaIRa7zTg/e3P9BIytjaU+T+T0Da/kfAI1Hf+3+b JdDK7Ga+P1sUYQASs/4wApckax3mMw2PJQ== X-Google-Smtp-Source: AA0mqf6L3oSY3eCW6Ug+yxcUjh+mvoQUgzuOBW819jhNeS5tCvsvEf+jllwjFrKssyehtHi00tQ5nQ== X-Received: by 2002:a05:620a:2114:b0:6ed:6067:fbd8 with SMTP id l20-20020a05620a211400b006ed6067fbd8mr47607658qkl.394.1669665713541; Mon, 28 Nov 2022 12:01:53 -0800 (PST) Received: from localhost.localdomain ([2607:fad8:4:3::1004]) by smtp.gmail.com with ESMTPSA id fy15-20020a05622a5a0f00b0039cc64bcb53sm7431518qtb.27.2022.11.28.12.01.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Nov 2022 12:01:53 -0800 (PST) From: Maxim Cournoyer Date: Mon, 28 Nov 2022 15:01:45 -0500 Message-Id: <20221128200145.9078-3-maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221128200145.9078-1-maxim.cournoyer@gmail.com> References: <20221128200145.9078-1-maxim.cournoyer@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Rationale: Even when not using an ext file system, the utilities provided by e2fsprogs are useful, for example to set the copy-on-write attribute of a Btrfs file system. * gnu/system.scm (%base-packages-utils): Add e2fsprogs. --- gnu/system.scm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gnu/system.scm b/gnu/system.scm index 3241a18288..84daf036f3 100644 --- a/gnu/system.scm +++ b/gnu/system.scm @@ -854,6 +854,8 @@ (define %base-packages-utils (cons* procps psmisc which (@ (gnu packages admin) shadow-with-man-pages) ;for 'passwd' + e2fsprogs ;for lsattr, chattr, etc. + guile-3.0-latest ;; The packages below are also in %FINAL-INPUTS, so take them from -- 2.38.1 From unknown Sat Jul 12 18:46:14 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#59661] [PATCH 2/3] install: Add missing e2fsprogs utility. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 28 Nov 2022 20:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59661 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 59661@debbugs.gnu.org Cc: Maxim Cournoyer Received: via spool by 59661-submit@debbugs.gnu.org id=B59661.16696657397120 (code B ref 59661); Mon, 28 Nov 2022 20:03:02 +0000 Received: (at 59661) by debbugs.gnu.org; 28 Nov 2022 20:02:19 +0000 Received: from localhost ([127.0.0.1]:50597 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozkKY-0001qj-JZ for submit@debbugs.gnu.org; Mon, 28 Nov 2022 15:02:18 -0500 Received: from mail-qv1-f51.google.com ([209.85.219.51]:36352) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozkKF-0001pj-TM for 59661@debbugs.gnu.org; Mon, 28 Nov 2022 15:02:00 -0500 Received: by mail-qv1-f51.google.com with SMTP id o12so7929271qvn.3 for <59661@debbugs.gnu.org>; Mon, 28 Nov 2022 12:01:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=USrw97BQ+wA+u7LpOawUOGHyLoQhAyyHg3otu5cOp9o=; b=e+Wj1lw2YWgJW5PEQfbLPONQNXoa3yjCL8S8z6pvV05poa4ZAESme/CCcYJaqYgAZC RTTKjZeUBgTjPTEiuZp6pfrOjrtmwRNXuakFDIvGPO0gtHMaA99BtPCBYFWDw8Dys3qB 8oL90chAbc7GgT6P9rikO4QQgkwENby525TVykY/AxqaVFJGqB/A64Potpvcipj+yvVT BQT3evXxIgkKhAxCTKt5mMYd5z0j5QFzdPx7HQ9vPcIFbsq1ilqmB2P4er3HPJhafqwE ZzsNq91WpRm08MWODIuZz5eD+2XSuENo1jEPvZSKlH7whDXxg0Ed+Kj+VoMYIRcoHqpU wS2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=USrw97BQ+wA+u7LpOawUOGHyLoQhAyyHg3otu5cOp9o=; b=iZOoJ98nOSbAya4Ip6DgYme3NwHFRm2hZp/ojbL04RCt7yVpXQBs7DX7Swn+rWjp2B gGOXjmFxTqrDi9rPm0WIiIdELLQmqCnuai5zTprpR2QL/Zgh5abrWEOsXU2//87TEulN etAbISgpGKIChIbNsY8w3Ui9zfCnCDoPzAts/uQqAXrljSjjtyYNGGwVAJ1uMf29uNHN axnwBtQmEPkbSNl+AbjMFQSnsYcNkQgm4ZVJppn0+okb5Pj9avnhW9nQDWR1pZVlfOAF ToYlSTQLc1LYg90AvOnoIZHY5+FmfH9Ev4yFPDDZe1JXuuX0Nzt0mV+3SgHMh9AqLB4L 9fGA== X-Gm-Message-State: ANoB5pmqkqcm1tPU12gkiFA5Cps3oVTvElrp+RV9HHjIQqTOKMdjYDLW HC/uEzCmaTPkaDoaDzdIVKBlu5MnAtlmuQ== X-Google-Smtp-Source: AA0mqf4KSBf56WoqPuhcsXUAg/bRHNRZZ0Qv5hkpKhKO5X58iwsOAd1g6qqKon1IlRlM+KMm/rlfSA== X-Received: by 2002:a05:6214:5bc2:b0:4c6:5a5f:3068 with SMTP id lr2-20020a0562145bc200b004c65a5f3068mr29740384qvb.118.1669665712737; Mon, 28 Nov 2022 12:01:52 -0800 (PST) Received: from localhost.localdomain ([2607:fad8:4:3::1004]) by smtp.gmail.com with ESMTPSA id fy15-20020a05622a5a0f00b0039cc64bcb53sm7431518qtb.27.2022.11.28.12.01.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Nov 2022 12:01:52 -0800 (PST) From: Maxim Cournoyer Date: Mon, 28 Nov 2022 15:01:44 -0500 Message-Id: <20221128200145.9078-2-maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221128200145.9078-1-maxim.cournoyer@gmail.com> References: <20221128200145.9078-1-maxim.cournoyer@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/system/install.scm (%installer-disk-utilities): Add e2fsprogs. --- gnu/system/install.scm | 1 + 1 file changed, 1 insertion(+) diff --git a/gnu/system/install.scm b/gnu/system/install.scm index d34d974338..f6f1923121 100644 --- a/gnu/system/install.scm +++ b/gnu/system/install.scm @@ -471,6 +471,7 @@ (define %installer-disk-utilities cryptsetup mdadm dosfstools btrfs-progs + e2fsprogs f2fs-tools jfsutils xfsprogs)) -- 2.38.1 From unknown Sat Jul 12 18:46:14 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#59661] [PATCH v2 1/3] system: Rename and move %base-packages-disk-utilities. References: <20221128191831.1325-1-maxim.cournoyer@gmail.com> In-Reply-To: <20221128191831.1325-1-maxim.cournoyer@gmail.com> Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 04 Dec 2022 04:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59661 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 59661@debbugs.gnu.org Cc: ludo@gnu.org, Maxim Cournoyer Received: via spool by 59661-submit@debbugs.gnu.org id=B59661.167012904323747 (code B ref 59661); Sun, 04 Dec 2022 04:45:02 +0000 Received: (at 59661) by debbugs.gnu.org; 4 Dec 2022 04:44:03 +0000 Received: from localhost ([127.0.0.1]:55167 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1grD-0006Ax-54 for submit@debbugs.gnu.org; Sat, 03 Dec 2022 23:44:03 -0500 Received: from mail-qv1-f51.google.com ([209.85.219.51]:45611) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1grB-0006AQ-Rb for 59661@debbugs.gnu.org; Sat, 03 Dec 2022 23:44:02 -0500 Received: by mail-qv1-f51.google.com with SMTP id d2so6137985qvp.12 for <59661@debbugs.gnu.org>; Sat, 03 Dec 2022 20:44:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=YChF74t2kCjVmzLtc3VVwUQ1Wqz7G6sD7m6m1FBRe7A=; b=MB7DZKP+abALI/00Iz6GCBmJocjSSeo5mNygLu044Jw9zsdjL8y7uNqo+xpkyBcTND U5ogVlF8/ad1sYfpLJKweKSG/g+IA7wNKoNe92QZ4OhkXrUaFrkisVPlZxBLpbjzmFbi D/XqC2jyHFf8eMGyZlBpMRVHmLLtZaeIIL8hlPyJLtF5f6LMKvR5wmDUbLP6PEombZPc 2OCYSjGAvUiioHxLf2krCJIOjk4RCqtJebBE02gNyzbHUc+UUC5Hjiqrk/oD2k2WV+47 qPZAAqPryOTq+d7t25fIrtzFP6lc9vse9VMQfcqdmjS5Yt+xskAWSKIH83Qr8vM7TygU 3thg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YChF74t2kCjVmzLtc3VVwUQ1Wqz7G6sD7m6m1FBRe7A=; b=DHgCahAQ2zimg5YeftKkjU6O8T5biWHl4/PnXjWz2/fLpXE+CG41+xSh2VURIxBGdy nXLB2ddLQHhX0JffLDah7G6phTmSIaJEHE7iBbj9L1MQRXr/0MUPEHyHpoBaHBJqqMLe DghodEoFX9z3tvLWlA4h5IqTeFU9/0KPu8vLYUtCZ/vJ0RTwDF4s3RSOVb0NsMlL01mj kOOHnchBWtBUFLtEBDnQsHx34c4NoH3DK2+3siePoKNO/OlQIOtpA+7h4xvufyEtfIkL 5q4M00Ek8uisU9gqL117zANPU85pPTrDJEvrdaiO9QPzdi05shoBhYSnRWlIDFkY6vkz zaPw== X-Gm-Message-State: ANoB5pmtnkZM+TioKx8uB+K0qWHIu7SDTw6wBBsYRjQ0nVW5I5XK5NsV VjP/XmMGV2qEhpOh7QFeJJohi26hRD4= X-Google-Smtp-Source: AA0mqf5wZ/7tz68AVRsxrKZ7U3jtzEub9gQIUCv3Z9ei1c3SQEbQgJSpatb/vZFqIAmKs4z711ItWg== X-Received: by 2002:ad4:4202:0:b0:4c6:fd1d:c7cf with SMTP id k2-20020ad44202000000b004c6fd1dc7cfmr29515591qvp.19.1670129035780; Sat, 03 Dec 2022 20:43:55 -0800 (PST) Received: from localhost.localdomain (dsl-157-235.b2b2c.ca. [66.158.157.235]) by smtp.gmail.com with ESMTPSA id x22-20020ac84a16000000b003a68f5d98c1sm6905272qtq.93.2022.12.03.20.43.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Dec 2022 20:43:55 -0800 (PST) From: Maxim Cournoyer Date: Sat, 3 Dec 2022 23:43:45 -0500 Message-Id: <20221204044347.23147-1-maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Rationale: It is only used in INSTALLATION-OS and doesn't make sense to be used in another context, given that file systems now automatically pull their dependencies since commit 45eac6cdf5c8d9d7b0c564b105c790d2d2007799 (services: Add file system utilities to profile). * gnu/system.scm (%base-packages-disk-utilities): Deprecate and rename to... * gnu/system/install.scm (%installer-disk-utilities): ... this. (installation-os) [packages]: Adjust accordingly. --- gnu/system.scm | 19 ++----------------- gnu/system/install.scm | 19 ++++++++++++++++++- 2 files changed, 20 insertions(+), 18 deletions(-) diff --git a/gnu/system.scm b/gnu/system.scm index 3478afcec4..1c119c31b6 100644 --- a/gnu/system.scm +++ b/gnu/system.scm @@ -38,6 +38,7 @@ (define-module (gnu system) #:use-module (guix gexp) #:use-module (guix records) #:use-module (guix packages) + #:use-module (guix deprecation) #:use-module (guix derivations) #:use-module (guix profiles) #:use-module ((guix utils) #:select (substitute-keyword-arguments)) @@ -49,9 +50,6 @@ (define-module (gnu system) #:use-module (gnu packages bash) #:use-module (gnu packages compression) #:use-module (gnu packages cross-base) - #:use-module (gnu packages cryptsetup) - #:use-module (gnu packages disk) - #:use-module (gnu packages file-systems) #:use-module (gnu packages firmware) #:use-module (gnu packages gawk) #:use-module (gnu packages guile) @@ -896,20 +894,7 @@ (define %base-packages-networking ;; many people are familiar with, so keep it around. iw wireless-tools)) -(define %base-packages-disk-utilities - ;; A well-rounded set of packages for interacting with disks, - ;; partitions and filesystems, included with the Guix installation - ;; image. - (list parted gptfdisk ddrescue - ;; We used to provide fdisk from GNU fdisk, but as of version 2.0.0a - ;; it pulls Guile 1.8, which takes unreasonable space; furthermore - ;; util-linux's fdisk is already available, in %base-packages-linux. - cryptsetup mdadm - dosfstools - btrfs-progs - f2fs-tools - jfsutils - xfsprogs)) +(define-deprecated %base-packages-disk-utilities #f '()) (define %base-packages ;; Default set of packages globally visible. It should include anything diff --git a/gnu/system/install.scm b/gnu/system/install.scm index 003c49a3e7..d34d974338 100644 --- a/gnu/system/install.scm +++ b/gnu/system/install.scm @@ -48,6 +48,9 @@ (define-module (gnu system install) #:use-module (gnu packages bootloaders) #:use-module (gnu packages certs) #:use-module (gnu packages compression) + #:use-module (gnu packages cryptsetup) + #:use-module (gnu packages disk) + #:use-module (gnu packages file-systems) #:use-module (gnu packages fonts) #:use-module (gnu packages fontutils) #:use-module (gnu packages guile) @@ -458,6 +461,20 @@ (define %issue \x1b[1;33mUse Alt-F2 for documentation.\x1b[0m ") +(define %installer-disk-utilities + ;; A well-rounded set of packages for interacting with disks, partitions and + ;; file systems, included with the Guix installation image. + (list parted gptfdisk ddrescue + ;; We used to provide fdisk from GNU fdisk, but as of version 2.0.0a + ;; it pulls Guile 1.8, which takes unreasonable space; furthermore + ;; util-linux's fdisk is already available, in %base-packages-linux. + cryptsetup mdadm + dosfstools + btrfs-progs + f2fs-tools + jfsutils + xfsprogs)) + (define installation-os ;; The operating system used on installation images for USB sticks etc. (operating-system @@ -530,7 +547,7 @@ (define installation-os font-dejavu font-gnu-unifont grub ; mostly so xrefs to its manual work nss-certs) ; To access HTTPS, use git, etc. - %base-packages-disk-utilities + %installer-disk-utilities %base-packages)))) (define* (os-with-u-boot os board #:key (bootloader-target "/dev/mmcblk0") base-commit: bf46192d4c7c4cd8d71edb8ace2cdf86322aafe7 -- 2.38.1 From unknown Sat Jul 12 18:46:14 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#59661] [PATCH v2 2/3] install: Add missing e2fsprogs utility. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 04 Dec 2022 04:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59661 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 59661@debbugs.gnu.org Cc: ludo@gnu.org, Maxim Cournoyer Received: via spool by 59661-submit@debbugs.gnu.org id=B59661.167012904523764 (code B ref 59661); Sun, 04 Dec 2022 04:45:02 +0000 Received: (at 59661) by debbugs.gnu.org; 4 Dec 2022 04:44:05 +0000 Received: from localhost ([127.0.0.1]:55172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1grF-0006B9-L9 for submit@debbugs.gnu.org; Sat, 03 Dec 2022 23:44:05 -0500 Received: from mail-qt1-f169.google.com ([209.85.160.169]:42976) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1grD-0006AR-L2 for 59661@debbugs.gnu.org; Sat, 03 Dec 2022 23:44:03 -0500 Received: by mail-qt1-f169.google.com with SMTP id h24so9381714qta.9 for <59661@debbugs.gnu.org>; Sat, 03 Dec 2022 20:44:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=USrw97BQ+wA+u7LpOawUOGHyLoQhAyyHg3otu5cOp9o=; b=k3DAG8GifOOpGcTmUvJTQcjHg35NQvRT3IvpAO/A4JT+xDI1jgl7VGtwkuCeEFEFVY c8ybcGy3RziRenegDKsvzk0RSwowgVve5mFc0dk6EjitvdfghXe/LlbEMAfP4PeEgtke ZO/oAgS8A1F0N/dGOI2Fl3ICOrPX+J+dcedyp3xd+3gZygR7iETOGWxJuJlzOhPu+CiA A59Uqi8pao7dRgmgs7KoF1AaFJxKlSxX5JB/FBqmK/I0KILL9klrc5Vs02xMVwdf7d6R Tc97+5hdkpp64sJh0s2hjo2HoVIXPbKfsTiIcS0gpcGOoQrOD8z3wcGFISx6Ta35KNIl O+Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=USrw97BQ+wA+u7LpOawUOGHyLoQhAyyHg3otu5cOp9o=; b=cABZkd+N8t/ZOXSDyPvJqoRIVtl99OA/AaCL1AXuJfAi3C0ErWw0du3pZrrtkMPYHb Fm+4gorVO2LQvUmbcTHWrmGrMZZ38USmElF18HUeOuKmyj/WyysulwkJ1R5jToyvdJpl UmkQCFYYp3dLFpJRVz1V1T4s8jK/oc7NBtXc8+/ELGHI6xeAOnuYitZhb6u1DSJSx/+x 1VqbviDJOuBnSXu9YZLpg9rwoWi5HbGfaoGCuoYIBbHwVgKthIZtOI83pZXur6TUwaQP 4mbOCtiGdVE/bLzceiP6HOvaGtaUydvvxEY4H1bXzQxQ/tYt/7U1jM93jvu4YQZP34tQ OpaQ== X-Gm-Message-State: ANoB5pk0bMjTLNl3QdlKW6HKsiOg1ImpxkG7HgYkzmfevG0qum4jCMyC l5MyljYen7JvPhyzHK2L42iycBJUv5g= X-Google-Smtp-Source: AA0mqf5GGdCMOkYpOXmyBFT2G/pQ5obLvUH46eoG/rvoCTtydIw51ZQHBX53bMQCjV2OdEeO+IGY+w== X-Received: by 2002:ac8:7492:0:b0:3a5:425b:f865 with SMTP id v18-20020ac87492000000b003a5425bf865mr57207428qtq.589.1670129038076; Sat, 03 Dec 2022 20:43:58 -0800 (PST) Received: from localhost.localdomain (dsl-157-235.b2b2c.ca. [66.158.157.235]) by smtp.gmail.com with ESMTPSA id x22-20020ac84a16000000b003a68f5d98c1sm6905272qtq.93.2022.12.03.20.43.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Dec 2022 20:43:57 -0800 (PST) From: Maxim Cournoyer Date: Sat, 3 Dec 2022 23:43:46 -0500 Message-Id: <20221204044347.23147-2-maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221204044347.23147-1-maxim.cournoyer@gmail.com> References: <20221204044347.23147-1-maxim.cournoyer@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/system/install.scm (%installer-disk-utilities): Add e2fsprogs. --- gnu/system/install.scm | 1 + 1 file changed, 1 insertion(+) diff --git a/gnu/system/install.scm b/gnu/system/install.scm index d34d974338..f6f1923121 100644 --- a/gnu/system/install.scm +++ b/gnu/system/install.scm @@ -471,6 +471,7 @@ (define %installer-disk-utilities cryptsetup mdadm dosfstools btrfs-progs + e2fsprogs f2fs-tools jfsutils xfsprogs)) -- 2.38.1 From unknown Sat Jul 12 18:46:14 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#59661] [PATCH v2 3/3] system: Add e2fsprogs to %base-packages-utils. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 04 Dec 2022 04:45:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59661 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 59661@debbugs.gnu.org Cc: ludo@gnu.org, Maxim Cournoyer Received: via spool by 59661-submit@debbugs.gnu.org id=B59661.167012904723771 (code B ref 59661); Sun, 04 Dec 2022 04:45:03 +0000 Received: (at 59661) by debbugs.gnu.org; 4 Dec 2022 04:44:07 +0000 Received: from localhost ([127.0.0.1]:55174 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1grG-0006BL-Tk for submit@debbugs.gnu.org; Sat, 03 Dec 2022 23:44:07 -0500 Received: from mail-qt1-f174.google.com ([209.85.160.174]:40643) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1grF-0006AT-BI for 59661@debbugs.gnu.org; Sat, 03 Dec 2022 23:44:05 -0500 Received: by mail-qt1-f174.google.com with SMTP id jr1so9403589qtb.7 for <59661@debbugs.gnu.org>; Sat, 03 Dec 2022 20:44:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Enxr9gUCj4fymsTYgAk0rbnW4Jlyt2T6p3jZi56wRfQ=; b=htRLWPKC9ruLACEXCoJHDq7ldQzR0EhgQUI4452io0+ty0Q1+2/KMr5rLVTWIIgRFA +yWX8zpduvMire+dSRl6hZ/cMZwq6krF6GpCyAeMsMFOQatw7+XrEsw5/4q8Xv6RP7LD zERm08h0rPbHDBAEXgPfnwnJJzQzDmSsGfY0gxB2AeKm0u3ZjITNMIxirymsgEexcJyS Oq6vNV9L0z5IYjLE8TETxynowIZktz5lKDu4CT32ZSQy7zJafnTbwuoDxcr15ms+AxJ3 xGswzYKN0RWLMXyAoLqJbr6H6J5pXM9GxXtQOm3g7zhXxAIgpZCqwT1XDF+JS7jtmrFm vBqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Enxr9gUCj4fymsTYgAk0rbnW4Jlyt2T6p3jZi56wRfQ=; b=ISGQ5Bnz1ON1q45rKIlj1/s+T2u83kSXMi+bXox4k8TDAakzjEpuVMxn6tdqJJ1Mxb oe3A9rbiDiJM+wNpqk686mrl9wDJiYHRXJNk4qR57f9gcRw9leapJcC7sluzfa5yGKLQ RjjIDFEYBnAdACc9U95eqaqJ7TTbaXqO4Y2eN6ksZH5cX5m7XRQHLuFzUoc4zzqdF7Lk hawVM06sF3rmUUpmtMCMv+9Fyjg+L417u/4anPfyr2MQ00IYUN/3n3adv2dAKujRQoYV nsPAMbtYEOngO1rQMomXxf7RorLJt5+AAFQGzeLH9E1XFdkD/3SOYYwaFi8OCeVd01jB 5SyQ== X-Gm-Message-State: ANoB5plho9cB0+YJNHyMc4UKgXAkA+FdeXSQHy+HpczKT1dCA5NeTzrG /1TdmhqHIpW5FTlo84HB4tlYkLLFhMc= X-Google-Smtp-Source: AA0mqf58qAJF8K1Am5KbOjQMBljVHToUSRRzyWcZYSBdOcmgELqG70YfhKwCr3msHx9JPDd/ARX+CQ== X-Received: by 2002:ac8:6792:0:b0:3a5:1c8b:8890 with SMTP id b18-20020ac86792000000b003a51c8b8890mr73462126qtp.63.1670129039591; Sat, 03 Dec 2022 20:43:59 -0800 (PST) Received: from localhost.localdomain (dsl-157-235.b2b2c.ca. [66.158.157.235]) by smtp.gmail.com with ESMTPSA id x22-20020ac84a16000000b003a68f5d98c1sm6905272qtq.93.2022.12.03.20.43.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Dec 2022 20:43:59 -0800 (PST) From: Maxim Cournoyer Date: Sat, 3 Dec 2022 23:43:47 -0500 Message-Id: <20221204044347.23147-3-maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221204044347.23147-1-maxim.cournoyer@gmail.com> References: <20221204044347.23147-1-maxim.cournoyer@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Rationale: Even when not using an ext file system, the utilities provided by e2fsprogs are useful, for example to set the copy-on-write attribute of a Btrfs file system. * gnu/system.scm (%base-packages-utils): Add e2fsprogs. --- gnu/system.scm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gnu/system.scm b/gnu/system.scm index 1c119c31b6..62c8e0c2b6 100644 --- a/gnu/system.scm +++ b/gnu/system.scm @@ -856,6 +856,8 @@ (define %base-packages-utils (cons* procps psmisc which (@ (gnu packages admin) shadow-with-man-pages) ;for 'passwd' + e2fsprogs ;for lsattr, chattr, etc. + guile-3.0-latest ;; The packages below are also in %FINAL-INPUTS, so take them from -- 2.38.1 From unknown Sat Jul 12 18:46:14 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#59661] [PATCH v2 1/3] system: Rename and move %base-packages-disk-utilities. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 04 Dec 2022 16:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59661 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 59661@debbugs.gnu.org, Efraim Flashner Received: via spool by 59661-submit@debbugs.gnu.org id=B59661.16701708535651 (code B ref 59661); Sun, 04 Dec 2022 16:21:02 +0000 Received: (at 59661) by debbugs.gnu.org; 4 Dec 2022 16:20:53 +0000 Received: from localhost ([127.0.0.1]:58492 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1rjY-0001T5-NP for submit@debbugs.gnu.org; Sun, 04 Dec 2022 11:20:52 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46396) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1rjX-0001Sy-Jx for 59661@debbugs.gnu.org; Sun, 04 Dec 2022 11:20:51 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p1rjS-0002HJ-2R; Sun, 04 Dec 2022 11:20:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=l8zu1faBvUgmlS3EHSVbBFHnagXF2E/5kIt31jZmt5Q=; b=ZRlqVz9gY3T8kTW0735I ECpGP9vnW08LqvEpmy1eu1UE9yUSFTfSCELIuXQF8RC5G2iERZ1K63GeYNVhtzJhLae1Z0BTWNQ5c rCJrgG7CVxfAmRJ3carYqnL4oLuQ0KKercfsy6mBgcNuKA5lTxUiHrhBw9tgx+9fgRsNJOgqvCwcc LqyOghFMeRTlq02gbWZCkTeSTeWVPQpLbW2TH1NZDhOIzCvzDqPDULIEa8+BcLgvsJZYrTdJDxsx9 H9POE2Lyn6H0M7x48f49niy58i7DhODzpR4+HGiIglUIugUGIW5TOvcjnr5DDynseIBP7J1fjrpBr bCjdpAF8yUDhfw==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p1rjR-0007BO-JN; Sun, 04 Dec 2022 11:20:45 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20221204044347.23147-1-maxim.cournoyer@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Quartidi 14 Frimaire an 231 de la =?UTF-8?Q?R=C3=A9volution,?= jour du Sapin X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sun, 04 Dec 2022 17:20:42 +0100 In-Reply-To: <20221204044347.23147-1-maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Sat, 3 Dec 2022 23:43:45 -0500") Message-ID: <875yernns5.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Maxim Cournoyer skribis: > Rationale: It is only used in INSTALLATION-OS and doesn't make sense to be > used in another context, given that file systems now automatically pull t= heir > dependencies since commit 45eac6cdf5c8d9d7b0c564b105c790d2d2007799 (servi= ces: > Add file system utilities to profile). > > * gnu/system.scm (%base-packages-disk-utilities): Deprecate and rename to= ... > * gnu/system/install.scm (%installer-disk-utilities): ... this. > (installation-os) [packages]: Adjust accordingly. Efraim, this variable was added in e6e076281e62518056987e9ddd3d96fccab20475 and used in 4170af491c8bc3b0a5308116a26e758d8ff245c5; do you think it=E2=80=99s okay to remove now? (It LGTM, but I=E2=80=99d like to make sure we don=E2=80=99t c= reate churn.) > +(define-deprecated %base-packages-disk-utilities #f '()) =E2=80=98#f=E2=80=99 here would lead to weird deprecation messages. I=E2= =80=99d make it: (define-deprecated %base-packages-disk-utilities %base-packages '()) This is not quite accurate but it should convey the idea. Thanks, Ludo=E2=80=99. From unknown Sat Jul 12 18:46:14 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#59661] [PATCH v2 2/3] install: Add missing e2fsprogs utility. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 04 Dec 2022 16:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59661 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 59661@debbugs.gnu.org Received: via spool by 59661-submit@debbugs.gnu.org id=B59661.167017167215061 (code B ref 59661); Sun, 04 Dec 2022 16:35:01 +0000 Received: (at 59661) by debbugs.gnu.org; 4 Dec 2022 16:34:32 +0000 Received: from localhost ([127.0.0.1]:58561 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1rwl-0003ur-T9 for submit@debbugs.gnu.org; Sun, 04 Dec 2022 11:34:32 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35410) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1rwk-0003uj-96 for 59661@debbugs.gnu.org; Sun, 04 Dec 2022 11:34:30 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p1rwf-0006jW-2O; Sun, 04 Dec 2022 11:34:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=83fnY0zaM/15H4ZV8Nv144vZtuQwzl1eINHgYoeVkEg=; b=IS3MxoOOU8OS2a84t0r3 HrrPcvZhf2ZYSzJdBSoCe8XnTidafqZVjoZ4/V0CqvQ+b0iVXG7eKngwoB7VPJjPABK6LUDN8iLbq LoBksFYjjgeBmBWOb+Np6thbP3+uWtUVnDOnzC8kGIv/PH5Jouh+IqekEMDqWCqYH9SVTvN4bq4fZ 405tYc5g7KET0sAK3pUDcvxDz+mID+Dbmbq0FQ/nBG4MlZ8Cy3W+2AFP7z/Xf8htmz2KdckXgn/JG 3r511RtIGOJCYG8fh4ZlMdih/Y2C/bwF1p4EHYUEzkwNH6IJOlsuOaIsoHbwxHvTWs5GMr0zhLl3L wYGvCLLviVP4XQ==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p1rwe-0005VV-IL; Sun, 04 Dec 2022 11:34:24 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20221204044347.23147-1-maxim.cournoyer@gmail.com> <20221204044347.23147-2-maxim.cournoyer@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Quartidi 14 Frimaire an 231 de la =?UTF-8?Q?R=C3=A9volution,?= jour du Sapin X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sun, 04 Dec 2022 17:34:23 +0100 In-Reply-To: <20221204044347.23147-2-maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Sat, 3 Dec 2022 23:43:46 -0500") Message-ID: <87wn77m8kw.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Maxim Cournoyer skribis: > * gnu/system/install.scm (%installer-disk-utilities): Add e2fsprogs. LGTM! e2fsprogs binaries are indeed missing from $PATH in guix-system-install-1.4.0rc1.*.iso; I=E2=80=99ll cherry-pick it on =E2=80=98version-1.4.0=E2=80=99. What I don=E2=80=99t get is that our manual installation tests should have caught this issue because they use =E2=80=98mkfs.ext4=E2=80=99 and expect t= o have it in $PATH. I=E2=80=99ll take a look=E2=80=A6 Ludo=E2=80=99. From unknown Sat Jul 12 18:46:14 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#59661] [PATCH v2 3/3] system: Add e2fsprogs to %base-packages-utils. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 04 Dec 2022 16:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59661 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 59661@debbugs.gnu.org Received: via spool by 59661-submit@debbugs.gnu.org id=B59661.167017182315169 (code B ref 59661); Sun, 04 Dec 2022 16:38:01 +0000 Received: (at 59661) by debbugs.gnu.org; 4 Dec 2022 16:37:03 +0000 Received: from localhost ([127.0.0.1]:58575 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1rzD-0003wb-Ce for submit@debbugs.gnu.org; Sun, 04 Dec 2022 11:37:03 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35324) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1rzB-0003wB-Uu for 59661@debbugs.gnu.org; Sun, 04 Dec 2022 11:37:02 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p1rz6-0007Nj-E0; Sun, 04 Dec 2022 11:36:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=7aCbq5e2sCtu7rDFQIESkBZwsQcGSHqs/Vs1TrmmHBw=; b=KtbubI8cWQI7kar6HHFz V+UzTgCAeASgxZXaVl4V6jGD93CgjYGh4/LBQYyJr52S2TaueNsr6HlEJjIRecuKcYGF3B8hfgHSe 3pqvUcYGcR9bevCzhcvmMcGzrhJp7rLD+KWWrGl6otKzeebhxpxm0dKNT85HCUTRJgqd2jPKH8VUM onNyDx629s71G3leCP5CtSvtbXl0Sml7i+e9brRR+D4caRS1oY4sK0UnqR9+KKIOJA1xMRpO91uff N0tnPdxbNQZO9IzvE0n2OMYBpe5Wk0RGjrwWPMn31bTZIduQEJA4dy/dc8yX7qu5ql3lhJUfoc272 19Fft49CvppImw==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p1rz5-0005pP-Ox; Sun, 04 Dec 2022 11:36:55 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20221204044347.23147-1-maxim.cournoyer@gmail.com> <20221204044347.23147-3-maxim.cournoyer@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Quartidi 14 Frimaire an 231 de la =?UTF-8?Q?R=C3=A9volution,?= jour du Sapin X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sun, 04 Dec 2022 17:36:54 +0100 In-Reply-To: <20221204044347.23147-3-maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Sat, 3 Dec 2022 23:43:47 -0500") Message-ID: <87sfhvm8gp.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Maxim Cournoyer skribis: > Rationale: Even when not using an ext file system, the utilities provided by > e2fsprogs are useful, for example to set the copy-on-write attribute of a > Btrfs file system. > > * gnu/system.scm (%base-packages-utils): Add e2fsprogs. LGTM! From unknown Sat Jul 12 18:46:14 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#59661] [PATCH 0/3] Add e2fsprogs to %base-packages-utils. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 04 Dec 2022 17:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59661 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 59661@debbugs.gnu.org Received: via spool by 59661-submit@debbugs.gnu.org id=B59661.167017493626169 (code B ref 59661); Sun, 04 Dec 2022 17:29:02 +0000 Received: (at 59661) by debbugs.gnu.org; 4 Dec 2022 17:28:56 +0000 Received: from localhost ([127.0.0.1]:58827 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1snP-0006o1-S2 for submit@debbugs.gnu.org; Sun, 04 Dec 2022 12:28:56 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51950) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1snN-0006nv-AZ for 59661@debbugs.gnu.org; Sun, 04 Dec 2022 12:28:54 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p1snH-00075P-4C; Sun, 04 Dec 2022 12:28:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=a0YeV0dGfJJ7dBCOGu4lDSbobDETzKyOURQAzphYLI8=; b=Qh7NAaB83MQ8PapPoH3u 9GEv449HpiO8lOKzOMhYeqI/beZ2MvUAlOcw4Bpktd4mMLWWRGKYKjGTNfxsvCnCzCBYNXYS1TdBa 7THWbydgOHIUTjxkgqx+z7/6mNwFjQK9/GMIVxKbPLcBGJu2fC32xIYW57xWeZ1OHecY07FBnOCjj 7vt4oJt4rSCmfsjFHhZP5hhTCg/tatYa8i7qt6HcAxMkq8Le/stS+MZdI3OSpUXixY5tUYkLcGgWs XtBXrb6lAE+zHPk0JstGceevKnBMKmMxCojGyK3pYu92Llf6W2WvmwQy8shKSxOMTZCPUr6GA1fwa DApOQvODO9fVAw==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p1snG-00041O-Lo; Sun, 04 Dec 2022 12:28:46 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20221204044347.23147-1-maxim.cournoyer@gmail.com> <20221204044347.23147-2-maxim.cournoyer@gmail.com> <87wn77m8kw.fsf@gnu.org> Date: Sun, 04 Dec 2022 18:28:44 +0100 In-Reply-To: <87wn77m8kw.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Sun, 04 Dec 2022 17:34:23 +0100") Message-ID: <877cz7m62b.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Ludovic Court=C3=A8s skribis: > Maxim Cournoyer skribis: > >> * gnu/system/install.scm (%installer-disk-utilities): Add e2fsprogs. > > LGTM! > > e2fsprogs binaries are indeed missing from $PATH in > guix-system-install-1.4.0rc1.*.iso; I=E2=80=99ll cherry-pick it on > =E2=80=98version-1.4.0=E2=80=99. > > What I don=E2=80=99t get is that our manual installation tests should have > caught this issue because they use =E2=80=98mkfs.ext4=E2=80=99 and expect= to have it in > $PATH. I=E2=80=99ll take a look=E2=80=A6 Got it: Mathieu worked around it in 0f66ef9aa99d2043abccbc80d858bdeca57534ac by explicitly adding e2fsprogs and the installation system used by the tests: commit 0f66ef9aa99d2043abccbc80d858bdeca57534ac Author: Mathieu Othacehe Date: Fri Sep 30 15:19:36 2022 +0200 tests: install: Fix iso-image-installer test. This is a follow-up of: 45eac6cdf5c8d9d7b0c564b105c790d2d2007799. It fixes the following error: + mkfs.ext4 -L my-root /dev/vda2 sh: line 12: mkfs.ext4: command not found * gnu/tests/install.scm (%test-iso-image-installer): Add e2fsprogs to= the appended packages. We should be able to revert this commit once the installer provides e2fsprogs by default. Thanks, Ludo=E2=80=99. From unknown Sat Jul 12 18:46:14 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#59661] [PATCH v2 1/3] system: Rename and move %base-packages-disk-utilities. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 04 Dec 2022 21:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59661 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 59661@debbugs.gnu.org, Efraim Flashner Received: via spool by 59661-submit@debbugs.gnu.org id=B59661.167018990311636 (code B ref 59661); Sun, 04 Dec 2022 21:39:02 +0000 Received: (at 59661) by debbugs.gnu.org; 4 Dec 2022 21:38:23 +0000 Received: from localhost ([127.0.0.1]:59914 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1wgo-00031c-OJ for submit@debbugs.gnu.org; Sun, 04 Dec 2022 16:38:23 -0500 Received: from mail-qv1-f42.google.com ([209.85.219.42]:46613) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1wgm-00031V-AD for 59661@debbugs.gnu.org; Sun, 04 Dec 2022 16:38:21 -0500 Received: by mail-qv1-f42.google.com with SMTP id mn15so7072751qvb.13 for <59661@debbugs.gnu.org>; Sun, 04 Dec 2022 13:38:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=ujatZ66pvgTRezi+KLRaxbfNdGSoNmvHlR1G0dwKiWE=; b=b06inj5KSSzTJDI3Ybr2wqrnY/Hasu/BgiTvIzbCnQ6YdWsO93OJY707lRmIhKlAJx vnnRuEQrv4LO83qVjmjmOiO8ZyUWnKRmyG8PW3Sjn3x27kr3KDlNmWjDGLDvwC0Ajjf4 p1rMrUjzC5BYjgiZpg6r11UnXSXB6tRnaEdwmjSpWytlgD6/U/8xYPoRWoFFmKM6dOkj 91JVqY+D/baNz3eKwLcOcdmVPrDpi4Pq8tF1wjLxAt9bvB3Wl5PvnGTXvgDRlT+peXL5 +48az+jSrd4h2j9x0tvRTQHN0TZzeKRwSPP9ExAZHYeI31md42Oj6Zy5nFyHcCZm+cmP 8HtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ujatZ66pvgTRezi+KLRaxbfNdGSoNmvHlR1G0dwKiWE=; b=uN7Lr8BBMHb0slYeEetzNBznYH5kMHazRkt4kLT86YY/Rg3hOSTGVfvtrpak4sjVLG 5fO6xV69YWplcYLQJQiyUXqH6rdg7FUPBUBIjk+cULhI2ZeRnSb6ewRoQAqHBPeAh92P VvI3mNVUmsyvUXo+QiaeWTu+53nuBCoLF3ZJTJjy7zgX9z7W5wUPBIZZQzzyXoMgynqm v9oEIkxLYN/YykvJkVpDNUI5/7knSO9KVsB7R1zwpRRSX45DVF135k2ydD/UDv8rKKkX 2j/AN4KzCEofpY9mbbf5irBwo/ZCLa7RW/Eq2+kLsAnHIEZ6Sl9Ni0y0mGNdii7gcdRr //BQ== X-Gm-Message-State: ANoB5plsE/JSa4PJyUQ/gDyS5x9O3OT4/k9pH9/Je6UOR/QJXojOKL+F b8Ee9dq2kRhlo/U5EQsh/RPJ8vIuzcg= X-Google-Smtp-Source: AA0mqf6W518S1XZdyE3XIZyaX85/FN2//k5DWugxl2fXAUsH3yLvBkdb6DnNob5JHsZLAWs8RDs34g== X-Received: by 2002:a0c:de0a:0:b0:4c7:1a90:228f with SMTP id t10-20020a0cde0a000000b004c71a90228fmr21207720qvk.61.1670189894699; Sun, 04 Dec 2022 13:38:14 -0800 (PST) Received: from hurd (dsl-156-154.b2b2c.ca. [66.158.156.154]) by smtp.gmail.com with ESMTPSA id y26-20020a37f61a000000b006fc62eabcc9sm10354604qkj.134.2022.12.04.13.38.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Dec 2022 13:38:14 -0800 (PST) From: Maxim Cournoyer References: <20221204044347.23147-1-maxim.cournoyer@gmail.com> <875yernns5.fsf@gnu.org> Date: Sun, 04 Dec 2022 16:38:13 -0500 In-Reply-To: <875yernns5.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Sun, 04 Dec 2022 17:20:42 +0100") Message-ID: <87y1rm6e9m.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Ludovic, Ludovic Court=C3=A8s writes: > Hi, > > Maxim Cournoyer skribis: > >> Rationale: It is only used in INSTALLATION-OS and doesn't make sense to = be >> used in another context, given that file systems now automatically pull = their >> dependencies since commit 45eac6cdf5c8d9d7b0c564b105c790d2d2007799 (serv= ices: >> Add file system utilities to profile). >> >> * gnu/system.scm (%base-packages-disk-utilities): Deprecate and rename t= o... >> * gnu/system/install.scm (%installer-disk-utilities): ... this. >> (installation-os) [packages]: Adjust accordingly. > > Efraim, this variable was added in > e6e076281e62518056987e9ddd3d96fccab20475 and used in > 4170af491c8bc3b0a5308116a26e758d8ff245c5; do you think it=E2=80=99s okay = to > remove now? (It LGTM, but I=E2=80=99d like to make sure we don=E2=80=99t= create churn.) > >> +(define-deprecated %base-packages-disk-utilities #f '()) > > =E2=80=98#f=E2=80=99 here would lead to weird deprecation messages. I=E2= =80=99d make it: > > (define-deprecated %base-packages-disk-utilities %base-packages '()) > > This is not quite accurate but it should convey the idea. I had shown an actual message example produced when using #f. It is what I want (it just mentions the variable is deprecated, and doesn't mention a replacement -- there are none in this case). For a quick reference, this is how 'warn-about-deprecation' is defined: --8<---------------cut here---------------start------------->8--- (define* (warn-about-deprecation variable properties #:key replacement) (let ((location (and properties (source-properties->location properties))= )) (if replacement (warning location (G_ "'~a' is deprecated, use '~a' instead~%") variable replacement) (warning location (G_ "'~a' is deprecated~%") variable)))) --8<---------------cut here---------------end--------------->8--- So I prefer my version. If you still think the produced message is weird, I'll need a bit more explanation to understand why you think so :-). --=20 Thanks, Maxim From unknown Sat Jul 12 18:46:14 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#59661] [PATCH v2 1/3] system: Rename and move %base-packages-disk-utilities. Resent-From: Efraim Flashner Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 05 Dec 2022 10:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59661 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 59661@debbugs.gnu.org, Maxim Cournoyer Received: via spool by 59661-submit@debbugs.gnu.org id=B59661.167023659210398 (code B ref 59661); Mon, 05 Dec 2022 10:37:02 +0000 Received: (at 59661) by debbugs.gnu.org; 5 Dec 2022 10:36:32 +0000 Received: from localhost ([127.0.0.1]:35182 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p28pr-0002he-Sy for submit@debbugs.gnu.org; Mon, 05 Dec 2022 05:36:32 -0500 Received: from mail-ej1-f45.google.com ([209.85.218.45]:45762) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p28pp-0002hX-Bp for 59661@debbugs.gnu.org; Mon, 05 Dec 2022 05:36:30 -0500 Received: by mail-ej1-f45.google.com with SMTP id fc4so19713267ejc.12 for <59661@debbugs.gnu.org>; Mon, 05 Dec 2022 02:36:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender:from:to :cc:subject:date:message-id:reply-to; bh=HfhSojpXrrXW2/9sv67u+18VnuRuugIru0koAs+zXcM=; b=EEvME55sVaJ8iQkXx8UDHuOghKudopD1eREFzQcZIuo+kq4MRtpUju+SVBeKbhRZeH IGEPYoJec37pR5EEsiIMAJnIBWBTcp3jjR78nBcBkpPftGJYWo4y+rULtFF5iZIX9TsP jyqL/G/vdYz8++1gDWJblDCYVwp8VKMclaUbh9E7bIVk2GGxIU/uTjhFC8sk+THdDkC1 b/xl5SUgjPICalrxJ7MqTZ7Qnob0oOfKS24ZQKLnY/1fBxgfTNput2qUTuO/HuEc6QgL w3+2DmsEqQDya3HCKFJFovRlJXJhTKwmdRcREGNunqK7Ds8avBTTca0F3BN+HRPszmrq GHow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HfhSojpXrrXW2/9sv67u+18VnuRuugIru0koAs+zXcM=; b=QOqB1QQtmicIhMGKZtb33dzdcn92kL4Qnfk8GmZoXP5tHRHp2QLugdIjuu4LdzbYrB bzEAWNuVcFsaIi4kUHpv6jg6fsPASLMnWXHX8fryzxpKknPdrUqwQBA4ZCzIR0Qckl4s EtJ35EYaG6i6sK8vWmQZdu17s0hf3R4jWuzTx2O+tzat1zoCjuk2RHP6im87bbPhykAj dIIRvM0lPIeFa43qxd+Apu0AAFhrPZ4NNy3qEkyMIF4uBX+Ffc3AikqYXzQYbhAVi2mZ 6YBCyvE0kXOzhumFXoIurP/MNuuPG/Aq8ZQ+OuzI9Manf63CsqUv5aaE4d5RIQghB20D 1uqA== X-Gm-Message-State: ANoB5plEKDCQ8/AzzswW0WBm+w4eWxKyru5Eyv0fe/gxf6EouBa1hLIK 68GBB2OccPNMi60jxQjpHtA= X-Google-Smtp-Source: AA0mqf6j7jQsSUD24+IBVnBdg8gIaDiGCFsZjAbK4Qa271kFUDdwxjidbO32YACrcnMvPf3vawwcxg== X-Received: by 2002:a17:907:2c45:b0:7b8:bbbe:5ca with SMTP id hf5-20020a1709072c4500b007b8bbbe05camr52002286ejc.544.1670236583304; Mon, 05 Dec 2022 02:36:23 -0800 (PST) Received: from localhost ([2a02:ed3:914:3200:b62e:99ff:fef0:7bc0]) by smtp.gmail.com with ESMTPSA id n9-20020aa7c449000000b004588ef795easm6098505edr.34.2022.12.05.02.36.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Dec 2022 02:36:22 -0800 (PST) Date: Mon, 5 Dec 2022 12:36:21 +0200 From: Efraim Flashner Message-ID: Mail-Followup-To: Efraim Flashner , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Maxim Cournoyer , 59661@debbugs.gnu.org References: <20221204044347.23147-1-maxim.cournoyer@gmail.com> <875yernns5.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="MbHQEFkFJl1km2Fw" Content-Disposition: inline In-Reply-To: <875yernns5.fsf@gnu.org> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --MbHQEFkFJl1km2Fw Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Dec 04, 2022 at 05:20:42PM +0100, Ludovic Court=C3=A8s wrote: > Hi, >=20 > Maxim Cournoyer skribis: >=20 > > Rationale: It is only used in INSTALLATION-OS and doesn't make sense to= be > > used in another context, given that file systems now automatically pull= their > > dependencies since commit 45eac6cdf5c8d9d7b0c564b105c790d2d2007799 (ser= vices: > > Add file system utilities to profile). > > > > * gnu/system.scm (%base-packages-disk-utilities): Deprecate and rename = to... > > * gnu/system/install.scm (%installer-disk-utilities): ... this. > > (installation-os) [packages]: Adjust accordingly. >=20 > Efraim, this variable was added in > e6e076281e62518056987e9ddd3d96fccab20475 and used in > 4170af491c8bc3b0a5308116a26e758d8ff245c5; do you think it=E2=80=99s okay = to > remove now? (It LGTM, but I=E2=80=99d like to make sure we don=E2=80=99t= create churn.) I looked back through the commits around there. The whole point was the following commit, to divide the longish haphazard list of packages into sets of a sort. If it's only used in (gnu system install) then I don't see a problem with moving it there. The closest I know of to another user of %base-packages-disk-utilities is my gparted guix image=C2=B9. > > +(define-deprecated %base-packages-disk-utilities #f '()) >=20 > =E2=80=98#f=E2=80=99 here would lead to weird deprecation messages. I=E2= =80=99d make it: >=20 > (define-deprecated %base-packages-disk-utilities %base-packages '()) >=20 > This is not quite accurate but it should convey the idea. Would it be better to do (define-deprecated/alias-public %base-packages-disk-utilities %installer-disk-utilities) And remove the export from the list at the top of (gnu system)? =C2=B9 https://git.sr.ht/~efraim/guix-config/tree/master/item/gparted.scm --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --MbHQEFkFJl1km2Fw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmONyaEACgkQQarn3Mo9 g1GjVBAAn3pWezvi0wZEUD6KO0W2mBD4y/bXLeSulmtjYn0iUumXrpjqhKB6k2Vq pMO1tgQlkVyVKbHJyOpeAKB7VNB6B9+g5ufLDjc4DjLFy8caP6m2ljSlHclqDH2C q3Q5U4gO6mRrSMqjUS/mxYO+u6z/mGNZaxQ0Kl0YwhbKUoiHj8vzVGcQ/zDGpKRq ElFztmRujy/unb2VKFTayIAZaAVahidaE8FCmmDJ5hZlrrhJ7i14J6kT3CVqlKiU wNc7H6Pq8uuQzzCrgFGIQ9DQKiUoAvkykw6wTIhTzhOfB9VAhmmDgTYLgrVAYTJi aes1v+EzSvx8w/oe2VRPVywNRTsZp97OEru+2Nb1ukTIXtG5aBoFPd/ZZttLQN8A OFPFGSJKqtRUN543ro96dgf0n+y8/5vhz4TeOAcHw8qwov7A62dZ2uzI2LAsIBVQ 9eInOHTzBzE6dgZyoN4Qa2718/Tibl++lc8vFRdyMAKMrUfawZ2t0S9HI4ZAtQqt WPciC8UACKpUPfOkhk7Ez0wrgp3xzltAbaFxLNAZg3xrqSHtlpwZhmnpsSbYCvDl r4Rfg/znyEaLFCZvdkTh5xb/QS60yc+3HpRItJ6gHrTqYHqAVqQfE7n0lW1xmgdE lxO2L6r/o9fN5iOYRr9naKnPdjQGlGM+koPGkLm35FvF7jLuA4k= =TKgl -----END PGP SIGNATURE----- --MbHQEFkFJl1km2Fw-- From unknown Sat Jul 12 18:46:14 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#59661] [PATCH v2 1/3] system: Rename and move %base-packages-disk-utilities. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 05 Dec 2022 15:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59661 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Efraim Flashner Cc: 59661@debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 59661-submit@debbugs.gnu.org id=B59661.167025424617082 (code B ref 59661); Mon, 05 Dec 2022 15:31:01 +0000 Received: (at 59661) by debbugs.gnu.org; 5 Dec 2022 15:30:46 +0000 Received: from localhost ([127.0.0.1]:36709 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2DQc-0004RS-2k for submit@debbugs.gnu.org; Mon, 05 Dec 2022 10:30:46 -0500 Received: from mail-qk1-f179.google.com ([209.85.222.179]:34695) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2DQa-0004RM-5f for 59661@debbugs.gnu.org; Mon, 05 Dec 2022 10:30:45 -0500 Received: by mail-qk1-f179.google.com with SMTP id c2so5221258qko.1 for <59661@debbugs.gnu.org>; Mon, 05 Dec 2022 07:30:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=RFWbbLSqiR0huBXs+t2MeufRyWNRiCUzUfFT6cHrCsM=; b=hgGAVVM+YPLOp/mWx7l+yOm6cbBuoRywEP0kYfApE4XUItR9WKYiupTp8LmdOWpRWJ JXZt0Rg9po0MLxq+nOu5aVg4hQcUS3B7KONzLX0NGT1TExfwJlpwI1cdVGovxq7rew2V q+WFJMnsbzmhZQFyjN6zyOD/dQ++4qRnT5xvhPAVAyflsbZqzaOt1arA2HZuVNLItQi2 4NRi9p7yyLqDR/HE7Io5RnJP4SvzmBmbYjiJS5jJM6mrM/M0EJHWGJxBR92q4dtn0Vok AgqMFPEmL6ILSFuXDjGohQ8avADQq3gTU5YXPepIpKuROgEPCxqwTg6xrkAB+wAT3sBX SzcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RFWbbLSqiR0huBXs+t2MeufRyWNRiCUzUfFT6cHrCsM=; b=6DLfPl74WiJPyMAh/VTCE8UFgyIlydInlOPX4IVOq2uydS8vwRiZzA+DGOx3AQIMyl 5ZYmusiE07XFq1WQiAlJmT6PicUWH2//1s/wIyEsvnyXOOY7a+1N0y3eeFP2t5iEmEvS ZjjycSzNzK1JDV056tf5srOg8VYIwlgYCt/M7A53Mda1M7pPHcfQH01n76SA999d2NjS dSjRCpa3tlJ8yMya74iLVzZAiYSBlxa2UcSSnwTfsw6ougyeRwynI+FPE4hc8dc5k2SQ NmI97YaFMcbcZoTuMbuh1QFh/GiGCg83xG1M/StWLI2ZcRiSCaC06xgerjxBoaquuXhP wCNw== X-Gm-Message-State: ANoB5pmqWaU2RoajQkSYLrkJSeNvdEcxiF9nFScDnpMfR7mJcgHELUVe 5Hg8O1wnb9JV8TOSS4x8zsF5EIUrBy4= X-Google-Smtp-Source: AA0mqf4jOIh5tupqMGjTabsH0sXhWNgFol+c0KOWzsofB3ZrwrOjPiXDc4B0Rd4A+nxeBRAPqt6xUQ== X-Received: by 2002:a05:620a:111c:b0:6fc:cce2:4cf2 with SMTP id o28-20020a05620a111c00b006fccce24cf2mr7440746qkk.785.1670254238200; Mon, 05 Dec 2022 07:30:38 -0800 (PST) Received: from hurd ([2607:fad8:4:3::1003]) by smtp.gmail.com with ESMTPSA id u4-20020a37ab04000000b006bb29d932e1sm5915482qke.105.2022.12.05.07.30.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Dec 2022 07:30:37 -0800 (PST) From: Maxim Cournoyer References: <20221204044347.23147-1-maxim.cournoyer@gmail.com> <875yernns5.fsf@gnu.org> Date: Mon, 05 Dec 2022 10:30:36 -0500 In-Reply-To: (Efraim Flashner's message of "Mon, 5 Dec 2022 12:36:21 +0200") Message-ID: <87pmcx6f6r.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Efraim, Efraim Flashner writes: [...] > Would it be better to do > > (define-deprecated/alias-public %base-packages-disk-utilities > %installer-disk-utilities) > > And remove the export from the list at the top of (gnu system)? Currently %installer-disk-utilities is not exported from (gnu system install). And even if it was, we'd still have to import it in (gnu system), which would perhaps introduce a module cycle. So I think the deprecation warning saying it's gone (i.e., using #f as replacement) is the most accurate and least problematic option. -- Thanks, Maxim From unknown Sat Jul 12 18:46:14 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#59661] [PATCH 0/3] Add e2fsprogs to %base-packages-utils. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 05 Dec 2022 15:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59661 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 59661@debbugs.gnu.org, Efraim Flashner Received: via spool by 59661-submit@debbugs.gnu.org id=B59661.167025436517146 (code B ref 59661); Mon, 05 Dec 2022 15:33:01 +0000 Received: (at 59661) by debbugs.gnu.org; 5 Dec 2022 15:32:45 +0000 Received: from localhost ([127.0.0.1]:36721 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2DSX-0004SU-Hx for submit@debbugs.gnu.org; Mon, 05 Dec 2022 10:32:45 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48416) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2DSW-0004SO-8a for 59661@debbugs.gnu.org; Mon, 05 Dec 2022 10:32:44 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2DSQ-0002c4-LZ; Mon, 05 Dec 2022 10:32:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=GQxcwLTnwg4LUD+kcSnFGOmzter9c2gRsrrL90gCloQ=; b=CjIIytxm7OVDuq+sb86Z K1uyYo4QXsUIPH5BdjDYWqhAWpmhlk4PVTjIjEVwmebFazYySYRLhMSwpmBja+8fuNJ+7Fc2OvBa9 CVNXL0R+qUkQYsMVP80hqeyTbE8NesBcxvMbkm5AxuQC065J6LAQ2m5f1TF8HRjv2Ag7J1h75+Kje qRB5mOTc93QpJq6vUhD5lObuTJi9CJAPh/kmJsvbv+mnuGKthriQUdjtqlN0eQ0DDHQkeUmV6hmNS g/pE7vXFLP0xNqSH4s9jTZ/69UW399ANVUfi2RLw7m0D3RmBhdr1oJBEV2R5trCVFYMY8ocAqqE5g B6wAjBWgHZIiGw==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2DSP-0004nK-Nt; Mon, 05 Dec 2022 10:32:38 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20221204044347.23147-1-maxim.cournoyer@gmail.com> <875yernns5.fsf@gnu.org> <87y1rm6e9m.fsf@gmail.com> Date: Mon, 05 Dec 2022 16:32:35 +0100 In-Reply-To: <87y1rm6e9m.fsf@gmail.com> (Maxim Cournoyer's message of "Sun, 04 Dec 2022 16:38:13 -0500") Message-ID: <87tu29q31o.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Maxim Cournoyer skribis: > Ludovic Court=C3=A8s writes: [...] >>> +(define-deprecated %base-packages-disk-utilities #f '()) >> >> =E2=80=98#f=E2=80=99 here would lead to weird deprecation messages. I= =E2=80=99d make it: >> >> (define-deprecated %base-packages-disk-utilities %base-packages '()) >> >> This is not quite accurate but it should convey the idea. > > I had shown an actual message example produced when using #f. It is > what I want (it just mentions the variable is deprecated, and doesn't > mention a replacement -- there are none in this case). For a quick > reference, this is how 'warn-about-deprecation' is defined: > > (define* (warn-about-deprecation variable properties > #:key replacement) > (let ((location (and properties (source-properties->location properties= )))) > (if replacement > (warning location (G_ "'~a' is deprecated, use '~a' instead~%") > variable replacement) > (warning location (G_ "'~a' is deprecated~%") > variable)))) > > So I prefer my version. Oh I had overlooked it, sorry for the confusion. I prefer your version as well; LGTM! Ludo=E2=80=99. From unknown Sat Jul 12 18:46:14 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#59661] [PATCH 0/3] Add e2fsprogs to %base-packages-utils. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 05 Dec 2022 15:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59661 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Efraim Flashner Cc: 59661@debbugs.gnu.org, Maxim Cournoyer Received: via spool by 59661-submit@debbugs.gnu.org id=B59661.167025450017209 (code B ref 59661); Mon, 05 Dec 2022 15:35:01 +0000 Received: (at 59661) by debbugs.gnu.org; 5 Dec 2022 15:35:00 +0000 Received: from localhost ([127.0.0.1]:36735 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2DUi-0004TV-17 for submit@debbugs.gnu.org; Mon, 05 Dec 2022 10:35:00 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39714) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2DUg-0004TO-5F for 59661@debbugs.gnu.org; Mon, 05 Dec 2022 10:34:58 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2DUa-0002mX-UQ; Mon, 05 Dec 2022 10:34:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=PeU3UXk9sl3+WKuO7QviV9u7u0LaYcA67IpGkCTafMA=; b=jKCzBAs4fYh+bUp/CRzS I6aPUdoRo/If+eHsm/jV8Cv9XTmaTDfSfVYRDftsP5x3zSelAeAJRXLrmT0nXkUXqpxTAefbzWb57 s/8M32EmlRYaaE/8sGMKzCOisp0nPoUJ04ch+T+1s5vLpO/OKV2FUMS8WlIt1qBl8jWsTCXhJ6t39 xFIHhPZRmMnLIkmsfLyPPxZ+m9PY7vpi+8eN/PrEptG1SKSguEIzxsgbnhZQNBy51zRVRXfg9CHsG VoT7azZEfl8LMlvMYYw+bjNldEdERY2E+09E71eEy4IpGFX6PIFSaCOb/gEiPEO5bsOQG+gS7C4LH l4+4L9blQsbAeA==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2DUa-0003YF-Dn; Mon, 05 Dec 2022 10:34:52 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20221204044347.23147-1-maxim.cournoyer@gmail.com> <875yernns5.fsf@gnu.org> Date: Mon, 05 Dec 2022 16:34:50 +0100 In-Reply-To: (Efraim Flashner's message of "Mon, 5 Dec 2022 12:36:21 +0200") Message-ID: <87pmcxq2xx.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Efraim Flashner skribis: > On Sun, Dec 04, 2022 at 05:20:42PM +0100, Ludovic Court=C3=A8s wrote: >> Hi, >>=20 >> Maxim Cournoyer skribis: >>=20 >> > Rationale: It is only used in INSTALLATION-OS and doesn't make sense t= o be >> > used in another context, given that file systems now automatically pul= l their >> > dependencies since commit 45eac6cdf5c8d9d7b0c564b105c790d2d2007799 (se= rvices: >> > Add file system utilities to profile). >> > >> > * gnu/system.scm (%base-packages-disk-utilities): Deprecate and rename= to... >> > * gnu/system/install.scm (%installer-disk-utilities): ... this. >> > (installation-os) [packages]: Adjust accordingly. >>=20 >> Efraim, this variable was added in >> e6e076281e62518056987e9ddd3d96fccab20475 and used in >> 4170af491c8bc3b0a5308116a26e758d8ff245c5; do you think it=E2=80=99s okay= to >> remove now? (It LGTM, but I=E2=80=99d like to make sure we don=E2=80=99= t create churn.) > > I looked back through the commits around there. The whole point was the > following commit, to divide the longish haphazard list of packages into > sets of a sort. If it's only used in (gnu system install) then I don't > see a problem with moving it there. OK. >> (define-deprecated %base-packages-disk-utilities %base-packages '()) >>=20 >> This is not quite accurate but it should convey the idea. > > Would it be better to do > > (define-deprecated/alias-public %base-packages-disk-utilities > %installer-disk-utilities) > > And remove the export from the list at the top of (gnu system)? I don=E2=80=99t think we want users to rely on =E2=80=98%installer-disk-uti= lities=E2=80=99 in their OS config, so I=E2=80=99d go for Maxim=E2=80=99s version. Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 05 11:32:13 2022 Received: (at control) by debbugs.gnu.org; 5 Dec 2022 16:32:13 +0000 Received: from localhost ([127.0.0.1]:37047 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2EO5-00054K-Lp for submit@debbugs.gnu.org; Mon, 05 Dec 2022 11:32:13 -0500 Received: from mail-qt1-f174.google.com ([209.85.160.174]:37818) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2EO4-00054E-4K for control@debbugs.gnu.org; Mon, 05 Dec 2022 11:32:12 -0500 Received: by mail-qt1-f174.google.com with SMTP id l15so11783959qtv.4 for ; Mon, 05 Dec 2022 08:32:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:from:to:message-id:date:from:to:cc:subject:date:message-id :reply-to; bh=tNwFjctP2RGCSqVfTyFta1ngw1vQI1yEAEfNYWmd+b8=; b=oCA3d2KzsjWJ8RAjjrHzP3D9B+X3eae5FpJl6IEwDxpyV6Htd5z3zQ640knpykpfwD LO0PQKyzaFr2oZv8P2A+onarRZhQiHZ/D3O3y0BAWYkhU+NjtZvw4uwYcJIfqi8mf37f D3yRj7AQBkPzu2EqXf+IC5ZAw7B3HWqbhUZmL1Tu602nkFf6idA0NiuAuGHYs2Z4mys6 8S2Whq2iH0TVM+yu9fFtvm1B/DLQ6lHG9/keyOArwr1bjog+49mmu47k1GOQ5/Rj2OOY KasZt3vtwC2aCAVP28rz0pbHYsmgihCXvMaIJ9LL3KzMEiddQIJEARL8wvmuJD8SudEb cFSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=subject:from:to:message-id:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tNwFjctP2RGCSqVfTyFta1ngw1vQI1yEAEfNYWmd+b8=; b=ioerhNAlKpf8yjbPX+Gg9aCaba7xc6AdS99fAJUSpQQL+2YMRR9rPu2jFuCWkoSna2 CSvqIMAOsMYzeAYwz4BAeqzTR1msK9W67z2OK0W+37i4/HeHLQxQ1X/wsgvZn0BHUt1s 5U/HKAr2eFejv46nwlIcnkGUq32hcTXB73Resh3Df95bA4GnbNNi77Rdb8lufTAToTTD CEIGYDpQ5tk4yojWiFg1IiJ5UjsfXNoXMpUxC5gDao/pIn6mmlQcEXvhb8FzMMrxP29A 8ruMYhype+p0gr61/hBsCbOc6VmiFk9YM9nBKN0AJ7K5FYLnC/9P/U1a6kiLceiOWdjl SviA== X-Gm-Message-State: ANoB5pkjlkQpGcBGmUBkhZFhcYCld7dNmeXWrHUs+52X0pG7Lgl1VQ7n M1jV+eqZ3FBWEdWy4Lq93oVbrws3qK4= X-Google-Smtp-Source: AA0mqf4fL6bUnuDfQkg2FqCFBWZ23nkJyYUWBtVfSCdp3T+KhnvFRPgq/L7G96Y24xIrRLMffzVRKQ== X-Received: by 2002:a05:622a:4a84:b0:3a7:e5e4:3736 with SMTP id fw4-20020a05622a4a8400b003a7e5e43736mr3028321qtb.533.1670257926336; Mon, 05 Dec 2022 08:32:06 -0800 (PST) Received: from hurd ([2607:fad8:4:3::1003]) by smtp.gmail.com with ESMTPSA id u6-20020a05620a430600b006fc5a1d9cd4sm12744535qko.34.2022.12.05.08.32.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Dec 2022 08:32:05 -0800 (PST) Date: Mon, 05 Dec 2022 11:32:04 -0500 Message-Id: <87h6y96ccb.fsf@gmail.com> To: control@debbugs.gnu.org From: Maxim Cournoyer Subject: control message for bug #58238 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) merge 58238 59661 quit From unknown Sat Jul 12 18:46:14 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Maxim Cournoyer Subject: bug#59661: closed (Re: bug#59661: [PATCH 0/3] Add e2fsprogs to %base-packages-utils.) Message-ID: References: <878rjl6br1.fsf_-_@gmail.com> <20221128191831.1325-1-maxim.cournoyer@gmail.com> X-Gnu-PR-Message: they-closed 59661 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: moreinfo patch Reply-To: 59661@debbugs.gnu.org Date: Mon, 05 Dec 2022 16:45:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1670258703-20048-1" This is a multi-part message in MIME format... ------------=_1670258703-20048-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #59661: [PATCH 0/3] Add e2fsprogs to %base-packages-utils. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 59661@debbugs.gnu.org. --=20 59661: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D59661 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1670258703-20048-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 59661-done) by debbugs.gnu.org; 5 Dec 2022 16:44:59 +0000 Received: from localhost ([127.0.0.1]:37126 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2EaR-0005CW-DD for submit@debbugs.gnu.org; Mon, 05 Dec 2022 11:44:59 -0500 Received: from mail-qk1-f170.google.com ([209.85.222.170]:37629) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2EaP-0005CO-R9 for 59661-done@debbugs.gnu.org; Mon, 05 Dec 2022 11:44:58 -0500 Received: by mail-qk1-f170.google.com with SMTP id x18so5417676qki.4 for <59661-done@debbugs.gnu.org>; Mon, 05 Dec 2022 08:44:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=l+8Yb34DPcZsost6NhXmk2NoV0RSXNz/XEWIqFvWp5U=; b=T+/sNJ1dsEYGgPl65A0+0aXM4TxgPaTf1ZIx1bRtTxvUxnFXG5t2dfpL0nVIj8q87w 90wkLiCukRGIB2Z1sAsIUtFtaUI0O1HP3sIEkOgtit65ozktsR/c1S5B/03bML8tKpl1 fZ0R6DAOvAyFsAVbYMVd8+tdFNCCIcvSekkzuokQF889zUKxO/2gA+wQW91GT3bsfSOT Iske0bFwNK2oVqMf0npk72n0MKapfIVBOX/Ue5EsGtah3fyHIWBbIzgIX+LXIuIJzZky xpCR6PcHc1bJdaA3/IWeb7rcWNjL1/yJWo9tJ+rMJiaxjgLaw//MBUH++3MIX9SIJJFN kyDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=l+8Yb34DPcZsost6NhXmk2NoV0RSXNz/XEWIqFvWp5U=; b=QH0guvsTn0Ih8Gw+n1UAVz4S+Kjd/LSRT4Zt2W3ROE0hG+rqcnJ3e3D8tNaFNYzK9J g+/WSbmXOgXjRulQN6DgDrBBRSnJdbytwT4hoEXdiApP+fxPLMdCnW6aEY3Z6OtFHeZY D2rcdTEyMN0Mt4oxsqy5yNEikmbv5CQHkW7tlTYKV331JY7WBZSOLvzsJC56olrLvc5a yf6JypJMMpgj2yVGIWEyNGVRVMIY36C0tA+5eft/+uV/PcP/KKYB5Uan4x4W6ysuRE2k BNOG+FOxQ6MN9U0npISE0Aq/QJv+6JPHms99n9Em1IXl7gWWvHryIKGbpNc6rcvm6GC+ IzCg== X-Gm-Message-State: ANoB5pk/m+yi2K7RxTOfXbUeOtJEPKXBgnoLDqAJOu1ohVP9I1oZfd1x ouPNHL1uJsKy99UGDNSPGe6gqlYpVa4= X-Google-Smtp-Source: AA0mqf56wIFhZz0P44fkTFYRo2rorX7HvlA3Ke1ccVWCYULtgx+lZ4fVaRz8hjOiXTTPOYvJMZE4bQ== X-Received: by 2002:a05:620a:a5e:b0:6ef:166e:f070 with SMTP id j30-20020a05620a0a5e00b006ef166ef070mr56606551qka.56.1670258692187; Mon, 05 Dec 2022 08:44:52 -0800 (PST) Received: from hurd ([2607:fad8:4:3::1003]) by smtp.gmail.com with ESMTPSA id do22-20020a05620a2b1600b006fcc3858044sm6517220qkb.86.2022.12.05.08.44.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Dec 2022 08:44:51 -0800 (PST) From: Maxim Cournoyer To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#59661: [PATCH 0/3] Add e2fsprogs to %base-packages-utils. References: <20221204044347.23147-1-maxim.cournoyer@gmail.com> <20221204044347.23147-2-maxim.cournoyer@gmail.com> <87wn77m8kw.fsf@gnu.org> <877cz7m62b.fsf_-_@gnu.org> Date: Mon, 05 Dec 2022 11:44:50 -0500 In-Reply-To: <877cz7m62b.fsf_-_@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s?= =?utf-8?Q?=22's?= message of "Sun, 04 Dec 2022 18:28:44 +0100") Message-ID: <878rjl6br1.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59661-done Cc: 59661-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Ludovic Court=C3=A8s writes: > Ludovic Court=C3=A8s skribis: > >> Maxim Cournoyer skribis: >> >>> * gnu/system/install.scm (%installer-disk-utilities): Add e2fsprogs. >> >> LGTM! >> >> e2fsprogs binaries are indeed missing from $PATH in >> guix-system-install-1.4.0rc1.*.iso; I=E2=80=99ll cherry-pick it on >> =E2=80=98version-1.4.0=E2=80=99. >> >> What I don=E2=80=99t get is that our manual installation tests should ha= ve >> caught this issue because they use =E2=80=98mkfs.ext4=E2=80=99 and expec= t to have it in >> $PATH. I=E2=80=99ll take a look=E2=80=A6 > > Got it: Mathieu worked around it in > 0f66ef9aa99d2043abccbc80d858bdeca57534ac by explicitly adding e2fsprogs > and the installation system used by the tests: > > commit 0f66ef9aa99d2043abccbc80d858bdeca57534ac > Author: Mathieu Othacehe > Date: Fri Sep 30 15:19:36 2022 +0200 > > tests: install: Fix iso-image-installer test. > > This is a follow-up of: 45eac6cdf5c8d9d7b0c564b105c790d2d2007799. > It fixes the following error: > > + mkfs.ext4 -L my-root /dev/vda2 > sh: line 12: mkfs.ext4: command not found > > * gnu/tests/install.scm (%test-iso-image-installer): Add e2fsprogs = to the > appended packages. > > We should be able to revert this commit once the installer provides > e2fsprogs by default. I applied this series, reverted 0f66ef9aa99d2043abccbc80d858bdeca57534ac as suggested above, ran: --8<---------------cut here---------------start------------->8--- make check-system TESTS=3Diso-image-installer --8<---------------cut here---------------end--------------->8--- And pushed! Closing. --=20 Thanks, Maxim ------------=_1670258703-20048-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 28 Nov 2022 19:18:41 +0000 Received: from localhost ([127.0.0.1]:50397 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozjeL-0001KP-H1 for submit@debbugs.gnu.org; Mon, 28 Nov 2022 14:18:41 -0500 Received: from lists.gnu.org ([209.51.188.17]:49090) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozjeK-0001KJ-1I for submit@debbugs.gnu.org; Mon, 28 Nov 2022 14:18:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozjeJ-0002RS-Rm for guix-patches@gnu.org; Mon, 28 Nov 2022 14:18:39 -0500 Received: from mail-qt1-x82b.google.com ([2607:f8b0:4864:20::82b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ozjeI-0007nl-EK for guix-patches@gnu.org; Mon, 28 Nov 2022 14:18:39 -0500 Received: by mail-qt1-x82b.google.com with SMTP id jr19so7402491qtb.7 for ; Mon, 28 Nov 2022 11:18:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=mmBXCMJjudMbqbjrYw/1hHHM/87iMf49qEBTHht02gs=; b=pFmkfv2aLCm4Wz0XO5bP0s4OFd355UvqXoKTe6knpXOk0iIM26py2CZ8K1fk26loS8 c6yEgZ6VGSeWjGOdgwf5hoUsAjkfV0TKLTxilQ3vkSS1UNCnEk0mmsuj5vnvjxG7Z4IH 3SqpNyBVP2abQIyZ2u4gz5unEcRftuvrp9Trn73TrWSWaffLx2WiWwsRO3olR44XZN1X StA8fMU2kHwtrjiup7Oun/e/iHeo/hIF7NT2zsWk5pKVZo0Py7q0Yy0O7J+aPqZYvx6p j3myMgJPd4QNnDjnrUJbOkKOAgHquPWvv9ObpeZRrxEa1DkA0osIPotyIorHme7YDeQa khCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mmBXCMJjudMbqbjrYw/1hHHM/87iMf49qEBTHht02gs=; b=cDKUQ8AGw+9tcHWroDxEmIi81+6ThQU/0ulxjYFge7WsRBCmFIXWdj1aeMuqe5X8VQ PFslKR5dNNpGCn8FgnAY00T4YRlU/QLFHgmBjBvR/xz2NytvEw73vw2SI8v5/4wmDhX6 oi2I6MsUVTIcew9ppMv49uSuQ5jnFT5IHaNrmem56G9xSjvMmv0jBrbppvoQ6PoVap7Z TDEa6bdcOOjji2rec9vGzp9++8UC2hLEyHNL6JCgErFu2gzb13RSISKJQhgzFbP3oxww 6bUJb9q9CCw0zIRJ4KKnJDaeqlhB2EA7Zgb3Dei5b+MC1v3xm5Pmc6KHgJQ2ZAIwocT2 raGw== X-Gm-Message-State: ANoB5pn8nI3Jk+UblwOBvu/YQ6ZxU6vRFk9AZd2QNRduSexkv8ufAQuk EQ/p1qKwHdZRHUlkGIT4vbEW1rwCKAc= X-Google-Smtp-Source: AA0mqf5rEUmir1ihiXrPAbQoD2hW3Js2+VqKSA11lmmQ0u35r2xjLKhnQ/hj1mBvqopKWYt/T6CNwg== X-Received: by 2002:ac8:5296:0:b0:3a5:ab2c:38d6 with SMTP id s22-20020ac85296000000b003a5ab2c38d6mr34204169qtn.341.1669663116045; Mon, 28 Nov 2022 11:18:36 -0800 (PST) Received: from localhost.localdomain ([2607:fad8:4:3::1004]) by smtp.gmail.com with ESMTPSA id d16-20020a376810000000b006b640efe6dasm8659727qkc.132.2022.11.28.11.18.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Nov 2022 11:18:35 -0800 (PST) From: Maxim Cournoyer To: guix-patches@gnu.org Subject: [PATCH 0/3] Add e2fsprogs to %base-packages-utils. Date: Mon, 28 Nov 2022 14:18:31 -0500 Message-Id: <20221128191831.1325-1-maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::82b; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qt1-x82b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.3 (/) X-Debbugs-Envelope-To: submit Cc: Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi Guix, Here's a simple series adjusting some annoyance noticed by someone on guix-help (no e2fsprogs in installer) and by myself (no lsattr/chattr on my system). Thank you, Maxim Cournoyer (3): system: Rename and move %base-packages-disk-utilities. install: Add missing e2fsprogs utility. system: Add e2fsprogs to %base-packages-utils. gnu/system.scm | 18 ++---------------- gnu/system/install.scm | 17 ++++++++++++++++- 2 files changed, 18 insertions(+), 17 deletions(-) base-commit: 059d38dc3f8b087f4a42df586daeb05761ee18d7 -- 2.38.1 ------------=_1670258703-20048-1-- From unknown Sat Jul 12 18:46:14 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Adam Kandur Subject: bug#58238: closed (Re: bug#59661: [PATCH 0/3] Add e2fsprogs to %base-packages-utils.) Message-ID: References: <878rjl6br1.fsf_-_@gmail.com> <20221001230917.2150-1-kefironpremise@gmail.com> X-Gnu-PR-Message: they-closed 58238 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: moreinfo patch Reply-To: 58238@debbugs.gnu.org Date: Mon, 05 Dec 2022 16:45:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1670258703-20048-3" This is a multi-part message in MIME format... ------------=_1670258703-20048-3 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #59661: [PATCH] make e2fsprogs visible which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 58238@debbugs.gnu.org. --=20 59661: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D59661 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1670258703-20048-3 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 59661-done) by debbugs.gnu.org; 5 Dec 2022 16:44:59 +0000 Received: from localhost ([127.0.0.1]:37126 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2EaR-0005CW-DD for submit@debbugs.gnu.org; Mon, 05 Dec 2022 11:44:59 -0500 Received: from mail-qk1-f170.google.com ([209.85.222.170]:37629) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2EaP-0005CO-R9 for 59661-done@debbugs.gnu.org; Mon, 05 Dec 2022 11:44:58 -0500 Received: by mail-qk1-f170.google.com with SMTP id x18so5417676qki.4 for <59661-done@debbugs.gnu.org>; Mon, 05 Dec 2022 08:44:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=l+8Yb34DPcZsost6NhXmk2NoV0RSXNz/XEWIqFvWp5U=; b=T+/sNJ1dsEYGgPl65A0+0aXM4TxgPaTf1ZIx1bRtTxvUxnFXG5t2dfpL0nVIj8q87w 90wkLiCukRGIB2Z1sAsIUtFtaUI0O1HP3sIEkOgtit65ozktsR/c1S5B/03bML8tKpl1 fZ0R6DAOvAyFsAVbYMVd8+tdFNCCIcvSekkzuokQF889zUKxO/2gA+wQW91GT3bsfSOT Iske0bFwNK2oVqMf0npk72n0MKapfIVBOX/Ue5EsGtah3fyHIWBbIzgIX+LXIuIJzZky xpCR6PcHc1bJdaA3/IWeb7rcWNjL1/yJWo9tJ+rMJiaxjgLaw//MBUH++3MIX9SIJJFN kyDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=l+8Yb34DPcZsost6NhXmk2NoV0RSXNz/XEWIqFvWp5U=; b=QH0guvsTn0Ih8Gw+n1UAVz4S+Kjd/LSRT4Zt2W3ROE0hG+rqcnJ3e3D8tNaFNYzK9J g+/WSbmXOgXjRulQN6DgDrBBRSnJdbytwT4hoEXdiApP+fxPLMdCnW6aEY3Z6OtFHeZY D2rcdTEyMN0Mt4oxsqy5yNEikmbv5CQHkW7tlTYKV331JY7WBZSOLvzsJC56olrLvc5a yf6JypJMMpgj2yVGIWEyNGVRVMIY36C0tA+5eft/+uV/PcP/KKYB5Uan4x4W6ysuRE2k BNOG+FOxQ6MN9U0npISE0Aq/QJv+6JPHms99n9Em1IXl7gWWvHryIKGbpNc6rcvm6GC+ IzCg== X-Gm-Message-State: ANoB5pk/m+yi2K7RxTOfXbUeOtJEPKXBgnoLDqAJOu1ohVP9I1oZfd1x ouPNHL1uJsKy99UGDNSPGe6gqlYpVa4= X-Google-Smtp-Source: AA0mqf56wIFhZz0P44fkTFYRo2rorX7HvlA3Ke1ccVWCYULtgx+lZ4fVaRz8hjOiXTTPOYvJMZE4bQ== X-Received: by 2002:a05:620a:a5e:b0:6ef:166e:f070 with SMTP id j30-20020a05620a0a5e00b006ef166ef070mr56606551qka.56.1670258692187; Mon, 05 Dec 2022 08:44:52 -0800 (PST) Received: from hurd ([2607:fad8:4:3::1003]) by smtp.gmail.com with ESMTPSA id do22-20020a05620a2b1600b006fcc3858044sm6517220qkb.86.2022.12.05.08.44.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Dec 2022 08:44:51 -0800 (PST) From: Maxim Cournoyer To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#59661: [PATCH 0/3] Add e2fsprogs to %base-packages-utils. References: <20221204044347.23147-1-maxim.cournoyer@gmail.com> <20221204044347.23147-2-maxim.cournoyer@gmail.com> <87wn77m8kw.fsf@gnu.org> <877cz7m62b.fsf_-_@gnu.org> Date: Mon, 05 Dec 2022 11:44:50 -0500 In-Reply-To: <877cz7m62b.fsf_-_@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s?= =?utf-8?Q?=22's?= message of "Sun, 04 Dec 2022 18:28:44 +0100") Message-ID: <878rjl6br1.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59661-done Cc: 59661-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Ludovic Court=C3=A8s writes: > Ludovic Court=C3=A8s skribis: > >> Maxim Cournoyer skribis: >> >>> * gnu/system/install.scm (%installer-disk-utilities): Add e2fsprogs. >> >> LGTM! >> >> e2fsprogs binaries are indeed missing from $PATH in >> guix-system-install-1.4.0rc1.*.iso; I=E2=80=99ll cherry-pick it on >> =E2=80=98version-1.4.0=E2=80=99. >> >> What I don=E2=80=99t get is that our manual installation tests should ha= ve >> caught this issue because they use =E2=80=98mkfs.ext4=E2=80=99 and expec= t to have it in >> $PATH. I=E2=80=99ll take a look=E2=80=A6 > > Got it: Mathieu worked around it in > 0f66ef9aa99d2043abccbc80d858bdeca57534ac by explicitly adding e2fsprogs > and the installation system used by the tests: > > commit 0f66ef9aa99d2043abccbc80d858bdeca57534ac > Author: Mathieu Othacehe > Date: Fri Sep 30 15:19:36 2022 +0200 > > tests: install: Fix iso-image-installer test. > > This is a follow-up of: 45eac6cdf5c8d9d7b0c564b105c790d2d2007799. > It fixes the following error: > > + mkfs.ext4 -L my-root /dev/vda2 > sh: line 12: mkfs.ext4: command not found > > * gnu/tests/install.scm (%test-iso-image-installer): Add e2fsprogs = to the > appended packages. > > We should be able to revert this commit once the installer provides > e2fsprogs by default. I applied this series, reverted 0f66ef9aa99d2043abccbc80d858bdeca57534ac as suggested above, ran: --8<---------------cut here---------------start------------->8--- make check-system TESTS=3Diso-image-installer --8<---------------cut here---------------end--------------->8--- And pushed! Closing. --=20 Thanks, Maxim ------------=_1670258703-20048-3 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 1 Oct 2022 23:09:56 +0000 Received: from localhost ([127.0.0.1]:45858 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oelcK-0005IY-63 for submit@debbugs.gnu.org; Sat, 01 Oct 2022 19:09:56 -0400 Received: from lists.gnu.org ([209.51.188.17]:44916) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oelcJ-0005IR-0x for submit@debbugs.gnu.org; Sat, 01 Oct 2022 19:09:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37428) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oelcI-00089k-Rp for guix-patches@gnu.org; Sat, 01 Oct 2022 19:09:54 -0400 Received: from mail-ed1-x542.google.com ([2a00:1450:4864:20::542]:46645) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oelcH-0000kk-18 for guix-patches@gnu.org; Sat, 01 Oct 2022 19:09:54 -0400 Received: by mail-ed1-x542.google.com with SMTP id m15so10183441edb.13 for ; Sat, 01 Oct 2022 16:09:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date; bh=HqqyFAiutBtBNkWuXJ+cBS9LK1WJ66DXDGtKv1PsjZs=; b=iKcxWCPWVRQg5udNKQAyhgvVBTadhL2a/Mo9A5RzYUwlGzRXtIujwxa0whaYvYUH3p +rrzI77v+cmNun8psipzDmwLUhiOVXDRGLjOcrGyLAj7j/L9Wm7TflN162n33vDEgyCi dPkU6zxzyUYhEMkS6lpE6ek86r0HaQ4K/IlNDvvViO7mt/8GFbI0cCWXEe7NugzvAlHT egIJ1QBiORaCyAKNf4BYoOPOF/amYIvG1SzN3tUldG7olujVhbS9/qOuvxXZucnPkQ23 vanUbd7bqHpjICfLpj8dPxb/crlzLIZxsh9iI4yzmk7rLUU1G30NxII58xwzXec7uKRk e6xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date; bh=HqqyFAiutBtBNkWuXJ+cBS9LK1WJ66DXDGtKv1PsjZs=; b=oajaO9hVdWGLE0IsnVajpWVu0AoU2dekqQ8Mrfbp+r222OUSVU2Jqg6GmMfitFY6ws LJGJ+gWjRfHKd8tm294AMjQTDqMOCfR42tGVnhEDX8Xk2udUYzTeCjwaFNc2wRLS+K2K ut/qzaPyt6SLxAJnWA7ekZjc2X+z718oUFVKbZE1vI9BA22uWuBgcWNiSm+GX4ok5Kfr fVFrEvJ6qPWujZWJ5JpJ2f78njmNgG2mepm61gSjqt9LoZuli3RXqh2hnyRCZrIrcoWC sKavlptwtLP7CZhYq5JTR1Ykp0g7ck0ajK1gbLhZm3haIrWUTNaVUK4hdVQmd/n9/4Cv U4zw== X-Gm-Message-State: ACrzQf0g4ElEVTVtGOiGOP9ovskCeppTkNgGvKbid2tAf1lVXa00tOEg LcIdp2fUjMw3sP0jIARF+bXk+M7iors= X-Google-Smtp-Source: AMsMyM7MVd6Qu96j4GfOFn5+cgtu319aAph2aR2ZHHuWvVn60Ddt570wvVqmcGKvdDbgRw59hdz7HA== X-Received: by 2002:a05:6402:1d86:b0:457:e84:f0e with SMTP id dk6-20020a0564021d8600b004570e840f0emr12917660edb.241.1664665790163; Sat, 01 Oct 2022 16:09:50 -0700 (PDT) Received: from localhost.localdomain ([79.137.199.166]) by smtp.googlemail.com with ESMTPSA id p32-20020a056402502000b00457a92f8ad6sm4274080eda.28.2022.10.01.16.09.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Oct 2022 16:09:49 -0700 (PDT) From: Adam Kandur To: guix-patches@gnu.org Subject: [PATCH] make e2fsprogs visible Date: Sun, 2 Oct 2022 02:09:17 +0300 Message-Id: <20221001230917.2150-1-kefironpremise@gmail.com> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::542; envelope-from=kefironpremise@gmail.com; helo=mail-ed1-x542.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Adam Kandur X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --- Can I ask to add e2fsprogs to %base-packages? Because there is no e2fsprogs, there are no commands like mkfs.ext2 or mkfs.ext4 in the user profile during the installation. Commands are in /gnu/store/*e2fsprogs*/sbin/ and are usable. But it would be more convenient to have them available in the user profile. gnu/system.scm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gnu/system.scm b/gnu/system.scm index 66ca629..8e14ec3 100644 --- a/gnu/system.scm +++ b/gnu/system.scm @@ -913,7 +913,8 @@ (define %base-packages-disk-utilities (define %base-packages ;; Default set of packages globally visible. It should include anything ;; required for basic administrator tasks. - (append %base-packages-artwork + (append (list e2fsprogs) + %base-packages-artwork %base-packages-interactive %base-packages-linux %base-packages-networking -- 2.37.3 ------------=_1670258703-20048-3--