GNU bug report logs - #59660
29.0.50; typescript-ts-mode consistently fontifies method-names incorrectly

Previous Next

Package: emacs;

Reported by: jostein <at> kjonigsen.net

Date: Mon, 28 Nov 2022 15:05:03 UTC

Severity: normal

Found in version 29.0.50

Fixed in version 29.1

Done: Yuan Fu <casouri <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


Message #38 received at 59660 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>
Cc: 59660 <at> debbugs.gnu.org, casouri <at> gmail.com, jostein <at> kjonigsen.net,
 theo <at> thornhill.no
Subject: Re: bug#59660: 29.0.50; typescript-ts-mode consistently fontifies
 method-names incorrectly
Date: Tue, 29 Nov 2022 16:30:09 +0200
> Date: Tue, 29 Nov 2022 14:58:59 +0100
> Cc: jostein <at> kjonigsen.net, 59660 <at> debbugs.gnu.org, theo <at> thornhill.no
> From: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>
> 
> > This could be a personal preference, perhaps?  It isn't clear to me that
> > only one of the two is definitely correct.  So maybe we need a user option
> > for which one overrides which?
> 
> I honestly think this is reasonably clear.
> 
> "Properties" with getters and setters are at this point in time almost 
> entirely unused in EcmaScript/TypeScript space. They are optional and 
> have complicated syntax, and don't play well with JSON serialization 
> (and thus can't be used in REST APIs).

So you are saying Typescript should not even support these features in the
tree-sitter based fontifications?  If so, I'm okay with that, but it sounds
like :override is the wrong tool for that, and we should simply remove
"properties" from the list of features for Typescript?




This bug report was last modified 2 years and 197 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.