GNU bug report logs - #59660
29.0.50; typescript-ts-mode consistently fontifies method-names incorrectly

Previous Next

Full log

Message #29 received at 59660 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: jostein <at> kjonigsen.net
Cc: 59660 <at> debbugs.gnu.org, theo <at> thornhill.no
Subject: Re: bug#59660: 29.0.50; typescript-ts-mode consistently fontifies
 method-names incorrectly
Date: Mon, 28 Nov 2022 15:06:30 -0800

> On Nov 28, 2022, at 7:04 AM, Jostein Kjønigsen <jostein <at> secure.kjonigsen.net> wrote:
> 
> From: "Jostein Kjønigsen" <jostein <at> ThinkPad-T14s.mail-host-address-is-not-set>
> To: bug-gnu-emacs <at> gnu.org
> Subject: 29.0.50; typescript-ts-mode consistently fontifies method-names incorrectly
> --text follows this line--
> 
> --
> When I:
> 
> 1. create a typescript file (sample.ts)
> 2. create class and add some methods to it.
> 
> I observe that:
> 
> - method names are consistently fontified as font-lock-property-face.
> 
> I expected that:
> 
> - method names to be consistently fontified as font-luck-function-name-face.
> 
> This seems to be because of the "property_identifier" is used for
> functions in the treesitter-grammar, and this property is used
> indiscriminately to apply font-lock-property-face at the bottom of the
> major-mode grammar.
> 
> This "shadows" the former rules which correctly apply font-lock-function-name-face.
> 
> The best would obviously have a way to identify properties more accurately, to precent
> shadowing from taking place. Unfortunately I cannot see a realiable way to do that
> based on the current parse-tree.
> 
> Seeing as properties in Typescript are fairly rare while methods are very common,
> it seems appropriate to me to remove the property-specific fontification rules
> to restore the method-fontification rules.
> 
> I got a patch for this ready, if people are willing to accept it.

Maybe you can remove the :override flag for the property_identifier rule, so it doesn’t shadow the function rule? Would that work better?

Yuan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.