GNU bug report logs - #59660
29.0.50; typescript-ts-mode consistently fontifies method-names incorrectly

Previous Next

Full log

View this message in rfc822 format

From: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>
To: Eli Zaretskii <eliz <at> gnu.org>, jostein <at> kjonigsen.net
Cc: 59660 <at> debbugs.gnu.org, casouri <at> gmail.com, theo <at> thornhill.no
Subject: bug#59660: lisp/progmodes/typescript-ts-mode.el: restore method-name fontification
Date: Mon, 28 Nov 2022 19:00:53 +0100

[Message part 1 (text/plain, inline)]

On 28.11.2022 18:27, Eli Zaretskii wrote:
>> Date: Mon, 28 Nov 2022 18:08:01 +0100
>> From: Jostein Kjønigsen<jostein <at> secure.kjonigsen.net>
>>
>> All fixes and one more squashed into the attached patch :)
> Which "all", please?  AFAICT, you also posted a patch in another bug number,
> so is that also included?

No.

I've registered separate bugs for csharp-ts-mode and typescript-ts-mode, 
since they are distinct major-modes with no code in common.

As such patches for C# has been sent to the C# bug.

And TypeScript patches have been sent to the TypeScript-bug.

As for "all", both csharp-ts-mode and typescript-ts-mode are "new" 
modes, and as such probably will have a few ripening issues once tested 
on real production code-bases and daily use (like I do now),

In name of brewity, I decided not to file a bug-report for every single 
fontification issue I found, but rather bulk up the fixes per mode on 
the respective bugs for those two languages. I hope this is OK.

As for TypeScript, IMO there still are a few minor issues wrt to how 
font-lock-variable-name-face gets applied (or not), but I don't have 
patches for those yet, and I would not consider them deal-breakers or 
release-killers :)

--
Kind regards*
Jostein Kjønigsen*

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.