From unknown Sun Jul 13 03:50:03 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#59660 <59660@debbugs.gnu.org> To: bug#59660 <59660@debbugs.gnu.org> Subject: Status: 29.0.50; typescript-ts-mode consistently fontifies method-names incorrectly Reply-To: bug#59660 <59660@debbugs.gnu.org> Date: Sun, 13 Jul 2025 10:50:03 +0000 retitle 59660 29.0.50; typescript-ts-mode consistently fontifies method-nam= es incorrectly reassign 59660 emacs submitter 59660 jostein@kjonigsen.net severity 59660 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 28 10:05:02 2022 Received: (at submit) by debbugs.gnu.org; 28 Nov 2022 15:05:02 +0000 Received: from localhost ([127.0.0.1]:49100 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozfgq-0005Bs-N2 for submit@debbugs.gnu.org; Mon, 28 Nov 2022 10:05:02 -0500 Received: from lists.gnu.org ([209.51.188.17]:38386) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozfgn-0005Bm-Ei for submit@debbugs.gnu.org; Mon, 28 Nov 2022 10:04:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozfgi-0000Dt-MN for bug-gnu-emacs@gnu.org; Mon, 28 Nov 2022 10:04:54 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozfgd-0005sQ-83 for bug-gnu-emacs@gnu.org; Mon, 28 Nov 2022 10:04:51 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 344E85C012C; Mon, 28 Nov 2022 10:04:45 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Mon, 28 Nov 2022 10:04:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:reply-to:sender :subject:subject:to:to; s=fm3; t=1669647885; x=1669734285; bh=Dw Ham5WsUT0Nvbsxa37Q/3+oiHNHvJBECFVZSWkRlxM=; b=Yik2SN0guG6+sB+zOZ /AmDhKsfF4ZumF1gg4hjEBw1oa/Tsh2n/Jt4q1Ut0LN7VImT4eKnAG4nkSzp/OVH NZqxtXh6hALc7KD+5EdfbzHYEoNa6EhiXjrI21mfZ2B9wRuW8WdivdyOBrcB/GUr iFa4CsNlzYQsTkJthxMqZgxxMiqZGKiMEw0gyFv6kEjasT2mtcEL9GSc6Yp+nb7h pyRyP12BozChavKuw5fWJwuxO8qeBbwFrSXv9mQEeyn/yLV/pv2YhZ8U/I1RxpXH Ic5lHw2F+ZkQAmGRIerObxzNsO0HkQela565guYHNRqvrg4337xzm9F/1RzfggoL 37bg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:message-id:mime-version :reply-to:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1669647885; x=1669734285; bh=DwHam5WsUT0Nvbsxa37Q/3+oiHNHvJBECFV ZSWkRlxM=; b=sDlpF9atT1ITjo46WMZDSPug1F8aZlOE5/nOH4xzs44XCEWK8rb NlchjQ/LhUnJZRRNE2GXocq91RRqOsX4H5zcxV/vNjL8bjquIQUgUubphUVFVGN0 Z+5AguzA8d+ePZHAocg6EoWHgoi10/rd+Zm0HWRrB1f1AjI1++M13vI5G0l0dp+8 r1sPmG4jQz8RNVfs/cIpyU0ujjRsxzf8geGyA2yaB9JxIjn10dIwg5/9F/IzlL/T eQ+q9GbkrP2buLSpDw5u6JDGriuv3WYU9yMi7LcyXDP36vVsTeOuIMkw71c2zdF0 CPC3V2kzyFtU+C5xLg5pEUPvoGJsRaZFfhg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrjedvgdejfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpegtkfffgggfrhfvhffusegrtderredtfeejnecuhfhrohhmpeflohhsthgvihhn ucfmjhppnhhighhsvghnuceojhhoshhtvghinhesshgvtghurhgvrdhkjhhonhhighhsvg hnrdhnvghtqeenucggtffrrghtthgvrhhnpeethfelgfetgfeiieeghfeukeefjefgveeu kefgudegheehuefftddvjeeiiefhjeenucffohhmrghinhepkhhjnhhighhsvghnrdhnoh enucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehjohhs thgvihhnsehsvggtuhhrvgdrkhhjohhnihhgshgvnhdrnhgvth X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 28 Nov 2022 10:04:43 -0500 (EST) Content-Type: multipart/alternative; boundary="------------lZQoF2ERdgA2CHN7t5s0VgnM" Message-ID: Date: Mon, 28 Nov 2022 16:04:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Content-Language: nb-NO To: "bug-gnu-emacs@gnu.org" , Theodor Thornhill , Yuan Fu From: =?UTF-8?Q?Jostein_Kj=c3=b8nigsen?= Subject: 29.0.50; typescript-ts-mode consistently fontifies method-names incorrectly Received-SPF: pass client-ip=66.111.4.25; envelope-from=jostein@secure.kjonigsen.net; helo=out1-smtp.messagingengine.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: jostein@kjonigsen.net Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) This is a multi-part message in MIME format. --------------lZQoF2ERdgA2CHN7t5s0VgnM Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit From: "Jostein Kjønigsen" To: bug-gnu-emacs@gnu.org Subject: 29.0.50; typescript-ts-mode consistently fontifies method-names incorrectly --text follows this line-- -- When I: 1. create a typescript file (sample.ts) 2. create class and add some methods to it. I observe that: - method names are consistently fontified as font-lock-property-face. I expected that: - method names to be consistently fontified as font-luck-function-name-face. This seems to be because of the "property_identifier" is used for functions in the treesitter-grammar, and this property is used indiscriminately to apply font-lock-property-face at the bottom of the major-mode grammar. This "shadows" the former rules which correctly apply font-lock-function-name-face. The best would obviously have a way to identify properties more accurately, to precent shadowing from taking place. Unfortunately I cannot see a realiable way to do that based on the current parse-tree. Seeing as properties in Typescript are fairly rare while methods are very common, it seems appropriate to me to remove the property-specific fontification rules to restore the method-fontification rules. I got a patch for this ready, if people are willing to accept it. -- In GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version  3.24.34, cairo version 1.16.0) of 2022-11-28 built on ThinkPad-T14s Repository revision: a85ff22300736212e38f43cc7d56e8e3d4ae1203 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12201003 System Description: Ubuntu 22.10 Configured using:  'configure --with-tree-sitter' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB Important settings:   value of $LC_MONETARY: nb_NO.UTF-8   value of $LC_NUMERIC: nb_NO.UTF-8   value of $LC_TIME: nb_NO.UTF-8   value of $LANG: en_US.UTF-8   locale-coding-system: utf-8-unix Major mode: TypeScript Minor modes in effect:   global-git-commit-mode: t   magit-auto-revert-mode: t   lsp-diagnostics-mode: t   lsp-headerline-breadcrumb-mode: t   lsp-modeline-workspace-status-mode: t   lsp-modeline-diagnostics-mode: t   lsp-modeline-code-actions-mode: t   electric-pair-mode: t   lsp-completion-mode: t   editorconfig-mode: t   flycheck-mode: t   which-function-mode: t   nlinum-mode: t   company-mode: t   global-ede-mode: t   dap-tooltip-mode: t   dap-ui-many-windows-mode: t   dap-ui-controls-mode: t   dap-ui-mode: t   treemacs-filewatch-mode: t   treemacs-follow-mode: t   treemacs-git-mode: t   treemacs-fringe-indicator-mode: t   dap-auto-configure-mode: t   dap-mode: t   global-undo-tree-mode: t   undo-tree-mode: t   doom-modeline-mode: t   projectile-mode: t   ido-yes-or-no-mode: t   helm-mode: t   helm-minibuffer-history-mode: t   helm--remap-mouse-mode: t   async-bytecomp-package-mode: t   delete-selection-mode: t   global-auto-revert-mode: t   server-mode: t   shell-dirtrack-mode: t   global-hl-line-mode: t   lsp-managed-mode: t   lsp-mode: t   yas-global-mode: t   yas-minor-mode: t   tooltip-mode: t   global-eldoc-mode: t   eldoc-mode: t   show-paren-mode: t   electric-indent-mode: t   mouse-wheel-mode: t   menu-bar-mode: t   file-name-shadow-mode: t   global-font-lock-mode: t   font-lock-mode: t   blink-cursor-mode: t   column-number-mode: t   line-number-mode: t   auto-fill-function: yas--auto-fill   transient-mark-mode: t   auto-composition-mode: t   auto-encryption-mode: t   auto-compression-mode: t Load-path shadows: /home/jostein/.emacs.d/elpa/transient-20221028.1430/transient hides /home/jostein/build/emacs/lisp/transient /home/jostein/.emacs.d/elpa/eglot-20221020.1010/eglot hides /home/jostein/build/emacs/lisp/progmodes/eglot Features: (cl-print git-rebase shadow sort emacsbug magit-extras mail-extr flyspell ispell mule-util tree-sitter-langs tree-sitter-langs-build tar-mode arc-mode archive-mode tree-sitter-hl tree-sitter-debug tree-sitter tree-sitter-load tree-sitter-cli tsc tsc-dyn tsc-dyn-get dired-aux tsc-obsolete misearch multi-isearch semantic/lex-spp ede/emacs semantic/db semantic/util-modes semantic/util semantic semantic/tag semantic/lex semantic/fw mode-local bug-reference magit-submodule magit-obsolete magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log magit-diff smerge-mode git-commit log-edit message sendmail yank-media rfc822 mml mml-sec epa mm-decode mm-bodies mm-encode mailabbrev gmm-utils mailheader pcvs-util magit-core magit-autorevert magit-margin magit-transient magit-process with-editor magit-mode transient magit-git magit-base magit-section crm compat-27 compat-26 executable helm-command helm-elisp helm-eval helm-info url-http url-auth mail-parse rfc2231 rfc2047 rfc2045 ietf-drums url-gw face-remap lsp-diagnostics lsp-headerline lsp-icons lsp-modeline view vc-git diff-mode vc-dispatcher disp-table elec-pair winner ffap tramp-archive tramp-gvfs tramp-cache warnings time-stamp zeroconf dbus add-log lsp-zig lsp-steep lsp-svelte lsp-sqls lsp-ruby-syntax-tree lsp-yaml lsp-xml lsp-vimscript lsp-vhdl lsp-volar lsp-vetur lsp-html lsp-verilog lsp-vala lsp-v lsp-typeprof lsp-ttcn3 lsp-toml lsp-terraform lsp-tex lsp-sorbet lsp-solargraph lsp-rust lsp-rf lsp-remark lsp-racket lsp-r lsp-purescript lsp-pylsp lsp-pyls lsp-php lsp-pls lsp-perlnavigator lsp-perl lsp-openscad lsp-ocaml lsp-magik lsp-nix lsp-nim lsp-nginx lsp-mint lsp-marksman lsp-markdown lsp-lua lsp-kotlin lsp-json lsp-javascript lsp-idris lsp-haxe lsp-groovy lsp-hack lsp-graphql lsp-gleam lsp-go lsp-completion lsp-gdscript lsp-fsharp lsp-fortran lsp-eslint lsp-erlang lsp-emmet lsp-elixir lsp-elm lsp-dockerfile lsp-dhall lsp-d lsp-css lsp-csharp gnutls lsp-crystal lsp-cmake lsp-clojure lsp-semantic-tokens lsp-clangd lsp-beancount lsp-bash lsp-ansible lsp-angular lsp-ada lsp-actionscript ido-completing-read+ memoize minibuf-eldef elisp-slime-nav paredit editorconfig editorconfig-core editorconfig-core-handle editorconfig-fnmatch flycheck highlight-symbol which-func edebug debug backtrace nlinum linum company-oddmuse company-keywords company-etags etags fileloop generator company-gtags company-dabbrev-code company-dabbrev company-files company-clang company-capf company-cmake company-semantic company-template company-bbdb company-web-html company-web company-css web-completion-data company eww url-queue shr pixel-fill kinsoku url-file svg mm-url gnus nnheader gnus-util mail-utils range mm-util mail-prsvr ede/speedbar ede/files ede ede/detect ede/base ede/auto ede/source eieio-base eieio-speedbar speedbar ezimage dframe eieio-custom cedet dap-mouse dap-ui lsp-treemacs lsp-treemacs-generic lsp-treemacs-themes treemacs-treelib treemacs treemacs-header-line treemacs-compatibility treemacs-mode treemacs-interface treemacs-persistence treemacs-filewatch-mode treemacs-follow-mode treemacs-rendering treemacs-annotations treemacs-async treemacs-workspaces treemacs-dom treemacs-visuals treemacs-fringe-indicator treemacs-scope pulse treemacs-faces treemacs-icons treemacs-themes treemacs-core-utils pfuture treemacs-logging treemacs-customization treemacs-macros gdb-mi bindat gud bui bui-list bui-info bui-entry bui-core bui-history bui-button bui-utils lsp-lens dap-gdb-lldb dap-netcore dap-node dap-utils dom xml dap-pwsh lsp-pwsh dap-python dap-mode dap-tasks dap-launch lsp-docker yaml posframe dap-overlays undo-tree diff queue doom-modeline doom-modeline-segments doom-modeline-env doom-modeline-core all-the-icons all-the-icons-faces data-material data-weathericons data-octicons data-fileicons data-faicons data-alltheicons shrink-path compat compat-macs projectile lisp-mnt grep ibuf-ext ibuffer ibuffer-loaddefs helm-imenu ob-plantuml org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-footnote org-src ob-comint org-pcomplete org-list org-faces org-entities org-version ob-emacs-lisp ob-core ob-eval org-table oc-basic bibtex ol org-keys oc org-compat org-macs org-loaddefs find-func cal-menu calendar cal-loaddefs ido-yes-or-no ido helm-mode helm-misc helm-files image-dired image-dired-tags image-dired-external image-dired-util xdg image-mode dired dired-loaddefs exif tramp tramp-loaddefs trampver tramp-integration cus-edit pp cus-load files-x tramp-compat parse-time iso8601 time-date ls-lisp helm-buffers helm-occur helm-tags helm-locate helm-grep helm-regexp format-spec helm-utils helm-help helm-types helm helm-global-bindings helm-easymenu edmacro kmacro helm-core easy-mmode async-bytecomp helm-source helm-multi-match helm-lib async helm-config delsel cl-extra autorevert typescript-ts-mode js derived csharp-mode treesit cc-langs cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs server powershell advice shell pcomplete hl-line lsp-mode lsp-protocol yasnippet help-mode xref project tree-widget wid-edit spinner pcase network-stream puny nsm markdown-mode color thingatpt noutline outline icons lv inline imenu ht filenotify f f-shortdoc shortdoc s ewoc epg rfc6068 epg-config dash dracula-theme compile-eslint compile text-property-search comint ansi-osc ansi-color ring cl finder-inf rx helm-projectile-autoloads expand-region-autoloads all-the-icons-autoloads helm-autoloads dracula-theme-autoloads eglot-autoloads nlinum-autoloads rust-mode-autoloads multiple-cursors-autoloads magit-autoloads magit-section-autoloads doom-modeline-autoloads assess-autoloads m-buffer-autoloads cargo-autoloads package-lint-autoloads company-autoloads web-mode-autoloads flycheck-autoloads git-commit-autoloads with-editor-autoloads git-timemachine-autoloads js2-mode-autoloads projectile-autoloads yaml-mode-autoloads helpful-autoloads elisp-refs-autoloads powershell-autoloads helm-core-autoloads async-autoloads editorconfig-autoloads dap-mode-autoloads lsp-docker-autoloads yaml-autoloads lsp-treemacs-autoloads lsp-mode-autoloads markdown-mode-autoloads transient-autoloads compat-autoloads paredit-autoloads pcache-autoloads f-autoloads popup-autoloads tree-sitter-langs-autoloads treemacs-autoloads posframe-autoloads ht-autoloads hydra-autoloads pfuture-autoloads ace-window-autoloads avy-autoloads s-autoloads info dash-autoloads macrostep-autoloads package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit xinput2 x multi-tty make-network-process emacs) Memory information: ((conses 16 769231 98943)  (symbols 48 61705 77)  (strings 32 224824 12295)  (string-bytes 1 6961649)  (vectors 16 129092)  (vector-slots 8 2341344 202175)  (floats 8 1075 874)  (intervals 56 26101 3923)  (buffers 992 54)) -- Vennlig hilsen *Jostein Kjønigsen* jostein@kjonigsen.net 🍵 jostein@gmail.com https://jostein.kjønigsen.no --------------lZQoF2ERdgA2CHN7t5s0VgnM Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

From: "Jostein Kjønigsen" <jostein@ThinkPad-T14s.mail-host-address-is-not-set>
To: bug-gnu-emacs@gnu.org
Subject: 29.0.50; typescript-ts-mode consistently fontifies method-names incorrectly
--text follows this line--

--
When I:

1. create a typescript file (sample.ts)
2. create class and add some methods to it.

I observe that:

- method names are consistently fontified as font-lock-property-face.

I expected that:

- method names to be consistently fontified as font-luck-function-name-face.

This seems to be because of the "property_identifier" is used for
functions in the treesitter-grammar, and this property is used
indiscriminately to apply font-lock-property-face at the bottom of the
major-mode grammar.

This "shadows" the former rules which correctly apply font-lock-function-name-face.

The best would obviously have a way to identify properties more accurately, to precent
shadowing from taking place. Unfortunately I cannot see a realiable way to do that
based on the current parse-tree.

Seeing as properties in Typescript are fairly rare while methods are very common,
it seems appropriate to me to remove the property-specific fontification rules
to restore the method-fontification rules.

I got a patch for this ready, if people are willing to accept it.

--


In GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
 3.24.34, cairo version 1.16.0) of 2022-11-28 built on ThinkPad-T14s
Repository revision: a85ff22300736212e38f43cc7d56e8e3d4ae1203
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12201003
System Description: Ubuntu 22.10

Configured using:
 'configure --with-tree-sitter'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY
INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS
TREE_SITTER X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB

Important settings:
  value of $LC_MONETARY: nb_NO.UTF-8
  value of $LC_NUMERIC: nb_NO.UTF-8
  value of $LC_TIME: nb_NO.UTF-8
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: TypeScript

Minor modes in effect:
  global-git-commit-mode: t
  magit-auto-revert-mode: t
  lsp-diagnostics-mode: t
  lsp-headerline-breadcrumb-mode: t
  lsp-modeline-workspace-status-mode: t
  lsp-modeline-diagnostics-mode: t
  lsp-modeline-code-actions-mode: t
  electric-pair-mode: t
  lsp-completion-mode: t
  editorconfig-mode: t
  flycheck-mode: t
  which-function-mode: t
  nlinum-mode: t
  company-mode: t
  global-ede-mode: t
  dap-tooltip-mode: t
  dap-ui-many-windows-mode: t
  dap-ui-controls-mode: t
  dap-ui-mode: t
  treemacs-filewatch-mode: t
  treemacs-follow-mode: t
  treemacs-git-mode: t
  treemacs-fringe-indicator-mode: t
  dap-auto-configure-mode: t
  dap-mode: t
  global-undo-tree-mode: t
  undo-tree-mode: t
  doom-modeline-mode: t
  projectile-mode: t
  ido-yes-or-no-mode: t
  helm-mode: t
  helm-minibuffer-history-mode: t
  helm--remap-mouse-mode: t
  async-bytecomp-package-mode: t
  delete-selection-mode: t
  global-auto-revert-mode: t
  server-mode: t
  shell-dirtrack-mode: t
  global-hl-line-mode: t
  lsp-managed-mode: t
  lsp-mode: t
  yas-global-mode: t
  yas-minor-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  column-number-mode: t
  line-number-mode: t
  auto-fill-function: yas--auto-fill
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
/home/jostein/.emacs.d/elpa/transient-20221028.1430/transient hides /home/jostein/build/emacs/lisp/transient
/home/jostein/.emacs.d/elpa/eglot-20221020.1010/eglot hides /home/jostein/build/emacs/lisp/progmodes/eglot

Features:
(cl-print git-rebase shadow sort emacsbug magit-extras mail-extr
flyspell ispell mule-util tree-sitter-langs tree-sitter-langs-build
tar-mode arc-mode archive-mode tree-sitter-hl tree-sitter-debug
tree-sitter tree-sitter-load tree-sitter-cli tsc tsc-dyn tsc-dyn-get
dired-aux tsc-obsolete misearch multi-isearch semantic/lex-spp ede/emacs
semantic/db semantic/util-modes semantic/util semantic semantic/tag
semantic/lex semantic/fw mode-local bug-reference magit-submodule
magit-obsolete magit-blame magit-stash magit-reflog magit-bisect
magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit
magit-sequence magit-notes magit-worktree magit-tag magit-merge
magit-branch magit-reset magit-files magit-refs magit-status magit
magit-repos magit-apply magit-wip magit-log magit-diff smerge-mode
git-commit log-edit message sendmail yank-media rfc822 mml mml-sec epa
mm-decode mm-bodies mm-encode mailabbrev gmm-utils mailheader pcvs-util
magit-core magit-autorevert magit-margin magit-transient magit-process
with-editor magit-mode transient magit-git magit-base magit-section crm
compat-27 compat-26 executable helm-command helm-elisp helm-eval
helm-info url-http url-auth mail-parse rfc2231 rfc2047 rfc2045
ietf-drums url-gw face-remap lsp-diagnostics lsp-headerline lsp-icons
lsp-modeline view vc-git diff-mode vc-dispatcher disp-table elec-pair
winner ffap tramp-archive tramp-gvfs tramp-cache warnings time-stamp
zeroconf dbus add-log lsp-zig lsp-steep lsp-svelte lsp-sqls
lsp-ruby-syntax-tree lsp-yaml lsp-xml lsp-vimscript lsp-vhdl lsp-volar
lsp-vetur lsp-html lsp-verilog lsp-vala lsp-v lsp-typeprof lsp-ttcn3
lsp-toml lsp-terraform lsp-tex lsp-sorbet lsp-solargraph lsp-rust lsp-rf
lsp-remark lsp-racket lsp-r lsp-purescript lsp-pylsp lsp-pyls lsp-php
lsp-pls lsp-perlnavigator lsp-perl lsp-openscad lsp-ocaml lsp-magik
lsp-nix lsp-nim lsp-nginx lsp-mint lsp-marksman lsp-markdown lsp-lua
lsp-kotlin lsp-json lsp-javascript lsp-idris lsp-haxe lsp-groovy
lsp-hack lsp-graphql lsp-gleam lsp-go lsp-completion lsp-gdscript
lsp-fsharp lsp-fortran lsp-eslint lsp-erlang lsp-emmet lsp-elixir
lsp-elm lsp-dockerfile lsp-dhall lsp-d lsp-css lsp-csharp gnutls
lsp-crystal lsp-cmake lsp-clojure lsp-semantic-tokens lsp-clangd
lsp-beancount lsp-bash lsp-ansible lsp-angular lsp-ada lsp-actionscript
ido-completing-read+ memoize minibuf-eldef elisp-slime-nav paredit
editorconfig editorconfig-core editorconfig-core-handle
editorconfig-fnmatch flycheck highlight-symbol which-func edebug debug
backtrace nlinum linum company-oddmuse company-keywords company-etags
etags fileloop generator company-gtags company-dabbrev-code
company-dabbrev company-files company-clang company-capf company-cmake
company-semantic company-template company-bbdb company-web-html
company-web company-css web-completion-data company eww url-queue shr
pixel-fill kinsoku url-file svg mm-url gnus nnheader gnus-util
mail-utils range mm-util mail-prsvr ede/speedbar ede/files ede
ede/detect ede/base ede/auto ede/source eieio-base eieio-speedbar
speedbar ezimage dframe eieio-custom cedet dap-mouse dap-ui lsp-treemacs
lsp-treemacs-generic lsp-treemacs-themes treemacs-treelib treemacs
treemacs-header-line treemacs-compatibility treemacs-mode
treemacs-interface treemacs-persistence treemacs-filewatch-mode
treemacs-follow-mode treemacs-rendering treemacs-annotations
treemacs-async treemacs-workspaces treemacs-dom treemacs-visuals
treemacs-fringe-indicator treemacs-scope pulse treemacs-faces
treemacs-icons treemacs-themes treemacs-core-utils pfuture
treemacs-logging treemacs-customization treemacs-macros gdb-mi bindat
gud bui bui-list bui-info bui-entry bui-core bui-history bui-button
bui-utils lsp-lens dap-gdb-lldb dap-netcore dap-node dap-utils dom xml
dap-pwsh lsp-pwsh dap-python dap-mode dap-tasks dap-launch lsp-docker
yaml posframe dap-overlays undo-tree diff queue doom-modeline
doom-modeline-segments doom-modeline-env doom-modeline-core
all-the-icons all-the-icons-faces data-material data-weathericons
data-octicons data-fileicons data-faicons data-alltheicons shrink-path
compat compat-macs projectile lisp-mnt grep ibuf-ext ibuffer
ibuffer-loaddefs helm-imenu ob-plantuml org ob ob-tangle ob-ref ob-lob
ob-table ob-exp org-macro org-footnote org-src ob-comint org-pcomplete
org-list org-faces org-entities org-version ob-emacs-lisp ob-core
ob-eval org-table oc-basic bibtex ol org-keys oc org-compat org-macs
org-loaddefs find-func cal-menu calendar cal-loaddefs ido-yes-or-no ido
helm-mode helm-misc helm-files image-dired image-dired-tags
image-dired-external image-dired-util xdg image-mode dired
dired-loaddefs exif tramp tramp-loaddefs trampver tramp-integration
cus-edit pp cus-load files-x tramp-compat parse-time iso8601 time-date
ls-lisp helm-buffers helm-occur helm-tags helm-locate helm-grep
helm-regexp format-spec helm-utils helm-help helm-types helm
helm-global-bindings helm-easymenu edmacro kmacro helm-core easy-mmode
async-bytecomp helm-source helm-multi-match helm-lib async helm-config
delsel cl-extra autorevert typescript-ts-mode js derived csharp-mode
treesit cc-langs cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles
cc-align cc-engine cc-vars cc-defs server powershell advice shell
pcomplete hl-line lsp-mode lsp-protocol yasnippet help-mode xref project
tree-widget wid-edit spinner pcase network-stream puny nsm markdown-mode
color thingatpt noutline outline icons lv inline imenu ht filenotify f
f-shortdoc shortdoc s ewoc epg rfc6068 epg-config dash dracula-theme
compile-eslint compile text-property-search comint ansi-osc ansi-color
ring cl finder-inf rx helm-projectile-autoloads expand-region-autoloads
all-the-icons-autoloads helm-autoloads dracula-theme-autoloads
eglot-autoloads nlinum-autoloads rust-mode-autoloads
multiple-cursors-autoloads magit-autoloads magit-section-autoloads
doom-modeline-autoloads assess-autoloads m-buffer-autoloads
cargo-autoloads package-lint-autoloads company-autoloads
web-mode-autoloads flycheck-autoloads git-commit-autoloads
with-editor-autoloads git-timemachine-autoloads js2-mode-autoloads
projectile-autoloads yaml-mode-autoloads helpful-autoloads
elisp-refs-autoloads powershell-autoloads helm-core-autoloads
async-autoloads editorconfig-autoloads dap-mode-autoloads
lsp-docker-autoloads yaml-autoloads lsp-treemacs-autoloads
lsp-mode-autoloads markdown-mode-autoloads transient-autoloads
compat-autoloads paredit-autoloads pcache-autoloads f-autoloads
popup-autoloads tree-sitter-langs-autoloads treemacs-autoloads
posframe-autoloads ht-autoloads hydra-autoloads pfuture-autoloads
ace-window-autoloads avy-autoloads s-autoloads info dash-autoloads
macrostep-autoloads package browse-url url url-proxy url-privacy
url-expand url-methods url-history url-cookie generate-lisp-file
url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq
eieio eieio-core cl-macs password-cache json subr-x map byte-opt gv
bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip
cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type
elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd
fontset image regexp-opt fringe tabulated-list replace newcomment
text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow
isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax
font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic
indonesian philippine cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs
theme-loaddefs faces cus-face macroexp files window text-properties
overlay sha1 md5 base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads dbusbind inotify lcms2
dynamic-setting system-font-setting font-render-setting cairo
move-toolbar gtk x-toolkit xinput2 x multi-tty make-network-process
emacs)

Memory information:
((conses 16 769231 98943)
 (symbols 48 61705 77)
 (strings 32 224824 12295)
 (string-bytes 1 6961649)
 (vectors 16 129092)
 (vector-slots 8 2341344 202175)
 (floats 8 1075 874)
 (intervals 56 26101 3923)
 (buffers 992 54))

--
Vennlig hilsen
Jostein Kjønigsen

jostein@kjonigsen.net 🍵 jostein@gmail.com
https://jostein.kjønigsen.no
--------------lZQoF2ERdgA2CHN7t5s0VgnM-- From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 28 10:09:17 2022 Received: (at 59660) by debbugs.gnu.org; 28 Nov 2022 15:09:17 +0000 Received: from localhost ([127.0.0.1]:49141 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozfky-0005FW-Oy for submit@debbugs.gnu.org; Mon, 28 Nov 2022 10:09:17 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:36567) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozfkx-0005FQ-4g for 59660@debbugs.gnu.org; Mon, 28 Nov 2022 10:09:15 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id E1EE55C01AE; Mon, 28 Nov 2022 10:09:09 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Mon, 28 Nov 2022 10:09:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:reply-to:sender :subject:subject:to:to; s=fm3; t=1669648149; x=1669734549; bh=1p akqdPgsnN3nFwyQBUUpFynTrSbA73YRX8yM86vQD0=; b=nTu/pjLvS6Kdwvf0+E WgkPIKb3o1FCt/cSGOEXGnuFvZbEJKWyrPR7T5u2dtBpJ7CTvnc+RSg8BaPb65Nu lwv2noYss3rMHn0tOErKrEmuPzVpkPmXkOeWNdahVQmK7nXPw2P+1sdRiUXMANHF BESJQCLzk+pkXfwIuZ0UnGcL/ILHHZe60dzvLvn6Ix+xBBz19dTKiljAH4Yg7Q2Z kW+wEtbAyra0dqtCt9WD7BaqD5U6B2mM9m0/cPGe3L+6O/CsoFO3bqBOgR4WMs8j wJ8c52/2RMZ8GCf/WZ41o8KCN10o9YaMI4h5HiKkYf8/ob9NAZDNK89p0jSvX2Nm kl7w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:message-id:mime-version :reply-to:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1669648149; x=1669734549; bh=1pakqdPgsnN3nFwyQBUUpFynTrSbA73YRX8 yM86vQD0=; b=VUXTlIlYPBhfcVGwwSFaFq2PWgDKsZp0NpBZBSkfOBNdDgbZkM4 kfBie+7PQJmJeN1i0XOwaLit1fwO40Zs4MTahheoRDAyXNsW3fF9GWaVu8GHEhsX wsjZnz39DOkdbeI1vPU9jsgAiXIsEXHiDVF/wDQnMHUy3YqQD4A5HKDBTK5fOo8v aLMoTsAkefG89rjkkyUGyCr8cU4+E3i2/5bblMBdo17YUBKTqHbieMO69c7JJn/G HRhwzhk0p2lzKzOQ8BcNl4deBXWJqIjJwC3JNbJEsQVVpyJBVj2RKqY2F7Cbe96T crx1QiAevZDWkAlDaI7uxmqxOuyP7ofb22Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrjedvgdejgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpegtkfffgggfrhfvhffusehmtderredtfeejnecuhfhrohhmpeflohhsthgvihhn ucfmjhppnhhighhsvghnuceojhhoshhtvghinhesshgvtghurhgvrdhkjhhonhhighhsvg hnrdhnvghtqeenucggtffrrghtthgvrhhnpeehtdfflefggedtgefguddvheevgedujeev veetteevtdettdefhedthfdtuddvveenucffohhmrghinhepkhhjnhhighhsvghnrdhnoh enucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehjohhs thgvihhnsehsvggtuhhrvgdrkhhjohhnihhgshgvnhdrnhgvth X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 28 Nov 2022 10:09:03 -0500 (EST) Content-Type: multipart/mixed; boundary="------------t903RP7SFSOC8XDI49joaUWk" Message-ID: <729dcdf6-7cf7-3398-78d8-2b7ca1f2c005@secure.kjonigsen.net> Date: Mon, 28 Nov 2022 16:09:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Content-Language: nb-NO, en-GB To: 59660@debbugs.gnu.org, Theodor Thornhill , Yuan Fu From: =?UTF-8?Q?Jostein_Kj=c3=b8nigsen?= Subject: bug#59660: lisp/progmodes/typescript-ts-mode.el: restore method-name fontification X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59660 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: jostein@kjonigsen.net Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is a multi-part message in MIME format. --------------t903RP7SFSOC8XDI49joaUWk Content-Type: multipart/alternative; boundary="------------oBIzP0Z95ibo6egBrY19C2u3" --------------oBIzP0Z95ibo6egBrY19C2u3 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Attached is a simple patch which addresses this font-lock issue and makes typescript-ts-mode much better to use. -- Kind regards *Jostein Kjønigsen* jostein@kjonigsen.net 🍵 jostein@gmail.com https://jostein.kjønigsen.no --------------oBIzP0Z95ibo6egBrY19C2u3 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Attached is a simple patch which addresses this font-lock issue and makes typescript-ts-mode much better to use.

--
Kind regards
Jostein Kjønigsen

jostein@kjonigsen.net 🍵 jostein@gmail.com
https://jostein.kjønigsen.no
--------------oBIzP0Z95ibo6egBrY19C2u3-- --------------t903RP7SFSOC8XDI49joaUWk Content-Type: text/x-patch; charset=UTF-8; name="0004-lisp-progmodes-typescript-ts-mode.el-restore-method-.patch" Content-Disposition: attachment; filename*0="0004-lisp-progmodes-typescript-ts-mode.el-restore-method-.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA5Y2QwNGEwOTg0YTg3ODEyNTk1OGI5NWUxM2ZmODQwMDA0ZjI4NmU4IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/Sm9zdGVpbj0yMEtqPUMzPUI4bmln c2VuPz0gPGpvc3RlaW5Aa2pvbmlnc2VuLm5ldD4KRGF0ZTogTW9uLCAyOCBOb3YgMjAyMiAx NjowNToyNyArMDEwMApTdWJqZWN0OiBbUEFUQ0ggNC80XSBsaXNwL3Byb2dtb2Rlcy90eXBl c2NyaXB0LXRzLW1vZGUuZWw6IHJlc3RvcmUgbWV0aG9kLW5hbWUKIGZvbnRpZmljYXRpb24u CgotLS0KIGxpc3AvcHJvZ21vZGVzL3R5cGVzY3JpcHQtdHMtbW9kZS5lbCB8IDQgKy0tLQog MSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAzIGRlbGV0aW9ucygtKQoKZGlmZiAt LWdpdCBhL2xpc3AvcHJvZ21vZGVzL3R5cGVzY3JpcHQtdHMtbW9kZS5lbCBiL2xpc3AvcHJv Z21vZGVzL3R5cGVzY3JpcHQtdHMtbW9kZS5lbAppbmRleCBiZjQ4M2EzMWQzNC4uM2EzOTJi YjhkNWYgMTAwNjQ0Ci0tLSBhL2xpc3AvcHJvZ21vZGVzL3R5cGVzY3JpcHQtdHMtbW9kZS5l bAorKysgYi9saXNwL3Byb2dtb2Rlcy90eXBlc2NyaXB0LXRzLW1vZGUuZWwKQEAgLTI2Nyw5 ICsyNjcsNyBAQCB0eXBlc2NyaXB0LXRzLW1vZGUtLWZvbnQtbG9jay1zZXR0aW5ncwogICAg Omxhbmd1YWdlICd0c3gKICAgIDpvdmVycmlkZSB0CiAgICA6ZmVhdHVyZSAncHJvcGVydHkK LSAgIGAoKChwcm9wZXJ0eV9pZGVudGlmaWVyKSBAZm9udC1sb2NrLXByb3BlcnR5LWZhY2Up Ci0KLSAgICAgKHBhaXIgdmFsdWU6IChpZGVudGlmaWVyKSBAZm9udC1sb2NrLXZhcmlhYmxl LW5hbWUtZmFjZSkKKyAgIGAoKHBhaXIgdmFsdWU6IChpZGVudGlmaWVyKSBAZm9udC1sb2Nr LXZhcmlhYmxlLW5hbWUtZmFjZSkKIAogICAgICAoKHNob3J0aGFuZF9wcm9wZXJ0eV9pZGVu dGlmaWVyKSBAZm9udC1sb2NrLXByb3BlcnR5LWZhY2UpCiAKLS0gCjIuMzcuMgoK --------------t903RP7SFSOC8XDI49joaUWk-- From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 28 11:44:27 2022 Received: (at 59660) by debbugs.gnu.org; 28 Nov 2022 16:44:27 +0000 Received: from localhost ([127.0.0.1]:49616 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozhF4-00065O-SU for submit@debbugs.gnu.org; Mon, 28 Nov 2022 11:44:27 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:42801) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozhF2-00065I-Pm for 59660@debbugs.gnu.org; Mon, 28 Nov 2022 11:44:25 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 5988A5C005E; Mon, 28 Nov 2022 11:44:19 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Mon, 28 Nov 2022 11:44:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:reply-to:sender:subject:subject:to:to; s=fm3; t= 1669653859; x=1669740259; bh=WqQP26nlqVKxsD5Y+3vWW27FHJbAyTlI6kQ T1emdhYI=; b=yWN7FgIjIAFTPHOJrrbcqWZjjzm5syXBXJBvVBL0g/PdJ/dI8Qr nOGxyQNVaa3fbVQRM1vdk+6ZccuGazQmVVpezMmZNFhFLBrcTQ3+fXh8Zt9RUTjm syJ84LDv1q6icd7WvGsQtXUGyfwaXhC+WrHXJjLomN7KPMlxUlHsKBQW94KAhbCR p1ycswS/L/7q/RKvZS5IWJ7NHaexlKEjG56Eesu2WjgrC71fJG1Zyba4PmXc1rGu kAWo5H/CBuivaJQ7edEacuOE4wCT+th0wRRuEEaLAptmiWeopH4qgCuCMGHLznxL lULz9oVKdiRN122820gbo+Wgw5rqT4jwSTQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1669653859; x=1669740259; bh=WqQP26nlqVKxs D5Y+3vWW27FHJbAyTlI6kQT1emdhYI=; b=ajijJp6cSk68n8vnoAlh8bgj8jczs 7qsbqECWj6kJ1WUt5Snxevz5nOzgLR+Z67P1n5GJt1f5vsdKCjVMhzoAiCOudvoI F31CBTrfUgA9CTzOS03tjYYgVScYb3iQGrYJjy+FTcXmqb/2IBpWWnh2pQFyVser Yn8/Uov8s1535Vwf78j6ma6KrdnWL0iJmXCgMNdoY2Q75PbwvIpViQ0pctmg/xWB O3WkXm2RyuLrnb+brhZGLsGPZmbiXRiz5tMeoqRcLyssslJ9WSrGRdRLBOKhAZJM +64PQdAS08MvbG/hQHFpn/hp0EoQ7GaJoaubre5HJq09hOfNtQShMmcZQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrjedvgdelgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpegtkfffgggfrhfuhffvfhgjsehmtderredtfeejnecuhfhrohhmpeflohhsthgv ihhnucfmjhppnhhighhsvghnuceojhhoshhtvghinhesshgvtghurhgvrdhkjhhonhhigh hsvghnrdhnvghtqeenucggtffrrghtthgvrhhnpeejieffffdtieduhffhgfelueetgeeg hffhtdfftdffudelveffgeekudffhfevieenucffohhmrghinhepkhhjnhhighhsvghnrd hnohenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehj ohhsthgvihhnsehsvggtuhhrvgdrkhhjohhnihhgshgvnhdrnhgvth X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 28 Nov 2022 11:44:18 -0500 (EST) Content-Type: multipart/mixed; boundary="------------6wRHbsSKNnEa21EsHmna9Bav" Message-ID: <00b6627a-860b-f86c-06a9-5166da99a965@secure.kjonigsen.net> Date: Mon, 28 Nov 2022 17:44:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: bug#59660: lisp/progmodes/typescript-ts-mode.el: restore method-name fontification Content-Language: nb-NO From: =?UTF-8?Q?Jostein_Kj=c3=b8nigsen?= To: 59660@debbugs.gnu.org, Theodor Thornhill , Yuan Fu References: <729dcdf6-7cf7-3398-78d8-2b7ca1f2c005@secure.kjonigsen.net> In-Reply-To: <729dcdf6-7cf7-3398-78d8-2b7ca1f2c005@secure.kjonigsen.net> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59660 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: jostein@kjonigsen.net Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is a multi-part message in MIME format. --------------6wRHbsSKNnEa21EsHmna9Bav Content-Type: multipart/alternative; boundary="------------Oj3NqKrL1VarVxepEXSr0fHd" --------------Oj3NqKrL1VarVxepEXSr0fHd Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit This additional patch further improves fontification by fontifying function-arguments as variables too. -- Kind regards *Jostein Kjønigsen* jostein@kjonigsen.net 🍵 jostein@gmail.com https://jostein.kjønigsen.no On 28.11.2022 16:09, Jostein Kjønigsen wrote: > > Attached is a simple patch which addresses this font-lock issue and > makes typescript-ts-mode much better to use. > > -- > Kind regards > *Jostein Kjønigsen* > > jostein@kjonigsen.net 🍵 jostein@gmail.com > https://jostein.kjønigsen.no --------------Oj3NqKrL1VarVxepEXSr0fHd Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

This additional patch further improves fontification by fontifying function-arguments as variables too.

--

Kind regards
Jostein Kjønigsen

jostein@kjonigsen.net 🍵 jostein@gmail.com
https://jostein.kjønigsen.no
On 28.11.2022 16:09, Jostein Kjønigsen wrote:

Attached is a simple patch which addresses this font-lock issue and makes typescript-ts-mode much better to use.

--
Kind regards
Jostein Kjønigsen

jostein@kjonigsen.net 🍵 jostein@gmail.com
https://jostein.kjønigsen.no
--------------Oj3NqKrL1VarVxepEXSr0fHd-- --------------6wRHbsSKNnEa21EsHmna9Bav Content-Type: text/x-patch; charset=UTF-8; name="0005-lisp-progmodes-typescript-ts-mode.el-Fontify-functio.patch" Content-Disposition: attachment; filename*0="0005-lisp-progmodes-typescript-ts-mode.el-Fontify-functio.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSBiMTA2NmYxZDM2ZWFiYTdlNGMxNWQxNjI5ZTA4MjU0OTc5ZTM3YzYyIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/Sm9zdGVpbj0yMEtqPUMzPUI4bmln c2VuPz0gPGpvc3RlaW5Aa2pvbmlnc2VuLm5ldD4KRGF0ZTogTW9uLCAyOCBOb3YgMjAyMiAx Nzo0MzowMSArMDEwMApTdWJqZWN0OiBbUEFUQ0ggNS81XSBsaXNwL3Byb2dtb2Rlcy90eXBl c2NyaXB0LXRzLW1vZGUuZWw6IEZvbnRpZnkKIGZ1bmN0aW9uLWFyZ3VtZW50cyBhcyB2YXJp YWJsZXMuCgotLS0KIGxpc3AvcHJvZ21vZGVzL3R5cGVzY3JpcHQtdHMtbW9kZS5lbCB8IDIg KysKIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9saXNw L3Byb2dtb2Rlcy90eXBlc2NyaXB0LXRzLW1vZGUuZWwgYi9saXNwL3Byb2dtb2Rlcy90eXBl c2NyaXB0LXRzLW1vZGUuZWwKaW5kZXggM2EzOTJiYjhkNWYuLmJiMDBkODczMTYxIDEwMDY0 NAotLS0gYS9saXNwL3Byb2dtb2Rlcy90eXBlc2NyaXB0LXRzLW1vZGUuZWwKKysrIGIvbGlz cC9wcm9nbW9kZXMvdHlwZXNjcmlwdC10cy1tb2RlLmVsCkBAIC0xNTAsNiArMTUwLDggQEAg dHlwZXNjcmlwdC10cy1tb2RlLS1mb250LWxvY2stc2V0dGluZ3MKIAogICAgICAobWV0aG9k X2RlZmluaXRpb24KICAgICAgIG5hbWU6IChwcm9wZXJ0eV9pZGVudGlmaWVyKSBAZm9udC1s b2NrLWZ1bmN0aW9uLW5hbWUtZmFjZSkKKyAgICAgKHJlcXVpcmVkX3BhcmFtZXRlciAoaWRl bnRpZmllcikgQGZvbnQtbG9jay12YXJpYWJsZS1uYW1lLWZhY2UpCisgICAgIChvcHRpb25h bF9wYXJhbWV0ZXIgKGlkZW50aWZpZXIpIEBmb250LWxvY2stdmFyaWFibGUtbmFtZS1mYWNl KQogCiAgICAgICh2YXJpYWJsZV9kZWNsYXJhdG9yCiAgICAgICBuYW1lOiAoaWRlbnRpZmll cikgQGZvbnQtbG9jay12YXJpYWJsZS1uYW1lLWZhY2UpCi0tIAoyLjM3LjIKCg== --------------6wRHbsSKNnEa21EsHmna9Bav-- From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 28 11:53:55 2022 Received: (at 59660) by debbugs.gnu.org; 28 Nov 2022 16:53:55 +0000 Received: from localhost ([127.0.0.1]:49676 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozhOF-0006Aw-1a for submit@debbugs.gnu.org; Mon, 28 Nov 2022 11:53:55 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:47745) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozhOD-0006Ap-H0 for 59660@debbugs.gnu.org; Mon, 28 Nov 2022 11:53:54 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 327315C017F; Mon, 28 Nov 2022 11:53:48 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Mon, 28 Nov 2022 11:53:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:reply-to:sender:subject:subject:to:to; s=fm3; t= 1669654428; x=1669740828; bh=S82aTdNzOCMna9IOGpjaJ0bPLjvUyBKNJEN w+Q+baRU=; b=g0rHL56icclZfB3vnC2V4OQ/HrhhwtNzMYflIZfErqx/bCAN3Gm rdc3OvrcsNVEIv9CK47dSGmNUrLzLLT0DXoKSG06uPMnpopxqDzEFGSze00kj6gM vwIT3wBPRoITnLuYA4Q+sxxw8wP1KGmbYu5rHdfyXHTXV5qh9pTvhV5coxWzFy1m vbJJCzLIV3kxFFp4XWwGV4A/iG3X24dJJ3AS4qXNtIdDHcYedNINJ+5KUcYr4Rmi IP5FAPlY7lzvw4UPT2FiJNaCsS84rMk9A6iqE5k1cIOvGQaVBKgqdZxoJBQfNUuh gMag2k8E7DaDbLKoJU5CA6KbqnlNYKxv3aA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1669654428; x=1669740828; bh=S82aTdNzOCMna 9IOGpjaJ0bPLjvUyBKNJENw+Q+baRU=; b=tFCuA7OUzmWK67ApiG0Bu3roDMaMG E9qRn1cxcNm0QjmxbuKLvEePw2YnLDvEh1xGA8TU5PCvUEDbQQnlTTIg/uKQMJFN FgpVF5MAI7ccqciZFKVs16nZmii/SXZJOK1EzzyRayU+XTgY66UPNSLrCGabULBA qFVzh7+Z89RE0fAwo2xCVPWl5XoG4ZHCjPw3TKzWG2ZDfSVdNAsxXRNZUHLbToBR 4f7t1W43Z2Zdkm+63JCuEZ02dRQ7yJGGku4261x9PU+EeomRXgi+7avnL7f7zAGf nhNEvo3nmRL4hftWeX0GYBGd3EDnImwjZKbeoGtL7qyuORex997rnJTBw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrjedvgdeljecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpegtkfffgggfrhfuhffvfhgjsehmtderredtfeejnecuhfhrohhmpeflohhsthgv ihhnucfmjhppnhhighhsvghnuceojhhoshhtvghinhesshgvtghurhgvrdhkjhhonhhigh hsvghnrdhnvghtqeenucggtffrrghtthgvrhhnpeejieffffdtieduhffhgfelueetgeeg hffhtdfftdffudelveffgeekudffhfevieenucffohhmrghinhepkhhjnhhighhsvghnrd hnohenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehj ohhsthgvihhnsehsvggtuhhrvgdrkhhjohhnihhgshgvnhdrnhgvth X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 28 Nov 2022 11:53:46 -0500 (EST) Content-Type: multipart/mixed; boundary="------------UntO63YocxaNVTjs0rumuGSj" Message-ID: Date: Mon, 28 Nov 2022 17:53:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: bug#59660: lisp/progmodes/typescript-ts-mode.el: restore method-name fontification Content-Language: nb-NO From: =?UTF-8?Q?Jostein_Kj=c3=b8nigsen?= To: 59660@debbugs.gnu.org, Theodor Thornhill , Yuan Fu References: <729dcdf6-7cf7-3398-78d8-2b7ca1f2c005@secure.kjonigsen.net> <00b6627a-860b-f86c-06a9-5166da99a965@secure.kjonigsen.net> In-Reply-To: <00b6627a-860b-f86c-06a9-5166da99a965@secure.kjonigsen.net> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59660 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: jostein@kjonigsen.net Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is a multi-part message in MIME format. --------------UntO63YocxaNVTjs0rumuGSj Content-Type: multipart/alternative; boundary="------------Te5fkCidCyYpakep0tWxqhyu" --------------Te5fkCidCyYpakep0tWxqhyu Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit And another improvement. -- Kind regards *Jostein Kjønigsen* jostein@kjonigsen.net 🍵 jostein@gmail.com https://jostein.kjønigsen.no On 28.11.2022 17:44, Jostein Kjønigsen wrote: > > This additional patch further improves fontification by fontifying > function-arguments as variables too. > > -- > > Kind regards > *Jostein Kjønigsen* > > jostein@kjonigsen.net 🍵 jostein@gmail.com > https://jostein.kjønigsen.no > On 28.11.2022 16:09, Jostein Kjønigsen wrote: >> >> Attached is a simple patch which addresses this font-lock issue and >> makes typescript-ts-mode much better to use. >> >> -- >> Kind regards >> *Jostein Kjønigsen* >> >> jostein@kjonigsen.net 🍵 jostein@gmail.com >> https://jostein.kjønigsen.no --------------Te5fkCidCyYpakep0tWxqhyu Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

And another improvement.

--
Kind regards
Jostein Kjønigsen

jostein@kjonigsen.net 🍵 jostein@gmail.com
https://jostein.kjønigsen.no
On 28.11.2022 17:44, Jostein Kjønigsen wrote:

This additional patch further improves fontification by fontifying function-arguments as variables too.

--

Kind regards
Jostein Kjønigsen

jostein@kjonigsen.net 🍵 jostein@gmail.com
https://jostein.kjønigsen.no
On 28.11.2022 16:09, Jostein Kjønigsen wrote:

Attached is a simple patch which addresses this font-lock issue and makes typescript-ts-mode much better to use.

--
Kind regards
Jostein Kjønigsen

jostein@kjonigsen.net 🍵 jostein@gmail.com
https://jostein.kjønigsen.no
--------------Te5fkCidCyYpakep0tWxqhyu-- --------------UntO63YocxaNVTjs0rumuGSj Content-Type: text/x-patch; charset=UTF-8; name="0006-lisp-progmodes-typescript-ts-mode.el-Fontify-all-typ.patch" Content-Disposition: attachment; filename*0="0006-lisp-progmodes-typescript-ts-mode.el-Fontify-all-typ.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA3ZmRjYmY1ODIxYmYyY2QyZGRiZWMxZmRkNmMxMDM1NDQxZmJjMGI3IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/Sm9zdGVpbj0yMEtqPUMzPUI4bmln c2VuPz0gPGpvc3RlaW5Aa2pvbmlnc2VuLm5ldD4KRGF0ZTogTW9uLCAyOCBOb3YgMjAyMiAx Nzo1MToxOSArMDEwMApTdWJqZWN0OiBbUEFUQ0ggNi82XSBsaXNwL3Byb2dtb2Rlcy90eXBl c2NyaXB0LXRzLW1vZGUuZWw6IEZvbnRpZnkgYWxsIHR5cGVzCiBpbiBjbGFzcy1kZWNsYXJh dGlvbnMKCldpdGhvdXQgdGhpcyBwYXRjaCwgZXh0ZW5kcy1jbGF1c2luZyBsaWtlICJCYXIi IGluIHRoZSBmb2xsb3dpbmcgY29kZQp3aWxsIG5vdCBiZSBoaWdobGlnaHRlZCBhcyBhIHR5 cGU6CgpgYGBgdHMKY2xhc3MgRm9vIGV4dGVuZHMgQmFyIGltcGxlbWVudHMgQmF6IHsKfQpg YGBgCi0tLQogbGlzcC9wcm9nbW9kZXMvdHlwZXNjcmlwdC10cy1tb2RlLmVsIHwgMiArKwog MSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL2xpc3AvcHJv Z21vZGVzL3R5cGVzY3JpcHQtdHMtbW9kZS5lbCBiL2xpc3AvcHJvZ21vZGVzL3R5cGVzY3Jp cHQtdHMtbW9kZS5lbAppbmRleCBiYjAwZDg3MzE2MS4uNDNlZmU4N2FhZTEgMTAwNjQ0Ci0t LSBhL2xpc3AvcHJvZ21vZGVzL3R5cGVzY3JpcHQtdHMtbW9kZS5lbAorKysgYi9saXNwL3By b2dtb2Rlcy90eXBlc2NyaXB0LXRzLW1vZGUuZWwKQEAgLTE1OCw2ICsxNTgsOCBAQCB0eXBl c2NyaXB0LXRzLW1vZGUtLWZvbnQtbG9jay1zZXR0aW5ncwogCiAgICAgIChlbnVtX2RlY2xh cmF0aW9uIChpZGVudGlmaWVyKSBAZm9udC1sb2NrLXR5cGUtZmFjZSkKIAorICAgICAoZXh0 ZW5kc19jbGF1c2UgdmFsdWU6IChpZGVudGlmaWVyKSBAZm9udC1sb2NrLXR5cGUtZmFjZSkK KwogICAgICAoYXJyb3dfZnVuY3Rpb24KICAgICAgIHBhcmFtZXRlcjogKGlkZW50aWZpZXIp IEBmb250LWxvY2stdmFyaWFibGUtbmFtZS1mYWNlKQogCi0tIAoyLjM3LjIKCg== --------------UntO63YocxaNVTjs0rumuGSj-- From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 28 12:08:13 2022 Received: (at 59660) by debbugs.gnu.org; 28 Nov 2022 17:08:13 +0000 Received: from localhost ([127.0.0.1]:49781 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozhc5-0006Lg-6I for submit@debbugs.gnu.org; Mon, 28 Nov 2022 12:08:13 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:37909) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozhc2-0006LY-LA for 59660@debbugs.gnu.org; Mon, 28 Nov 2022 12:08:11 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 35FB95C0162; Mon, 28 Nov 2022 12:08:04 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 28 Nov 2022 12:08:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:reply-to:sender:subject:subject:to:to; s=fm3; t= 1669655284; x=1669741684; bh=DhXAP3fxYySQK5UynzTb0kaBAb1ZEexFGvR xnj7JMhI=; b=S1UenPNVqeTggPIbOPfe78EQygIXYffqTlqyyAcvRGjtx0QB/IH uj8wmgF4j0lgR7mJ8vcTjkMNvrOaAbF+tFGFlZeBDysujM9QhtfpK/lDyOqosyye U5LyMke2i8GUs5oi4vihqlIr92zlxQTbfiy3Sp/+Dc0wY6o2GcIAd4EBMvnkkPBL OACucnCTIrNmlXWZxVwonFjUPKuX8IqDgQSTgVqtJVm8PDttJ/Zn5ju8Q9ODB+KU EX2/ioen57MRD7StGRGsIb6NmVdmk/fQG6elRll/Lkad1E6iS+y4MgNbHsn1EEqk aMWFTvxCzYVl0zMxWl8Xa0oXFqqapZlzLBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1669655284; x=1669741684; bh=DhXAP3fxYySQK 5UynzTb0kaBAb1ZEexFGvRxnj7JMhI=; b=J3/LwtgZizpJLfDBbZ9frnxTopNXG pRv+4nXmcHmily0DLcBpvUoijFNrMzFIYHBb7erLPXWteU/Lm0tqC15wxkRWOoib 4TYeuDq2Q+n6wOSSbWA23jXi0VUOj81XZICM69sN3+84pO+AgagRyKLdAssBOHIv vbvCmDeezjayy/rSgK7YpAdHMEEpuM0UIraaXnhH2334qPxR45dmAmdbkZ9onlV8 6FpaFn3cizqcTq62FsxFnbGldPgUCsmVx14KixU5b6bFcy1F4FLaJ0hzhBX3yK6B nTwtVhk0cmDC2FNLcjrEDuIwGnFnHLk84u/kU8rwypLDZuQGaPwmgAmmw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrjedvgdellecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpegtkfffgggfrhfuhffvfhgjsehmtderredtfeejnecuhfhrohhmpeflohhsthgv ihhnucfmjhppnhhighhsvghnuceojhhoshhtvghinhesshgvtghurhgvrdhkjhhonhhigh hsvghnrdhnvghtqeenucggtffrrghtthgvrhhnpeejieffffdtieduhffhgfelueetgeeg hffhtdfftdffudelveffgeekudffhfevieenucffohhmrghinhepkhhjnhhighhsvghnrd hnohenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehj ohhsthgvihhnsehsvggtuhhrvgdrkhhjohhnihhgshgvnhdrnhgvth X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 28 Nov 2022 12:08:03 -0500 (EST) Content-Type: multipart/mixed; boundary="------------tNXHamhpEiTnD0iQd3Fimm0a" Message-ID: Date: Mon, 28 Nov 2022 18:08:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: bug#59660: lisp/progmodes/typescript-ts-mode.el: restore method-name fontification Content-Language: nb-NO From: =?UTF-8?Q?Jostein_Kj=c3=b8nigsen?= To: 59660@debbugs.gnu.org, Theodor Thornhill , Yuan Fu References: <729dcdf6-7cf7-3398-78d8-2b7ca1f2c005@secure.kjonigsen.net> <00b6627a-860b-f86c-06a9-5166da99a965@secure.kjonigsen.net> In-Reply-To: X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59660 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: jostein@kjonigsen.net Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is a multi-part message in MIME format. --------------tNXHamhpEiTnD0iQd3Fimm0a Content-Type: multipart/alternative; boundary="------------CMBpQnzhaZVv2A7EeVtTvV9i" --------------CMBpQnzhaZVv2A7EeVtTvV9i Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit All fixes and one more squashed into the attached patch :) Vennlig hilsen *Jostein Kjønigsen* jostein@kjonigsen.net 🍵 jostein@gmail.com https://jostein.kjønigsen.no On 28.11.2022 17:53, Jostein Kjønigsen wrote: > > And another improvement. > > -- > Kind regards > *Jostein Kjønigsen* > > jostein@kjonigsen.net 🍵 jostein@gmail.com > https://jostein.kjønigsen.no > On 28.11.2022 17:44, Jostein Kjønigsen wrote: >> >> This additional patch further improves fontification by fontifying >> function-arguments as variables too. >> >> -- >> >> Kind regards >> *Jostein Kjønigsen* >> >> jostein@kjonigsen.net 🍵 jostein@gmail.com >> https://jostein.kjønigsen.no >> On 28.11.2022 16:09, Jostein Kjønigsen wrote: >>> >>> Attached is a simple patch which addresses this font-lock issue and >>> makes typescript-ts-mode much better to use. >>> >>> -- >>> Kind regards >>> *Jostein Kjønigsen* >>> >>> jostein@kjonigsen.net 🍵 jostein@gmail.com >>> https://jostein.kjønigsen.no --------------CMBpQnzhaZVv2A7EeVtTvV9i Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

All fixes and one more squashed into the attached patch :)

Vennlig hilsen
Jostein Kjønigsen

jostein@kjonigsen.net 🍵 jostein@gmail.com
https://jostein.kjønigsen.no
On 28.11.2022 17:53, Jostein Kjønigsen wrote:

And another improvement.

--
Kind regards
Jostein Kjønigsen

jostein@kjonigsen.net 🍵 jostein@gmail.com
https://jostein.kjønigsen.no
On 28.11.2022 17:44, Jostein Kjønigsen wrote:

This additional patch further improves fontification by fontifying function-arguments as variables too.

--

Kind regards
Jostein Kjønigsen

jostein@kjonigsen.net 🍵 jostein@gmail.com
https://jostein.kjønigsen.no
On 28.11.2022 16:09, Jostein Kjønigsen wrote:

Attached is a simple patch which addresses this font-lock issue and makes typescript-ts-mode much better to use.

--
Kind regards
Jostein Kjønigsen

jostein@kjonigsen.net 🍵 jostein@gmail.com
https://jostein.kjønigsen.no
--------------CMBpQnzhaZVv2A7EeVtTvV9i-- --------------tNXHamhpEiTnD0iQd3Fimm0a Content-Type: text/x-patch; charset=UTF-8; name="0004-lisp-progmodes-typescript-ts-mode.el-fontification-i.patch" Content-Disposition: attachment; filename*0="0004-lisp-progmodes-typescript-ts-mode.el-fontification-i.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA4MTYyZmViNTYxYWI4NzM4NjBhY2NmMTllNmQzODRkMTljYTBmY2MzIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/Sm9zdGVpbj0yMEtqPUMzPUI4bmln c2VuPz0gPGpvc3RlaW5Aa2pvbmlnc2VuLm5ldD4KRGF0ZTogTW9uLCAyOCBOb3YgMjAyMiAx NjowNToyNyArMDEwMApTdWJqZWN0OiBbUEFUQ0ggNC80XSBsaXNwL3Byb2dtb2Rlcy90eXBl c2NyaXB0LXRzLW1vZGUuZWw6IGZvbnRpZmljYXRpb24KIGltcHJvdmVtZW50cwoKLSByZXN0 b3JlIG1ldGhvZC1uYW1lIGZvbnRpZmljYXRpb24uCi0gZm9udGlmeSBhbGwgdHlwZXMgaW4g Y2xhc3MtZGVjbGFyYXRpb25zLCBleHRlbmRlZXMgdG9vCi0tLQogbGlzcC9wcm9nbW9kZXMv dHlwZXNjcmlwdC10cy1tb2RlLmVsIHwgMTIgKysrKysrKysrLS0tCiAxIGZpbGUgY2hhbmdl ZCwgOSBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3Av cHJvZ21vZGVzL3R5cGVzY3JpcHQtdHMtbW9kZS5lbCBiL2xpc3AvcHJvZ21vZGVzL3R5cGVz Y3JpcHQtdHMtbW9kZS5lbAppbmRleCBiZjQ4M2EzMWQzNC4uNmM5MjZhNGUzZTAgMTAwNjQ0 Ci0tLSBhL2xpc3AvcHJvZ21vZGVzL3R5cGVzY3JpcHQtdHMtbW9kZS5lbAorKysgYi9saXNw L3Byb2dtb2Rlcy90eXBlc2NyaXB0LXRzLW1vZGUuZWwKQEAgLTE1MCwxMiArMTUwLDIwIEBA IHR5cGVzY3JpcHQtdHMtbW9kZS0tZm9udC1sb2NrLXNldHRpbmdzCiAKICAgICAgKG1ldGhv ZF9kZWZpbml0aW9uCiAgICAgICBuYW1lOiAocHJvcGVydHlfaWRlbnRpZmllcikgQGZvbnQt bG9jay1mdW5jdGlvbi1uYW1lLWZhY2UpCisgICAgIChyZXF1aXJlZF9wYXJhbWV0ZXIgKGlk ZW50aWZpZXIpIEBmb250LWxvY2stdmFyaWFibGUtbmFtZS1mYWNlKQorICAgICAob3B0aW9u YWxfcGFyYW1ldGVyIChpZGVudGlmaWVyKSBAZm9udC1sb2NrLXZhcmlhYmxlLW5hbWUtZmFj ZSkKIAogICAgICAodmFyaWFibGVfZGVjbGFyYXRvcgogICAgICAgbmFtZTogKGlkZW50aWZp ZXIpIEBmb250LWxvY2stdmFyaWFibGUtbmFtZS1mYWNlKQogCiAgICAgIChlbnVtX2RlY2xh cmF0aW9uIChpZGVudGlmaWVyKSBAZm9udC1sb2NrLXR5cGUtZmFjZSkKIAorICAgICAoZXh0 ZW5kc19jbGF1c2UgdmFsdWU6IChpZGVudGlmaWVyKSBAZm9udC1sb2NrLXR5cGUtZmFjZSkK KyAgICAgOzsgZXh0ZW5kcyBSZWFjdC5Db21wb25lbnQ8VD4KKyAgICAgKGV4dGVuZHNfY2xh dXNlIHZhbHVlOiAobWVtYmVyX2V4cHJlc3Npb24KKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgb2JqZWN0OiAoaWRlbnRpZmllcikgQGZvbnQtbG9jay10eXBlLWZhY2UKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgcHJvcGVydHk6IChwcm9wZXJ0eV9pZGVudGlmaWVy KSBAZm9udC1sb2NrLXR5cGUtZmFjZSkpCisKICAgICAgKGFycm93X2Z1bmN0aW9uCiAgICAg ICBwYXJhbWV0ZXI6IChpZGVudGlmaWVyKSBAZm9udC1sb2NrLXZhcmlhYmxlLW5hbWUtZmFj ZSkKIApAQCAtMjY3LDkgKzI3NSw3IEBAIHR5cGVzY3JpcHQtdHMtbW9kZS0tZm9udC1sb2Nr LXNldHRpbmdzCiAgICA6bGFuZ3VhZ2UgJ3RzeAogICAgOm92ZXJyaWRlIHQKICAgIDpmZWF0 dXJlICdwcm9wZXJ0eQotICAgYCgoKHByb3BlcnR5X2lkZW50aWZpZXIpIEBmb250LWxvY2st cHJvcGVydHktZmFjZSkKLQotICAgICAocGFpciB2YWx1ZTogKGlkZW50aWZpZXIpIEBmb250 LWxvY2stdmFyaWFibGUtbmFtZS1mYWNlKQorICAgYCgocGFpciB2YWx1ZTogKGlkZW50aWZp ZXIpIEBmb250LWxvY2stdmFyaWFibGUtbmFtZS1mYWNlKQogCiAgICAgICgoc2hvcnRoYW5k X3Byb3BlcnR5X2lkZW50aWZpZXIpIEBmb250LWxvY2stcHJvcGVydHktZmFjZSkKIAotLSAK Mi4zNy4yCgo= --------------tNXHamhpEiTnD0iQd3Fimm0a-- From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 28 12:26:39 2022 Received: (at 59660) by debbugs.gnu.org; 28 Nov 2022 17:26:39 +0000 Received: from localhost ([127.0.0.1]:49866 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozhtv-0006UL-EC for submit@debbugs.gnu.org; Mon, 28 Nov 2022 12:26:39 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53530) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozhtt-0006UF-Fu for 59660@debbugs.gnu.org; Mon, 28 Nov 2022 12:26:37 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozhtm-0004nR-An; Mon, 28 Nov 2022 12:26:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=0TP/I5e0MvjKPXUnPDYJl6g39nYvuhv6lcMCniBzlYE=; b=PMrnCRNsaB3FK/WKG6cd p+1fRpvRj21zAjj8L7qBaKy9KaFnS6VuWvzPrOUYFjCCDWkrS+OMNZ+SUiBeFbia+mdauVMOR1PqK daCLcSpRLYKvNb9FzzgfJLGJD+LXdmAlgS7w8h0qfDjqrGpzSul2SuwhyQwE1iJTMvrTOWqwusgPq 4v91VVGqtEMSH8NsdroH56bKYmr/yIGbwU2APIagxreAxYjKQWjJR9iyw+0NCC8W4nNIsW5Y+SPzJ MpQwQaBWQuLE/Dh+p0NHoBy1NBh0VwlQGhYZPnUrutpyQN72jiNTWZKm0hi/VQ5alS5iPm5TqIIdE 2wHh/VR1+q8SbQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozhtl-0002oq-O0; Mon, 28 Nov 2022 12:26:30 -0500 Date: Mon, 28 Nov 2022 19:27:00 +0200 Message-Id: <83y1rvm1ln.fsf@gnu.org> From: Eli Zaretskii To: jostein@kjonigsen.net In-Reply-To: (message from Jostein =?utf-8?Q?Kj=C3=B8nigsen?= on Mon, 28 Nov 2022 18:08:01 +0100) Subject: Re: bug#59660: lisp/progmodes/typescript-ts-mode.el: restore method-name fontification References: <729dcdf6-7cf7-3398-78d8-2b7ca1f2c005@secure.kjonigsen.net> <00b6627a-860b-f86c-06a9-5166da99a965@secure.kjonigsen.net> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59660 Cc: 59660@debbugs.gnu.org, casouri@gmail.com, theo@thornhill.no X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Mon, 28 Nov 2022 18:08:01 +0100 > From: Jostein Kjønigsen > > All fixes and one more squashed into the attached patch :) Which "all", please? AFAICT, you also posted a patch in another bug number, so is that also included? From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 28 13:01:11 2022 Received: (at 59660) by debbugs.gnu.org; 28 Nov 2022 18:01:11 +0000 Received: from localhost ([127.0.0.1]:50064 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oziRL-0000hV-4b for submit@debbugs.gnu.org; Mon, 28 Nov 2022 13:01:11 -0500 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:48799) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oziRF-0000h1-99 for 59660@debbugs.gnu.org; Mon, 28 Nov 2022 13:01:09 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 53BA7320097C; Mon, 28 Nov 2022 13:00:59 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Mon, 28 Nov 2022 13:00:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:reply-to:sender:subject:subject:to:to; s=fm3; t= 1669658458; x=1669744858; bh=uGtnfLi+4Q/NXAvcOVbY5KtkVoTF0wayRg5 aNCHPflE=; b=fhGkHi++mf5PRK8vqJhPF6rujl9bZMAngvovewjuFH+WnETc/kG kFs2p4faaECJJoJ2hGrr2JYkGrPt7CNAqRG2KAg26MgsNv3LANXJs0l5qC79fLY+ 47mxK7cJhylMvZ2kxi/Pr3beVJuDWIHbZxoO4/zvM7odgD0vRS5o8rLpfk/O3x0G +WWxY10jx4e4vCJRDwmWzFYFfvCp+itiUUwNMyZb6nMrJP0RS9Oiye1u/gK1OgjK u6WVhlYs5o0UfPT2B2DEdQsrAbQRkYHmqQSDh5eJle8sdmgjFzCm9fnJn4Zz7o30 CFvL0jzhDr1c1aRcnNAXvVMnjMGnEdUzhXw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1669658458; x=1669744858; bh=uGtnfLi+4Q/NX AvcOVbY5KtkVoTF0wayRg5aNCHPflE=; b=ezi5s0NQontgoAtcdNGl7+0fgCpWc Q1RNK6gEtMS7tFyimKUcenKRFFe5lVrEOcdNzd8FIBTLyeSjNzDW78VWa0Im4zdp zDMViYnvuSSkK1RoN8N9yXcZkAi8Zug/61dVUjBJ702A0Oy4r4JqJiR5Xxjicgkl exKm7eOXK96/BA8X8Wp7xKvEHrA5SHUouefOSVdMTNaPmzNYxH5BmjOR7c3iyaxQ CfZPdjeLNJ9TQ3AKAkVBfKTW03d0X3dXLhFELc3B5Hz2Hmotgx4X52YudsEZabyv zU3Zam1RQe/NzaKyet+sl0JKhe9WlzmXGHihyBTNrt/AeVU7E7sKZ7lvA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrjedvgdduuddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurheptgfkffggfghruffvvehfhfgjsegrtderredtfeejnecuhfhrohhmpeflohhs thgvihhnucfmjhppnhhighhsvghnuceojhhoshhtvghinhesshgvtghurhgvrdhkjhhonh highhsvghnrdhnvghtqeenucggtffrrghtthgvrhhnpeeujeejteehhfefgffftefghefg geeigeegtddvjeetjeejgedvueejhffgueefgeenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhn ihhgshgvnhdrnhgvth X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 28 Nov 2022 13:00:56 -0500 (EST) Content-Type: multipart/alternative; boundary="------------VN0YItkJCYJnVEn9AAcDSY5E" Message-ID: <4e6b1aa3-dd41-5116-06f1-c69d4f1ce917@secure.kjonigsen.net> Date: Mon, 28 Nov 2022 19:00:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: bug#59660: lisp/progmodes/typescript-ts-mode.el: restore method-name fontification Content-Language: nb-NO To: Eli Zaretskii , jostein@kjonigsen.net References: <729dcdf6-7cf7-3398-78d8-2b7ca1f2c005@secure.kjonigsen.net> <00b6627a-860b-f86c-06a9-5166da99a965@secure.kjonigsen.net> <83y1rvm1ln.fsf@gnu.org> From: =?UTF-8?Q?Jostein_Kj=c3=b8nigsen?= In-Reply-To: <83y1rvm1ln.fsf@gnu.org> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59660 Cc: 59660@debbugs.gnu.org, casouri@gmail.com, theo@thornhill.no X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: jostein@kjonigsen.net Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is a multi-part message in MIME format. --------------VN0YItkJCYJnVEn9AAcDSY5E Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 28.11.2022 18:27, Eli Zaretskii wrote: >> Date: Mon, 28 Nov 2022 18:08:01 +0100 >> From: Jostein Kjønigsen >> >> All fixes and one more squashed into the attached patch :) > Which "all", please? AFAICT, you also posted a patch in another bug number, > so is that also included? No. I've registered separate bugs for csharp-ts-mode and typescript-ts-mode, since they are distinct major-modes with no code in common. As such patches for C# has been sent to the C# bug. And TypeScript patches have been sent to the TypeScript-bug. As for "all", both csharp-ts-mode and typescript-ts-mode are "new" modes, and as such probably will have a few ripening issues once tested on real production code-bases and daily use (like I do now), In name of brewity, I decided not to file a bug-report for every single fontification issue I found, but rather bulk up the fixes per mode on the respective bugs for those two languages. I hope this is OK. As for TypeScript, IMO there still are a few minor issues wrt to how font-lock-variable-name-face gets applied (or not), but I don't have patches for those yet, and I would not consider them deal-breakers or release-killers :) -- Kind regards* Jostein Kjønigsen* --------------VN0YItkJCYJnVEn9AAcDSY5E Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit On 28.11.2022 18:27, Eli Zaretskii wrote:
Date: Mon, 28 Nov 2022 18:08:01 +0100
From: Jostein Kjønigsen <jostein@secure.kjonigsen.net>

All fixes and one more squashed into the attached patch :)

Which "all", please?  AFAICT, you also posted a patch in another bug number,
so is that also included?

No.

I've registered separate bugs for csharp-ts-mode and typescript-ts-mode, since they are distinct major-modes with no code in common.

As such patches for C# has been sent to the C# bug.

And TypeScript patches have been sent to the TypeScript-bug.

As for "all", both csharp-ts-mode and typescript-ts-mode are "new" modes, and as such probably will have a few ripening issues once tested on real production code-bases and daily use (like I do now),

In name of brewity, I decided not to file a bug-report for every single fontification issue I found, but rather bulk up the fixes per mode on the respective bugs for those two languages. I hope this is OK.

As for TypeScript, IMO there still are a few minor issues wrt to how font-lock-variable-name-face gets applied (or not), but I don't have patches for those yet, and I would not consider them deal-breakers or release-killers :)

--
Kind regards
Jostein Kjønigsen


--------------VN0YItkJCYJnVEn9AAcDSY5E-- From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 28 18:02:19 2022 Received: (at 59660) by debbugs.gnu.org; 28 Nov 2022 23:02:19 +0000 Received: from localhost ([127.0.0.1]:51490 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozn8k-00089Q-Pd for submit@debbugs.gnu.org; Mon, 28 Nov 2022 18:02:19 -0500 Received: from mail-pf1-f181.google.com ([209.85.210.181]:39913) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozn8i-00089J-JU for 59660@debbugs.gnu.org; Mon, 28 Nov 2022 18:02:17 -0500 Received: by mail-pf1-f181.google.com with SMTP id 140so11987222pfz.6 for <59660@debbugs.gnu.org>; Mon, 28 Nov 2022 15:02:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=g0vvpFzeZMkzHUPKVosGJ7RDpB1xGjs90cNFhMzDnck=; b=Rs20SSaWNyQ5K2powxmzfHekpEFJM29eQF33M4sW39T/4/cnrFNfNZ6nMVmFirnyYV DwnqncrXwGprDd8f1RhwRCn253IN5YvIyHs/ihVNk1qDheAfWYju6D0PYsthC5zd2u1l 9yB2M3BZsdlg5e8CmQEM+MBhjyjWB89vpgjXqLW3CRNLYBcDdmPId3GJWrdOnyRcYRNi Rwv+HSmrWpz2LhUhhwGyw8Vx/GWImbqpBGjLpsXpSBU6Ugh0UUaWzGirVq7E7dIEL48C dd79B+3fsiHa5zVG6yKeSO3bhZxq47idoLSXrczkvszxbvOCtTtjJ1mBlEc1SydEndOk SLIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=g0vvpFzeZMkzHUPKVosGJ7RDpB1xGjs90cNFhMzDnck=; b=0tuTDIaWi3BnYK22sscvxo4aefEpaWnQx4OnjqqLQxuBcKwownvaZ/sLDpwOtE4WqO ntuXZn/bOvXFgfZBx8lmZXTKiloMz5P5sqzJDHJHpB4g2nAWeXCNzLfMCtoVWNHaNAoL x3z9eaSDkYSTxy3MskdGXe4nSqaddN2A6KAHS6Jo7p7VUWTnbBabIoSv/uQTmZnsTbY4 K/GjrFKeYD+rWwdZrnyuu2Se/VoxEHHjOmS1jbZ6rjfcrxGz/wkkgANvItGSif+VevUL 9yJVw5usE4jtw4oEXzNg2KdBezxSj+Y7iRzG/K3hWzyydiUH88PRb4FkNrOK56tvsZKP RoRg== X-Gm-Message-State: ANoB5pkHiqQ2I/TBsQPIlrPgUIDCgJM1iVtFKdqcCgi8x61Onfjm60iI 3t5yQXYNmdD7JQiO4GFOGk0= X-Google-Smtp-Source: AA0mqf59QNldjQvTuxy+E3UioU8kjnKLcOxjvSmyUDMBcekStLp9Gl0c8CVoxKPrcpzO/zZreOIbWQ== X-Received: by 2002:a63:f40f:0:b0:478:1c89:5c9a with SMTP id g15-20020a63f40f000000b004781c895c9amr6195024pgi.384.1669676530785; Mon, 28 Nov 2022 15:02:10 -0800 (PST) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id ck11-20020a17090afe0b00b00218a7808ec9sm14573pjb.8.2022.11.28.15.02.09 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Nov 2022 15:02:10 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: bug#59660: lisp/progmodes/typescript-ts-mode.el: restore method-name fontification From: Yuan Fu In-Reply-To: Date: Mon, 28 Nov 2022 15:02:09 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: References: <729dcdf6-7cf7-3398-78d8-2b7ca1f2c005@secure.kjonigsen.net> <00b6627a-860b-f86c-06a9-5166da99a965@secure.kjonigsen.net> To: jostein@kjonigsen.net X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 59660 Cc: 59660@debbugs.gnu.org, Theodor Thornhill X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Nov 28, 2022, at 9:08 AM, Jostein Kj=C3=B8nigsen = wrote: >=20 > All fixes and one more squashed into the attached patch :) >=20 > Vennlig hilsen > Jostein Kj=C3=B8nigsen >=20 > jostein@kjonigsen.net =F0=9F=8D=B5 jostein@gmail.com > https://jostein.kj=C3=B8nigsen.no > On 28.11.2022 17:53, Jostein Kj=C3=B8nigsen wrote: >> And another improvement.=20 >>=20 >> -- >> Kind regards >> Jostein Kj=C3=B8nigsen >>=20 >> jostein@kjonigsen.net =F0=9F=8D=B5 jostein@gmail.com >> https://jostein.kj=C3=B8nigsen.no >> On 28.11.2022 17:44, Jostein Kj=C3=B8nigsen wrote: >>> This additional patch further improves fontification by fontifying = function-arguments as variables too. >>>=20 >>> -- >>>=20 >>> Kind regards >>> Jostein Kj=C3=B8nigsen >>>=20 >>> jostein@kjonigsen.net =F0=9F=8D=B5 jostein@gmail.com >>> https://jostein.kj=C3=B8nigsen.no >>> On 28.11.2022 16:09, Jostein Kj=C3=B8nigsen wrote: >>>> Attached is a simple patch which addresses this font-lock issue and = makes typescript-ts-mode much better to use. >>>>=20 >>>> --=20 >>>> Kind regards >>>> Jostein Kj=C3=B8nigsen >>>>=20 >>>> jostein@kjonigsen.net =F0=9F=8D=B5 jostein@gmail.com >>>> https://jostein.kj=C3=B8nigsen.no > <0004-lisp-progmodes-typescript-ts-mode.el-fontification-i.patch> Thanks! Applied with minor change to commit message. Yuan From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 28 18:06:39 2022 Received: (at 59660) by debbugs.gnu.org; 28 Nov 2022 23:06:39 +0000 Received: from localhost ([127.0.0.1]:51510 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oznCx-0008BG-F6 for submit@debbugs.gnu.org; Mon, 28 Nov 2022 18:06:39 -0500 Received: from mail-pg1-f181.google.com ([209.85.215.181]:40657) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oznCv-0008BA-Mj for 59660@debbugs.gnu.org; Mon, 28 Nov 2022 18:06:38 -0500 Received: by mail-pg1-f181.google.com with SMTP id f9so11316195pgf.7 for <59660@debbugs.gnu.org>; Mon, 28 Nov 2022 15:06:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=kuRV1rlPlgnxReQZtNZ7f0PUL/V4O1zc0W5N3z6mGeE=; b=IZ+8lxJTISj7U8u31sfUQDWeDQlR63m0aoAfixzqGunw/qhtfmkqaOSAbbAO9gdAWx qwkjMPVuX9Ernz/BtuLx0gpo3QKw4Hf4UUnuIhNi5bwK3f22pcnwGjpdJVyNxJeXmuuO 1YqRsVJIZK7Akmrq+vkfnYOJReKe1mo2Kz+JAkAXKmp+7glzIQg8gB2OmvYap0ZZPZ8N hv9EtoWWQ1Tn1CiB5idVz98sssskA1T5LuZOWRNPe1sQP0LbC3IA5Ov3o9OJzZrOC4n1 7rSpnUEg4A4iQsG89T392BTDBdhOKFG2ZoAZUm4dvOs28cx+CvFNxthDP+hYKeMZbZ9w baDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kuRV1rlPlgnxReQZtNZ7f0PUL/V4O1zc0W5N3z6mGeE=; b=j4Zm61Vo/6r15J+RxrdduxBDx4N7HzTLMpXfITl2VJnT28AoGbjOZLZSh/8Oftgz3b So7bct1a6mVsA+CyGpoZZzf1DHJ8HB1TJW84MEMOXmhlruTfL2L63Hx8I6o4TRbQrRjM KzwQWtWH/6GaYqOeAj+SsGUD0yiC+aLa7yxiT1ngcxpoVJ2XdPRTenaNhpfSZSYWUFoB rt7lE4/MPJLYHs21E3z2Ilx3X6D2ojrcc+AC/DHXPs9tPwlzT+ZPyU8DR8Bn0L2eqgce JBnJL/nSWctz39Iy25wyObwq3r5QQAOM24bwvAPsNOlGtSx5n0szQMolHzckWQGvUjLw 0SoQ== X-Gm-Message-State: ANoB5pmgHVLsPIGZ1v7T/OxsXpDx+CSAcjl8JKHZCLjtMTVUKJCQXGFn HlOJZnoE0ZjTKJYpXJVQQWA= X-Google-Smtp-Source: AA0mqf4zyjT7c9rb1qgdk9Yt7ygR8Zoc7rfGYeqPIfzf7RpJiRlzXkGnqAsFKU/f3aOClsDI3nhW1A== X-Received: by 2002:a62:5b43:0:b0:573:6cfc:2210 with SMTP id p64-20020a625b43000000b005736cfc2210mr36813000pfb.55.1669676792053; Mon, 28 Nov 2022 15:06:32 -0800 (PST) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id q17-20020a170902dad100b001898ee9f723sm2235557plx.2.2022.11.28.15.06.31 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Nov 2022 15:06:31 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: bug#59660: 29.0.50; typescript-ts-mode consistently fontifies method-names incorrectly From: Yuan Fu In-Reply-To: Date: Mon, 28 Nov 2022 15:06:30 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: References: To: jostein@kjonigsen.net X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59660 Cc: 59660@debbugs.gnu.org, theo@thornhill.no X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Nov 28, 2022, at 7:04 AM, Jostein Kj=C3=B8nigsen = wrote: >=20 > From: "Jostein Kj=C3=B8nigsen" = > To: bug-gnu-emacs@gnu.org > Subject: 29.0.50; typescript-ts-mode consistently fontifies = method-names incorrectly > --text follows this line-- >=20 > -- > When I: >=20 > 1. create a typescript file (sample.ts) > 2. create class and add some methods to it. >=20 > I observe that: >=20 > - method names are consistently fontified as font-lock-property-face. >=20 > I expected that: >=20 > - method names to be consistently fontified as = font-luck-function-name-face. >=20 > This seems to be because of the "property_identifier" is used for > functions in the treesitter-grammar, and this property is used > indiscriminately to apply font-lock-property-face at the bottom of the > major-mode grammar. >=20 > This "shadows" the former rules which correctly apply = font-lock-function-name-face. >=20 > The best would obviously have a way to identify properties more = accurately, to precent > shadowing from taking place. Unfortunately I cannot see a realiable = way to do that > based on the current parse-tree. >=20 > Seeing as properties in Typescript are fairly rare while methods are = very common, > it seems appropriate to me to remove the property-specific = fontification rules > to restore the method-fontification rules. >=20 > I got a patch for this ready, if people are willing to accept it. Maybe you can remove the :override flag for the property_identifier = rule, so it doesn=E2=80=99t shadow the function rule? Would that work = better? Yuan= From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 29 07:09:55 2022 Received: (at 59660) by debbugs.gnu.org; 29 Nov 2022 12:09:55 +0000 Received: from localhost ([127.0.0.1]:54334 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozzQw-0007s9-Nu for submit@debbugs.gnu.org; Tue, 29 Nov 2022 07:09:55 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45708) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozzQv-0007s2-En for 59660@debbugs.gnu.org; Tue, 29 Nov 2022 07:09:53 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozzQp-00040g-4x; Tue, 29 Nov 2022 07:09:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=lu9Dwl042oEau3t+S2u3o3o6VcuTcxoQEt+W8oHXH7M=; b=AI9sthsG25f15A3RVukc KLcKs1Czc262Fl5RpSpdkOlIJIFw1a5jaBZzPpS/B9YM/F93SQTOxZtEgiNu+CaFaTnEtdYNSIeyF GsbYMPFoJjlF7YzMxXuDh2U4YYFbU3DigsFxQSfwmB5hm9pn4Bx/JUb95qSa9fqu1NXvNyimXBC2D xpOT72IF5aCqSKfg73jo8AgDaQfd5aW6VNFWHNRVtd7mP5tUdG2fu5M1eGt7SspwRaGgaX3ttK9WN 0qAfVVbP2K3BNt1jXrnC7tZu2uIpvxSdj2/exxPY8WtiGVpIAHgAYLo8pdhMF/E9ZOsvRXRsQrV6K zPLhPIKZfyhXiA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozzQo-0002AH-Dh; Tue, 29 Nov 2022 07:09:46 -0500 Date: Tue, 29 Nov 2022 14:10:19 +0200 Message-Id: <83k03em05w.fsf@gnu.org> From: Eli Zaretskii To: Yuan Fu In-Reply-To: (message from Yuan Fu on Mon, 28 Nov 2022 15:06:30 -0800) Subject: Re: bug#59660: 29.0.50; typescript-ts-mode consistently fontifies method-names incorrectly References: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59660 Cc: 59660@debbugs.gnu.org, jostein@kjonigsen.net, theo@thornhill.no X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 59660@debbugs.gnu.org, theo@thornhill.no > From: Yuan Fu > Date: Mon, 28 Nov 2022 15:06:30 -0800 > > > 1. create a typescript file (sample.ts) > > 2. create class and add some methods to it. > > > > I observe that: > > > > - method names are consistently fontified as font-lock-property-face. > > > > I expected that: > > > > - method names to be consistently fontified as font-luck-function-name-face. > > > > This seems to be because of the "property_identifier" is used for > > functions in the treesitter-grammar, and this property is used > > indiscriminately to apply font-lock-property-face at the bottom of the > > major-mode grammar. > > > > This "shadows" the former rules which correctly apply font-lock-function-name-face. > > > > The best would obviously have a way to identify properties more accurately, to precent > > shadowing from taking place. Unfortunately I cannot see a realiable way to do that > > based on the current parse-tree. > > > > Seeing as properties in Typescript are fairly rare while methods are very common, > > it seems appropriate to me to remove the property-specific fontification rules > > to restore the method-fontification rules. > > > > I got a patch for this ready, if people are willing to accept it. > > Maybe you can remove the :override flag for the property_identifier rule, so it doesn’t shadow the function rule? Would that work better? This could be a personal preference, perhaps? It isn't clear to me that only one of the two is definitely correct. So maybe we need a user option for which one overrides which? From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 29 08:59:16 2022 Received: (at 59660) by debbugs.gnu.org; 29 Nov 2022 13:59:16 +0000 Received: from localhost ([127.0.0.1]:54518 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p018m-0002n5-5O for submit@debbugs.gnu.org; Tue, 29 Nov 2022 08:59:16 -0500 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:55765) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p018i-0002mw-1p for 59660@debbugs.gnu.org; Tue, 29 Nov 2022 08:59:13 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 6EF15320024A; Tue, 29 Nov 2022 08:59:02 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 29 Nov 2022 08:59:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1669730341; x=1669816741; bh=CLfy5PHLZv z55LHWJaipuDDSZUpVya+zkxFVRi/GKBU=; b=dogvogwZAdvFh1xxQYON9+Dqa/ moPuYKH4NobVFqDWGJ4FONHx6YiF1qiNEcmFCzCDiyyLNng6VqtcW1opaHP84YAf 3gPES9FylcsTYhf6eAY0YHVX+kWbQYLd0UBrio0UT6S2zl+ktafEBMgFyl1JZKcg XML+P7+govJvwJ26bqNEPiVSY4f5ffiNYGjKYfH/LwDDiQ21bffQw64SwT0BWU2y vHvqMgCjhl8MIVzSW5vcutqNA2HTCb8uQLMDkMAoYVNp/5ZIz2tbkBYm1ayfRsQj Y3j1LufzaOVAk+8ljVf33YnYS2aI4RJyF6FmXTSD9/0mXFbSpy/+NpzNrAXg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1669730341; x= 1669816741; bh=CLfy5PHLZvz55LHWJaipuDDSZUpVya+zkxFVRi/GKBU=; b=W pmwRVMgAiIVNMVM/CUufS8uSGlEXDAY7LqSCOL7Ja3+BuZUB2uTvjb+VyXteQJ0v /7BCNnPRWPgNqmRI8oK9ClprnJjDXE7dYIJtI3mfMJK7uxP0GtjN2HH5sgiLTQc1 TQ9SJ3FVWN28zmrSjdbFv1Ko6EpwMjQNRahWKXWjgbDBjXSh2KsTtoe5JxkqfD2d 7nNHLH6Bl0eqZ+dGbiDlCYILOW1HQJYjMMEXtTCJxYfi0yABkbIFFyELBhgvRXO/ s3TEPAA0kLEmGYFR5zN8iKgqgSN83GS8zQClXe8RpteRXIg8IiL+KlJA6jv6vJI6 +9ccGEli6agTAkMzi9AHA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrtddtgddvlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuvfevfhfhjggtgfesthekredttdefjeenucfhrhhomheplfhoshht vghinhcumfhjpphnihhgshgvnhcuoehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhnih hgshgvnhdrnhgvtheqnecuggftrfgrthhtvghrnheptddujefhvdekudefudffuddvuddu ieetheehkeelhedvgedtieevvdefieejtdffnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepjhhoshhtvghinhesshgvtghurhgvrdhkjhhonhhi ghhsvghnrdhnvght X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 29 Nov 2022 08:59:00 -0500 (EST) Message-ID: <5c6866bb-c353-58ee-39e4-9d861965e943@secure.kjonigsen.net> Date: Tue, 29 Nov 2022 14:58:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: bug#59660: 29.0.50; typescript-ts-mode consistently fontifies method-names incorrectly Content-Language: en-US To: Eli Zaretskii , Yuan Fu References: <83k03em05w.fsf@gnu.org> From: =?UTF-8?Q?Jostein_Kj=c3=b8nigsen?= In-Reply-To: <83k03em05w.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59660 Cc: 59660@debbugs.gnu.org, jostein@kjonigsen.net, theo@thornhill.no X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Cc: 59660@debbugs.gnu.org, theo@thornhill.no >> From: Yuan Fu >> Date: Mon, 28 Nov 2022 15:06:30 -0800 >> >> Maybe you can remove the :override flag for the property_identifier rule, so it doesn’t shadow the function rule? Would that work better? I plan to test that as quickly as I time permits. If we can make both behaviours work, that would obviously be the best. > This could be a personal preference, perhaps? It isn't clear to me that > only one of the two is definitely correct. So maybe we need a user option > for which one overrides which? I honestly think this is reasonably clear. "Properties" with getters and setters are at this point in time almost entirely unused in EcmaScript/TypeScript space. They are optional and have complicated syntax, and don't play well with JSON serialization (and thus can't be used in REST APIs). You however cannot write a program without defining or invoking methods/functions. So not having method-fontification working correctly will literally impact **all** TypeScript-users. -- Jostein From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 29 09:29:45 2022 Received: (at 59660) by debbugs.gnu.org; 29 Nov 2022 14:29:45 +0000 Received: from localhost ([127.0.0.1]:54558 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p01cH-00033x-3i for submit@debbugs.gnu.org; Tue, 29 Nov 2022 09:29:45 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34368) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p01cF-00033r-3v for 59660@debbugs.gnu.org; Tue, 29 Nov 2022 09:29:43 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p01c8-0007cB-UE; Tue, 29 Nov 2022 09:29:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=l8tccyvI1XwIbtJIBUIxH1CP5k8KEnXZXMp2vzyf1mY=; b=WmHmx0uVhqesjEE5tL1a 51VRrBrW3KyNZ4kx5Pcn3gmYYv/p2dNpcDL2QdJrUAHT/w1IDDHhdt7qyuLjvsCnBy5FovoGClQbM De8tQgMzZFAw7wKDfnUiNA3mQa/b1EGb+uDAtyTNEEptb4+tci9/L95XDzhO3ZyuSFC8yWY5vB81r aDDXxRcr6kHZZ6kdbpe5JQBv2I9NCUI3120Y70QGkSv3Ec+wUY5qOZ6eQtzYlr1LhexzjXMzEIk7m ihUqa/P3kajwE/7LmE79gp5BKamAm9zVhF7KwmEEb9082D7FxkgQ5pnkdiZiJYPQPeD5ac/rJdpr9 k4Z2ao1CPnJ7Cg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p01c8-0005xa-DM; Tue, 29 Nov 2022 09:29:36 -0500 Date: Tue, 29 Nov 2022 16:30:09 +0200 Message-Id: <8335a1n89a.fsf@gnu.org> From: Eli Zaretskii To: Jostein =?utf-8?Q?Kj=C3=B8nigsen?= In-Reply-To: <5c6866bb-c353-58ee-39e4-9d861965e943@secure.kjonigsen.net> (message from Jostein =?utf-8?Q?Kj=C3=B8nigsen?= on Tue, 29 Nov 2022 14:58:59 +0100) Subject: Re: bug#59660: 29.0.50; typescript-ts-mode consistently fontifies method-names incorrectly References: <83k03em05w.fsf@gnu.org> <5c6866bb-c353-58ee-39e4-9d861965e943@secure.kjonigsen.net> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59660 Cc: 59660@debbugs.gnu.org, casouri@gmail.com, jostein@kjonigsen.net, theo@thornhill.no X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Tue, 29 Nov 2022 14:58:59 +0100 > Cc: jostein@kjonigsen.net, 59660@debbugs.gnu.org, theo@thornhill.no > From: Jostein Kjønigsen > > > This could be a personal preference, perhaps? It isn't clear to me that > > only one of the two is definitely correct. So maybe we need a user option > > for which one overrides which? > > I honestly think this is reasonably clear. > > "Properties" with getters and setters are at this point in time almost > entirely unused in EcmaScript/TypeScript space. They are optional and > have complicated syntax, and don't play well with JSON serialization > (and thus can't be used in REST APIs). So you are saying Typescript should not even support these features in the tree-sitter based fontifications? If so, I'm okay with that, but it sounds like :override is the wrong tool for that, and we should simply remove "properties" from the list of features for Typescript? From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 29 10:10:17 2022 Received: (at 59660) by debbugs.gnu.org; 29 Nov 2022 15:10:17 +0000 Received: from localhost ([127.0.0.1]:54655 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p02FU-0003T9-O5 for submit@debbugs.gnu.org; Tue, 29 Nov 2022 10:10:17 -0500 Received: from out-237.mta0.migadu.com ([91.218.175.237]:64478) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p02FO-0003T1-Qr for 59660@debbugs.gnu.org; Tue, 29 Nov 2022 10:10:15 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1669734609; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1RpNUCb1in8XRRrrYOjyXXjfrNQe43vvLwWh12mT1IE=; b=e/DIs+XewtV0xqq0W84v5P/2VC8xWJZe4NY2Nln+ICfrgNRRWxIAL9PxWAAdawul9VKVof efOJ9aMhN9OZaoRVvzoUz/gjXSfgz+PulM9vSR403ultWeu0emdHv3mOij40wlB+meZaOh +QdW8OXUdSVdEHQ6g5AhY4en48iW+vaegTgANLVN+LBXNNGwHMp2Mf4gIPh69eP4ciy8Pd mY9UFO4ByljLJZdaMyw5wQDGF3q9uXOwEjM+HCqmWlXhptYaUOraGTDtPhUpfqVPzuP+Be Tm+JrodrTnJjmha117330xUPgxZ3n8x2rnAsntTD4RWBxGRnvcux2rP4cAeOdQ== From: Theodor Thornhill To: Jostein =?utf-8?Q?Kj=C3=B8nigsen?= , Eli Zaretskii , Yuan Fu Subject: Re: bug#59660: 29.0.50; typescript-ts-mode consistently fontifies method-names incorrectly In-Reply-To: <5c6866bb-c353-58ee-39e4-9d861965e943@secure.kjonigsen.net> References: <83k03em05w.fsf@gnu.org> <5c6866bb-c353-58ee-39e4-9d861965e943@secure.kjonigsen.net> Date: Tue, 29 Nov 2022 16:10:06 +0100 Message-ID: <87h6yhajap.fsf@thornhill.no> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59660 Cc: 59660@debbugs.gnu.org, jostein@kjonigsen.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jostein Kj=C3=B8nigsen writes: > Cc: 59660@debbugs.gnu.org, theo@thornhill.no >>> From: Yuan Fu >>> Date: Mon, 28 Nov 2022 15:06:30 -0800 >>> >>> Maybe you can remove the :override flag for the property_identifier rul= e, so it doesn=E2=80=99t shadow the function rule? Would that work better? > I plan to test that as quickly as I time permits. If we can make both=20 > behaviours work, that would obviously be the best. >> This could be a personal preference, perhaps? It isn't clear to me that >> only one of the two is definitely correct. So maybe we need a user opti= on >> for which one overrides which? > > I honestly think this is reasonably clear. > > "Properties" with getters and setters are at this point in time almost=20 > entirely unused in EcmaScript/TypeScript space. They are optional and=20 > have complicated syntax, and don't play well with JSON serialization=20 > (and thus can't be used in REST APIs). > > You however cannot write a program without defining or invoking=20 > methods/functions. So not having method-fontification working correctly=20 > will literally impact **all** TypeScript-users. Could you give me a code example, Jostein? I'm just interested in a repro, because I can't reproduce it with the typescript-ts-mode. I tried using this from [0]: ``` class Greeter { greeting: string; constructor(message: string) { this.greeting =3D message; } greet() { return "Hello, " + this.greeting; } } ``` On my end I get no property-face, just function-name-face. Both on constructor and greet. I'm not saying I disagree with you, but what am I missing? Theo [0]: https://www.typescriptlang.org/docs/handbook/classes.html From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 29 11:35:57 2022 Received: (at 59660) by debbugs.gnu.org; 29 Nov 2022 16:35:57 +0000 Received: from localhost ([127.0.0.1]:55092 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p03aP-0004OT-0v for submit@debbugs.gnu.org; Tue, 29 Nov 2022 11:35:57 -0500 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:59259) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p03aK-0004OM-Ra for 59660@debbugs.gnu.org; Tue, 29 Nov 2022 11:35:56 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id AD5F832001BB; Tue, 29 Nov 2022 11:35:46 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Tue, 29 Nov 2022 11:35:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1669739746; x=1669826146; bh=H4geYeTGhh YNPpb8tKqht7r3SOFPPkLZFICEYuGJcik=; b=MdMVb7mGL3QF4iNzDtfbgnkGK1 karm2UjZxhVwt7KWKJN7cY/GyEFCIo+tczMxy6lV6sp3kLR5Z7YpEBZkKmGtWDzy RoWslU9Y1y5mA/4TJx/9KTnWbxdkz1d8b/HSw9Cw0VEVlfgUjgh2ZITcx3EtYi7O 1TGjazg9KDPSG7Z/e+Qnd/rKNqsR74gRuO0JMoQHvk9iQInUJyIfkIw01aFSRjEG qMWPCmeYJl0o3tXPdou8XBfuvH85zGNQDDd0oU/gS3hhuLP9guG1/CMlbH9BiQQl el8zTpRpKwWnqv6IP5bdKezoRVLKSRob0mfXKTPuXSvh/boXLyAOiut5FvTA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1669739746; x= 1669826146; bh=H4geYeTGhhYNPpb8tKqht7r3SOFPPkLZFICEYuGJcik=; b=c yl1TEVmSinN08555RCfSQK9Z2WDbUPl7b6yLqPXNSCuh45bWJe0RqnvdrBfQzaDl boZHqQ7ZYAeMSNRVjkDPpZ5cdjIhbscmLk/7+D6K7xmhkgBlp6sET2GGodGzDRZQ PQ4b9XaJ4e+79txNKOjmpTx5x33fauupBz6nVr3J+Fc9CshBXPDzjjvTfyKyjyIK eifuSsjdiUyxSCgk7br7AK63zYVZCC2d5jIWGpN6su0LUjHjmElTlJJNZ29ZanaW 78qOPTLpXtQ/NpJNIikmQJVIVB++kmWX/fFegEPQcxSWtZ0Zj040j/Tz7H6JYoL+ 6FlwNQmPC73mZ4d1FSVUA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrtddtgdeiudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpegtgffhggfufffkfhevjgfvofesthhqmhdthhdtjeenucfhrhhomheplfhoshht vghinhcumfhjpphnihhgshgvnhcuoehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhnih hgshgvnhdrnhgvtheqnecuggftrfgrthhtvghrnhepfffgkefhvdeivdduhfeuieehfeev kedvveduudevfeeuleegffetfffgvdelueevnecuffhomhgrihhnpehthihpvghstghrih hpthhlrghnghdrohhrghdpkhhjnhhighhsvghnrdhnvghtnecuvehluhhsthgvrhfuihii vgeptdenucfrrghrrghmpehmrghilhhfrhhomhepjhhoshhtvghinhesshgvtghurhgvrd hkjhhonhhighhsvghnrdhnvght X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 29 Nov 2022 11:35:45 -0500 (EST) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: =?utf-8?Q?Jostein_Kj=C3=B8nigsen?= Mime-Version: 1.0 (1.0) Subject: Re: bug#59660: 29.0.50; typescript-ts-mode consistently fontifies method-names incorrectly Date: Tue, 29 Nov 2022 17:35:31 +0100 Message-Id: <30978023-D3F6-4A5D-B3D2-AF975807A637@secure.kjonigsen.net> References: <87h6yhajap.fsf@thornhill.no> In-Reply-To: <87h6yhajap.fsf@thornhill.no> To: Theodor Thornhill X-Mailer: iPhone Mail (20C5049e) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59660 Cc: 59660@debbugs.gnu.org, Eli Zaretskii , jostein@kjonigsen.net, Yuan Fu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > On 29 Nov 2022, at 16:10, Theodor Thornhill wrote: >=20 > =EF=BB=BFJostein Kj=C3=B8nigsen writes: >=20 >> Cc: 59660@debbugs.gnu.org, theo@thornhill.no >>>> From: Yuan Fu >>>> Date: Mon, 28 Nov 2022 15:06:30 -0800 >>>>=20 >>>> Maybe you can remove the :override flag for the property_identifier rul= e, so it doesn=E2=80=99t shadow the function rule? Would that work better? >> I plan to test that as quickly as I time permits. If we can make both=20 >> behaviours work, that would obviously be the best. >>> This could be a personal preference, perhaps? It isn't clear to me that= >>> only one of the two is definitely correct. So maybe we need a user opti= on >>> for which one overrides which? >>=20 >> I honestly think this is reasonably clear. >>=20 >> "Properties" with getters and setters are at this point in time almost=20= >> entirely unused in EcmaScript/TypeScript space. They are optional and=20 >> have complicated syntax, and don't play well with JSON serialization=20 >> (and thus can't be used in REST APIs). >>=20 >> You however cannot write a program without defining or invoking=20 >> methods/functions. So not having method-fontification working correctly=20= >> will literally impact **all** TypeScript-users. >=20 > Could you give me a code example, Jostein? I'm just interested in a > repro, because I can't reproduce it with the typescript-ts-mode. >=20 > I tried using this from [0]: > ``` > class Greeter { > greeting: string; >=20 > constructor(message: string) { > this.greeting =3D message; > } >=20 > greet() { > return "Hello, " + this.greeting; > } > } > ``` >=20 > On my end I get no property-face, just function-name-face. Both on > constructor and greet. I'm not saying I disagree with you, but what am > I missing? >=20 > Theo >=20 > [0]: https://www.typescriptlang.org/docs/handbook/classes.html >=20 I=E2=80=99ve already submitted patches to fix this which Yuan has pushed. Tr= y going a couple days back in time and try again ;)=20 What remains to be decided is what we do with property-highlighting, and if w= e can find a way to enable that without colliding with function-names.=20 =E2=80=94 Jostein Kj=C3=B8nigsen https://jostein.kj=C3=B8nigsen.net= From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 29 11:39:55 2022 Received: (at 59660) by debbugs.gnu.org; 29 Nov 2022 16:39:55 +0000 Received: from localhost ([127.0.0.1]:55116 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p03eE-0004Qb-MY for submit@debbugs.gnu.org; Tue, 29 Nov 2022 11:39:55 -0500 Received: from out-176.mta0.migadu.com ([91.218.175.176]:43372) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p03eC-0004QV-6h for 59660@debbugs.gnu.org; Tue, 29 Nov 2022 11:39:53 -0500 Date: Tue, 29 Nov 2022 17:39:44 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1669739989; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gS/ZAfqIsxwxAndLRrU+gi7YE2spXBNiHEcAyyHWqK8=; b=K9zfYlkMYR9db6jM2Lek4mFgSdV0HTP1v0PBecw6jdbYr8BdA9Vn9fv4mVyRZobwrsjUf4 qSaB/G52JMksek8i8xMgEfQraSXT5y6btqiI58x2e6BFSZo1IQvPJkXL+CX1AKADtFQqGe RkXQH3tJtnaoSaspfX5AlKuNpHsSnliihCUSdGbLcyfzJs7MUh0uNLeONrBXWWCiz0BNH9 ryHNGPEJEngkcWMGhRJnVjYEYBvTwZ5apYa/7GUn9i3SDKxve23VbjA8rlYc/4058TcPoA Lzrk5dwyQ+UJ9AVlUadknyojp+qNGQMydbuKQoS36DNExDoJXUZfs+T9pu2QOg== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Theodor Thornhill To: =?ISO-8859-1?Q?Jostein_Kj=F8nigsen?= Subject: =?US-ASCII?Q?Re=3A_bug=2359660=3A_29=2E0=2E50=3B_typescript-ts-mode_co?= =?US-ASCII?Q?nsistently_fontifies_method-names_incorrectly?= In-Reply-To: <30978023-D3F6-4A5D-B3D2-AF975807A637@secure.kjonigsen.net> References: <87h6yhajap.fsf@thornhill.no> <30978023-D3F6-4A5D-B3D2-AF975807A637@secure.kjonigsen.net> Message-ID: <003BFED0-4DA2-4DFF-9A7A-986B15B90D34@thornhill.no> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59660 Cc: 59660@debbugs.gnu.org, Eli Zaretskii , jostein@kjonigsen.net, Yuan Fu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 29 November 2022 17:35:31 CET, "Jostein Kj=C3=B8nigsen" wrote: > > >> On 29 Nov 2022, at 16:10, Theodor Thornhill wrote= : >>=20 >> =EF=BB=BFJostein Kj=C3=B8nigsen writ= es: >>=20 >>> Cc: 59660@debbugs=2Egnu=2Eorg, theo@thornhill=2Eno >>>>> From: Yuan Fu >>>>> Date: Mon, 28 Nov 2022 15:06:30 -0800 >>>>>=20 >>>>> Maybe you can remove the :override flag for the property_identifier = rule, so it doesn=E2=80=99t shadow the function rule? Would that work bette= r? >>> I plan to test that as quickly as I time permits=2E If we can make bot= h=20 >>> behaviours work, that would obviously be the best=2E >>>> This could be a personal preference, perhaps? It isn't clear to me t= hat >>>> only one of the two is definitely correct=2E So maybe we need a user= option >>>> for which one overrides which? >>>=20 >>> I honestly think this is reasonably clear=2E >>>=20 >>> "Properties" with getters and setters are at this point in time almost= =20 >>> entirely unused in EcmaScript/TypeScript space=2E They are optional an= d=20 >>> have complicated syntax, and don't play well with JSON serialization= =20 >>> (and thus can't be used in REST APIs)=2E >>>=20 >>> You however cannot write a program without defining or invoking=20 >>> methods/functions=2E So not having method-fontification working correc= tly=20 >>> will literally impact **all** TypeScript-users=2E >>=20 >> Could you give me a code example, Jostein? I'm just interested in a >> repro, because I can't reproduce it with the typescript-ts-mode=2E >>=20 >> I tried using this from [0]: >> ``` >> class Greeter { >> greeting: string; >>=20 >> constructor(message: string) { >> this=2Egreeting =3D message; >> } >>=20 >> greet() { >> return "Hello, " + this=2Egreeting; >> } >> } >> ``` >>=20 >> On my end I get no property-face, just function-name-face=2E Both on >> constructor and greet=2E I'm not saying I disagree with you, but what = am >> I missing? >>=20 >> Theo >>=20 >> [0]: https://www=2Etypescriptlang=2Eorg/docs/handbook/classes=2Ehtml >>=20 > >I=E2=80=99ve already submitted patches to fix this which Yuan has pushed= =2E Try going a couple days back in time and try again ;)=20 > >What remains to be decided is what we do with property-highlighting, and = if we can find a way to enable that without colliding with function-names= =2E=20 > >=E2=80=94 >Jostein Kj=C3=B8nigsen >https://jostein=2Ekj=C3=B8nigsen=2Enet Ah, don't mind me, I'll hide in the corner :-) From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 30 05:34:02 2022 Received: (at control) by debbugs.gnu.org; 30 Nov 2022 10:34:02 +0000 Received: from localhost ([127.0.0.1]:60133 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0KPi-0007Ae-G5 for submit@debbugs.gnu.org; Wed, 30 Nov 2022 05:34:02 -0500 Received: from mail-pf1-f180.google.com ([209.85.210.180]:38544) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0KPh-0007A7-AF for control@debbugs.gnu.org; Wed, 30 Nov 2022 05:34:01 -0500 Received: by mail-pf1-f180.google.com with SMTP id w129so16424076pfb.5 for ; Wed, 30 Nov 2022 02:34:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:date:message-id:subject:mime-version:content-transfer-encoding :from:from:to:cc:subject:date:message-id:reply-to; bh=9l/egK4JUNJ2W4L2BNCgEGQ4uneGD1aI5/dt9/04tBc=; b=G8twL2jQmbdRmTlC/JP8nrxWTyFLdh/KgQPyNjCzACdIKd/nAzTlPLK/j93ko27Ztl cdcXcgz8/WdVp137qy0df6jxCy20FxZaHe3lNbe8908J+slO8MQ9JpOpkaw6yifYbrLq bflJl+RGyiGrYMIyDFYA31i49shMjb6G3hwdF/ChCIevyiJAYqd2lOdte9G8i/EvYNjf 0mCIn7+y2E+iWsM2w2+orTVNhsQx6I5/nBMRXG1LcZScVctMtgK/BdppBfDqZ/n3yPQ0 RZjyrDMIAj1a3VLJJfP/reJXd4C4ZKJVEkkC1mJQi8DgjO/wkouEhGH/fiv+MMg8lYBg 7ctg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:date:message-id:subject:mime-version:content-transfer-encoding :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9l/egK4JUNJ2W4L2BNCgEGQ4uneGD1aI5/dt9/04tBc=; b=qirykN+XIPl7mkUsw0VJsdlx0S5QWuLE+IvSSWmNCVtmIZY4krCiv5H4km0Ccw6tQj Yvv0pAVUr63QMqDa9DII+v730macJoColOkcDZ057zgTd7V+5/l9nrrvhGE5y1TVHDLx 5Kohtnv2MiJdpXzNxdhv1gUXuOp1+DpDWfdcsBY/du+WPbe+4pIXOZYnH/CBRKs5psJ5 UIB+tcv/vS28br+m2Rwtoc3+/2NEZ8nD7EH+CpQc+Wa7eSihCJ7KfNkbhz1/To3wc9mO ZEvHkm/5yCL+IskSUbZsUzxCE/QTVcaGgIzKZoECYoptmfK97BI+7Q2hfUJZCAl0Shjz iUdQ== X-Gm-Message-State: ANoB5pmXNFL7INJmzR+7z+En/Kk2aQ8+uL7dplj32Hx8hLo470zeidi6 f6t5QBMdDj1EfDJu9hgevq2lY5SL/T8= X-Google-Smtp-Source: AA0mqf5wmAqb+hCDSa26G01lso0BAB+GjZgy5eBq6Mh4ce4M0C5aOPBcv9SwzLg0g7DuJB972fC2qA== X-Received: by 2002:a05:6a00:4308:b0:575:649c:e9e3 with SMTP id cb8-20020a056a00430800b00575649ce9e3mr9713310pfb.48.1669804435534; Wed, 30 Nov 2022 02:33:55 -0800 (PST) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id 16-20020a630f50000000b004767bc37e03sm744824pgp.39.2022.11.30.02.33.55 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Nov 2022 02:33:55 -0800 (PST) From: Yuan Fu Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: control message for bug #59660 Message-Id: <76F26A08-F144-494C-8782-8DFB8F7333DA@gmail.com> Date: Wed, 30 Nov 2022 02:33:54 -0800 To: control@debbugs.gnu.org X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 59660 29.1 quit From unknown Sun Jul 13 03:50:03 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 28 Dec 2022 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator