GNU bug report logs - #59648
[PATCH] gnu: icedove: Use native notifications when available

Previous Next

Package: guix-patches;

Reported by: SeerLite <seerlite <at> nixnet.email>

Date: Mon, 28 Nov 2022 04:55:01 UTC

Severity: normal

Tags: moreinfo, patch

Done: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#59648: closed ([PATCH] gnu: icedove: Use native notifications
 when available)
Date: Wed, 12 Apr 2023 08:35:01 +0000
[Message part 1 (text/plain, inline)]
Your message dated Wed, 12 Apr 2023 10:34:05 +0200
with message-id <677bc72b-04c8-bdf9-a16e-574767a3df8a <at> web.de>
and subject line [PATCH] gnu: icedove: Use native notifications when available
has caused the debbugs.gnu.org bug report #59648,
regarding [PATCH] gnu: icedove: Use native notifications when available
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
59648: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59648
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: SeerLite <seerlite <at> nixnet.email>
To: guix-patches <at> gnu.org
Cc: SeerLite <seerlite <at> nixnet.email>
Subject: [PATCH] gnu: icedove: Use native notifications when available
Date: Mon, 28 Nov 2022 01:54:09 -0300
* gnu/packages/gnuzilla.scm (icedove)[phases]{wrap-program}: Add libnotify
to LD_LIBRARY_PATH.
---
 gnu/packages/gnuzilla.scm | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
index feb80d81a2..6a8ee41a1e 100644
--- a/gnu/packages/gnuzilla.scm
+++ b/gnu/packages/gnuzilla.scm
@@ -1189,6 +1189,7 @@ (define (runpaths-of-input label)
                                         "eudev"
                                         "pulseaudio"
                                         ;; For the integration of native notifications
+                                        ;; (same reason as icedove)
                                         "libnotify"))))
                 (wrap-program (car (find-files lib "^icecat$"))
                   `("XDG_DATA_DIRS" prefix (,gtk-share))
@@ -1496,10 +1497,13 @@ (define-public icedove
                      (pulseaudio #$(this-package-input "pulseaudio"))
                      (pulseaudio-lib (string-append pulseaudio "/lib"))
                      (eudev #$(this-package-input "eudev"))
-                     (eudev-lib (string-append eudev "/lib")))
+                     (eudev-lib (string-append eudev "/lib"))
+                     ;; For the integration of native notifications (same reason as icecat)
+                     (libnotify #$(this-package-input "libnotify"))
+                     (libnotify-lib (string-append libnotify "/lib")))
                 (wrap-program (car (find-files lib "^icedove$"))
                   `("XDG_DATA_DIRS" prefix (,gtk-share))
-                  `("LD_LIBRARY_PATH" prefix (,pulseaudio-lib ,eudev-lib)))))))))
+                  `("LD_LIBRARY_PATH" prefix (,pulseaudio-lib ,eudev-lib ,libnotify-lib)))))))))
     (inputs
      (list alsa-lib
            bzip2
@@ -1519,6 +1523,7 @@ (define-public icedove
            libffi
            libgnome
            libjpeg-turbo
+           libnotify
            libpng-apng
            libvpx
            libxcomposite
-- 
2.38.1



[Message part 3 (message/rfc822, inline)]
From: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
To: 59648-done <at> debbugs.gnu.org
Subject: [PATCH] gnu: icedove: Use native notifications when available
Date: Wed, 12 Apr 2023 10:34:05 +0200
Hello SeerLite,

rebased and pushed as a3239ffd84e6ee9d9494085ddc3b875ebf43e225.

~Jonathan


This bug report was last modified 2 years and 40 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.