GNU bug report logs - #59623
[PATCH] gnu: Add bgpq3.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#59623: closed ([PATCH] gnu: Add bgpq3.)
Date: Fri, 02 Dec 2022 19:58:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 02 Dec 2022 20:44:01 +0100
with message-id <87edthy3uu.fsf <at> nckx>
and subject line Re: [bug#59623] [PATCH] gnu: Add bgpq3.
has caused the debbugs.gnu.org bug report #59623,
regarding [PATCH] gnu: Add bgpq3.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
59623: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59623
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Felix Lechner <felix.lechner <at> lease-up.com>
To: guix-patches <at> gnu.org
Cc: Felix Lechner <felix.lechner <at> lease-up.com>
Subject: [PATCH] gnu: Add bgpq3.
Date: Sat, 26 Nov 2022 18:27:27 -0800

* gnu/packages/networking.scm (bgpq3): New variable.
---
 gnu/packages/networking.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index f5276e330e..f5e0760878 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -2998,6 +2998,37 @@ (define-public quagga
     (home-page "https://www.nongnu.org/quagga/")
     (license license:gpl2+)))
 
+(define-public bgpq3
+  (let ((commit "9e46c66cff0c0cdcca653141b1664dbf6f9370ed")
+        (revision "0"))
+    (package
+      (name "bgpq3")
+      (version (git-version "0.1.36.1" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/snar/bgpq3")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "0768hihx7idmn2dk8ii21m0dm052amlnfpqq53vsfaapb60n1smc"))))
+      (build-system gnu-build-system)
+      (arguments
+       '(#:phases
+         (modify-phases %standard-phases
+           (delete 'check))))
+      (native-inputs (list python-markdown))
+      (home-page "http://snar.spb.ru/prog/bgpq3/")
+      (synopsis "Generate BGP filters from the Internet Routing Registry system")
+      (description
+       "This program generates BGP routing filters from data in the Internet
+Routing Registry system, including the Routing Assets Database that is operated
+by the Merit Network at the University of Michigan.  Examples are prefix-lists,
+extended access-lists, policy-statement terms and as-path lists.  It is an
+essential peering tool for exchange operators.")
+      (license license:bsd-2))))
+
 (define-public thc-ipv6
   (let ((revision "0")
         (commit "4bb72573e0950ce6f8ca2800a10748477020029e"))

base-commit: c457c715a83358fa1557f703b1e459435fb1a259
-- 
2.38.1

[Message part 3 (message/rfc822, inline)]

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: Felix Lechner <felix.lechner <at> lease-up.com>
Cc: guix-patches <at> gnu.org, 59623-done <at> debbugs.gnu.org
Subject: Re: [bug#59623] [PATCH] gnu: Add bgpq3.
Date: Fri, 02 Dec 2022 20:44:01 +0100

[Message part 4 (text/plain, inline)]

Hi Felix,

Felix Lechner via Guix-patches via 写道：
> * gnu/packages/networking.scm (bgpq3): New variable.

Thanks!

> +(define-public bgpq3
> +  (let ((commit "9e46c66cff0c0cdcca653141b1664dbf6f9370ed")
> +        (revision "0"))

I dropped this and referred directly to the

> +      (version (git-version "0.1.36.1" revision commit))

tag, only because that's the current convention.  The result is 
equivalent.

> +      (arguments
> +       '(#:phases
> +         (modify-phases %standard-phases
> +           (delete 'check))))

Similarly, we use

 #:tests? #f                 ; no test suite

instead.  No functional change.

> +      (home-page "http://snar.spb.ru/prog/bgpq3/")

Self-signed certificates are the best certificates!  :-/

> +      (synopsis "Generate BGP filters from the Internet Routing 
> Registry system")
> +      (description
> +       "This program generates BGP routing filters from data in 
> the Internet
> +Routing Registry system, including the Routing Assets Database 
> that is operated
> +by the Merit Network at the University of Michigan.  Examples 
> are prefix-lists,
> +extended access-lists, policy-statement terms and as-path 
> lists.  It is an
> +essential peering tool for exchange operators.")

I took the liberty of expanding this a bit, mostly by adding 
mark-up and including the search terms ‘IRR’ and ‘RADB’.

I don't dispute its accuracy, but ‘an essential peering tool’ runs 
afoul of Guix's policy of toning down marketing language.  I did 
keep the reference to IXes though.

> +      (license license:bsd-2))))

As noted on IRC, there are two BSD-3 files in this package.  Both 
the author & GitHub seem to have missed this.  I've submitted a 
bug report.

Pushed with the above changes as 
9ef6286bc3f6ed780606d3c2089aed7ff73074c3.

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.