GNU bug report logs - #59617
29.0.50; Add indent styles to all tree-sitter modes

Previous Next

Full log

Message #53 received at 59617 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Theodor Thornhill <theo <at> thornhill.no>, 59617 <at> debbugs.gnu.org
Subject: Re: bug#59617: 29.0.50; Add indent styles to all tree-sitter modes
Date: Wed, 30 Nov 2022 13:44:39 -0800

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Theodor Thornhill <theo <at> thornhill.no>
>> Cc: casouri <at> gmail.com, 59617 <at> debbugs.gnu.org
>> Date: Tue, 29 Nov 2022 16:19:26 +0100
>> 
>> Theodor Thornhill <theo <at> thornhill.no> writes:
>> 
>> > Rebased on emacs-29.
>> >
>> 
>> Is this good to go or should I change something here?
>
> Good to go from my POV, but I wanted also to hear from Yuan.
>
> Thanks.

Hey sorry, I was busy with some other things. I’ve looked at the patch,
it seems adding a hook that sets treesit-simple-indent-rules would have
the same effect, no? (Ie, user already can set a custom indent style)
Like instead of

(defvar my-personal-csharp-mode-indent-rules (...))

(setq csharp-ts-mode-indent-style
      (lambda () my-personal-csharp-mode-indent-rules))

you can just do

(defvar my-personal-csharp-mode-indent-rules (...))

(add-hook 'csharp-mode-hook
          (lambda ()
           (setq treesit-simple-indent-rules
                 my-personal-csharp-mode-indent-rules)))

This way there is no need to define a custom option and a function for
each mode. And users can use the same variable
treesit-simple-indent-rules, just in different major mode hooks.

Yuan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.