GNU bug report logs - #59605
29.0.50; gdb no more creates Gud menu entry for source file window

Previous Next

Full log

Message #11 received at 59605 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: martin rudalics <rudalics <at> gmx.at>, 59605 <at> debbugs.gnu.org
Subject: Re: bug#59605: 29.0.50; gdb no more creates Gud menu entry for
 source file window
Date: Mon, 28 Nov 2022 12:55:37 -0500

>> With emacs -Q visit an arbitrary Emacs C source file and do your
>> equivalent of M-: (gdb "gdb -i=mi emacs").  Now selecting the window
>> showing the source file buffer no more shows a Gud menu entry.  This has
>> the consequence that mouse clicking in a fringe no more sets/unsets a
>> breakpoint in that buffer.
>> 
>> The commit responsible for that behavior is
>> 
>> commit 8bb5c1bfec0929f2ba419e1c503f5acc01c336c2
>> Author: Lars Ingebrigtsen <larsi <at> gnus.org>
>> Date:   Thu Sep 1 13:39:14 2022 +0200
>> 
>>      Make easy-mmode-defmap obsolete and adjust only caller
>> 
>>      * lisp/emacs-lisp/easy-mmode.el (easy-mmode-defmap): Make obsolete.
>>      * lisp/progmodes/gud.el (gud-menu-map): Use easy-menu-define.
>
> Stefan, can you help here?  It looks like gud-minor-mode is not a proper
> minor mode,

Indeed, we should fix that.

> so the new code isn't working because gud-minor-mode-map is not
> in effect or something?

The immediate problem in the patch is that it removed

    (setf (alist-get 'gud-minor-mode minor-mode-map-alist)
          gud-minor-mode-map)

without replacing it with anything else.
Re-adding those 2 lines seems to bring back the previous behavior.


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.