From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 26 03:41:17 2022 Received: (at submit) by debbugs.gnu.org; 26 Nov 2022 08:41:17 +0000 Received: from localhost ([127.0.0.1]:37762 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyqkP-0001jL-4i for submit@debbugs.gnu.org; Sat, 26 Nov 2022 03:41:17 -0500 Received: from lists.gnu.org ([209.51.188.17]:37214) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyqkK-0001j9-0C for submit@debbugs.gnu.org; Sat, 26 Nov 2022 03:41:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyqkJ-0002ow-Q7 for bug-gnu-emacs@gnu.org; Sat, 26 Nov 2022 03:41:11 -0500 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyqkF-0002g9-35 for bug-gnu-emacs@gnu.org; Sat, 26 Nov 2022 03:41:11 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id A45BA240026 for ; Sat, 26 Nov 2022 09:41:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1669452064; bh=ifdhlkdLWVTY8HnEmAKIHWwGsl+EsBlib1/MndmyV1E=; h=From:To:Subject:Date:From; b=frd0e6KWEoXEMOUpcBSrXTmF1d/GLRjm/Vhf1dJyj8ynEN6QlCwOyEKrXAmPHGXUY tviryKuNw1nHfeHhXlCkvb5BcsXFsrFznJeddMrCUvikzjFIieWFSt8BJ9ss5qEZRl WD8pfp+ZKZKnlDP2IfrZq+5FntqjA2di7DuNXxfNPytNioI694lnpUqMnjJw+tOCua 6s5pQVBGBCB+R6L0YfRNu0I7O6nBXyRGmqY3QFnytc54bZmUGXHjjj6DwDvgxv5Azn wm0+oYogRSsVOeYC9IjtoRomwjBILIWQ4c9BNE4q2P0lv0WIKbxfz5Yo35aiL0dScm e1tPVnhvqMlRw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NK4vK142Bz6tmK for ; Sat, 26 Nov 2022 09:40:59 +0100 (CET) From: Ihor Radchenko To: bug-gnu-emacs@gnu.org Subject: 28.1.90; `ucs-normalize-string' fails to work Date: Sat, 26 Nov 2022 08:41:39 +0000 Message-ID: <87wn7ijef0.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi, I just stumbled upon `ucs-normalize-string' (defmacro ucs-normalize-string (ucs-normalize-region) `(with-temp-buffer (insert str) (,ucs-normalize-region (point-min) (point-max)) (buffer-string))) It apparently uses undefined variable `str', which does not look right. Also, no docstring. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 26 03:57:30 2022 Received: (at 59603-done) by debbugs.gnu.org; 26 Nov 2022 08:57:30 +0000 Received: from localhost ([127.0.0.1]:37776 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyr05-00028T-Lk for submit@debbugs.gnu.org; Sat, 26 Nov 2022 03:57:29 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46236) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyr03-00028G-ES for 59603-done@debbugs.gnu.org; Sat, 26 Nov 2022 03:57:27 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyqzx-0006C1-VM; Sat, 26 Nov 2022 03:57:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=aUf+pzBtPLYXNV0gk7VsChVfHOVOJ5eTSm+mGRzUpmg=; b=LaVz1suj3nHr vyrXmfOUXeA1cRbjP8cJtr1EWog5og5Wpk/UCq9OVYX/AfJFxUUYeKjVenqtBVjDZu6neIOnXgNNn lwC2zoWmtvcrHkM1Ryv+InZ/40CwhxZQXpiNjKKuIAEPthF6mtpTTN1LiWqpS3nk0oLHsh4sEKRbV VGz/RyBnFOtDLuKSyqG7kF9mHpey5I6fqdManrez5HV1EEIpwS4lY5DZmzG//RKuSHVq4ChCsptnF gaN0kz2d10BMCpI7why+E6jpmi+oyKjZ0MUb3iHi8ctnYf3GUKb8bHzDfa3SV3pQig08E5vCuWkQN IJwF/nc1dAalK9DJBTTt5Q==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyqzx-00083h-8m; Sat, 26 Nov 2022 03:57:21 -0500 Date: Sat, 26 Nov 2022 10:57:45 +0200 Message-Id: <83mt8et7na.fsf@gnu.org> From: Eli Zaretskii To: Ihor Radchenko In-Reply-To: <87wn7ijef0.fsf@localhost> (message from Ihor Radchenko on Sat, 26 Nov 2022 08:41:39 +0000) Subject: Re: bug#59603: 28.1.90; `ucs-normalize-string' fails to work References: <87wn7ijef0.fsf@localhost> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59603-done Cc: 59603-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Ihor Radchenko > Date: Sat, 26 Nov 2022 08:41:39 +0000 > > I just stumbled upon `ucs-normalize-string' > > (defmacro ucs-normalize-string (ucs-normalize-region) > `(with-temp-buffer > (insert str) > (,ucs-normalize-region (point-min) (point-max)) > (buffer-string))) > > It apparently uses undefined variable `str', which does not look right. It's a macro, not a function. So STR could come from the code which calls the macro. Look how it is used in that file, and you will see what I mean. > Also, no docstring. I added a doc string. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 26 04:03:54 2022 Received: (at 59603-done) by debbugs.gnu.org; 26 Nov 2022 09:03:54 +0000 Received: from localhost ([127.0.0.1]:37796 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyr6I-0002Jc-0m for submit@debbugs.gnu.org; Sat, 26 Nov 2022 04:03:54 -0500 Received: from mout02.posteo.de ([185.67.36.66]:42335) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyr6F-0002JP-Vo for 59603-done@debbugs.gnu.org; Sat, 26 Nov 2022 04:03:52 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 1C974240104 for <59603-done@debbugs.gnu.org>; Sat, 26 Nov 2022 10:03:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1669453426; bh=CVwwKHmvVo/+2IKRkrN+M0Mf3rHj4SgL3xdfKWICakw=; h=From:To:Cc:Subject:Date:From; b=a8g4wOdfx1cNTwuMAnNWNsCGG83wSR/araW5CqLUzKHDx7a4Cn2/EGRqxqE02eeSH kiebjBYsmU/MoyzXR6ZpaQPmFHu6b4i3i+7NmtQheTEethdaP2HmxSkkmaUbR7GtP7 as529VXch/Pz/QY1PrXT8Dl8ACcLaNaCQBZJdA/wnnW1bRQlRYQFlfhvNU1EYJgrc3 Mmd6xn21gNFT89wUWJMqamquSf8k2VHaSSHyA8BypTlrSx5FHydY3aepXrUHn5wUiw 10RECWB+2N9Hwtblu+RG0ndJ5o/vPG/VqHzUG64FIugOiEOyKQrFahpjeRL4z/gnKm bTPjdpG9YRoGQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NK5PW6lBmz6tlh; Sat, 26 Nov 2022 10:03:43 +0100 (CET) From: Ihor Radchenko To: Eli Zaretskii Subject: Re: bug#59603: 28.1.90; `ucs-normalize-string' fails to work In-Reply-To: <83mt8et7na.fsf@gnu.org> References: <87wn7ijef0.fsf@localhost> <83mt8et7na.fsf@gnu.org> Date: Sat, 26 Nov 2022 09:04:22 +0000 Message-ID: <87sfi6jdd5.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59603-done Cc: 59603-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: >> (defmacro ucs-normalize-string (ucs-normalize-region) >> `(with-temp-buffer >> (insert str) >> (,ucs-normalize-region (point-min) (point-max)) >> (buffer-string))) >> >> It apparently uses undefined variable `str', which does not look right. > > It's a macro, not a function. So STR could come from the code which calls > the macro. Look how it is used in that file, and you will see what I mean. I understand. But this macro is not private (no --). I feel like using "str" there is a questionable code style. >> Also, no docstring. > > I added a doc string. Thanks! The new docstring implies that STR is an argument, doesn't it? -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 26 04:23:34 2022 Received: (at 59603) by debbugs.gnu.org; 26 Nov 2022 09:23:34 +0000 Received: from localhost ([127.0.0.1]:37818 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyrPJ-0002lR-PR for submit@debbugs.gnu.org; Sat, 26 Nov 2022 04:23:34 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51934) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyrPI-0002lD-6f for 59603@debbugs.gnu.org; Sat, 26 Nov 2022 04:23:32 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyrPD-00033x-0E; Sat, 26 Nov 2022 04:23:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=29GxodvsKTAo8qnla6Yqni6x0oLjtgA6UITMDKa/8fw=; b=SZPRtORGjNGr no820uduK1BX63ZyF2Oa0y5tIJZ8+t/+LDJEvSUA6jmHSQWzweqTAbRN4iMY6585/bL9eJfSnoA/N wPMBoIHZtazzB5MsO+vewUYHWqFyPKdBqRDu8DzWF+7NBw71Sxbfv0/yfFZxszzUq0NGXH2rrX4qD kk1Lji0LoyzZCYQNfNsoebr6qsd58aM6P1IBHiBb6dFwK7GxnJuqWDqAEZJthr4HB7JBbbHlW875D cHmp1Pdr/CKjXBUhLX0YQre5J3yeQ+iMOHwLYLW4aVEzFwOpK5vYapg5uGyzmFcqe70u+0Ae+yki7 qGAp5V9KjMm4CG/UR/Z9vQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyrPC-0005Cg-Fw; Sat, 26 Nov 2022 04:23:26 -0500 Date: Sat, 26 Nov 2022 11:23:51 +0200 Message-Id: <83h6ymt6fs.fsf@gnu.org> From: Eli Zaretskii To: Ihor Radchenko In-Reply-To: <87sfi6jdd5.fsf@localhost> (message from Ihor Radchenko on Sat, 26 Nov 2022 09:04:22 +0000) Subject: Re: bug#59603: 28.1.90; `ucs-normalize-string' fails to work References: <87wn7ijef0.fsf@localhost> <83mt8et7na.fsf@gnu.org> <87sfi6jdd5.fsf@localhost> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59603 Cc: 59603@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Ihor Radchenko > Cc: 59603-done@debbugs.gnu.org > Date: Sat, 26 Nov 2022 09:04:22 +0000 > > Eli Zaretskii writes: > > >> (defmacro ucs-normalize-string (ucs-normalize-region) > >> `(with-temp-buffer > >> (insert str) > >> (,ucs-normalize-region (point-min) (point-max)) > >> (buffer-string))) > >> > >> It apparently uses undefined variable `str', which does not look right. > > > > It's a macro, not a function. So STR could come from the code which calls > > the macro. Look how it is used in that file, and you will see what I mean. > > I understand. But this macro is not private (no --). I feel like using > "str" there is a questionable code style. It's too late to change that: this macro is very old and predates the -- conventions. > >> Also, no docstring. > > > > I added a doc string. > > Thanks! The new docstring implies that STR is an argument, doesn't it? It doesn't. From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 26 04:37:22 2022 Received: (at 59603) by debbugs.gnu.org; 26 Nov 2022 09:37:23 +0000 Received: from localhost ([127.0.0.1]:37828 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyrcg-000364-F2 for submit@debbugs.gnu.org; Sat, 26 Nov 2022 04:37:22 -0500 Received: from mout02.posteo.de ([185.67.36.66]:60939) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyrcc-00035o-36 for 59603@debbugs.gnu.org; Sat, 26 Nov 2022 04:37:21 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 079D0240103 for <59603@debbugs.gnu.org>; Sat, 26 Nov 2022 10:37:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1669455432; bh=JDjjFctRfXoMBXyrAAAhnYY9VvGTxStX9oM4Q9m2KnA=; h=From:To:Cc:Subject:Date:From; b=DnZphfz3AYUoRDEUN94+B813rJvCtWBiqboVm3aUy6Ds9Ez5Se8LR0iTSZHVFwPSw omNlmoJSCHwlH6duZqLFkAXqTX6QlrNzFnzobApJ5tQhOM0sjH+ZZzTzNnJ8RR5SjK xEIEiRUELrC+wFjtE58immc99O/D0Cpobce67x/LEOBdtWn20Xkeqhn/v7klE1NWGj xloW8fdKs21dRHoBNIVLw0LSwSkOfrKhJ+2BZ0bIr6g35ScgcF6uZz+y/YtFxXGpId BPSsNzTkdUwj983475RSwvhRSbHMRvePwKcUaXWeMr1v3n0mM+EsjZTny/p0UCwMtj SZlRxOPJEPVFg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NK68434Vcz9rxL; Sat, 26 Nov 2022 10:37:07 +0100 (CET) From: Ihor Radchenko To: Eli Zaretskii Subject: Re: bug#59603: 28.1.90; `ucs-normalize-string' fails to work In-Reply-To: <83h6ymt6fs.fsf@gnu.org> References: <87wn7ijef0.fsf@localhost> <83mt8et7na.fsf@gnu.org> <87sfi6jdd5.fsf@localhost> <83h6ymt6fs.fsf@gnu.org> Date: Sat, 26 Nov 2022 09:37:47 +0000 Message-ID: <87pmdajbtg.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59603 Cc: 59603@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: >> I understand. But this macro is not private (no --). I feel like using >> "str" there is a questionable code style. > > It's too late to change that: this macro is very old and predates the -- > conventions. I see. >> >> Also, no docstring. >> > >> > I added a doc string. >>=20 >> Thanks! The new docstring implies that STR is an argument, doesn't it? > > It doesn't. I feel a bit confused now. I am now reviewing D.6 Tips for Documentation Strings section of Elisp manual: =E2=80=A2 When a function=E2=80=99s documentation string mentions the va= lue of an argument of the function, use the argument name in capital letters as if it were a name for that value. Thus, the documentation string of the function =E2=80=98eval=E2=80=99 refers to its first argu= ment as =E2=80=98FORM=E2=80=99, because the actual argument name is =E2=80=98f= orm=E2=80=99: Evaluate FORM and return its value. Also write metasyntactic variables in capital letters, such as when you show the decomposition of a list or vector into subunits, some of which may vary. =E2=80=98KEY=E2=80=99 and =E2=80=98VALUE=E2=80=99 = in the following example illustrate this practice: The argument TABLE should be an alist whose elements have the form (KEY . VALUE). Here, KEY is ... =E2=80=A2 Never change the case of a Lisp symbol when you mention it in = a doc string. If the symbol=E2=80=99s name is =E2=80=98foo=E2=80=99, write = =E2=80=9Cfoo=E2=80=9D, not =E2=80=9CFoo=E2=80=9D (which is a different symbol). I do see that uppercase symbol names may not always refer to the arguments, but don't `str' fit better into the conventions? It is the symbol to be used in the macro, after all. Or do I miss something? --=20 Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 26 05:10:44 2022 Received: (at 59603) by debbugs.gnu.org; 26 Nov 2022 10:10:44 +0000 Received: from localhost ([127.0.0.1]:37874 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oys8o-0003xy-Qy for submit@debbugs.gnu.org; Sat, 26 Nov 2022 05:10:44 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41244) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oys8n-0003xm-RW for 59603@debbugs.gnu.org; Sat, 26 Nov 2022 05:10:34 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oys8i-0004Vp-L8; Sat, 26 Nov 2022 05:10:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=K/DPjf23oTKebRs0GIMOVaHzL0gpyVk0uOFSJZNzNg0=; b=noTmZz8NFJEt bid9+cNOcTbb8KC6Yv2MaIP8+I4wzcbWVGdQtDnqCMWSuW3qeHd59Eb9xw2omJpEHiOAT06fpr3qr EPhm5AkySNsuGUqlYu8uRIRBkwWwFfNp8OMhLRTgHVIEtQcRd86wcQJPD38/0PGFtFeVUr729MbvY 7U9si/oxLRh0lfqRCEi9HgpuNCmergrkxocgdY5e7prWaX2vZrXO2iOYnooW3z8VSaB7xnHhKO7hE DdlpOe0DZ3S7rF+WFXRs6E4rGm/12hod5NdsfG3hp6/F42huNuMEeOprryuPH6vqfj1YVQY/RX78R PCo1F5AEykxfb6rOKU2geQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oys8h-0005j7-Kd; Sat, 26 Nov 2022 05:10:27 -0500 Date: Sat, 26 Nov 2022 12:10:52 +0200 Message-Id: <83edtqt49f.fsf@gnu.org> From: Eli Zaretskii To: Ihor Radchenko In-Reply-To: <87pmdajbtg.fsf@localhost> (message from Ihor Radchenko on Sat, 26 Nov 2022 09:37:47 +0000) Subject: Re: bug#59603: 28.1.90; `ucs-normalize-string' fails to work References: <87wn7ijef0.fsf@localhost> <83mt8et7na.fsf@gnu.org> <87sfi6jdd5.fsf@localhost> <83h6ymt6fs.fsf@gnu.org> <87pmdajbtg.fsf@localhost> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59603 Cc: 59603@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Ihor Radchenko > Cc: 59603@debbugs.gnu.org > Date: Sat, 26 Nov 2022 09:37:47 +0000 > > Eli Zaretskii writes: > > I do see that uppercase symbol names may not always refer to the > arguments, but don't `str' fit better into the conventions? It is the > symbol to be used in the macro, after all. > Or do I miss something? How else do you suggest to indicate in the doc string that the macro operates on a variable named 'str'? Using `str' is much more confusing, IMO. From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 26 05:15:47 2022 Received: (at 59603) by debbugs.gnu.org; 26 Nov 2022 10:15:47 +0000 Received: from localhost ([127.0.0.1]:37885 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oysDq-00046L-SN for submit@debbugs.gnu.org; Sat, 26 Nov 2022 05:15:47 -0500 Received: from mout02.posteo.de ([185.67.36.66]:52793) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oysDo-000467-9t for 59603@debbugs.gnu.org; Sat, 26 Nov 2022 05:15:45 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 40566240101 for <59603@debbugs.gnu.org>; Sat, 26 Nov 2022 11:15:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1669457738; bh=KOMVQgqjIop7+kxQTXBocrPiHlWHFDXQAfppsQ2gxa4=; h=From:To:Cc:Subject:Date:From; b=BNwJCdC/tB+iPG12PKJp+d7BbKdqEwmQmFaEpN+jFTkrVR1JX96QKsMrDrw+Ov+9n yxZsazCurobQ55nRLseDzpGT2r4xm3tIqfRkzfQTpSG+XZQpASwz3BNDF8FPKIa4RU p8oDULALtHUXfmoDxoYUS/FiD3tIHIekuezhYpPtEOBG1foX8W9ldtk2YXbtTRZkNN j9ooEXr0TnWBxAd2xWI0nNNBiNQEB9EzTGZZRy/8rt7Jfz0B1Spf4Z0cxcx1ymRtxj PhSryRAmJZ9kPrhLYY0yMJ/xENegGGF8fFbV5nM21DHGKKBCGN75sTS8g3X8zDv2Xv uk8x2GiXPaaDQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NK70S1C1Qz6tmb; Sat, 26 Nov 2022 11:15:33 +0100 (CET) From: Ihor Radchenko To: Eli Zaretskii Subject: Re: bug#59603: 28.1.90; `ucs-normalize-string' fails to work In-Reply-To: <83edtqt49f.fsf@gnu.org> References: <87wn7ijef0.fsf@localhost> <83mt8et7na.fsf@gnu.org> <87sfi6jdd5.fsf@localhost> <83h6ymt6fs.fsf@gnu.org> <87pmdajbtg.fsf@localhost> <83edtqt49f.fsf@gnu.org> Date: Sat, 26 Nov 2022 10:16:12 +0000 Message-ID: <87edtqja1f.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59603 Cc: 59603@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: >> I do see that uppercase symbol names may not always refer to the >> arguments, but don't `str' fit better into the conventions? It is the >> symbol to be used in the macro, after all. >> Or do I miss something? > > How else do you suggest to indicate in the doc string that the macro > operates on a variable named 'str'? Using `str' is much more confusing, > IMO. We clearly disagree here. `str' would be more clear for me. Or explicitly saying that `str' symbol value is used. In any case, this is a very minor concern. I mostly tried to find if I am missing something in my understanding of documentation conventions. I have no strong feelings about this particular change. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at From unknown Sun Jun 22 07:49:49 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 24 Dec 2022 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator