From unknown Sat Jun 21 03:25:43 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#59602 <59602@debbugs.gnu.org> To: bug#59602 <59602@debbugs.gnu.org> Subject: Status: 29.0.50; csharp-mode should either be a package, or compat code could be removed Reply-To: bug#59602 <59602@debbugs.gnu.org> Date: Sat, 21 Jun 2025 10:25:43 +0000 retitle 59602 29.0.50; csharp-mode should either be a package, or compat co= de could be removed reassign 59602 emacs submitter 59602 Stefan Kangas severity 59602 wishlist tag 59602 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 26 03:14:13 2022 Received: (at submit) by debbugs.gnu.org; 26 Nov 2022 08:14:14 +0000 Received: from localhost ([127.0.0.1]:37733 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyqKD-00014y-Nm for submit@debbugs.gnu.org; Sat, 26 Nov 2022 03:14:13 -0500 Received: from lists.gnu.org ([209.51.188.17]:34868) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyqK8-00014o-PI for submit@debbugs.gnu.org; Sat, 26 Nov 2022 03:14:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyqK8-0005UW-B1 for bug-gnu-emacs@gnu.org; Sat, 26 Nov 2022 03:14:08 -0500 Received: from mail-oa1-x2a.google.com ([2001:4860:4864:20::2a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oyqK5-0003Rf-OO for bug-gnu-emacs@gnu.org; Sat, 26 Nov 2022 03:14:07 -0500 Received: by mail-oa1-x2a.google.com with SMTP id 586e51a60fabf-12c8312131fso7594832fac.4 for ; Sat, 26 Nov 2022 00:14:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=2/MdRU7DINvZX/ga0oj3RixYHrrzDCNje1sVQj5MFgo=; b=N569IooEmbgqQhklAeVb5LST+075d/KsIP3adeD7qxxdjjFCU4Krux7t2a3vKQHUG7 cyZ2f7sjdLTpoV0PcpP9Y9u9HPYOyJOsqpbCV5bFYCUFHY6V7SBG73wdijCrO/Yvm/zM Q9EcImQecgFrUdNlmyx+GsBHG0u7pnVMKL6fbWLU5LKXRSOc5bI0GHf+ykULBVq/G6+t w8Hi445l0gDUjCJrUKlnSw75Goon+vlI80Eo25rF4rzsH+kVkhukDmOfwn4AB//83GQD XB2gO/gCEVveqKz48/lYLPUehuadt0kQ/ev/LOiiIUoSKgrSpbYsnqEuMhvnqNlBjfSK cOfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=2/MdRU7DINvZX/ga0oj3RixYHrrzDCNje1sVQj5MFgo=; b=NoemABd0KPmKw992PHMovASiXhISW8NlF06pqRKRXiLtZDEaFTVTCBVIxrz5HNMVsO 7zXdl+vAeWbQdGl+ajr+C3M1KhpJJq0qS4RjXsGbLbZoFSqtGEspLs+eKpIJIpbkLbaz tdxDJbpSv/1b2EkoU9rq4akt/YofqKkvRpFt+baV5BBCTa7w+MNUX3iHmGZG5mBthUTQ d4SNZbRBp9vFejx8/KRKHMVzgxPU2ET6G9xl5jrQd+YR7S+Fb7NlQJLQZbDycKHfbER/ 8grIQXPaXToIjiR27hWzrAx3FXO1bZJig66gfBpgO5WNAu2rOxq34zYqqcQabdndq1uU MjIQ== X-Gm-Message-State: ANoB5pmUbYdCIL6iKrFog4CCv4XMlGAEav+wBrwi4Ryv7PZeunYdd9YZ IBoxFabWOxyeOL1YN4hJNlaotzHlrNdwpcWIUlIrRBk4joA= X-Google-Smtp-Source: AA0mqf4Tzn48aZheAfZwGWvYRPp0MuOJ/AMU/amt+qL5NOttFQcVsn7cbBWIZtkwSybT7XrBwdev+IM9xuE49Mdj1aw= X-Received: by 2002:a05:6870:4995:b0:143:522a:ebcc with SMTP id ho21-20020a056870499500b00143522aebccmr6629165oab.199.1669450444541; Sat, 26 Nov 2022 00:14:04 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 26 Nov 2022 00:14:04 -0800 From: Stefan Kangas X-Debbugs-CC: =?UTF-8?Q?Theodor_Thornhill_=3Ctheo=40thornhill=2Eno=3E=2C_Jostein_?= =?UTF-8?Q?Kj=C3=B8nigsen_=3Cjostein=40kjonigsen=2Enet=3E?= X-Hashcash: 1:20:221126:bug-gnu-emacs@gnu.org::8wNdqVOV/YBXCTCb:05zB MIME-Version: 1.0 Date: Sat, 26 Nov 2022 00:14:04 -0800 Message-ID: Subject: 29.0.50; csharp-mode should either be a package, or compat code could be removed To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2001:4860:4864:20::2a; envelope-from=stefankangas@gmail.com; helo=mail-oa1-x2a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Severity: wishlist Is csharp-mode.el intended to be a :core package or should people just use the version that comes with Emacs? If the former, I guess some Version and Package-Requires headers are needed. If the latter, the compat code starting on line 512 could probably be removed. From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 26 14:13:09 2022 Received: (at 59602) by debbugs.gnu.org; 26 Nov 2022 19:13:09 +0000 Received: from localhost ([127.0.0.1]:41446 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oz0bs-0003tl-PH for submit@debbugs.gnu.org; Sat, 26 Nov 2022 14:13:09 -0500 Received: from out-118.mta0.migadu.com ([91.218.175.118]:59162) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oz0bq-0003tf-Qq for 59602@debbugs.gnu.org; Sat, 26 Nov 2022 14:13:08 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1669489985; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bCYId/mdfIiNLX6kLHWokz7j4kSELIKYdRtt8JVTBnM=; b=wMx8W7Y2zZFeHbFhvyblxnwlTzuZAapOlCGi7USOQRkrw2MJsLdEsir/xwFP3fURg7h+Gv 77yfiEvJEno9K+XfJENU52eY2srOU/9sQFwpPgKgEZ9ZMJMVVjbwSeJd8eiT3wJrLtRxU/ NZVfX+/BAnmFXuVXEg4Hdb8Zx+z0qwto2aED1YG1e5zSdwlhX2fZqhSm05TbZSKlArftFM NJ4mTyrsoMrcNYODhAO9w/+JVePXs/1QvwaMNen4E+zciz8+8+U5017pRumF2umcFPL2h+ +VMiTN7AOCkVCXDX/B7tfO24qNrPG5xbXTXqxiLinvt2ffBZXBtNQhCkXRfAEA== From: Theodor Thornhill To: Stefan Kangas , 59602@debbugs.gnu.org Subject: Re: bug#59602: 29.0.50; csharp-mode should either be a package, or compat code could be removed In-Reply-To: References: Date: Sat, 26 Nov 2022 20:12:58 +0100 Message-ID: <87o7st4jid.fsf@thornhill.no> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Migadu-Flow: FLOW_OUT X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59602 Cc: Jostein =?utf-8?Q?Kj=C3=B8nigsen?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Stefan Kangas writes: > Severity: wishlist > > Is csharp-mode.el intended to be a :core package or should people just > use the version that comes with Emacs? > > If the former, I guess some Version and Package-Requires headers > are needed. > > If the latter, the compat code starting on line 512 could probably be > removed. I agree. The compat code should be removed. I don't thing we have much to gain by maintaining this as a :core package, so here's a patch doing what you suggest. I don't think that code should be part of Emacs at all, if not absolutely necessary :-) Theo --=-=-= Content-Type: text/x-diff; charset=utf-8 Content-Disposition: attachment; filename=0001-Remove-compatibility-code-in-csharp-mode.patch Content-Transfer-Encoding: quoted-printable >From 44189f78889e22f3e9321d8b089ed452bfa3c87a Mon Sep 17 00:00:00 2001 From: Theodor Thornhill Date: Sat, 26 Nov 2022 20:10:58 +0100 Subject: [PATCH] Remove compatibility code in csharp-mode * lisp/progmodes/csharp-mode.el (c-basic-matchers-before): Remove invalid string check for Emacs 27. (version=3D): Remove compatibility hack for string handling in CC Mode in Emacs 27.1. --- lisp/progmodes/csharp-mode.el | 75 +---------------------------------- 1 file changed, 2 insertions(+), 73 deletions(-) diff --git a/lisp/progmodes/csharp-mode.el b/lisp/progmodes/csharp-mode.el index a544a4b5cb..354aacf9bc 100644 --- a/lisp/progmodes/csharp-mode.el +++ b/lisp/progmodes/csharp-mode.el @@ -319,12 +319,7 @@ csharp--color-forwards (c-lang-defconst c-basic-matchers-before csharp `( ;; Warning face on unclosed strings - ,@(if (version< emacs-version "27.0") - ;; Taken from 26.1 branch - `(,(c-make-font-lock-search-function - (concat ".\\(" c-string-limit-regexp "\\)") - '((c-font-lock-invalid-string)))) - `(("\\s|" 0 font-lock-warning-face t nil))) + ("\\s|" 0 font-lock-warning-face t nil) =20 ;; Invalid single quotes c-font-lock-invalid-single-quotes @@ -346,7 +341,6 @@ c-basic-matchers-before nil (goto-char (match-end 0))))) =20 - ;; Negation character (eval . (list "\\(!\\)[^=3D]" 1 c-negation-char-face-name)) =20 @@ -375,8 +369,7 @@ c-basic-matchers-before (eval . (list (concat "\\ *( *" csharp--regex-type-name-matcher " *) *") - 1 font-lock-type-face)) - )) + 1 font-lock-type-face)))) =20 (c-lang-defconst c-basic-matchers-after csharp (append @@ -505,70 +498,6 @@ csharp-guess-basic-syntax =20 ;;; End of new syntax constructs =20 - - -;;; Fix for strings on version 27.1 - -(when (version=3D emacs-version "27.1") - ;; See: - ;; https://github.com/emacs-csharp/csharp-mode/issues/175 - ;; https://github.com/emacs-csharp/csharp-mode/issues/151 - ;; for the full story. - (defun c-pps-to-string-delim (end) - (let* ((start (point)) - (no-st-s `(0 nil nil ?\" nil nil 0 nil ,start nil nil)) - (st-s `(0 nil nil t nil nil 0 nil ,start nil nil)) - no-st-pos st-pos - ) - (parse-partial-sexp start end nil nil no-st-s 'syntax-table) - (setq no-st-pos (point)) - (goto-char start) - (while (progn - (parse-partial-sexp (point) end nil nil st-s 'syntax-table) - (unless (bobp) - (c-clear-syn-tab (1- (point)))) - (setq st-pos (point)) - (and (< (point) end) - (not (eq (char-before) ?\"))))) - (goto-char (min no-st-pos st-pos)) - nil)) - - (defun c-multiline-string-check-final-quote () - (let (pos-ll pos-lt) - (save-excursion - (goto-char (point-max)) - (skip-chars-backward "^\"") - (while - (and - (not (bobp)) - (cond - ((progn - (setq pos-ll (c-literal-limits) - pos-lt (c-literal-type pos-ll)) - (memq pos-lt '(c c++))) - ;; In a comment. - (goto-char (car pos-ll))) - ((save-excursion - (backward-char) ; over " - (c-is-escaped (point))) - ;; At an escaped string. - (backward-char) - t) - (t - ;; At a significant " - (c-clear-syn-tab (1- (point))) - (setq pos-ll (c-literal-limits) - pos-lt (c-literal-type pos-ll)) - nil))) - (skip-chars-backward "^\"")) - (cond - ((bobp)) - ((eq pos-lt 'string) - (c-put-syn-tab (1- (point)) '(15))) - (t nil)))))) - -;;; End of fix for strings on version 27.1 - ;; When invoked by MSBuild, csc=E2=80=99s errors look like this: ;; subfolder\file.cs(6,18): error CS1006: Name of constructor must ;; match name of class [c:\Users\user\project.csproj] --=20 2.34.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 26 14:25:55 2022 Received: (at control) by debbugs.gnu.org; 26 Nov 2022 19:25:55 +0000 Received: from localhost ([127.0.0.1]:41461 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oz0oE-00041H-Vl for submit@debbugs.gnu.org; Sat, 26 Nov 2022 14:25:55 -0500 Received: from mail-oi1-f175.google.com ([209.85.167.175]:37456) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oz0oC-000418-Oy for control@debbugs.gnu.org; Sat, 26 Nov 2022 14:25:53 -0500 Received: by mail-oi1-f175.google.com with SMTP id v82so7680615oib.4 for ; Sat, 26 Nov 2022 11:25:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=DQ2jVOLtEtmj0I89os8ly1TipkFRmsbRNmY8EFfpcDY=; b=JvRYR9osfamIIlpKQqFMdGA1g+zFOlrXhTPvLk+IHkUilpx+AiYN7Mt5vQyAmpyF9z 2qABMmEPL03lgh5rRTfbW+HJX/U2c04IehY1PTACvH+vZ8WZcWMVislxvg6CzOA8Y8tW 2NOlAvnaGV0hWWHHuc++mVvYqooPt4HMydY1CSuJIthrpIxHFS3vX79NVpeqiGyoFFrp odbi4eepzAn4NvESISI4caj3cS//zQajX8dzg73dzEsppFYflGfkLPebeaV51pH5LJS6 BjYmjCXQvp6OVUG4esK1YeCL5AH8YVdHiHaJscf8gV7LyZjLSISnFX8rOUB4RP0itA1n FFSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=DQ2jVOLtEtmj0I89os8ly1TipkFRmsbRNmY8EFfpcDY=; b=DKw+QMGo+UAdHSahM+ff12aOy5P8qb5fcv64hKxXfnW7aY0bn4JWKmA65vUBOmztVn lGjuBVZB/cynwt0/zhjkKZvyT6BVNlBqgwA1o3wegyppj8Iziqvmv76bG6TCTacKDm5x tnUCY1uoxY4yVt9n4QCNu7HJGxvJD0KMVHn3IrT1g7ZjAg+I0Kf6IbC1UY4N3byjOtMy B5MLZUSylAHUypqdDK2nDrxBEGUlM3N5pIpo2T4ZDTrkHjh8geg7+oxp3J7xavjRJPQN LLHV5G5E/Vwhcr3dRKH5Kei0GxVjjNpetBUDCvyC8UH/V2b6msP7V7FbDVoLr9lUh0/U 55rQ== X-Gm-Message-State: ANoB5pnxK1emSe4iZ1P+bZRO9TYMeNnxjrb6GbfeHh928jbNJALDvdjh s1llgTKb9GG9PpbUF/3ydwvZlFup6N808UZvEB/ZaK4xNGg= X-Google-Smtp-Source: AA0mqf4HVeWg0Wetue/2VJTXoM06g7k+OTIKJG2IqalCPWfDftPSEexWc1XweCyfN1GGJBe+DzhMpixcDhrKdGEMYOE= X-Received: by 2002:a05:6808:2229:b0:35b:2b17:af81 with SMTP id bd41-20020a056808222900b0035b2b17af81mr12118374oib.199.1669490747283; Sat, 26 Nov 2022 11:25:47 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 26 Nov 2022 11:25:46 -0800 From: Stefan Kangas X-Hashcash: 1:20:221126:control@debbugs.gnu.org::UnJQkR0bh7pfhi+9:10Wt MIME-Version: 1.0 Date: Sat, 26 Nov 2022 11:25:46 -0800 Message-ID: Subject: To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 59602 + patch thanks Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.167.175 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.167.175 listed in wl.mailspike.net] 2.0 BLANK_SUBJECT Subject is present but empty 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) tags 59602 + patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 26 15:58:48 2022 Received: (at 59602) by debbugs.gnu.org; 26 Nov 2022 20:58:48 +0000 Received: from localhost ([127.0.0.1]:41570 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oz2G8-0007B5-9M for submit@debbugs.gnu.org; Sat, 26 Nov 2022 15:58:48 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:54121) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oz2G5-0007Az-Sz for 59602@debbugs.gnu.org; Sat, 26 Nov 2022 15:58:46 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id CA9815C00A0; Sat, 26 Nov 2022 15:58:40 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sat, 26 Nov 2022 15:58:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:reply-to:sender:subject:subject:to:to; s=fm3; t= 1669496320; x=1669582720; bh=GZJqYiPovoc/MgODPwtPVgKSWMKGcbr776m ed+uEtZo=; b=yK/6BpGQ1Mj5YWQAaMX6/xRxqX79ub6lhCAHXu0eyWc/OKacngu W5EsBTPnGfajzYK6hDWprKrtwMubM85EhAMQSoIVDDtJdhebbfwJJkBJby/+/Wh5 XAJYINJgzkFMft4BhmY10yUZ+G2VMtEupYUkHk8iVPs0t6GUyo+KiDIntU6mTyiG WDErAa/QzrvAXn5I2vYk4AiEPyUfmujjItcL6uTrdjYe1qlJ+gCxZwlG1QrkGlRY 84gN7YRv7m32xh1WGyeXouWymmB9E4XKu9sByrEdqpr/njy5SdSYUxfwKPCTIVZ6 fTQxLzR3ypTiu6x/iej1g6nkqFRLc6R0qog== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1669496320; x=1669582720; bh=GZJqYiPovoc/M gODPwtPVgKSWMKGcbr776med+uEtZo=; b=a/7GbQ8j4Jn+BBCJYghGs3AsF38Eg j8JpcFSYx0NNjh41cOoG13ijHZO6diiI4GB68BwC8TY6LdDt/mPwfnaxPkVfnkaT MPrnmQDQXLRopSmyvpJkEqyo+zXiE5klN82yTr4gzW3fpvNQDVN8oX4K8Cyk8eeh zgKEQ9Y7pTb7zqnk1RUD3P8kcc9wF3SMCcRaN3vahZUC2EojYMpNQURxn4WL3xhI gkjIf9k9mZP04FFw6JUtN7oTL4vAwCNb6oG7sVyd1R/7jnhXACmcTO6HyHoSVgKH oACxx0bhYfFC3JROaX+sfq8ZycbzsEpH5rLuebp7HkpKT7UGM2QXWknPw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrieejgddugeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurheptgfkffggfghruffvfhfhjgesrgdtreertdefjeenucfhrhhomheplfhoshht vghinhcumfhjpphnihhgshgvnhcuoehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhnih hgshgvnhdrnhgvtheqnecuggftrfgrthhtvghrnhepvdefuefhhfdvgfdtheeijedvheel jeeuleejhefhtdfhteffveduudfgheegjeelnecuffhomhgrihhnpehkjhhnihhgshgvnh drnhhonecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhep jhhoshhtvghinhesshgvtghurhgvrdhkjhhonhhighhsvghnrdhnvght X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 26 Nov 2022 15:58:39 -0500 (EST) Content-Type: multipart/alternative; boundary="------------cr0BD8eWqrFqec04vAKHjIC4" Message-ID: <495b9dec-013f-5248-8a57-5539f16575d7@secure.kjonigsen.net> Date: Sat, 26 Nov 2022 21:58:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: bug#59602: 29.0.50; csharp-mode should either be a package, or compat code could be removed Content-Language: nb-NO, en-GB To: Theodor Thornhill , Stefan Kangas , 59602@debbugs.gnu.org, Eli Zaretskii References: <87o7st4jid.fsf@thornhill.no> From: =?UTF-8?Q?Jostein_Kj=c3=b8nigsen?= In-Reply-To: <87o7st4jid.fsf@thornhill.no> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59602 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: jostein@kjonigsen.net Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is a multi-part message in MIME format. --------------cr0BD8eWqrFqec04vAKHjIC4 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit This may be a bit "on the side", but if me and Theodor are going to be maintaining csharp-mode in Emacs core, we currently face the slight "challenge" of not actually having write/push-access to the Emacs git-repo at savannah. That means that at top of our ability, we will be able to email in patches (like Theodor did now!) and hope for someone to review and/or merge them. While don't expect that providing for unlimited git-access out of the blue probably is how new major-modes are taken in, I'm also not sure what the "normal" procedure is in cases like this. Are there someone particular we are recommended to CC in our emails to make sure the patches get picked up efficiently? And what if it's not a registered "bug" yet, but just an improvement? Should we send it to emacs-devel instead? In short: Do you guys have any "onboarding guide" we can follow to make sure everyone is happy, and our patches get reviewed and applied efficiently? :) Any guidance appreciated! -- Kind regards *Jostein Kjønigsen* jostein@kjonigsen.net 🍵 jostein@gmail.com https://jostein.kjønigsen.no On 26.11.2022 20:12, Theodor Thornhill wrote: > Stefan Kangas writes: > >> Severity: wishlist >> >> Is csharp-mode.el intended to be a :core package or should people just >> use the version that comes with Emacs? >> >> If the former, I guess some Version and Package-Requires headers >> are needed. >> >> If the latter, the compat code starting on line 512 could probably be >> removed. > I agree. The compat code should be removed. I don't thing we have much > to gain by maintaining this as a :core package, so here's a patch doing > what you suggest. I don't think that code should be part of Emacs at > all, if not absolutely necessary :-) > > Theo > --------------cr0BD8eWqrFqec04vAKHjIC4 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

This may be a bit "on the side", but if me and Theodor are going to be maintaining csharp-mode in Emacs core, we currently face the slight "challenge" of not actually having write/push-access to the Emacs git-repo at savannah.

That means that at top of our ability, we will be able to email in patches (like Theodor did now!) and hope for someone to review and/or merge them.

While don't expect that providing for unlimited git-access out of the blue probably is how new major-modes are taken in, I'm also not sure what the "normal" procedure is in cases like this.

Are there someone particular we are recommended to CC in our emails to make sure the patches get picked up efficiently? And what if it's not a registered "bug" yet, but just an improvement? Should we send it to emacs-devel instead?

In short: Do you guys have any "onboarding guide" we can follow to make sure everyone is happy, and our patches get reviewed and applied efficiently? :)

Any guidance appreciated!

--
Kind regards
Jostein Kjønigsen

jostein@kjonigsen.net 🍵 jostein@gmail.com
https://jostein.kjønigsen.no
On 26.11.2022 20:12, Theodor Thornhill wrote:
Stefan Kangas <stefankangas@gmail.com> writes:


Severity: wishlist

Is csharp-mode.el intended to be a :core package or should people just
use the version that comes with Emacs?

If the former, I guess some Version and Package-Requires headers
are needed.

If the latter, the compat code starting on line 512 could probably be
removed.

I agree.  The compat code should be removed.  I don't thing we have much
to gain by maintaining this as a :core package, so here's a patch doing
what you suggest.  I don't think that code should be part of Emacs at
all, if not absolutely necessary :-)

Theo
--------------cr0BD8eWqrFqec04vAKHjIC4-- From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 27 01:03:51 2022 Received: (at 59602) by debbugs.gnu.org; 27 Nov 2022 06:03:51 +0000 Received: from localhost ([127.0.0.1]:41896 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozAla-00040V-TG for submit@debbugs.gnu.org; Sun, 27 Nov 2022 01:03:51 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47658) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozAlZ-00040P-A3 for 59602@debbugs.gnu.org; Sun, 27 Nov 2022 01:03:49 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozAlS-00031f-T7; Sun, 27 Nov 2022 01:03:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=BI/Jwn+9IB9jvIPW/mbBPwHjh4vG27jqju8fbwbHqrs=; b=o95mflisDXHeT2rDd5sP h7Bv31HNQ+0qzHMGAeEA8lHK3tv1d1Sa1gjXm+S1sjgt/mCTbWvGjv/HzBBQgjEGgljHJPggBPpDW 63+Tzm8o6Q3tOLpS+FSTKOzHTVYQUQ+3i0GjZM+Qb+hdbQ/tQGDHmqMxAftACnWTQBPHf8Pbw/YJE jvQH0PyDmKALU+GA7P1AcQPi+MwSkUnKnrYUQLRN1bRytY/TOltU/7DdaPx3oEvRTGyTBCzXjDbwc 3QPN61oAofkt8mrls1q3fKNJfCTyUu1ApRgWHcwCigggs3mceklO5MHblpEh57aoZLAC/BOAI2j4O Ic7kxhy9Y2Todw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozAlR-0001zH-Hx; Sun, 27 Nov 2022 01:03:41 -0500 Date: Sun, 27 Nov 2022 08:04:07 +0200 Message-Id: <83pmd9q6g8.fsf@gnu.org> From: Eli Zaretskii To: jostein@kjonigsen.net In-Reply-To: <495b9dec-013f-5248-8a57-5539f16575d7@secure.kjonigsen.net> (message from Jostein =?utf-8?Q?Kj=C3=B8nigsen?= on Sat, 26 Nov 2022 21:58:35 +0100) Subject: Re: bug#59602: 29.0.50; csharp-mode should either be a package, or compat code could be removed References: <87o7st4jid.fsf@thornhill.no> <495b9dec-013f-5248-8a57-5539f16575d7@secure.kjonigsen.net> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59602 Cc: 59602@debbugs.gnu.org, theo@thornhill.no, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 26 Nov 2022 21:58:35 +0100 > From: Jostein Kjønigsen > > While don't expect that providing for unlimited git-access out of the blue probably is how new major-modes > are taken in, I'm also not sure what the "normal" procedure is in cases like this. The "normal" procedure is to keep posting patches for review until you feel you've been doing that long enough, and managed to get to the state where your patches get only minor review comments, especially about coding and documentation conventions. Then request write access. > Are there someone particular we are recommended to CC in our emails to make sure the patches get > picked up efficiently? And what if it's not a registered "bug" yet, but just an improvement? Should we send it > to emacs-devel instead? It is always best to use report-emacs-bug for sending patches, even if it isn't a bug. debbugs is our issue tracker, not just bug tracker. emacs-devel is for discussing ideas and asking questions (you can also post diffs to better explain what you mean or if the question is about a particular code). TIA From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 27 04:38:54 2022 Received: (at 59602-done) by debbugs.gnu.org; 27 Nov 2022 09:38:54 +0000 Received: from localhost ([127.0.0.1]:42093 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozE7h-000087-RU for submit@debbugs.gnu.org; Sun, 27 Nov 2022 04:38:54 -0500 Received: from mail-oi1-f181.google.com ([209.85.167.181]:36838) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozE7e-00007o-8U for 59602-done@debbugs.gnu.org; Sun, 27 Nov 2022 04:38:51 -0500 Received: by mail-oi1-f181.google.com with SMTP id s206so8768124oie.3 for <59602-done@debbugs.gnu.org>; Sun, 27 Nov 2022 01:38:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=z7KSn3k1A+8UjrSeMHsMA2kJ/uIVnnuEKgXQ5YVMg04=; b=gmPv7PEAiE0pZqP82f4gTBil9hj4zOTLBo+2Wr01GSzvJdM/9GFsqcM3Lzt0zjeF2q 6OQrSN2fV7OsYAqIYmpA1YRNEI993BTmpgVN6A5liN1GdCvcJ1GQmIBNiQseZuJs9DSw CqriNTgwTMQU69wyvKEteuSz9Y+zouZ8dC5KtJlTdCziGtmPkk/8hrAJHEc7gi/76kMh +Ac4qVUEwRO9sOyWK0ckGU4xBGHPo6fEVQndPobqOSHqpSot6kA+Or3lpSXXp2rIpyEP CsDyfkZPQsiUi/pbwTHmoXmIAX+mCJekbWth69ucXbcjefVgBUh9K85mCOvKVEUYbsC2 t/Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=z7KSn3k1A+8UjrSeMHsMA2kJ/uIVnnuEKgXQ5YVMg04=; b=h4KQCrI4tLwCFsGAi32yto8t/JmXPz81rc1C7B64qg50qOb39AJTLCt+7NVJJ1Zf2x Z1EYhXwe1/kCFr+JDgHYJveAwCS23qmj9eN2QZNBO3jQPiWTGZWWV4p2P0NtXGLfNp0Z UMuwgoYS5o4J1ht3idr/CA2S0Dfg+c9QlOwZs82BWuVRnBVxvmg2FFK/5TmSOJEio110 qAY+RxzpLBFBvvI9E1FbvxknU4bhS3GGNN10hY1sJncQnqqFYpDgQDPjWpKPHFAx60EB Egczt34HYNRojS+VR75IxO8tKwIQcNO7QxDhvSlZVeYcTZoawpJJajZI4LHTJStOb8X1 MM8g== X-Gm-Message-State: ANoB5pnwKHwguh7Sc5PMVUo5r+s2erOiaD+n951Wd5Lq+/w7pgj3atAS 1Q2M4Nz9KXMnQ/3yHWU4Ro4U+tpNRAKt4fo5GQs= X-Google-Smtp-Source: AA0mqf55KyEmTzqVfBR3EHS61VV9GF99YsTPDc6TkM+ai3BRIUQWkatcbNDoUVaengIvBLO3dyNjPScu6RwabgYkV0g= X-Received: by 2002:a05:6808:2229:b0:35b:2b17:af81 with SMTP id bd41-20020a056808222900b0035b2b17af81mr12922372oib.199.1669541924538; Sun, 27 Nov 2022 01:38:44 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 27 Nov 2022 01:38:44 -0800 From: Stefan Kangas In-Reply-To: <87o7st4jid.fsf@thornhill.no> (Theodor Thornhill's message of "Sat, 26 Nov 2022 20:12:58 +0100") References: <87o7st4jid.fsf@thornhill.no> X-Hashcash: 1:20:221127:59602-done@debbugs.gnu.org::cbLptiBmDvFGGeyq:3m+v MIME-Version: 1.0 Date: Sun, 27 Nov 2022 01:38:44 -0800 Message-ID: Subject: Re: bug#59602: 29.0.50; csharp-mode should either be a package, or compat code could be removed To: Theodor Thornhill Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59602-done Cc: 59602-done@debbugs.gnu.org, =?UTF-8?Q?Jostein_Kj=C3=B8nigsen?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Theodor Thornhill writes: > I agree. The compat code should be removed. I don't thing we have much > to gain by maintaining this as a :core package, so here's a patch doing > what you suggest. I don't think that code should be part of Emacs at > all, if not absolutely necessary :-) Thanks, since both you and Jostein seems to agree, I've pushed this change (commit ea2f2f1e71). I'm therefore closing this bug report. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 27 04:59:12 2022 Received: (at 59602-done) by debbugs.gnu.org; 27 Nov 2022 09:59:12 +0000 Received: from localhost ([127.0.0.1]:42118 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozERM-0000KS-HC for submit@debbugs.gnu.org; Sun, 27 Nov 2022 04:59:12 -0500 Received: from out2.migadu.com ([188.165.223.204]:37512) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozERI-0000KM-2l for 59602-done@debbugs.gnu.org; Sun, 27 Nov 2022 04:59:10 -0500 Date: Sun, 27 Nov 2022 10:58:48 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1669543145; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vFWA9Rkyyao3ulmkRew/5EpW0aJeCUYRpaYf6Q4LlFU=; b=VDYN9oiew0+Rs2lK0sPAFZ/aF+K5pBQWqHbDb/v5XAYzszzR1xs9lEtre9C1PrNLM7O/1b uOfzal/NICyK9zKWyyRXOoGPmJla9zqAhdSFqNnMYQXqjVbDy1ZqXsaZ1Hf/Dl5URgx8Wn NMupd044CSquMRxmfjHLnLDo19ZtIe2Ng+Gg7NaD2yVe9txOKoMfz1+d8wDNnsM9IUvnn3 7KNor6LQUWRUqwzNXY1td7wEggmxHAPljAkvqPeNe6j5FJQVxPVIRr/TKhHybjAxxpPd3S /OBi6UTFne6fkyaP4Qjuf2VWLU2eWv5f3H4O2rLQJi3/bzwsNRtHobIJRjCT/g== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Theodor Thornhill To: Stefan Kangas Subject: =?US-ASCII?Q?Re=3A_bug=2359602=3A_29=2E0=2E50=3B_csharp-mode_should_eith?= =?US-ASCII?Q?er_be_a_package=2C_or_compat_code_could_be_removed?= In-Reply-To: References: <87o7st4jid.fsf@thornhill.no> Message-ID: <1FEA0C29-FAE5-4AFF-BE21-CAC41F553FC3@thornhill.no> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59602-done Cc: 59602-done@debbugs.gnu.org, =?ISO-8859-1?Q?Jostein_Kj=F8nigsen?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 27 November 2022 10:38:44 CET, Stefan Kangas = wrote: >Theodor Thornhill writes: > >> I agree=2E The compat code should be removed=2E I don't thing we have= much >> to gain by maintaining this as a :core package, so here's a patch doing >> what you suggest=2E I don't think that code should be part of Emacs at >> all, if not absolutely necessary :-) > >Thanks, since both you and Jostein seems to agree, I've pushed this >change (commit ea2f2f1e71)=2E I'm therefore closing this bug report=2E Thanks, appreciate it :) Theo From unknown Sat Jun 21 03:25:43 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 25 Dec 2022 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator