GNU bug report logs - #59581
29.0.50; [PATCH] Add completions details to Bookmarks

Previous Next

To reply to this bug, email your comments to 59581 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gabriel <gabriel376 <at> hotmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; [PATCH] Add completions details to Bookmarks
Date: Fri, 25 Nov 2022 16:19:38 -0300

[Message part 1 (text/plain, inline)]

Severity: wishlist

Description:

Add completions details (see `completions-detailed') to Bookmarks.  It
affects all bookmark functions that make uses of
`bookmark-completing-read' (e.g.: `bookmark-jump', `bookmark-relocate',
`bookmark-insert-location', `bookmark-rename' etc).  See also [1].

[1] https://lists.gnu.org/archive/html/emacs-devel/2022-11/msg00995.html

[0001-Add-completions-details-to-Bookmarks.patch (text/x-diff, attachment)]

[Message part 3 (text/plain, inline)]

---
Gabriel

Message #8 received at 59581 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Gabriel <gabriel376 <at> hotmail.com>, Karl Fogel <kfogel <at> red-bean.com>
Cc: 59581 <at> debbugs.gnu.org
Subject: Re: bug#59581: 29.0.50; [PATCH] Add completions details to Bookmarks
Date: Thu, 01 Dec 2022 10:45:11 +0200

> From: Gabriel <gabriel376 <at> hotmail.com>
> Date: Fri, 25 Nov 2022 16:19:38 -0300
> 
> Description:
> 
> Add completions details (see `completions-detailed') to Bookmarks.  It
> affects all bookmark functions that make uses of
> `bookmark-completing-read' (e.g.: `bookmark-jump', `bookmark-relocate',
> `bookmark-insert-location', `bookmark-rename' etc).  See also [1].
> 
> [1] https://lists.gnu.org/archive/html/emacs-devel/2022-11/msg00995.html

Karl, any comments to the patch?

Message #11 received at 59581 <at> debbugs.gnu.org (full text, mbox):

From: Karl Fogel <kfogel <at> red-bean.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 59580 <at> debbugs.gnu.org, Gabriel <gabriel376 <at> hotmail.com>,
 59581 <at> debbugs.gnu.org
Subject: Re: bug#59580 and bug#59581
Date: Mon, 19 Dec 2022 15:00:26 -0600

I am just seeing tickets #59580 and #59581 now.  I will review the 
patches as soon as I can and reply back.  This won't be till the 
end of the week, however, as I am traveling before then and won't 
have much working time while on the road.

Thanks for the patches Gabriel, and thanks for the ping, Eli.

Best regards,
-Karl

Message #14 received at 59581 <at> debbugs.gnu.org (full text, mbox):

From: Karl Fogel <kfogel <at> red-bean.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Gabriel <gabriel376 <at> hotmail.com>, 59581 <at> debbugs.gnu.org
Subject: Re: bug#59581: 29.0.50; [PATCH] Add completions details to Bookmarks
Date: Mon, 18 Dec 2023 17:51:39 -0600

On 01 Dec 2022, Eli Zaretskii wrote:
>> From: Gabriel <gabriel376 <at> hotmail.com>
>> Date: Fri, 25 Nov 2022 16:19:38 -0300
>> 
>> Description:
>> 
>> Add completions details (see `completions-detailed') to 
>> Bookmarks.  It
>> affects all bookmark functions that make uses of
>> `bookmark-completing-read' (e.g.: `bookmark-jump', 
>> `bookmark-relocate',
>> `bookmark-insert-location', `bookmark-rename' etc).  See also 
>> [1].
>> 
>> [1] 
>> https://lists.gnu.org/archive/html/emacs-devel/2022-11/msg00995.html
>
>Karl, any comments to the patch?

I applied this patch, reloaded bookmark.el, and then tested `M-x 
bookmark-jump' in two ways:

1) With `completions-detailed' == nil (my default)

2) With `completions-detailed' == t

In case (1) I saw the expected default behavior.  My bookmarks 
completed normally by name, and just their names were offered 
during completion.

In case (2), though, things seemed broken.  The "*Completions*" 
buffer says "19 possible completions:" at the top (as expected), 
but the buffer is otherwise blank.  And when I hit SPC or TAB at 
the "Jump to bookmark:" prompt, I get "[Wrong type argument: 
stringp, nil]" in the minibuffer.  My "*Messages*" buffer fills 
with messages like this:

 Making completion list...
 #<subr F616e6f6e796d6f75732d6c616d626461_anonymous_lambda_56>: \
 Wrong type argument: stringp, nil

Similar behavior happens for all the functions that depend on 
`bookmark-completing-read'.

This is in Emacs 30.0.50 (built today from 'master', commit 
1d5d2f16c330e).

Gabriel, does the patch maybe need a bit of updating?  I assume it 
worked for in the version of Emacs you originally wrote it in 
(which would be from a littl over a year ago now -- sorry for the 
delay; I wish I'd been able to follow up to this sooner).

Best regards,
-Karl

Message #17 received at 59581 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Karl Fogel <kfogel <at> red-bean.com>
Cc: Gabriel <gabriel376 <at> hotmail.com>, Eli Zaretskii <eliz <at> gnu.org>,
 59581 <at> debbugs.gnu.org
Subject: Re: bug#59581: 29.0.50; [PATCH] Add completions details to Bookmarks
Date: Tue, 11 Feb 2025 19:11:09 -0800

Karl Fogel <kfogel <at> red-bean.com> writes:

> On 01 Dec 2022, Eli Zaretskii wrote:
>>> From: Gabriel <gabriel376 <at> hotmail.com>
>>> Date: Fri, 25 Nov 2022 16:19:38 -0300
>>> Description:
>>> Add completions details (see `completions-detailed') to Bookmarks.  It
>>> affects all bookmark functions that make uses of
>>> `bookmark-completing-read' (e.g.: `bookmark-jump', `bookmark-relocate',
>>> `bookmark-insert-location', `bookmark-rename' etc).  See also [1].
>>> [1] https://lists.gnu.org/archive/html/emacs-devel/2022-11/msg00995.html
>>
>>Karl, any comments to the patch?
>
> I applied this patch, reloaded bookmark.el, and then tested `M-x bookmark-jump'
> in two ways:
>
> 1) With `completions-detailed' == nil (my default)
>
> 2) With `completions-detailed' == t
>
> In case (1) I saw the expected default behavior.  My bookmarks completed
> normally by name, and just their names were offered during completion.
>
> In case (2), though, things seemed broken.  The "*Completions*" buffer says "19
> possible completions:" at the top (as expected), but the buffer is otherwise
> blank.  And when I hit SPC or TAB at the "Jump to bookmark:" prompt, I get
> "[Wrong type argument: stringp, nil]" in the minibuffer.  My "*Messages*" buffer
> fills with messages like this:
>
>  Making completion list...
>  #<subr F616e6f6e796d6f75732d6c616d626461_anonymous_lambda_56>: \
>  Wrong type argument: stringp, nil
>
> Similar behavior happens for all the functions that depend on
> `bookmark-completing-read'.
>
> This is in Emacs 30.0.50 (built today from 'master', commit 1d5d2f16c330e).
>
> Gabriel, does the patch maybe need a bit of updating?  I assume it worked for in
> the version of Emacs you originally wrote it in (which would be from a littl
> over a year ago now -- sorry for the delay; I wish I'd been able to follow up to
> this sooner).
>
> Best regards,
> -Karl

Ping.

Gabriel, could you please look into the questions asked by Karl above?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.