GNU bug report logs - #5958
Sort-8.4 bug

Previous Next

Full log

Message #39 received at 5958-done <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: Alan Curry <pacman-cu <at> kosh.dhis.org>
Cc: Santiago Rodriguez <srodri <at> fi.upm.es>, 5958-done <at> debbugs.gnu.org,
	Eric Blake <eblake <at> redhat.com>, Jim Meyering <jim <at> meyering.net>
Subject: Re: bug#5958: Sort-8.4 bug
Date: Tue, 20 Apr 2010 23:10:44 +0100

On 20/04/10 22:05, Alan Curry wrote:
>>
>> I've changed it around in the attached patch so that
>> we consistently use zero based limits throughout the code.
>> I'll push this later on tonight unless there are objections.
> 
> In the definition of struct keyfield, is the comment by the "eword" member
> still correct? Or was it ever?
> 
>   size_t eword;                 /* Zero-origin first word after field. */
> 
> A shared understanding of what exactly the field represents would reduce the
> chance of future mishaps.

Good point. I think it was correct initially but
became out of sync with the logic about 10 years ago:
http://git.savannah.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=d92f4ac8

I've clarified the comment in what I've just pushed:
http://git.savannah.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=8fc12909

cheers,
Pádraig.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.