GNU bug report logs - #5958
Sort-8.4 bug

Previous Next

Package: coreutils;

Reported by: srodri <at> datsi.fi.upm.es

Date: Fri, 16 Apr 2010 12:14:02 UTC

Severity: normal

Merged with 5991

Fixed in version 8.5

Done: Eric Blake <eblake <at> redhat.com>

Bug is archived. No further changes may be made.

Full log

Message #38 received at 5958 <at> debbugs.gnu.org (full text, mbox):

From: "Alan Curry" <pacman-cu <at> kosh.dhis.org>
To: P <at> draigBrady.com (Pádraig Brady)
Cc: Santiago Rodriguez <srodri <at> fi.upm.es>, 5958 <at> debbugs.gnu.org,
	Eric Blake <eblake <at> redhat.com>, Jim Meyering <jim <at> meyering.net>
Subject: Re: bug#5958: Sort-8.4 bug
Date: Tue, 20 Apr 2010 16:05:59 -0500 (GMT+5)

> 
> I've changed it around in the attached patch so that
> we consistently use zero based limits throughout the code.
> I'll push this later on tonight unless there are objections.

In the definition of struct keyfield, is the comment by the "eword" member
still correct? Or was it ever?

  size_t eword;                 /* Zero-origin first word after field. */

A shared understanding of what exactly the field represents would reduce the
chance of future mishaps.

-- 
Alan Curry
This bug report was last modified 15 years and 35 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.