GNU bug report logs - #59578
[PATCH] gnu: Add guile-fibers-latest.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 59578 in the body.
You can then email your comments to 59578 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add guile-fibers-latest.
Date: Fri, 25 Nov 2022 17:01:08 +0000

* gnu/packages/guile-xyz.scm (guile-fibers-latest): New variable.
---
 gnu/packages/guile-xyz.scm | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index b1620618eb..6505798f27 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -707,6 +707,25 @@ (define-public guile-fibers-1.1
     (properties '((upstream-name . "fibers")))
     (license license:lgpl3+)))
 
+(define-public guile-fibers-latest
+  (let ((commit "0fa712ecd85c65d7d11ce0c897f068fba4e6ef3f")
+        (revision "0"))
+    (package
+      (inherit guile-fibers-1.1)
+      (name "guile-fibers-latest")
+      (version (git-version (package-version guile-fibers-1.1)
+                            revision
+                            commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/wingo/fibers")
+                      (commit commit)))
+                (file-name (git-file-name "guile-fibers" version))
+                (sha256
+                 (base32
+                  "0vfq4dkdq2szi5f99ywm856vll397c1x42a55rpxya61rrws8s9r")))))))
+
 (define-public guile-fibers
   (package
     (inherit guile-fibers-1.1)
-- 
2.38.1

Message #8 received at 59578 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: Christopher Baines <mail <at> cbaines.net>, 59578 <at> debbugs.gnu.org
Subject: Re: [bug#59578] [PATCH] gnu: Add guile-fibers-latest.
Date: Fri, 25 Nov 2022 20:07:39 +0100

Hi Chris,

On Fri, 25 Nov 2022 at 17:01, Christopher Baines <mail <at> cbaines.net> wrote:
> * gnu/packages/guile-xyz.scm (guile-fibers-latest): New variable.

From my understanding, the convention seems ’-next’ and not ’-latest’.

--8<---------------cut here---------------start------------->8---
45 candidates:
./gnu/packages/freedesktop.scm:1210:(define-public wayland-protocols-next
./gnu/packages/bioconductor.scm:13526:(define-public r-cistopic-next

[...]

./gnu/packages/emacs-xyz.scm:25239:(define-public emacs-spaceline-next
--8<---------------cut here---------------end--------------->8---

Although, 6 packages are using ’-latest’. :-)

--8<---------------cut here---------------start------------->8---
6 candidates:
./gnu/packages/guile-xyz.scm:1359:(define-public guile-email-latest
./gnu/packages/bioinformatics.scm:4161:(define-public java-htsjdk-latest
./gnu/packages/tls.scm:333:(define-public gnutls-latest
./gnu/packages/guile.scm:391:(define-public guile-3.0-latest
./gnu/packages/perl.scm:5493:(define-public perl-inc-latest
./gnu/packages/ruby.scm:5378:(define-public ruby-latest-ruby
--8<---------------cut here---------------end--------------->8---

Well, since this appears in the name, it appears to me better to have
the same convention; for discover-ability, for instance.


Cheers,
simon

Message #11 received at 59578 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 59578 <at> debbugs.gnu.org
Subject: Re: bug#59578: [PATCH] gnu: Add guile-fibers-latest.
Date: Mon, 28 Nov 2022 22:06:59 +0100

Hi Christopher,

Christopher Baines <mail <at> cbaines.net> skribis:

> * gnu/packages/guile-xyz.scm (guile-fibers-latest): New variable.

I agree with zimoun that this should be “-next” but otherwise LGTM.

Thanks,
Ludo’.

Message #16 received at 59578-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 59578-done <at> debbugs.gnu.org
Subject: Re: bug#59578: [PATCH] gnu: Add guile-fibers-latest.
Date: Tue, 06 Dec 2022 11:30:25 +0000

[Message part 1 (text/plain, inline)]

Ludovic Courtès <ludo <at> gnu.org> writes:

> Christopher Baines <mail <at> cbaines.net> skribis:
>
>> * gnu/packages/guile-xyz.scm (guile-fibers-latest): New variable.
>
> I agree with zimoun that this should be “-next” but otherwise LGTM.

Thanks both for looking at this, I've changed -next to -latest and
pushed this to master as ef2fba6fe3d020adfc95481fbd6958a62892aa45.

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.