From unknown Sat Aug 16 20:58:02 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#59575 <59575@debbugs.gnu.org> To: bug#59575 <59575@debbugs.gnu.org> Subject: Status: 29.0.50; add-log-current-defun-header-regexp matches Windows drive letter Reply-To: bug#59575 <59575@debbugs.gnu.org> Date: Sun, 17 Aug 2025 03:58:02 +0000 retitle 59575 29.0.50; add-log-current-defun-header-regexp matches Windows = drive letter reassign 59575 emacs submitter 59575 Juanma Barranquero severity 59575 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 25 10:54:42 2022 Received: (at submit) by debbugs.gnu.org; 25 Nov 2022 15:54:42 +0000 Received: from localhost ([127.0.0.1]:36964 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyb2H-0005of-Mf for submit@debbugs.gnu.org; Fri, 25 Nov 2022 10:54:41 -0500 Received: from lists.gnu.org ([209.51.188.17]:53328) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyb2F-0005oX-56 for submit@debbugs.gnu.org; Fri, 25 Nov 2022 10:54:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyb2E-000648-Vr for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2022 10:54:38 -0500 Received: from mail-ej1-x631.google.com ([2a00:1450:4864:20::631]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oyb27-0003uv-AF for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2022 10:54:38 -0500 Received: by mail-ej1-x631.google.com with SMTP id f18so11244198ejz.5 for ; Fri, 25 Nov 2022 07:54:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=KoO/cd5El1AnbwFZGd6JMgyL1GEYUCLsL/qy0GbZx70=; b=YHlPJxet7ed3XDgik1BJTpOI9T6QP7gZYQtsEsVXuB53HhF+GgQCxjIAkqho7UvV3q UyIRlLkl7q+N9/3MZeonUWdVyGNR55zuldZh3Sbc95XdpQU1tOcV9TEF5rZWMZS8MB0T 3F22ncTZQLDEbjB1lquO6zlmh+c1KWKdpxr8HmaCT0asBzr0kQu7H8HZjN79S32FeWhC N/Q+/lRQJm+UfjJTZ5d8pUC4jGF09EgmSc8Cfi+ac3Bg9eqgWp32yKPopMGYYEWCzdFQ Zy4LueZHgGHjnHaVzxIeXcHWte5/3hu3ixMGRukcy/P3eHbHDTimWQppGj1AfDafpZP6 tTvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=KoO/cd5El1AnbwFZGd6JMgyL1GEYUCLsL/qy0GbZx70=; b=vUgiKxqDy1BzN+94skuVB0V9R+kDKM5bNRRbBqk846DVFrbdaT1HFleiy00XZ4IbH9 S134raEr/1xnkgNp3YizrYM4PQWSwyo/ctVrjmROOZMJLh0XLjH+GMvgX2NuQ7tnuLOI ewk/A2ryQVov1tVHGz9PWIbJvgva84c5qStzxioXqD3ZXnduRJ1juAOQ4VKt9x/CtUG6 QGmlmZHfbpjZi+AlHbIg3SgLZnVgec7HD6quDTaHSkS9gcg5lP34MF5aNroBkLlL1TG+ AEcah3+E+jnT3NigjWKJ/KOwf57JmQ3ybn1EVXEJ9y7IK+/qfw1LO6a+Q9p/meGjqR1x uPaQ== X-Gm-Message-State: ANoB5pk1O7bdBHmNTHiyYNs37K1Kcv2phdEBWfJA64QGFaOPeJeLoE0T jROu+TkzG5EVqlX5/fcPvdPmtzVyAAGftnUCCc5KRBBzPXs= X-Google-Smtp-Source: AA0mqf5TCjMVmyMCO4ynG0A0+AcDUl/IZE7x14ZpYlSd1RikFWo86TlsAcVGePkifAcH7wnXnxH/qcgmbZ26MXHMkJs= X-Received: by 2002:a17:906:2416:b0:7ad:4a55:d6f5 with SMTP id z22-20020a170906241600b007ad4a55d6f5mr33325382eja.220.1669391669080; Fri, 25 Nov 2022 07:54:29 -0800 (PST) MIME-Version: 1.0 From: Juanma Barranquero Date: Fri, 25 Nov 2022 16:53:51 +0100 Message-ID: Subject: 29.0.50; add-log-current-defun-header-regexp matches Windows drive letter To: Bug-Gnu-Emacs Content-Type: multipart/alternative; boundary="0000000000006d374f05ee4d8968" Received-SPF: pass client-ip=2a00:1450:4864:20::631; envelope-from=lekktu@gmail.com; helo=mail-ej1-x631.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --0000000000006d374f05ee4d8968 Content-Type: text/plain; charset="UTF-8" If you have an *xref* buffer with absolute Windows filenames, like ~/.emacs.d/init.el 93: server-name (replace-regexp-in-string "\\\\+" "\\" serv t t) 1102: (let ((s (when server-name 1104: (string-match (rx (+ (not (any ?\\))) line-end) server-name) 1105: (upcase (match-string 0 server-name)))))) d:/Devel/emacs/repo/trunk/lisp/erc/erc-backend.el 1820: (pcase-let ((`(,server-name ,server-version) 1823: (setq erc-server-announced-name server-name) 1827: 's004 ?s server-name ?v server-version and put the cursor in an absolute filename line (like the one d:/Devel/[etc] above), calling `add-log-current-defun' returns the drive letter "d", because it matches a-l-c-d-header-regexp. The effect is visible when you have which-function-mode enabled, because the function returns non-nil, so which-function does not resort to imenu, and you end with "d" in the mode-line. I suppose this should be fixed in xref.el, which apparently assumes that file name lines will be either relative or Unix-style (/path/file works correctly, it's just d:/path/file that fails) and the add-log heuristics will always fail. --0000000000006d374f05ee4d8968 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
If you have an *xref* buffer with absolute Windows filenames= , like

~/.emacs.d/init.el
=C2=A0 = 93: =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 server-name =C2=A0 =C2=A0(rep= lace-regexp-in-string "\\\\+" "\\" serv t t)
1102: = =C2=A0 (let ((s (when server-name
1104: =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0(string-match (rx (+ (not (any ?\\))) line-end) ser= ver-name)
1105: =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(= upcase (match-string 0 server-name))))))
d:/Devel/emacs/repo/trunk/lisp/= erc/erc-backend.el
1820: =C2=A0 (pcase-let ((`(,server-name ,server-vers= ion)
1823: =C2=A0 =C2=A0 (setq erc-server-announced-name server-name)1827: =C2=A0 =C2=A0 =C2=A0's004 ?s server-name ?v server-version

and put the cursor in an absolute filename line (li= ke the one d:/Devel/[etc] above), calling `add-log-current-defun' retur= ns the drive letter "d", because it matches a-l-c-d-header-regexp= .

The effect is visible when you have which-function-mode enabled, b= ecause the function returns non-nil, so which-function does not resort to i= menu, and you end with "d" in the mode-line.

I suppose thi= s should=C2=A0be fixed in xref.el, which apparently assumes that file name = lines will be either relative or Unix-style (/path/file works correctly, it= 's just d:/path/file that fails) and the add-log heuristics will always= fail.

--0000000000006d374f05ee4d8968-- From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 26 08:03:55 2022 Received: (at 59575) by debbugs.gnu.org; 26 Nov 2022 13:03:55 +0000 Received: from localhost ([127.0.0.1]:38149 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyuqZ-0006zz-0f for submit@debbugs.gnu.org; Sat, 26 Nov 2022 08:03:55 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58304) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyuqX-0006zo-G3 for 59575@debbugs.gnu.org; Sat, 26 Nov 2022 08:03:53 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyuqS-0007Xk-8r; Sat, 26 Nov 2022 08:03:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=P2gVeLUQQfJWniZf6ADv2DrB6fC+VcrqhbOLd4kwiiY=; b=L4nkn3hSvRwH0EvFTaQe WvBMdFtsC3Vd4T+UBdb4Ud+OzP6PcfwrKxdCfWSdYOHfmtX2Zvvhm2TVdYWmYk9aT+nyrE2FKc2Ev f8yjQMBnPwkXSWJsiY0zydl2DtVXCDtFznQajEvC71OO2ew3wR+v+jf2AZLC2CoS+3WBO7JRTJ0d1 TYaiy+/1AgpGjTOT2fEoAEsDGBIzzDJKlqc8RH84Gty5lhQAgRDWQX3jEVSn3YDH8Px7AvOxOfmQX Y/l6bqV4pWnRdmaLlW/FYl6kuYM2VceddeHO6NY/91kk867OBHc5ciLo+GcXALE+2aqbp9Kdh5fJz JIDhIyETJuqGlg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyuqC-0003JW-Df; Sat, 26 Nov 2022 08:03:39 -0500 Date: Sat, 26 Nov 2022 15:03:55 +0200 Message-Id: <83zgcdsw90.fsf@gnu.org> From: Eli Zaretskii To: Juanma Barranquero , Dmitry Gutov In-Reply-To: (message from Juanma Barranquero on Fri, 25 Nov 2022 16:53:51 +0100) Subject: Re: bug#59575: 29.0.50; add-log-current-defun-header-regexp matches Windows drive letter References: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59575 Cc: 59575@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juanma Barranquero > Date: Fri, 25 Nov 2022 16:53:51 +0100 > > If you have an *xref* buffer with absolute Windows filenames, like > > ~/.emacs.d/init.el > 93: server-name (replace-regexp-in-string "\\\\+" "\\" serv t t) > 1102: (let ((s (when server-name > 1104: (string-match (rx (+ (not (any ?\\))) line-end) server-name) > 1105: (upcase (match-string 0 server-name)))))) > d:/Devel/emacs/repo/trunk/lisp/erc/erc-backend.el > 1820: (pcase-let ((`(,server-name ,server-version) > 1823: (setq erc-server-announced-name server-name) > 1827: 's004 ?s server-name ?v server-version > > and put the cursor in an absolute filename line (like the one d:/Devel/[etc] above), calling > `add-log-current-defun' returns the drive letter "d", because it matches a-l-c-d-header-regexp. > > The effect is visible when you have which-function-mode enabled, because the function returns non-nil, so > which-function does not resort to imenu, and you end with "d" in the mode-line. > > I suppose this should be fixed in xref.el, which apparently assumes that file name lines will be either relative > or Unix-style (/path/file works correctly, it's just d:/path/file that fails) and the add-log heuristics will always > fail. xref.el doesn't know anything about add-log, and AFAICT doesn't customize it in any way, shape, or form. So I think this should be fixed in add-log.el. Its regexp is too naïve, and should be beefed-up not to fail in this way. For example, is it really reasonable to accept "defuns" whose name is a single letter? Or if it's impossible to do that in the regexp, then we should reject such "matches" in add-log-current-defun instead. It is also possible to have xref.el define its customized add-log-current-defun-function, but that sounds like overkill to me. Dmitry, WDYT? From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 26 08:18:29 2022 Received: (at 59575) by debbugs.gnu.org; 26 Nov 2022 13:18:29 +0000 Received: from localhost ([127.0.0.1]:38163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyv4f-0001B2-0A for submit@debbugs.gnu.org; Sat, 26 Nov 2022 08:18:29 -0500 Received: from mail-ed1-f48.google.com ([209.85.208.48]:43759) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyv4c-0001Am-0K for 59575@debbugs.gnu.org; Sat, 26 Nov 2022 08:18:27 -0500 Received: by mail-ed1-f48.google.com with SMTP id r26so7595909edc.10 for <59575@debbugs.gnu.org>; Sat, 26 Nov 2022 05:18:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=2//TKXoNK4d6u3CFWTplgrJppYdlWlZBNFdPJkXv+ek=; b=OfOXgH1m44QXqLTEvTJro49/kgYj4o9GV+4tSw0epsaavxsCAg//OCHnJKkSsGMGFQ 12PRBwFq58GVLyuScRnG28yKvpK8DpQfEPzYhULn4xl+dinupatbhwJGE06HYu+OWxmO oMYAcfJYQqrF90mDZpuZSf9nJ16ESNLmzzV04OpmxIy4JH8mg6iyLZ4W2beNF9L/oUxd 001HdUdZjRZHtR33qW64blWMMHuYbbB9IGGNJ3G9YMX9vazp8k83Pn113vlot5mvz5V2 rBpFuuzkP95bXYNd7uboFOjecfKUFTuUgZ+7ExhZbzZ8Tqv3Gt6Fh94tBwau9Cr3IK94 aFOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2//TKXoNK4d6u3CFWTplgrJppYdlWlZBNFdPJkXv+ek=; b=bN+OHxbPrieERYsyhaPoDhONVxAt7xdMFGIDI4ZgNDHCdzDJpM5sCFI2VsZR++c33J cYrDGIg8PqkX/dxJLJOGKMeIlhjta8L3g9QpWvQ90VL3+V0dlzu+QDRFX47BzUBsgehP QCd2mFpQHDDhJ7bv/UO0gqsl1z8uf887jOSFWkaGutNqo/iLBlZ+mip1KelXVfm4dTxq QBgZBssuTc0whu8vexM4x9gkRKqdHo8AW3CSaqRpbXawF5iYy7dI5+WhZDEvITAmx86i rn7WDwlowVseWCe05lfwdih9qgoB2wDRPOUY51XN0su6NVa238QV6hoKS4oZo9toh+ZU +9nQ== X-Gm-Message-State: ANoB5pm/qh0XfMTdzAPvnHxQJ7qzjncnFqNiC0Avi3/y67eXoNaS8dTY PJ7e69npcUu6bMX0Y7cu2RMbXBnVDW4QJlVU2cc= X-Google-Smtp-Source: AA0mqf4lRMikyBj/idi+hypyDS3KsUZ5L0MeWtLSS10+YOrLQyVCHAfNr/Untr2+Qt7BJVpGoyehR55hqaVA2HEttnQ= X-Received: by 2002:a05:6402:3214:b0:459:278b:7a8b with SMTP id g20-20020a056402321400b00459278b7a8bmr25291486eda.355.1669468700201; Sat, 26 Nov 2022 05:18:20 -0800 (PST) MIME-Version: 1.0 References: <83zgcdsw90.fsf@gnu.org> In-Reply-To: <83zgcdsw90.fsf@gnu.org> From: Juanma Barranquero Date: Sat, 26 Nov 2022 14:17:42 +0100 Message-ID: Subject: Re: bug#59575: 29.0.50; add-log-current-defun-header-regexp matches Windows drive letter To: Eli Zaretskii Content-Type: multipart/alternative; boundary="000000000000d6df2a05ee5f78b3" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59575 Cc: 59575@debbugs.gnu.org, Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000d6df2a05ee5f78b3 Content-Type: text/plain; charset="UTF-8" On Sat, Nov 26, 2022 at 2:03 PM Eli Zaretskii wrote: > It is also possible to have xref.el define its customized > add-log-current-defun-function, but that sounds like overkill to me. That's what I meant, because it seemed to me less fragile than fiddling with the regexp. But I don't have a strong preference, as long as it is fixed. --000000000000d6df2a05ee5f78b3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Sat, Nov 26, 2022 at 2:03 PM Eli Zarets= kii <eliz@gnu.org> wrote:

> It is also possible = to have xref.el define its customized
> add-log-current-defun-functio= n, but that sounds like overkill to me.

That's what I meant, because it= seemed to me less fragile than fiddling with the regexp. But I don't h= ave a strong preference, as long as it is fixed.

--000000000000d6df2a05ee5f78b3-- From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 26 20:54:38 2022 Received: (at 59575) by debbugs.gnu.org; 27 Nov 2022 01:54:38 +0000 Received: from localhost ([127.0.0.1]:41753 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oz6sP-0001X8-QV for submit@debbugs.gnu.org; Sat, 26 Nov 2022 20:54:38 -0500 Received: from mail-wr1-f45.google.com ([209.85.221.45]:34353) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oz6sO-0001X0-E9 for 59575@debbugs.gnu.org; Sat, 26 Nov 2022 20:54:36 -0500 Received: by mail-wr1-f45.google.com with SMTP id o5so2761253wrm.1 for <59575@debbugs.gnu.org>; Sat, 26 Nov 2022 17:54:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=0MCRreAh66FdZ4If/EW9Jzd+KMdtdm0qM6EUZuQbTIo=; b=lG63IaEHSvAvMsuEplMwcDWjklQSZaYC+8zJfXqmdhgyLArcffbjCey1eI1AN9Bcsn I1rvTiR3geZ0i8j9eOQg1ktlD4Q+v0mMvvSAd3OlbSDx14ES7DvwaMEs3RTx9E7aVagD EA6mFyqqZshcrr7ucoGEtr7tb9Bxmbhq85q45cyTA+NVP2geB3dMTVSE6yBNqH7IBId7 WjmSNPoKESORTNbhzd8PEfCbPSUd884O8eYsEXTSgUqZuIxohlyMe2Rlb48jjcOGBA77 L70FEjW54gn98CNYr7fdje6dQuhvYr5xlmNbCB7YCjIS1xR/4sq5Qd6sN7AASAnuEAdd 0vmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0MCRreAh66FdZ4If/EW9Jzd+KMdtdm0qM6EUZuQbTIo=; b=WmUcmEMp4atlhVSjC/XClwTQcog/4kj2ZK8ddYf/TUAFXK6D5+jY5axVTU9NjfgxUE fVZep78gI7BQ793/ARWRKw7THkUmW3eC4htaLyea+QxbzgBw6O5V3kCqIiXNkuuxXxul bVYGsBxMawWgY2HUtB28H+orBfpuqPANLABB8SsnvDLcVqic/y+RQnE0UGKV46R6ITYj dZnOowo5tbrULdhxYFeUj7fFFUwZpYHQM+UCFhTsCV4PYL+9H4ubfpAJKK9SxidzCF02 iiSy1VYH+8D7Rv8y9O+68lqyuGkJswzEZJcwGFTGbF3cGsVCU52NOB/VJMZ8gmprQwwp 26Zw== X-Gm-Message-State: ANoB5plWvkLBL3+lEt+YHRMfXRaPPsuTmcVx8GoXi8ix8cE6/uPUd1w/ npyhFwfiU8w1dYdIMzNkm3I= X-Google-Smtp-Source: AA0mqf4redaIzuK5KQzy/EkoOddxh013Uq5j9l0G5Gn/3GVkULa16tE8IWkYl+j8JAWPyWVZsj37gA== X-Received: by 2002:a5d:63cd:0:b0:242:b6a:1cac with SMTP id c13-20020a5d63cd000000b002420b6a1cacmr3571132wrw.519.1669514070274; Sat, 26 Nov 2022 17:54:30 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id h12-20020a056000000c00b00241cfa9333fsm7402063wrx.5.2022.11.26.17.54.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 26 Nov 2022 17:54:29 -0800 (PST) Message-ID: Date: Sun, 27 Nov 2022 03:54:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: bug#59575: 29.0.50; add-log-current-defun-header-regexp matches Windows drive letter Content-Language: en-US To: Eli Zaretskii , Juanma Barranquero References: <83zgcdsw90.fsf@gnu.org> From: Dmitry Gutov In-Reply-To: <83zgcdsw90.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 59575 Cc: 59575@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On 26/11/22 15:03, Eli Zaretskii wrote: > It is also possible to have xref.el define its customized > add-log-current-defun-function, but that sounds like overkill to me. > Dmitry, WDYT? It seems like (setq add-log-current-defun-function nil) should suffice. Is that the intended behavior, to report the absence of the current defun? From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 27 01:49:30 2022 Received: (at 59575) by debbugs.gnu.org; 27 Nov 2022 06:49:30 +0000 Received: from localhost ([127.0.0.1]:41950 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozBTm-0006v7-13 for submit@debbugs.gnu.org; Sun, 27 Nov 2022 01:49:30 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45402) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozBTk-0006v1-Sw for 59575@debbugs.gnu.org; Sun, 27 Nov 2022 01:49:29 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozBTf-00050c-D2; Sun, 27 Nov 2022 01:49:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=h3HhQVYM4R/VZYARxNOgMq/zx14KTz1khUjqk0Uwbi0=; b=MyTuyuae+ZOD 25s2EJV4TXEfUEgGwIaXQuE1u/SENgMpEYyoW9/Ah6nq99Yk4XXUtcnG8SVM3IMX40rgVNli4MVVX j81K55QLGGd1PBp8ULFBy2/OCImPOyZqsv1P9bYs/Zx5GxJFNF7ZBdH04AnlVUeM5IR2lu+ciZJ2D WnV5IXGW6liOE/jSwsdNbskcPKeyzTP8GXLcCD8eeQeZN+JCE4nurLkxORcsiBrRJVJtC8jXBuBU4 CAv44JtsW3XRJkYGz6qF8WnI8Bf1lkr9Tr4UdrkBjgoqOzJk3fajxIauWjpWKf5c97+kOp+HOuzEF S9Ysl5H6Hx/uQ3LUDcCczA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozBTd-0006Wz-Jq; Sun, 27 Nov 2022 01:49:21 -0500 Date: Sun, 27 Nov 2022 08:49:49 +0200 Message-Id: <83edtoriwi.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-Reply-To: (message from Dmitry Gutov on Sun, 27 Nov 2022 03:54:27 +0200) Subject: Re: bug#59575: 29.0.50; add-log-current-defun-header-regexp matches Windows drive letter References: <83zgcdsw90.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59575 Cc: lekktu@gmail.com, 59575@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 27 Nov 2022 03:54:27 +0200 > Cc: 59575@debbugs.gnu.org > From: Dmitry Gutov > > On 26/11/22 15:03, Eli Zaretskii wrote: > > It is also possible to have xref.el define its customized > > add-log-current-defun-function, but that sounds like overkill to me. > > Dmitry, WDYT? > > It seems like > > (setq add-log-current-defun-function nil) > > should suffice. The value is already nil in the *xref* buffer, so I'm unsure how will the above help. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 27 03:30:44 2022 Received: (at 59575) by debbugs.gnu.org; 27 Nov 2022 08:30:44 +0000 Received: from localhost ([127.0.0.1]:42058 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozD3j-00081O-OI for submit@debbugs.gnu.org; Sun, 27 Nov 2022 03:30:44 -0500 Received: from mail-ej1-f51.google.com ([209.85.218.51]:41764) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozD3g-00081H-ED for 59575@debbugs.gnu.org; Sun, 27 Nov 2022 03:30:42 -0500 Received: by mail-ej1-f51.google.com with SMTP id vp12so17776001ejc.8 for <59575@debbugs.gnu.org>; Sun, 27 Nov 2022 00:30:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=91KO4eZsJm81w0O/fbkW6L8bco8Rv8yMnn2UK8oXZB0=; b=Ypf1olc745SvyGNAP5Bx1XJzKXrESiC1IykuVaye+ATCLvLcceecCuLedACH1fYJnB ufm2j0KxBxJrNumQV1vPGGzkNjlECEFPBc4dq2mGDjhosLvDQP+RG9K4mSc5/4Q1635p 1Na83oKrZ/zpbz3fW8f5PIc0PS/1OF780P2ezFh6qynj0WNKznQK0UWWsnw6OiqmZpQY aHErP+kLJ8kogP/NZYfTFGG4B8GkvVzS2KGEesabAHyN/3ZWcJjbU0WWlj73SH9SFbtN mGJwqmyCL5Stc8zmom0B6jMKzbx+QJhohjEgtXVs2oGGQ8nc3VEKlwBh92e3wl75v1Dv SY1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=91KO4eZsJm81w0O/fbkW6L8bco8Rv8yMnn2UK8oXZB0=; b=CE4rcywwaOmCWUnKaTuEtd3CYkr5VQvk+DMHi9iWwmlPOTNEUEe0liTGZF8SrsPcuB T2sYdq/4sOOSGaLE7QPwS8btyYIQICkVb8jJx2NnOLha2nxrTehoU+pAQgq+aI6mPg9v e5XfOsdfWF9VmnSMX1HihhPGMDPINgkTLl6dRPyERSgGaKPxr18+SzVOGNRkELcSgkdY F41WeGPdUnxWKByPI6g48jvnMukEbrG/t6Rla+q1uR99p6XJKijLoDCt6B3RQZF2CF9i A4Yon8klHTeGd2RWOrjQYLN6B8VerTY6PLS5jaKcjcFRvzn8WwDA70CRNMltGOu5dm/k ensg== X-Gm-Message-State: ANoB5plhqqsrWF7ZamHApnLFhbLlFIAP1Lu49SV7G1jWp5Ig3zQrgdnK AdnqHaDJ4HXuBpPRrNKPrbZh2T/HjD/L0YIBnig= X-Google-Smtp-Source: AA0mqf7tZQxmR4tc8XfAHaxxrzhkMf1PJCqEVZSpuPXcoaCBaeQ5hqAIdO1WAKgnKI5gwvHypSr+FXShOExXEQBc5eQ= X-Received: by 2002:a17:906:a991:b0:7ba:85a7:2ec3 with SMTP id jr17-20020a170906a99100b007ba85a72ec3mr16104974ejb.36.1669537834470; Sun, 27 Nov 2022 00:30:34 -0800 (PST) MIME-Version: 1.0 References: <83zgcdsw90.fsf@gnu.org> In-Reply-To: From: Juanma Barranquero Date: Sun, 27 Nov 2022 09:29:56 +0100 Message-ID: Subject: Re: bug#59575: 29.0.50; add-log-current-defun-header-regexp matches Windows drive letter To: Dmitry Gutov Content-Type: multipart/alternative; boundary="00000000000090129405ee6f91aa" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59575 Cc: Eli Zaretskii , 59575@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000090129405ee6f91aa Content-Type: text/plain; charset="UTF-8" On Sun, Nov 27, 2022 at 2:54 AM Dmitry Gutov wrote: > It seems like > > (setq add-log-current-defun-function nil) > > should suffice. That does not stop add-log-current-defun for working, in absence of an a-l-c-d-function it just uses the regexp, which is what is returning the spurious name. Either adding a custom add-log-current-defun-function, or setting add-log-current-defun-header-regexp to a buffer-local value so it recognizes filenames would work. (Buffer-locally, because the variable is in fact customizable so we can't be sure what its global value will be.) This works, for example: (defun xref--add-log-current-defun () (if-let (item (xref--item-at-point)) (xref-file-location-file (xref-match-item-location item)) (xref--imenu-extract-index-name))) (setq-local add-log-current-defun-function #'xref--add-log-current-defun) > Is that the intended behavior, to report the absence of the current defun? The final intended behavior, IIUC, is that the filenames in the xref--xref-buffer-mode get passed to which-function as "defun" names. --00000000000090129405ee6f91aa Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Sun, Nov 27, 2022 at 2:54 AM Dmitry Gut= ov <dgutov@yandex.= ru> wrote:
> It seems= like
>
> =C2=A0 =C2=A0(setq add-log-current-defun-function nil)
>= =C2=A0
> should suffice.

That does not stop add-log-current-defun for wo= rking, in absence of an a-l-c-d-function it just uses the regexp, which is = what is returning the spurious name.

Either adding a custom add-log-current-defun-function, or setting= add-log-current-defun-header-regexp to a buffer-local value so it recognizes filenames would work. (Buffer-locally, because the variable is in f= act customizable so we can't be sure what its global value will be.)

This works, for example:

(defun xref--add-log-current-defun ()
= =C2=A0 (if-let (item (xref--item-at-point))
=C2=A0 =C2=A0 =C2=A0 (xref-f= ile-location-file (xref-match-item-location item))
=C2=A0 =C2=A0 (xref--= imenu-extract-index-name)))

(setq-local add-log-current-defun-functi= on #'xref--add-log-current-defun)

> Is that the inten= ded behavior, to report the absence of the current defun?

The final i= ntended behavior, IIUC, is that the filenames in the xref--xref-buffer-mode= get passed to which-function as "defun" names.

--00000000000090129405ee6f91aa-- From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 27 06:11:48 2022 Received: (at 59575) by debbugs.gnu.org; 27 Nov 2022 11:11:48 +0000 Received: from localhost ([127.0.0.1]:42185 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozFZc-0000zl-5m for submit@debbugs.gnu.org; Sun, 27 Nov 2022 06:11:48 -0500 Received: from mail-ej1-f44.google.com ([209.85.218.44]:41622) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozFZa-0000zd-WA for 59575@debbugs.gnu.org; Sun, 27 Nov 2022 06:11:47 -0500 Received: by mail-ej1-f44.google.com with SMTP id vp12so18238901ejc.8 for <59575@debbugs.gnu.org>; Sun, 27 Nov 2022 03:11:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=yTOYXYffYed4f4rznJPSleQIurzGIcO/qO6KFH15mxY=; b=gx3qO/zL1IPrCJHZ2A9yFqRFaNfpro/xbDYvOIj6RxNvwKYkcyhZheapa9kEBmqW8Y 8pLp55eNyGf66GmhVHto3LwMVdq0rblpM42Wm8xOIhxqFRYM5x4iUNCjA8XHPJUgJI5e AzRzTf3gh7IE9qSf95FOaCDfr2bFq/eft9FjoS5sE9XEFEaBOP0jEwF64Kb+E403RwQ9 jcgwKMQppTI+xsHnyAY272XNP2UeFKrM6scD/kLjhhN0YhaR7JLY+20n/4zmaospWWYq Dcj/vT9N3dePzhiXc9vs8hPWmtdxECb00MLYY99Np3YSKQLgJ4C4R/5zBVmDQUtRqa8p hDXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yTOYXYffYed4f4rznJPSleQIurzGIcO/qO6KFH15mxY=; b=ieI5mCQV9QANb/htDZ4Bu0h5+Rv033sssap/RIFi6+ohM+K9OccIu/cnWMMh0GNDWp EpNxFyHHbHlmgHXjxdnfvLxjetjbDP765SZqWy14ohsF3sjBSQEOHAfBFpGgvpbp64Up YcgzztMVdejd64eJFyaMCVWPEakcZKurdbk7qNqI1eV/cyQo2pr7w7s8eHKdR8qqOYdn l9xaTPdslGwyXr6Vg9IGBi7X0wp0JyeI8HojdN254OGazcjkTuO/MuASMV3LPsYAseTw rM1J/oP7zQoTtkSF5Y84ww4MysQm2mfHr4DDDtyi+rurGX975nLOVdOmp5zmBxOzb7fd 4LXw== X-Gm-Message-State: ANoB5plLxSisRDZfQZnivklIaxaEaZggfMpzo0mWDKAuCeDn5XyFh3O6 hRlaDDgSMklF+6fkBSL4myCGgFAkGkDSJ12giAI= X-Google-Smtp-Source: AA0mqf5B6GOj0bw4+bdVBKnh7emrtXVe2/McBGe632N1oB3ZIZQA35kCxjpdHxORxOLTrBgXFxN7vuWS9CF1k1dq6ZA= X-Received: by 2002:a17:906:6dc9:b0:7bc:5700:490 with SMTP id j9-20020a1709066dc900b007bc57000490mr9926033ejt.592.1669547501092; Sun, 27 Nov 2022 03:11:41 -0800 (PST) MIME-Version: 1.0 References: <83zgcdsw90.fsf@gnu.org> In-Reply-To: From: Juanma Barranquero Date: Sun, 27 Nov 2022 12:11:03 +0100 Message-ID: Subject: Re: bug#59575: 29.0.50; add-log-current-defun-header-regexp matches Windows drive letter To: Dmitry Gutov Content-Type: multipart/alternative; boundary="000000000000bd054105ee71d1d4" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59575 Cc: Eli Zaretskii , 59575@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000bd054105ee71d1d4 Content-Type: text/plain; charset="UTF-8" On Sun, Nov 27, 2022 at 9:29 AM Juanma Barranquero wrote: > > This works, for example: > > (defun xref--add-log-current-defun () > (if-let (item (xref--item-at-point)) > (xref-file-location-file (xref-match-item-location item)) > (xref--imenu-extract-index-name))) > > (setq-local add-log-current-defun-function #'xref--add-log-current-defun) In fact, to respect the value of `xref-file-name-display' (which seems a good idea) a bit more complexity is required: (defun xref--add-log-current-defun () "Return the string used to group a set of locations. This function is used as a value for `add-log-current-defun-function'." (xref--group-name-for-display (if-let (item (xref--item-at-point)) (xref-location-group (xref-match-item-location item)) (xref--imenu-extract-index-name)) (xref--project-root (project-current)))) but that uncovers a different bug in xref--group-name-for-display: (cl-ecase xref-file-name-display (abs group) (nondirectory (if (string-match-p "\\`~?/" group) (file-name-nondirectory group) group)) that is, for the 'nondirectory case it tries to match against ~/filename or /filename, but (again) ignores absolute Windows paths with a drive letter. That should be changed to (cl-ecase xref-file-name-display (abs group) (nondirectory - (if (string-match-p "\\`~?/" group) + (if (string-match-p "\\`\\(~\\|[A-Za-z]:\\)?/" group) (file-name-nondirectory group) group)) (project-relative or something similar. --000000000000bd054105ee71d1d4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Sun, Nov 27, 2022 at 9:29 AM Juanma Bar= ranquero <lekktu@gmail.com> w= rote:
>
> This works, for example:
>
> (defun= xref--add-log-current-defun ()
> =C2=A0 (if-let (item (xref--item-at= -point))
> =C2=A0 =C2=A0 =C2=A0 (xref-file-location-file (xref-match-= item-location item))
> =C2=A0 =C2=A0 (xref--imenu-extract-index-name)= ))
>
> (setq-local add-log-current-defun-function #'xref--a= dd-log-current-defun)

In fact, to respect the value of `xref-file-nam= e-display' (which seems a good idea) a bit more complexity is required:=

(defun xref--add-log-current-defun = ()
=C2=A0 "Return the string used to group a set of locations.
T= his function is used as a value for `add-log-current-defun-function'.&q= uot;
=C2=A0 (xref--group-name-for-display
=C2=A0 =C2=A0(if-let (item = (xref--item-at-point))
=C2=A0 =C2=A0 =C2=A0 =C2=A0(xref-location-group (= xref-match-item-location item))
=C2=A0 =C2=A0 =C2=A0(xref--imenu-extract= -index-name))
=C2=A0 =C2=A0(xref--project-root (project-current))))

but that uncovers a different bug in xref--group-name-for-dis= play:

=C2=A0 =C2=A0(cl-ecase xref-f= ile-name-display
=C2=A0 =C2=A0 =C2=A0(abs group)
=C2=A0 =C2=A0 =C2=A0= (nondirectory
=C2=A0 =C2=A0 =C2=A0 (if (string-match-p "\\`~?/"= ; group)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (file-name-nondirectory grou= p)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 group))

that is, for the=C2=A0'nondirectory case it tries to matc= h against ~/filename or /filename, but (again) ignores absolute Windows pat= hs with a drive letter.

That should be changed t= o

=C2=A0 =C2=A0(cl-ecase xref-file-= name-display
=C2=A0 =C2=A0 =C2=A0(abs group)
=C2=A0 =C2=A0 =C2=A0(non= directory
- =C2=A0 =C2=A0 (if (string-match-p "\\`~?/" group)<= br>+ =C2=A0 =C2=A0 (if (string-match-p "\\`\\(~\\|[A-Za-z]:\\)?/"= group)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (file-name-nondirectory group= )
=C2=A0 =C2=A0 =C2=A0 =C2=A0 group))
=C2=A0 =C2=A0 =C2=A0(project-re= lative

or something similar.=

--000000000000bd054105ee71d1d4-- From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 27 06:22:46 2022 Received: (at 59575) by debbugs.gnu.org; 27 Nov 2022 11:22:46 +0000 Received: from localhost ([127.0.0.1]:42190 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozFkE-00015z-Fs for submit@debbugs.gnu.org; Sun, 27 Nov 2022 06:22:46 -0500 Received: from mail-ej1-f42.google.com ([209.85.218.42]:34549) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozFkC-00015q-8P for 59575@debbugs.gnu.org; Sun, 27 Nov 2022 06:22:45 -0500 Received: by mail-ej1-f42.google.com with SMTP id ho10so19586280ejc.1 for <59575@debbugs.gnu.org>; Sun, 27 Nov 2022 03:22:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=d1qKgXPQw54P9ehRRjwNQQAtUbeB4F6aS/X6fZTKGIE=; b=K+Ms8/meTT8gV67bdJGaOdu13AMG3nnFvq6ASjc9uiG24oRzBaOONo1gYxNQMxItRG lFURQ3Iz0qEAaOrWPg9tiZYSHozLqkX98VMa4vyuG0KB9HAOU3B/fZHToTQOrBozGEy3 ELe010B4Zz2cGGxt0N8E8cCYxKmsiVupK/EOBYg99WgjQLuES4jqevaefyHI0HwfhO1T flCNQhLTVAqqZbA4RUz0MJRe98Iq6gktKxyE0azqxXlJ/gtYYWKBpAf695eNtCg5Y5E3 tXaWOHVvtc7jhMHSpnv7x+pIT1BkYI9Zu/wCxchoockfj64/jV6D/XG4+x4ojLErwn7u RcbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=d1qKgXPQw54P9ehRRjwNQQAtUbeB4F6aS/X6fZTKGIE=; b=tNp07rg1QNGUsKsqgAxOD/V15eIy8Ixu8uUOIXri5z4w63J5WQpHiU0vB3Y8NpYAqa odQvS9VqMxbIvxukwyxX5Wot4njIlQiVPk5XHrG3uC8mTlvcgWzi66uOciO6ZoRTGzH6 8E3ltfJ5uRWUMIdxPNMoOEQNp7n0I/Sypx7y1b3wTVIS31LnFlelI1k0555n0vCPJI8S 8FmPuDs4UyZWrZSFvCqjH+HHJD22j2pS1v9Fju/0O8kxqs3w3Q3JlgbsbO083GvT6w8E 9rdZwXUrbi6A5iFUzWeehVt+Pgff9I6pacYpvxP5sOG5LBUfJ81loPaQTsbBhWy8rl9u m9ig== X-Gm-Message-State: ANoB5pkS4Ze27XPI8coh2yFbjVxrSN8u4Ys5/n7dvakyZ5F5rX4RFxxO I1IojaOZcVKKM6yhQUZRGuV6YtWdhys7+X76ENc= X-Google-Smtp-Source: AA0mqf5AOUr3AykGPmBwb1rQm/0GLp5OgxdgUPM/WxSpzZdyOgkLM1snBEWVySvrpJ2kw1jBqP8WMjs6fGWfEvpTx/E= X-Received: by 2002:a17:906:2416:b0:7ad:4a55:d6f5 with SMTP id z22-20020a170906241600b007ad4a55d6f5mr40284596eja.220.1669548158329; Sun, 27 Nov 2022 03:22:38 -0800 (PST) MIME-Version: 1.0 References: <83zgcdsw90.fsf@gnu.org> In-Reply-To: From: Juanma Barranquero Date: Sun, 27 Nov 2022 12:22:00 +0100 Message-ID: Subject: Re: bug#59575: 29.0.50; add-log-current-defun-header-regexp matches Windows drive letter To: Dmitry Gutov Content-Type: multipart/alternative; boundary="000000000000e9a9ba05ee71f8c8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59575 Cc: Eli Zaretskii , 59575@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000e9a9ba05ee71f8c8 Content-Type: text/plain; charset="UTF-8" On Sun, Nov 27, 2022 at 12:11 PM Juanma Barranquero wrote: > That should be changed to > > (cl-ecase xref-file-name-display > (abs group) > (nondirectory > - (if (string-match-p "\\`~?/" group) > + (if (string-match-p "\\`\\(~\\|[A-Za-z]:\\)?/" group) > (file-name-nondirectory group) > group)) > (project-relative > > or something similar. > Silly me, that should just use `file-name-absolute-p'. OK to fix this, regardless of what's decided for the original bug? --000000000000e9a9ba05ee71f8c8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sun, Nov 27, 2022 at 12:11 PM Juanma Barranquero <lekktu@gmail.com> wrote:
=C2=A0
That should be changed to

=C2= =A0 =C2=A0(cl-ecase xref-file-name-display<= br>=C2=A0 =C2=A0 =C2=A0(abs group)
=C2=A0 =C2=A0 =C2=A0(nondirectory
= - =C2=A0 =C2=A0 (if (string-match-p "\\`~?/" group)
+ =C2=A0 = =C2=A0 (if (string-match-p "\\`\\(~\\|[A-Za-z]:\\)?/" group)
= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (file-name-nondirectory group)
=C2=A0= =C2=A0 =C2=A0 =C2=A0 group))
=C2=A0 =C2=A0 =C2=A0(project-relative

or something similar.

Silly me, that should just use `file-name-absolute-= p'.

OK to fix this, regardless of what's decided for the ori= ginal bug?
--000000000000e9a9ba05ee71f8c8-- From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 27 07:34:15 2022 Received: (at 59575) by debbugs.gnu.org; 27 Nov 2022 12:34:15 +0000 Received: from localhost ([127.0.0.1]:42235 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozGrH-0004Bm-3a for submit@debbugs.gnu.org; Sun, 27 Nov 2022 07:34:15 -0500 Received: from mail-wm1-f41.google.com ([209.85.128.41]:52057) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozGrE-0004BP-1u for 59575@debbugs.gnu.org; Sun, 27 Nov 2022 07:34:05 -0500 Received: by mail-wm1-f41.google.com with SMTP id 5so6662684wmo.1 for <59575@debbugs.gnu.org>; Sun, 27 Nov 2022 04:34:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=Cyld3RXUnRszeEaLxRJZWDzWXcpJKhJZcEJ5YeA2YKU=; b=LL5b8fQYymzESSFmQeV3/1H/LicgnCHA29wxtirIGDOfGzYnhm3R3D7+xf48oimfP5 6DKYO90iD0j2WQy9Zxusnw0jDDoubimxVmUULk3YOGhN5Ljv6QjIUzfU6NVHpbxP3Lh3 50hiQInRIfZEo8Ir2SJ/5PB28M/yt3jI9637JTCAILtwJWssb2VKhuwwxurMx0rAIodo TUE/Z3AqdbiMnrblmCoIKcn1jtKCkGxWSXCBpobNWoVxKPUx2XMKobr4j4lZZa95/it3 TH+izbuGhGAVP+LWHxoA1+Z9EOwbSvLEQIKjX3EMmppKt21jGjTD39fgEXK8qovSXmTV 0dRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Cyld3RXUnRszeEaLxRJZWDzWXcpJKhJZcEJ5YeA2YKU=; b=rUHw1cQ8ckm9XQn94O3vjs4y2vAJNkuKTtIQu2DSU06mYuAgoyaxMGED0QpUxCIhhD EGIRxUSb5yO3vd7H9Ur3QNvxaY6w/NJtSLnRnjCjF/k4bmfWN9A8pBzbzzfVE1tipXqz n4chWMKyK4IfeWLbt0NvZslNw4CbEAhpGOVfpxBZl46MSVHvytAENBOxe5RwahUKN1Uv uh1I3ysDOmtp8+4qmU7qYijTS8nOT2FwUUqEnoBiZRss/TfXGUOvknvkMJFAtLXfLzOq PtOl6oxULEjzRvpjjgoENsV8U2Agy6wuDR4pLAE7TXcdyAkexW6ZsIe7tXSwhZQ9OyHh kxMw== X-Gm-Message-State: ANoB5pnlFWWXB43/zkI7qmbNb24ZEx+NgG5kzn6xredBZU07uGKSu6J6 o0HI8LUbCd7BKS9YxzO4VRw= X-Google-Smtp-Source: AA0mqf6AqnBDkYj3ONUT4zJoliyvyvAPAwtvAd66KDmZRgS3u+pk6jiUvCv4OHx6xpK59uKEBGLdrQ== X-Received: by 2002:a05:600c:3ac9:b0:3cf:cfc8:9450 with SMTP id d9-20020a05600c3ac900b003cfcfc89450mr21226975wms.99.1669552438150; Sun, 27 Nov 2022 04:33:58 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id k15-20020a05600c1c8f00b003b47b80cec3sm18256642wms.42.2022.11.27.04.33.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Nov 2022 04:33:57 -0800 (PST) Message-ID: <2b1a90fa-4500-83f2-d76d-4759b03053c4@yandex.ru> Date: Sun, 27 Nov 2022 14:33:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: bug#59575: 29.0.50; add-log-current-defun-header-regexp matches Windows drive letter Content-Language: en-US To: Eli Zaretskii References: <83zgcdsw90.fsf@gnu.org> <83edtoriwi.fsf@gnu.org> From: Dmitry Gutov In-Reply-To: <83edtoriwi.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 59575 Cc: lekktu@gmail.com, 59575@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 27/11/22 08:49, Eli Zaretskii wrote: >> Date: Sun, 27 Nov 2022 03:54:27 +0200 >> Cc:59575@debbugs.gnu.org >> From: Dmitry Gutov >> >> On 26/11/22 15:03, Eli Zaretskii wrote: >>> It is also possible to have xref.el define its customized >>> add-log-current-defun-function, but that sounds like overkill to me. >>> Dmitry, WDYT? >> It seems like >> >> (setq add-log-current-defun-function nil) >> >> should suffice. > The value is already nil in the*xref* buffer, so I'm unsure how will the > above help. Sorry, brain fart. I meant (setq add-log-current-defun-function #'ignore) From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 27 07:40:50 2022 Received: (at 59575) by debbugs.gnu.org; 27 Nov 2022 12:40:51 +0000 Received: from localhost ([127.0.0.1]:42240 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozGxm-0004Eb-Kk for submit@debbugs.gnu.org; Sun, 27 Nov 2022 07:40:50 -0500 Received: from mail-ej1-f45.google.com ([209.85.218.45]:38543) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozGxl-0004EV-1T for 59575@debbugs.gnu.org; Sun, 27 Nov 2022 07:40:49 -0500 Received: by mail-ej1-f45.google.com with SMTP id td2so5697077ejc.5 for <59575@debbugs.gnu.org>; Sun, 27 Nov 2022 04:40:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Y3iDIzpMCzTLNug7XJCnfL3L6L/QUKPuhGKN+M0HGoY=; b=mayu2YlwYY2d+4/pQem6EPpy/Y3fIe6FTQwoLgqh/rc73qFXGfp/996OL04q+OKveD LPXMSlmcvM3y3405yviG836CqpFXmFiDdoo4VQBOb1c9P4CfeGwppZsvsREgcxIz61jo TwF1vQ+ajDbUxIN3T2J0irQ1lznBYCTh89AxLyPvDDJ16q6SxUnLUqwMpA/jUWNzYNv5 wxsY71NFa7xgmpO74/lWFnhVGXrndkY5OvJw25zKYAefuJsIAE0K+EnzhXZ+yYefh1Dk MaIlzouv3yX869VcGdu1ZnBH32N0v2QMiZb5Rn2iM9Kchy2DdsuZU0KAX4yppFOHGh4R JacA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Y3iDIzpMCzTLNug7XJCnfL3L6L/QUKPuhGKN+M0HGoY=; b=MgrW3mBG5hbNJJsIHg0ez6Z3pCabsVCeyKUI1C2cV0utVahcMRR+1yIP8UlEOo8l8I RMHsUJz45VxOxL94c1dCt88NecXAvHuu3+rEhcgfoyCA317AjWM6uD6qsyuxy/s1ycgd QhEql9+kAhJvUPoJ2ye2zKPcWdMgZFgzSzdAq5VTZATN15kkxIwc+wP4oKWCa8ANbXEg 5C3I2YLcKWqqt9ZvompckGLcbn8ATJlRAYxNj7mTRamJ5s4HOSdorClJCDu2EFUe0rup z4HHZi5aVqfEE+9BI25j2hj1uTA6pj6HjrdpH0/AcFt7GU+ZiAS+jGeJmP6F2l2arHDW ssRw== X-Gm-Message-State: ANoB5pnHJPp+t7rf0l1RcWn4i0Y845Bg4usqWElDmdnOkcOjVUJm8jg2 LCi42lXPJmxZJbf+D/hEhqSk3PiOSCfIDEc9//w= X-Google-Smtp-Source: AA0mqf7syf3sBDSpHrtsYpd3lOGHZCD693AooF79hxFig9X01xsRFn3RpVAiVb4iKwDnYVve/LCb4RxWVm7BZU3VQW0= X-Received: by 2002:a17:906:4bcc:b0:7be:6ab8:4ccc with SMTP id x12-20020a1709064bcc00b007be6ab84cccmr3901624ejv.713.1669552843138; Sun, 27 Nov 2022 04:40:43 -0800 (PST) MIME-Version: 1.0 References: <83zgcdsw90.fsf@gnu.org> <83edtoriwi.fsf@gnu.org> <2b1a90fa-4500-83f2-d76d-4759b03053c4@yandex.ru> In-Reply-To: <2b1a90fa-4500-83f2-d76d-4759b03053c4@yandex.ru> From: Juanma Barranquero Date: Sun, 27 Nov 2022 13:40:05 +0100 Message-ID: Subject: Re: bug#59575: 29.0.50; add-log-current-defun-header-regexp matches Windows drive letter To: Dmitry Gutov Content-Type: multipart/alternative; boundary="000000000000262ad705ee7310cf" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59575 Cc: Eli Zaretskii , 59575@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000262ad705ee7310cf Content-Type: text/plain; charset="UTF-8" On Sun, Nov 27, 2022 at 1:33 PM Dmitry Gutov wrote: > Sorry, brain fart. I meant > > (setq add-log-current-defun-function #'ignore) That "works", in the sense that now which-func gets "n/a" in the xref results buffer instead of a bogus name. But which-func can be useful in xref result buffers. --000000000000262ad705ee7310cf Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


<= div dir=3D"ltr" class=3D"gmail_attr">On Sun, Nov 27, 2022 at 1:33 PM Dmitry= Gutov <dgutov@yandex.ru> wro= te:

> Sor= ry, brain fart. I meant
>
>=C2=A0 =C2=A0(setq add-log-current-defun-function #'ignore)
<= br>That "works", in the sense that now which-func gets "n/a&= quot; in the xref results buffer instead of a bogus name. But which-func ca= n be useful in xref result buffers.
--000000000000262ad705ee7310cf-- From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 27 08:04:35 2022 Received: (at 59575) by debbugs.gnu.org; 27 Nov 2022 13:04:35 +0000 Received: from localhost ([127.0.0.1]:42253 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozHKk-0004UH-Lb for submit@debbugs.gnu.org; Sun, 27 Nov 2022 08:04:34 -0500 Received: from mail-wr1-f45.google.com ([209.85.221.45]:41699) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozHKi-0004UB-Qc for 59575@debbugs.gnu.org; Sun, 27 Nov 2022 08:04:33 -0500 Received: by mail-wr1-f45.google.com with SMTP id q7so12035815wrr.8 for <59575@debbugs.gnu.org>; Sun, 27 Nov 2022 05:04:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=6BymVVU0bznvOTSFz0mVQjiNxf9pmAYAFw5n45tSpWM=; b=KQ/iJk0TlPnbRv3+mqOoL00qDnnF8WYtRqwTSmRPdgt+U9LnelbPs+rzMTT6sHIAmr GcbnAzoWVRoWIGpSgQ7QiHfniINEcSzI9INr9cCACvFhfIOOiV7qlRQZK0vfh7XIzZIB TeH3OIZ2L1SfrrSuZz585aroFb6xavgolC/dfhSe2huyBC3D6PCDaDyh59sYWk8rM1OQ q+YwfsMyvLGUQv7x0ZrScWuaQNsjfGVLrd1ISnP91US53tGG2OImoQLixmIRzG9COFhZ ztZCw4qDe4Jbdh5qb8W0wFJaizw6G3NxVCnjZY+Kl1DkLRgDTI1tUyyikIcRQpW0Aur6 n6dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6BymVVU0bznvOTSFz0mVQjiNxf9pmAYAFw5n45tSpWM=; b=JBEIJIfhdK54/w9ZUCzgKXvhlv4rqgnk3q0r8BdouqvwAo85LhRqSrdtS4JKcWdjdT DLKWV88ZSohyJQCYk+9xB24LvMv4+89539b0p02fL/yF9zAfXRK6us+8EIoQUTALSb8t vUgjJp8oG4PMtWretvkNp2jH3LBGBtORKe9MH8k+pm+xz7C2dRGAPnMc/0Gns3sf+z6n y0LsV98y6WF/PjGUJKHUKrvaSTG/aQ7iNMg+dEeo+p9vg7S5l/gTATjD3+pYPiSVFfvO wrFNzndqQugp0iV2T2FcStAvjxVwpXDjetY5s1IPBbtHvU5eu0kwWSxLV2abm9tmVJEc VjVg== X-Gm-Message-State: ANoB5pnRojaCxbXj6YoAw/omXh6ZJwLAzHbCExI8Nt+4v8ZL6RQ93cR3 Bue7+6ItItWYUppq/DpESV8= X-Google-Smtp-Source: AA0mqf6CHKFGdhC6CyHIMLmRGxf1aMqAa/IZS7uIflFJGanD2w3bLer3IdpBHBY94qGjbAFIsTcDyw== X-Received: by 2002:a5d:4e49:0:b0:242:d4f:961 with SMTP id r9-20020a5d4e49000000b002420d4f0961mr3554757wrt.474.1669554267071; Sun, 27 Nov 2022 05:04:27 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id k1-20020a7bc401000000b003cfbe1da539sm11750447wmi.36.2022.11.27.05.04.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Nov 2022 05:04:26 -0800 (PST) Message-ID: Date: Sun, 27 Nov 2022 15:04:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: bug#59575: 29.0.50; add-log-current-defun-header-regexp matches Windows drive letter Content-Language: en-US To: Juanma Barranquero References: <83zgcdsw90.fsf@gnu.org> From: Dmitry Gutov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 27/11/22 13:22, Juanma Barranquero wrote: > On Sun, Nov 27, 2022 at 12:11 PM Juanma Barranquero > wrote: > > That should be changed to > >  (cl-ecase x [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (dgutov[at]yandex.ru) -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.221.45 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.45 listed in wl.mailspike.net] 0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different -0.0 NICE_REPLY_A Looks like a legit reply (A) 1.0 FREEMAIL_REPLY From and body contain different freemails X-Debbugs-Envelope-To: 59575 Cc: Eli Zaretskii , 59575@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On 27/11/22 13:22, Juanma Barranquero wrote: > On Sun, Nov 27, 2022 at 12:11 PM Juanma Barranquero > wrote: > > That should be changed to > >  (cl-ecase xref-file-name-display >      (abs group) >      (nondirectory > -     (if (string-match-p "\\`~?/" group) > +     (if (string-match-p "\\`\\(~\\|[A-Za-z]:\\)?/" group) >           (file-name-nondirectory group) >         group)) >      (project-relative > > or something similar. > > > Silly me, that should just use `file-name-absolute-p'. > > OK to fix this, regardless of what's decided for the original bug? Yes, please. The original idea was to avoid costly operations (in case the list of matches is long), but looks like file-name-absolute-p doesn't hit the disk. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 27 08:05:53 2022 Received: (at 59575) by debbugs.gnu.org; 27 Nov 2022 13:05:53 +0000 Received: from localhost ([127.0.0.1]:42257 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozHM1-0004V9-3A for submit@debbugs.gnu.org; Sun, 27 Nov 2022 08:05:53 -0500 Received: from mail-wm1-f50.google.com ([209.85.128.50]:39445) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozHLy-0004V3-QB for 59575@debbugs.gnu.org; Sun, 27 Nov 2022 08:05:51 -0500 Received: by mail-wm1-f50.google.com with SMTP id 83-20020a1c0256000000b003d03017c6efso8938721wmc.4 for <59575@debbugs.gnu.org>; Sun, 27 Nov 2022 05:05:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=VLJe3PjnxgCJK4iVe1bD4PXkfmK5bDPW+WUKeg1XWWY=; b=DEcFvXTSJAuHcoUgJgahrcghBU0+2R+S0ldkH//HzjvirpZI8L3QbWm78JFatOdWmJ EpU/Em7mYEqKPJE/VrS8PiwqVHJ5JzCe+yMd1O7D/bzncxTEgiCx6omR/rUypewR5IG7 FHnYhty8T7Zwx6whmzWMY0aJAdXQFlXX90ZvbT9cWkcPlzNALrsPW+10MWsLrxglO4cj 3oW3HvAVZElPVEHg2UClX9B16R6TWUx+6QjYS6m0br/HBsazQeQa2Aw3kMEC8qYK9eOi hofAJRBswptNag0NytfcCXfOpuzRQC/Cya7T5zjO+ubHzhBqSfl0j1KwZS93ddI7p8IV l+FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VLJe3PjnxgCJK4iVe1bD4PXkfmK5bDPW+WUKeg1XWWY=; b=6G5YzqVYfkxm2it7qNfLbKHng93DJaSoIGnFPQ4B6eWR1lIuOQfplyLJi1GDMqIuOR Nv9P8AtSHcnY5XK0209n5ZQpWZfo8kDtKVhQMavxZZP9W8OSB91lOWPlX4F20M2Yun0D i2f2bWw5a/F8mIxAsOyNcIqUd+jcmSYaX66rjDu8GylmwBgbCNfNKHsaAPr3AawiQKNP o+1OcIruuy9ZT6BIkxKaU6pegLZKcDdVYYgXK/3ewrFE5dZway8W8+hy0Pd18Pn0ofeJ QBFNYnNvlQ5/gGkWiheGsOKq2Tbc+As2N/XgB0zDWRSB0e9w8EMrTO+PjaanuUNZFa0T arQg== X-Gm-Message-State: ANoB5pmb+OD7Wl/XkmhoOykmqns9gQghMvgqxC2FRSRZldr7veyrNzTH Jin5gDXBNPrpgoUsznA8utI= X-Google-Smtp-Source: AA0mqf6bEJQ05RarMu500gl1vbIqfusmAqetMkkBfoda+YgwYTFuYZm4uUIvOY8y7ZPZESFgcbPi4g== X-Received: by 2002:a7b:ce89:0:b0:3c6:c986:f2b9 with SMTP id q9-20020a7bce89000000b003c6c986f2b9mr34147320wmj.53.1669554344949; Sun, 27 Nov 2022 05:05:44 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id i12-20020adffdcc000000b002420cfcd13dsm3607979wrs.105.2022.11.27.05.05.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Nov 2022 05:05:44 -0800 (PST) Message-ID: <8273f7a6-23d2-b5b6-ffe3-cb3d0f0c26f8@yandex.ru> Date: Sun, 27 Nov 2022 15:05:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: bug#59575: 29.0.50; add-log-current-defun-header-regexp matches Windows drive letter Content-Language: en-US To: Juanma Barranquero References: <83zgcdsw90.fsf@gnu.org> From: Dmitry Gutov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 59575 Cc: Eli Zaretskii , 59575@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On 27/11/22 10:29, Juanma Barranquero wrote: >> Is that the intended behavior, to report the absence of the current defun? > > The final intended behavior, IIUC, is that the filenames in the > xref--xref-buffer-mode get passed to which-function as "defun" names. I don't mind this approach either, but given that the "definitions" in Xref buffers are often only 1 line long, or maybe a few, wouldn't showing the file name again somewhere nearby (e.g. the header bar) just be redundant? From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 27 08:19:29 2022 Received: (at 59575) by debbugs.gnu.org; 27 Nov 2022 13:19:30 +0000 Received: from localhost ([127.0.0.1]:42285 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozHZB-0004cq-Hi for submit@debbugs.gnu.org; Sun, 27 Nov 2022 08:19:29 -0500 Received: from mail-ej1-f52.google.com ([209.85.218.52]:40830) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozHZ9-0004ck-RN for 59575@debbugs.gnu.org; Sun, 27 Nov 2022 08:19:28 -0500 Received: by mail-ej1-f52.google.com with SMTP id b2so3626182eja.7 for <59575@debbugs.gnu.org>; Sun, 27 Nov 2022 05:19:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=G+pD2tmXYoRjYArQtqzQaAn7dLv8ghOSPpdSLn9lLAE=; b=dvjt4nRYikdBbEbKrz80KyMHdToWtDKIMnjYtgWPNM5VAkSNfn0snlwMS0n2KjB6Vm cekYMOsS+GjwnohLDPcCLZqNoltlIlhWBBVGiowFR7OZTcv+jFdzji4p/QPS6QNTcxGc 5FaGzzPN58CJYDACGWI9QkzqLDdLAoJJ+ryANJtHzPcK1nJVQTJWHBYcIikxvk0rRx5k yHwkpP3pUQjllJr2dB1uAFkvZdKg8+9GnnAt2A59iXV2HuFJIVeUqiS6qV0/co2ZDn+I YNF9LKB7RR1zQBpdvff02cKhoZTaGz1sSlzOFXUSALIGqPC3afDxSuNPUVL8ISm9VVe+ gfow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=G+pD2tmXYoRjYArQtqzQaAn7dLv8ghOSPpdSLn9lLAE=; b=d0k9cjKQAxmsofbKHeSzb599faLyFwphFx+iYHMhBnVj0ghtTn7cCaimc1da8FbdOT 4Rc+qoItLaYlNNElIie6S4juxBg9l2vmnF0J1oGoQyE4p9hPjK+rbfGVxi7N9utynxVP 2nWHBaU9glEuODFodyjgcMxIy7NREqCCwfKpJ0RWSchs+rs6/R2QY3nmN+8QvteXUfU5 wxrn0iQfSNuL28p0Uw6YltAFnyNGjxymsmFWe9GVZYNm0MJqeMM5oBYF7QzCqP+vWm5s 0F7odtVZc7/dBamoZSNMuQHW8yVtYxqU4vJhE8PoJ5WxqwWCvKOW8K8wHWxK67Q1jpyg XNug== X-Gm-Message-State: ANoB5pmXcA/TabVLKuZJ86vihZ3W2O+KqxxBuxsVoDte75/ISKrAeAIe dvhCAiAHGbAhPwPIa7PNYro+olP6Li6tHHFKoHc= X-Google-Smtp-Source: AA0mqf5dZDtAkgvIOs8fE4UL8/9dPgWG02CSWS2vPzlxBxsXgm1Rau2ezi8l7VO7g0v/9l/jeb6QRlYvlUBYetmKRRg= X-Received: by 2002:a17:906:4bcc:b0:7be:6ab8:4ccc with SMTP id x12-20020a1709064bcc00b007be6ab84cccmr3994342ejv.713.1669555161887; Sun, 27 Nov 2022 05:19:21 -0800 (PST) MIME-Version: 1.0 References: <83zgcdsw90.fsf@gnu.org> <8273f7a6-23d2-b5b6-ffe3-cb3d0f0c26f8@yandex.ru> In-Reply-To: <8273f7a6-23d2-b5b6-ffe3-cb3d0f0c26f8@yandex.ru> From: Juanma Barranquero Date: Sun, 27 Nov 2022 14:18:45 +0100 Message-ID: Subject: Re: bug#59575: 29.0.50; add-log-current-defun-header-regexp matches Windows drive letter To: Dmitry Gutov Content-Type: multipart/alternative; boundary="0000000000005b78cd05ee739a35" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59575 Cc: Eli Zaretskii , 59575@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000005b78cd05ee739a35 Content-Type: text/plain; charset="UTF-8" On Sun, Nov 27, 2022 at 2:05 PM Dmitry Gutov wrote: > I don't mind this approach either, but given that the "definitions" in > Xref buffers are often only 1 line long, or maybe a few, wouldn't > showing the file name again somewhere nearby (e.g. the header bar) just > be redundant? Sometimes you've got a lot of matches. Also, I tend to display the output of xref (and, generally speaking, of all kinds of "locating"/"matching" functions, like occur, etc) in small windows, usually less than ten lines high. And anyway, this won't bother anyone who's not already using which-func. --0000000000005b78cd05ee739a35 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Sun, Nov 27, 2022 at 2:05 PM Dmitry Gut= ov <dgutov@yandex.ru> wrote:<= br>

> I don't = mind this approach either, but given that the "definitions" in> = Xref buffers are often only 1 line long, or maybe a few, wouldn'= t
&= gt; showing the file name again somewhere nearby (e.g. the header ba= r) just
> be redundant?

Sometimes you've got a lot of matches. A= lso, I tend to display the output of xref (and, generally speaking, of all = kinds of "locating"/"matching" functions, like occur, e= tc) in small windows, usually less than ten lines high. And anyway, this wo= n't bother anyone who's not already using which-func.

--0000000000005b78cd05ee739a35-- From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 27 08:22:50 2022 Received: (at 59575) by debbugs.gnu.org; 27 Nov 2022 13:22:50 +0000 Received: from localhost ([127.0.0.1]:42289 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozHcQ-0004eh-6v for submit@debbugs.gnu.org; Sun, 27 Nov 2022 08:22:50 -0500 Received: from mail-ed1-f49.google.com ([209.85.208.49]:35425) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozHcN-0004eb-NG for 59575@debbugs.gnu.org; Sun, 27 Nov 2022 08:22:48 -0500 Received: by mail-ed1-f49.google.com with SMTP id x2so12178815edd.2 for <59575@debbugs.gnu.org>; Sun, 27 Nov 2022 05:22:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=yW6thW+wjcfU/6k3z/YfyVLvugNnSMnphPmSUlTJKp8=; b=Oii0ZOIbxRfkksa76f9kEO6BR4tuNP4/KfrRu7S904YauBW30Aty9SkYOWPmRcGOiH 3qPqIepekBrPyMKEUUFAY0viSU7Y81IGfiE5ei9s8mYJ8jUGMCubi44LahM9z/H0eyHc mSbiyPeO/B3IrrprkImzjeBEM0aswx9WeGawfYb5U+v0aKzW37Uv9bLfh0vRBXk2M/WF 4AaKTLQDXrXot8JHP/nWAOq6C9m+ijoggj0iw1SPAkPMOCNgqNg/rAlFbSjYYjYyjjxa X788b7iaSRm80NHoc/WL1CWcLBEGNLZCe3seAFkw1tFoNX/A+yLU4rfnv3zB7NIQfZHx 47IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yW6thW+wjcfU/6k3z/YfyVLvugNnSMnphPmSUlTJKp8=; b=5cHExj9jnjqSGFkbPkvbCbnyA6zeKA4NQaIuP1Glvev1ieBUdUre5Vv5TlTRk79kTO qMTY4Iht/WjiOlZF2UUFmblfBfMHdM0nUsYv1yky9RBA0cbwfBUylBROWWKrXApiO3Xt vxp4SvaU2xbN3+3/14oSeKrTqOiaZ0pN0lLQXG87FQd3htenQQnGttKf4Oy5W39FIvex FKDc3SHg5peAIv3zU91usKZhLr0JIcATUjWLtmdrgJp63zc8CSmDmG6t0QhT2TNPUNjK fvUZ0VfSIimoMHn2dly8lqfjR/HyGbEPqHC/BMJEh7hoHRbUgba2s05rVxwndT6+V90Q QyHQ== X-Gm-Message-State: ANoB5pmjlb0EonZA2bACRPtDrugCWxlL2vKo9z939C/slJu3CCkWnkaZ GETYJaJ/UWbUN3/elvnUQEbSOPnL9CDKMteWtno= X-Google-Smtp-Source: AA0mqf5q9e0uR6ptGuGN0hduqewbEwnVcBlwW8Ma6do6Af4M1heFPPZcD8pW/C9LeP+X6lx7i+G/JXt3Zg7Src6OxQk= X-Received: by 2002:aa7:c055:0:b0:45a:1af2:ed6d with SMTP id k21-20020aa7c055000000b0045a1af2ed6dmr28572614edo.364.1669555361987; Sun, 27 Nov 2022 05:22:41 -0800 (PST) MIME-Version: 1.0 References: <83zgcdsw90.fsf@gnu.org> In-Reply-To: From: Juanma Barranquero Date: Sun, 27 Nov 2022 14:22:05 +0100 Message-ID: Subject: Re: bug#59575: 29.0.50; add-log-current-defun-header-regexp matches Windows drive letter To: Dmitry Gutov Content-Type: multipart/alternative; boundary="00000000000048bfd105ee73a6a1" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59575 Cc: Eli Zaretskii , 59575@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000048bfd105ee73a6a1 Content-Type: text/plain; charset="UTF-8" On Sun, Nov 27, 2022 at 2:04 PM Dmitry Gutov wrote: > Yes, please. The original idea was to avoid costly operations (in case > the list of matches is long), but looks like file-name-absolute-p > doesn't hit the disk. Done in commit 41d2365d58 of 2022-11-27: Fix xref to correctly display Windows absolute filenames --00000000000048bfd105ee73a6a1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Sun, Nov 27, 2022 at 2:04 PM Dmitry Gut= ov <dgutov@yandex.ru> wrote:<= br>

> Yes, please. The original idea was to avoid costly operat= ions (in case
> the list of matches is long), but looks like file-nam= e-absolute-p
> doesn't hit the disk.

Done in commit 41d2365d58 of= 2022-11-27:
Fix xref to correctly display Windows absolute filenames
--00000000000048bfd105ee73a6a1-- From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 27 08:41:40 2022 Received: (at 59575) by debbugs.gnu.org; 27 Nov 2022 13:41:40 +0000 Received: from localhost ([127.0.0.1]:42294 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozHud-0004pB-Tm for submit@debbugs.gnu.org; Sun, 27 Nov 2022 08:41:40 -0500 Received: from mail-wm1-f51.google.com ([209.85.128.51]:35678) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozHub-0004p5-Gj for 59575@debbugs.gnu.org; Sun, 27 Nov 2022 08:41:38 -0500 Received: by mail-wm1-f51.google.com with SMTP id h131-20020a1c2189000000b003d02dd48c45so3820589wmh.0 for <59575@debbugs.gnu.org>; Sun, 27 Nov 2022 05:41:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=B69I1wcRWQkiORAz7Gnq5Zzzo0ejdqCvWZDx4+Z9LCU=; b=SAcHRr44KHer+hxyw3rRkIF7G/Tpgr4BlBC9jKZrKoj/Bgu6zALnw5K4zoCzOOlAyL yPp2u+wS6swZ0RIoCcJ/wLqKDsE/rbo9gmXIgAvowUAsDy57BnjJePsABiTu+w42RLy5 0fs8INcWBEPZ7rkTE6TrZWnKjE+Rsx1wBM3SBci1AhjLeJuvSLEWSwumwXAIBQGYh4HA mBd7YpDJX6JAUiTPOVz0nelqlONFAJC7AdFtC9oQHEh2Rwk4gHYijz2XBi3aJOx6dFU2 bS04BSJ/8Hb6xtoG9+cJaV/BI8Dt5xrWOhKahFCHZiJtUtrZ/4I6pcF9v5OroGEYCR1x sZ3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=B69I1wcRWQkiORAz7Gnq5Zzzo0ejdqCvWZDx4+Z9LCU=; b=3gbBq/tNwM3ypP3TeQe5/ATt7YHhXLBRKGkRD1fxznQnsDjdnefmIVXgLTdAa8eyY8 bbuvuX7ZMeFX1vaEkxpcYwySBL0ud3lJG16axSapKHqWBzscFG7Qtc+Mdl2uIPYfuue5 mzrWqnfUiktdKCnjKfT3H6P7eRpaUz8chsMgonF33es5fVsQwMaYpX7Fuhxx5OVpwRno 54vCCgCWXmyRHkVXM4QIxHT7NXGvWOprgs2jQ4z0qxhv3bQcm415HJ9YtxgfVkn7tU9H tGsm1MjlR6yUSpx5Bv9KF8kNK/7F23Ipc8GGbAu8cPobt9pJz3qjTDoBy732j8SEPfHy HQow== X-Gm-Message-State: ANoB5pmQlQ5RtCM+2Dgv/Fk6ga0YsyW1Z/KAPLq6gVNKIEXb1dxYWNwa djoUiPKzKVOMGkbzTFtEWK0= X-Google-Smtp-Source: AA0mqf54HzZt/vnsD0uY7WJeKsPVJ/+Ny1uYvojjmdy2VycHcZUONM0zQ/Raq8/e4SvXTSVvBKAszQ== X-Received: by 2002:a05:600c:430c:b0:3cf:8ed7:7124 with SMTP id p12-20020a05600c430c00b003cf8ed77124mr36496111wme.140.1669556491514; Sun, 27 Nov 2022 05:41:31 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id f10-20020a5d58ea000000b0022e6178bd84sm8228060wrd.8.2022.11.27.05.41.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Nov 2022 05:41:30 -0800 (PST) Message-ID: <6ccdea49-cf77-e9d6-f094-9087a74e3798@yandex.ru> Date: Sun, 27 Nov 2022 15:41:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: bug#59575: 29.0.50; add-log-current-defun-header-regexp matches Windows drive letter Content-Language: en-US To: Juanma Barranquero References: <83zgcdsw90.fsf@gnu.org> <8273f7a6-23d2-b5b6-ffe3-cb3d0f0c26f8@yandex.ru> From: Dmitry Gutov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 59575 Cc: Eli Zaretskii , 59575@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On 27/11/22 15:18, Juanma Barranquero wrote: > On Sun, Nov 27, 2022 at 2:05 PM Dmitry Gutov > wrote: > >> I don't mind this approach either, but given that the "definitions" in >> Xref buffers are often only 1 line long, or maybe a few, wouldn't >> showing the file name again somewhere nearby (e.g. the header bar) just >> be redundant? > > Sometimes you've got a lot of matches. Also, I tend to display the > output of xref (and, generally speaking, of all kinds of > "locating"/"matching" functions, like occur, etc) in small windows, > usually less than ten lines high. And anyway, this won't bother anyone > who's not already using which-func. Yeah, okay. Sounds good. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 27 09:03:26 2022 Received: (at 59575-done) by debbugs.gnu.org; 27 Nov 2022 14:03:26 +0000 Received: from localhost ([127.0.0.1]:42310 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozIFi-00052q-Cz for submit@debbugs.gnu.org; Sun, 27 Nov 2022 09:03:26 -0500 Received: from mail-ej1-f51.google.com ([209.85.218.51]:37603) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozIFg-00052i-Nm for 59575-done@debbugs.gnu.org; Sun, 27 Nov 2022 09:03:25 -0500 Received: by mail-ej1-f51.google.com with SMTP id ud5so20076724ejc.4 for <59575-done@debbugs.gnu.org>; Sun, 27 Nov 2022 06:03:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=lKEgEvGfytqj6dx0GW4RppKN1dmJG+vjDWpc+SDnicw=; b=ZZrxDz72FD3yB2Y4cnG+Bx1tikr7RFikBbYRnjAHAGa9DI71E47OttH64c/ghaBkcK FqG2ChOXJwSXqecX3F8w2hKdBv25jbVjL1/cY6nsOnTXpxR+UvvdPfS2+CAW0tuY9kGL KLmEgJxkR+TLdj/eWsEc5TfLdl6Zs1d1K5PWZv+JejJ63/ekpT/kBnq0264cvzD+O1k/ 7IDH4vvM45TfHMoAWG5b7b927N1f1xslWdW/SJHzZkJudHfXoZ5GDGn9kP4Dr/N7R4vL Owc+qDF9H/zTa8hAKq0nTXDOipsMt3sCiSCKECmqeJJ/84m7qrrR9S7hpM9ERp/OXHnn 2+sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lKEgEvGfytqj6dx0GW4RppKN1dmJG+vjDWpc+SDnicw=; b=ZlYA4sW2TtW6181mAisTTVsqI+wZY1947s9qPmuhkdKxGIzX2muvV7KxyJZY3EiwBf c0bJ20IU7NXl/jAC6Dgn9K7GF/JquHlUym4gGdQu/CXC1Pg3ivUYOCWTJ1pXSULHQTWb JVJaKsMHPOhPjpPNEorp8vkTRKWr2eadST1B+hWwLmV/Pg5NRQMH1Q0exB6HWa+wooke IVEUOS9zOGraNe0A1KmOtI4dgiIbjN4RA/XRNgPdQZIyydmf50sE62HLib9ZBjnmb/wc vqvDQZa1dqM0+sy5AmlE4hSsiCMoFgRTY/RH84Zho50jVrxpf5QPcgkXPh/tMmrNE/sN +mkg== X-Gm-Message-State: ANoB5plzCRu/zYwTN+60x/pJ388xSvcfDbfKM73J5avV/K2HhUh0XLyT fUcOXN9/IseKvlk6bd2tEWG7XVC4kGSynY25ZcE= X-Google-Smtp-Source: AA0mqf7RcB/DF9ekGEvdbbNv9l95pIhBTfKaAnp5gY4RR5GeulxUeoThq08PbGhjjrs53VyIjlVVub6aHAfFR+64Ge0= X-Received: by 2002:a17:906:914d:b0:7af:113a:7416 with SMTP id y13-20020a170906914d00b007af113a7416mr39637330ejw.16.1669557798745; Sun, 27 Nov 2022 06:03:18 -0800 (PST) MIME-Version: 1.0 References: <83zgcdsw90.fsf@gnu.org> <8273f7a6-23d2-b5b6-ffe3-cb3d0f0c26f8@yandex.ru> <6ccdea49-cf77-e9d6-f094-9087a74e3798@yandex.ru> In-Reply-To: <6ccdea49-cf77-e9d6-f094-9087a74e3798@yandex.ru> From: Juanma Barranquero Date: Sun, 27 Nov 2022 15:02:42 +0100 Message-ID: Subject: Re: bug#59575: 29.0.50; add-log-current-defun-header-regexp matches Windows drive letter To: Dmitry Gutov Content-Type: multipart/alternative; boundary="00000000000086bbf205ee7437b4" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59575-done Cc: Eli Zaretskii , 59575-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000086bbf205ee7437b4 Content-Type: text/plain; charset="UTF-8" Fixed in commit 31cfd6d311 of 2022-11-27 Fix xref interaction with which-func (bug#59575) --00000000000086bbf205ee7437b4 Content-Type: text/html; charset="UTF-8"
Fixed in commit 31cfd6d311 of 2022-11-27
Fix xref interaction with which-func (bug#59575)
--00000000000086bbf205ee7437b4-- From unknown Sat Aug 16 20:58:02 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 26 Dec 2022 12:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator