Subject: Re: [bug#59569] [PATCH 1/2] gnu: Add gst-plugins-good-qt.

From: "(" <[email-masked]>
Date: Fri, 25 Nov 2022 15:57:04 +0000

On Fri Nov 25, 2022 at 11:13 AM GMT, Martin Schmidt wrote:
> * gnu/packages/gstreamer.scm (gst-plugins-good-qt): New variable.

> --- a/gnu/packages/gstreamer.scm
> +++ b/gnu/packages/gstreamer.scm

> @@ -734,6 +734,27 @@ (define libsoup

> +(define-public gst-plugins-good-qt
> +  (package (inherit gst-plugins-good)
> +    (name "gst-plugins-good-qt")
> +    (build-system meson-build-system)
> +
> +    (inputs
> +     (modify-inputs (package-inputs gst-plugins-good)
> +		    (prepend qtbase-5 qtdeclarative-5 qtx11extras qtwayland-5)))
> +
> +    (arguments
> +     (substitute-keyword-arguments (package-arguments gst-plugins-good)
> +				   ((#:configure-flags flags #~'())
> +				    #~(list "-Dgst-plugins-good:qt5=enabled" ))

> +
> +
> +))))

Indentation is... a wee bit off :) Also, the build-system override is a no-op.

Try this instead:

  (define-public gst-plugins-good-qt
    (package
      (inherit gst-plugins-good)
      (arguments
       (substitute-keyword-arguments
           (package-arguments gst-plugins-good)
         ((#:configure-flags flags)
          #~(cons "-Dgst-plugins-good:qt5=enabled"
                  flags))))
      (inputs
       (modify-inputs (package-inputs gst-plugins-good)
         (prepend qtbase-5
                  qtdeclarative-5
                  qtwayland-5
                  qtx11extras)))))

    -- (