GNU bug report logs - #5956
[PATCH] cp: preserve "capabilities" when also preserving file ownership

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Pádraig Brady <P <at> draigBrady.com>
Subject: bug#5956 closed by Pádraig Brady <P <at> draigBrady.com>
 (Re: bug#5956: [PATCH] cp: preserve "capabilities" when also preserving
 file ownership)
Date: Fri, 16 Apr 2010 22:14:02 +0000

[Message part 1 (text/plain, inline)]

This is an automatic notification regarding your bug report
which was filed against the coreutils package:

#5956: [PATCH] cp: preserve "capabilities" when also preserving file ownership

It has been closed by Pádraig Brady <P <at> draigBrady.com>.

Their explanation is attached below along with your original report.
If this explanation is unsatisfactory and you have not received a
better one in a separate message then please contact Pádraig Brady <P <at> draigBrady.com> by
replying to this email.


-- 
5956: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=5956
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Pádraig Brady <P <at> draigBrady.com>
To: Jim Meyering <jim <at> meyering.net>
Cc: 5956-done <at> debbugs.gnu.org
Subject: Re: bug#5956: [PATCH] cp: preserve "capabilities" when also preserving
	file ownership
Date: Fri, 16 Apr 2010 23:12:59 +0100

On 16/04/10 21:13, Jim Meyering wrote:
> Pádraig Brady wrote:
>> `sudo cp -a non-root-file copy` would not preserve capabilities.
>> The attached fixes this and passes all tests.
> ...
>> Subject: [PATCH] cp: preserve "capabilities" when also preserving file ownership
>>
>> * src/copy.c (copy_reg): Copy xattrs _after_ setting file ownership
>> so that capabilities are not cleared when setting ownership.
>> * tests/cp/capability: A new root test.
>> * tests/Makefile.am (root_tests): Reference the new test.
>> * NEWS: Mention the fix.
> 
> Good catch!
> The patch looks fine.
> Some tiny suggestions:

Thanks for the review.
I've just pushed that.

cheers,
Pádraig.

[Message part 3 (message/rfc822, inline)]

From: Pádraig Brady <P <at> draigBrady.com>
To: Report bugs to <bug-coreutils <at> gnu.org>
Subject: [PATCH] cp: preserve "capabilities" when also preserving file
	ownership
Date: Fri, 16 Apr 2010 09:41:00 +0100

[Message part 4 (text/plain, inline)]

`sudo cp -a non-root-file copy` would not preserve capabilities.
The attached fixes this and passes all tests.

cheers,
Pádraig.

[cp-capabilities.diff (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.