GNU bug report logs - #5956
[PATCH] cp: preserve "capabilities" when also preserving file ownership

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Pádraig Brady <P <at> draigBrady.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#5956: marked as done ([PATCH] cp: preserve "capabilities"
 when also preserving file ownership)
Date: Fri, 16 Apr 2010 22:14:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 16 Apr 2010 23:12:59 +0100
with message-id <4BC8E0EB.3080802 <at> draigBrady.com>
and subject line Re: bug#5956: [PATCH] cp: preserve "capabilities" when also preserving file ownership
has caused the GNU bug report #5956,
regarding [PATCH] cp: preserve "capabilities" when also preserving file ownership
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact help-debbugs <at> gnu.org
immediately.)


-- 
5956: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=5956
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Pádraig Brady <P <at> draigBrady.com>
To: Report bugs to <bug-coreutils <at> gnu.org>
Subject: [PATCH] cp: preserve "capabilities" when also preserving file
	ownership
Date: Fri, 16 Apr 2010 09:41:00 +0100

[Message part 3 (text/plain, inline)]

`sudo cp -a non-root-file copy` would not preserve capabilities.
The attached fixes this and passes all tests.

cheers,
Pádraig.

[cp-capabilities.diff (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Pádraig Brady <P <at> draigBrady.com>
To: Jim Meyering <jim <at> meyering.net>
Cc: 5956-done <at> debbugs.gnu.org
Subject: Re: bug#5956: [PATCH] cp: preserve "capabilities" when also preserving
	file ownership
Date: Fri, 16 Apr 2010 23:12:59 +0100

On 16/04/10 21:13, Jim Meyering wrote:
> Pádraig Brady wrote:
>> `sudo cp -a non-root-file copy` would not preserve capabilities.
>> The attached fixes this and passes all tests.
> ...
>> Subject: [PATCH] cp: preserve "capabilities" when also preserving file ownership
>>
>> * src/copy.c (copy_reg): Copy xattrs _after_ setting file ownership
>> so that capabilities are not cleared when setting ownership.
>> * tests/cp/capability: A new root test.
>> * tests/Makefile.am (root_tests): Reference the new test.
>> * NEWS: Mention the fix.
> 
> Good catch!
> The patch looks fine.
> Some tiny suggestions:

Thanks for the review.
I've just pushed that.

cheers,
Pádraig.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.