GNU bug report logs - #5955
completions in M-x find-library include .elc files

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#5955: closed (completions in M-x find-library include .elc files)
Date: Thu, 19 Aug 2010 21:33:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 19 Aug 2010 23:24:29 +0200
with message-id <jwvvd76xqra.fsf-monnier+emacs <at> gnu.org>
and subject line Re: bug#5955: completions in M-x find-library include .elc files
has caused the GNU bug report #5955,
regarding completions in M-x find-library include .elc files
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
5955: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=5955
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: "Aaron S. Hawley" <aaron.s.hawley <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: completions in M-x find-library include .elc files
Date: Thu, 15 Apr 2010 22:28:57 -0400

Typing TAB or ? in M-x find-library shows .el and .elc files when it
probably should just be the name of the library without the extension.
 Appears that this is a general problem with
locate-file-completion-table in files.el.  It appears to put all files
in to the completion table without condition.  The fix is just
removing the first `push' operation.

=== modified file 'lisp/files.el'
--- lisp/files.el	2010-03-31 01:51:54 +0000
+++ lisp/files.el	2010-04-16 01:57:24 +0000
@@ -760,7 +760,6 @@
 	(when (file-directory-p dir)
 	  (dolist (file (file-name-all-completions
 			 string-file dir))
-	    (push file names)
 	    (when (string-match suffix file)
 	      (setq file (substring file 0 (match-beginning 0)))
               (push file names)))))

Hope this can get fixed.  I'd love to have the size of my
*completions* buffers reduced by a factor of 3!

Thanks for Emacs,
/a

[Message part 3 (message/rfc822, inline)]

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: "Aaron S. Hawley" <aaron.s.hawley <at> gmail.com>
Subject: Re: bug#5955: completions in M-x find-library include .elc files
Date: Thu, 19 Aug 2010 23:24:29 +0200

>> BTW, please try the patch below, to see if you like the
>> resulting behavior.
> Interesting idea.  Show matches for more than one library without
> suffixes, but if there is only one match show the possible extensions.
> I'd say this is an improvement for users over the current behavior.

I've installed this change (well, a slightly different version).

> However, some libraries names are a prefix for another.  So really,

Yes, it's not perfect, but I think it's good enough.  I don't think it's
a clean enough behavior to warrant documenting.


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.