GNU bug report logs - #59548
[PATCH] Include the package name in package-vc--unpack's prompt

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 59548 in the body.
You can then email your comments to 59548 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: daanturo <daanturo <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Include the package name in package-vc--unpack's prompt
Date: Fri, 25 Nov 2022 00:12:37 +0700

[Message part 1 (text/plain, inline)]

--=-=-=
Content-Type: text/plain

Tags: patch


Make the prompt a bit more informative, as sometimes I am presented with

this question at startup without even knowing the cause.


-- 
Daanturo.

[0001-More-informant-prompt-for-package-vc-unpack.patch (text/x-patch, attachment)]

Message #10 received at 59548 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: daanturo <daanturo <at> gmail.com>
Cc: Philip Kaludercic <philipk <at> posteo.net>, 59548 <at> debbugs.gnu.org
Subject: Re: bug#59548: [PATCH] Include the package name in
 package-vc--unpack's prompt
Date: Thu, 24 Nov 2022 15:27:41 -0800

daanturo <daanturo <at> gmail.com> writes:

> Tags: patch
>
> Make the prompt a bit more informative, as sometimes I am presented with
> this question at startup without even knowing the cause.

LGTM.  Philip, WDYT?

> From dba6787f0cb1e92f3c9eb62b1f7d9ab6599c43a1 Mon Sep 17 00:00:00 2001
> From: Daanturo <daanturo <at> gmail.com>
> Date: Fri, 25 Nov 2022 00:06:37 +0700
> Subject: [PATCH] More informant prompt for package-vc--unpack
>
> * lisp/emacs-lisp/package-vc.el (package-vc--unpack): show the package's
> name while asking whether to overwrite its previous checkout.
> ---
>  lisp/emacs-lisp/package-vc.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el
> index bf1ea2bdf4..a9c1bbfe60 100644
> --- a/lisp/emacs-lisp/package-vc.el
> +++ b/lisp/emacs-lisp/package-vc.el
> @@ -523,7 +523,7 @@ package-vc--unpack
>                 (pkg-dir (expand-file-name dirname package-user-dir)))
>      (setf (package-desc-dir pkg-desc) pkg-dir)
>      (when (file-exists-p pkg-dir)
> -      (if (yes-or-no-p "Overwrite previous checkout?")
> +      (if (yes-or-no-p (format "Overwrite %s's previous checkout?" name))
>            (package--delete-directory pkg-dir)
>          (error "There already exists a checkout for %s" name)))
>      (package-vc--clone pkg-desc pkg-spec pkg-dir rev)

Message #13 received at 59548 <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: 59548 <at> debbugs.gnu.org, daanturo <daanturo <at> gmail.com>
Subject: Re: bug#59548: [PATCH] Include the package name in
 package-vc--unpack's prompt
Date: Fri, 25 Nov 2022 07:31:01 +0000

Stefan Kangas <stefankangas <at> gmail.com> writes:

> daanturo <daanturo <at> gmail.com> writes:
>
>> Tags: patch
>>
>> Make the prompt a bit more informative, as sometimes I am presented with
>> this question at startup without even knowing the cause.
>
> LGTM.  Philip, WDYT?

Likewise, can you push the patch?  Otherwise I'll do so some time later.

>> From dba6787f0cb1e92f3c9eb62b1f7d9ab6599c43a1 Mon Sep 17 00:00:00 2001
>> From: Daanturo <daanturo <at> gmail.com>
>> Date: Fri, 25 Nov 2022 00:06:37 +0700
>> Subject: [PATCH] More informant prompt for package-vc--unpack
>>
>> * lisp/emacs-lisp/package-vc.el (package-vc--unpack): show the package's
>> name while asking whether to overwrite its previous checkout.
>> ---
>>  lisp/emacs-lisp/package-vc.el | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el
>> index bf1ea2bdf4..a9c1bbfe60 100644
>> --- a/lisp/emacs-lisp/package-vc.el
>> +++ b/lisp/emacs-lisp/package-vc.el
>> @@ -523,7 +523,7 @@ package-vc--unpack
>>                 (pkg-dir (expand-file-name dirname package-user-dir)))
>>      (setf (package-desc-dir pkg-desc) pkg-dir)
>>      (when (file-exists-p pkg-dir)
>> -      (if (yes-or-no-p "Overwrite previous checkout?")
>> +      (if (yes-or-no-p (format "Overwrite %s's previous checkout?" name))
>>            (package--delete-directory pkg-dir)
>>          (error "There already exists a checkout for %s" name)))
>>      (package-vc--clone pkg-desc pkg-spec pkg-dir rev)

Message #18 received at 59548-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: 59548-done <at> debbugs.gnu.org, daanturo <daanturo <at> gmail.com>
Subject: Re: bug#59548: [PATCH] Include the package name in
 package-vc--unpack's prompt
Date: Fri, 25 Nov 2022 00:04:06 -0800

Philip Kaludercic <philipk <at> posteo.net> writes:

> Likewise, can you push the patch?

Thanks, I pushed it with this modified commit message:

    Show package name in package-vc--unpack prompt

    * lisp/emacs-lisp/package-vc.el (package-vc--unpack): Display the
    package name when asking whether to overwrite its previous
    checkout.  (Bug#59548)

I also tweaked the message to:

    Overwrite previous checkout for package `%s'?

See commit c7a7488c52.  Closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.