GNU bug report logs - #59544
[PATCH] Fixed lib-src/etags.c command execute vulnerability

Previous Next

Full log

Message #82 received at 59544 <at> debbugs.gnu.org (full text, mbox):

From: lux <lx <at> shellcodes.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 59544 <at> debbugs.gnu.org, stefankangas <at> gmail.com
Subject: Re: bug#59544: [PATCH] Fixed lib-src/etags.c command execute
 vulnerability
Date: Sun, 27 Nov 2022 11:05:37 +0800

[Message part 1 (text/plain, inline)]

On 2022/11/27 01:11, Eli Zaretskii wrote:
>> Date: Sun, 27 Nov 2022 01:03:10 +0800
>> Cc: stefankangas <at> gmail.com, 59544 <at> debbugs.gnu.org
>> From: lux <lx <at> shellcodes.org>
>>
>> I'm going to add the xxx parameter. If it is true, the line break will
>> be kept. Is this logic consistent with what you expressed? thank you
>> very much.
> Much simpler:
>
> static ptrdiff_t
> readline_internal (linebuffer *lbp, FILE *stream, char const *filename, bool leave_cr)
> {
>   [...]
>        if (c == '\n')
> 	{
> 	  if (!leave_cr && p > buffer && p[-1] == '\r')
> 	    {
>   [...]
>
> IOW, when this flag is TRUE, don't process \r specially.
>
> Thanks.

Ok,  edited and added test case,  and move the patch code to the new 
function `clean_matched_file_tag`.

Thanks.

[0001-Fixed-ctags-local-command-execute-vulnerability.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.