GNU bug report logs - #59544
[PATCH] Fixed lib-src/etags.c command execute vulnerability

Previous Next

Full log

Message #79 received at 59544 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: lux <lx <at> shellcodes.org>
Cc: 59544 <at> debbugs.gnu.org, stefankangas <at> gmail.com
Subject: Re: bug#59544: [PATCH] Fixed lib-src/etags.c command execute
 vulnerability
Date: Sat, 26 Nov 2022 19:11:29 +0200

> Date: Sun, 27 Nov 2022 01:03:10 +0800
> Cc: stefankangas <at> gmail.com, 59544 <at> debbugs.gnu.org
> From: lux <lx <at> shellcodes.org>
> 
> I'm going to add the xxx parameter. If it is true, the line break will 
> be kept. Is this logic consistent with what you expressed? thank you 
> very much.

Much simpler:

static ptrdiff_t
readline_internal (linebuffer *lbp, FILE *stream, char const *filename, bool leave_cr)
{
 [...]
      if (c == '\n')
	{
	  if (!leave_cr && p > buffer && p[-1] == '\r')
	    {
 [...]

IOW, when this flag is TRUE, don't process \r specially.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.