GNU bug report logs - #59523
[PATCH] doc: contributing: Note '-v REVISION' bug in 'git send-email'.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#59523: closed ([PATCH] doc: contributing: Note '-v REVISION'
 bug in 'git send-email'.)
Date: Tue, 21 Mar 2023 12:42:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 21 Mar 2023 08:41:47 -0400
with message-id <87mt46s2d0.fsf_-_ <at> gmail.com>
and subject line Re: bug#59523: [PATCH] doc: contributing: Note '-v REVISION' bug in 'git send-email'.
has caused the debbugs.gnu.org bug report #59523,
regarding [PATCH] doc: contributing: Note '-v REVISION' bug in 'git send-email'.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
59523: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59523
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: "(" <paren <at> disroot.org>
To: guix-patches <at> gnu.org
Cc: "\(" <paren <at> disroot.org>
Subject: [PATCH] doc: contributing: Note '-v REVISION' bug in 'git send-email'.
Date: Wed, 23 Nov 2022 19:07:10 +0000

* doc/contributing.texi ("Submitting Patches")["Sending a Patch Series"]:
Note that a bug in 'git send-email' means '-v REVISION' (with a
space) will not work.
---
Heya Guix,

Turns out that due to a bug in ``git send-email'', using ``-v 2'' with
a space between the flag and the argument won't work. If you try it, it'll
print a confusing error message, so this patch updates the manual to note
this and remove the space in an example that uses it.

  -- (

 doc/contributing.texi | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/doc/contributing.texi b/doc/contributing.texi
index 40ae33ecac..913c7cf436 100644
--- a/doc/contributing.texi
+++ b/doc/contributing.texi
@@ -1462,10 +1462,16 @@ address and the @option{-v} flag with @command{git send-email}.
 
 @example
 $ git commit -a
-$ git send-email -1 -a --base=auto -v @var{REVISION} \
+$ git send-email -1 -a --base=auto -v <at> var{REVISION} \
       --to=@var{ISSUE_NUMBER}@@debbugs.gnu.org
 @end example
 
+@quotation Note
+Due to an apparent bug in @command{git send-email},
+@option{-v @var{REVISION}} (with the space) will not work; you
+@emph{must} use @option{-v <at> var{REVISION}}.
+@end quotation
+
 You can find out @var{ISSUE_NUMBER} either by searching on the mumi
 interface at @url{issues.guix.gnu.org} for the name of your patch or
 reading the acknowledgement email sent automatically by Debbugs in

base-commit: d33ed58169edc027cfb6c256ecabde87e59918ed
-- 
2.38.1

[Message part 3 (message/rfc822, inline)]

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Christopher Baines <mail <at> cbaines.net>
Cc: "\(" <paren <at> disroot.org>, 59523-done <at> debbugs.gnu.org
Subject: Re: bug#59523: [PATCH] doc: contributing: Note '-v REVISION' bug in
 'git send-email'.
Date: Tue, 21 Mar 2023 08:41:47 -0400

Hi,

Christopher Baines <mail <at> cbaines.net> writes:

> "( via Guix-patches" via <guix-patches <at> gnu.org> writes:
>
>> * doc/contributing.texi ("Submitting Patches")["Sending a Patch Series"]:
>> Note that a bug in 'git send-email' means '-v REVISION' (with a
>> space) will not work.
>> ---
>>  doc/contributing.texi | 8 +++++++-
>>  1 file changed, 7 insertions(+), 1 deletion(-)
>
> I've pushed this to master now as
> 09cd488c973c2ea27cfa2224489aca317f596341.

OK! Don't forget to revert when git 2.40 lands in master, as it includes
a fix.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.