From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 15 01:14:20 2010 Received: (at submit) by debbugs.gnu.org; 15 Apr 2010 05:14:20 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O2HPA-0007z5-J2 for submit@debbugs.gnu.org; Thu, 15 Apr 2010 01:14:20 -0400 Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O2HP9-0007z0-4Q for submit@debbugs.gnu.org; Thu, 15 Apr 2010 01:14:19 -0400 Received: from lists.gnu.org ([199.232.76.165]:45600) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1O2HP5-0002l8-Mg for submit@debbugs.gnu.org; Thu, 15 Apr 2010 01:14:15 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O2HP4-0003Yd-SK for bug-gnu-emacs@gnu.org; Thu, 15 Apr 2010 01:14:14 -0400 Received: from [140.186.70.92] (port=37742 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O2HOy-0003X5-VO for bug-gnu-emacs@gnu.org; Thu, 15 Apr 2010 01:14:13 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.0 (2010-01-18) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,T_DKIM_INVALID,T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.0 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O2HOx-0007YV-Pt for bug-gnu-emacs@gnu.org; Thu, 15 Apr 2010 01:14:08 -0400 Received: from mail-vw0-f41.google.com ([209.85.212.41]:36826) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O2HOx-0007YN-Mv for bug-gnu-emacs@gnu.org; Thu, 15 Apr 2010 01:14:07 -0400 Received: by vws8 with SMTP id 8so513911vws.0 for ; Wed, 14 Apr 2010 22:14:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :reply-to:user-agent:mime-version:to:subject:content-type :content-transfer-encoding; bh=ipUILTB3H34paOeChrKzugnamqkFbCUbU/62dmSvHgY=; b=fieUu1fZoRhCIkRjY3yMUHv41sqC9KrPs80jbHMsuAlNdTrHjc9FwIBV4xXLyBEI6E Tui2uRRjrof/mwfihmb3r+3989Jo+ayynPPsZSr1tTsjoZos/AHahbufFrpHwIx0+INn XwGN7MD+14ivT7L/rOhbfV4dox8uiHXW3+wSs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:reply-to:user-agent:mime-version:to :subject:content-type:content-transfer-encoding; b=QWVLOjS/o9kr01bisCD1ZetKXJNbjiJyC3ZPE34RfhL3iiQ8057rSYBZPYNGOGgxwg z/pCQhezVquizRHAZjs68XqZcnNk9hFNyL0Fmv5TQGkyTEVvO+35O8frC0Gk/4f3co0c 5cS7Xh7krCWG5bMpM8LDFy+mgzKS+S2KkPvVg= Received: by 10.220.60.135 with SMTP id p7mr4775480vch.155.1271308446774; Wed, 14 Apr 2010 22:14:06 -0700 (PDT) Received: from [114.51.149.18] (EM114-51-149-18.pool.e-mobile.ne.jp [114.51.149.18]) by mx.google.com with ESMTPS id 22sm23495429vws.3.2010.04.14.22.14.03 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 14 Apr 2010 22:14:06 -0700 (PDT) Message-ID: <4BC6A096.8030801@yahoo.co.jp> Date: Thu, 15 Apr 2010 14:13:58 +0900 From: IRIE Shinsuke User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.9) Gecko/20100404 Thunderbird/3.0.4 MIME-Version: 1.0 To: bug-gnu-emacs@gnu.org Subject: defvaralias after defvar should be warned in runtime Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -3.9 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: irieshinsuke@yahoo.co.jp List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.0 (----) Please consider below: We assume an user wrote .emacs file as: (setq old-foo 123) (load "bar") Here, bar.el includes the following: (defvar foo 456) (define-obsolete-variable-alias 'old-foo 'foo) By this .emacs setting, the user probably hopes `old-foo' remains 123 after loading bar.el, but actually it will be changed to 456. This behavior is inconsistent with the principle that `defvar' must not override existing value, so bar.el should be modified as: (define-obsolete-variable-alias 'old-foo 'foo) (defvar foo 456) I think the programs like bar.el should be warned when running (and byte-compiling, if possible). -- IRIE Shinsuke, Ph.D. From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 15 16:13:33 2010 Received: (at 5950) by debbugs.gnu.org; 15 Sep 2010 20:13:33 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OvyMG-0005MU-MQ for submit@debbugs.gnu.org; Wed, 15 Sep 2010 16:13:32 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OvyME-0005MP-KW for 5950@debbugs.gnu.org; Wed, 15 Sep 2010 16:13:31 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1OvyOh-0000G9-Tv; Wed, 15 Sep 2010 16:16:03 -0400 To: IRIE Shinsuke Subject: Re: bug#5950: defvaralias after defvar should be warned in runtime References: <4BC6A096.8030801@yahoo.co.jp> From: Glenn Morris X-Spook: White Water nitrate Uzi brigand e-bomb covert video X-Ran: yY@l@pG>(>Lo0uU2AdMd~3Bjr~a%ni/sg2,$KQf9Gy'zx:aWg__}wxl:I=3G|3o*TKK?w% X-Hue: green X-Debbugs-No-Ack: yes X-Attribution: GM Date: Wed, 15 Sep 2010 16:16:03 -0400 In-Reply-To: <4BC6A096.8030801@yahoo.co.jp> (IRIE Shinsuke's message of "Thu\, 15 Apr 2010 14\:13\:58 +0900") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.4 (-----) X-Debbugs-Envelope-To: 5950 Cc: 5950@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.2 (------) IRIE Shinsuke wrote: > We assume an user wrote .emacs file as: > > (setq old-foo 123) > (load "bar") > > Here, bar.el includes the following: > > (defvar foo 456) > (define-obsolete-variable-alias 'old-foo 'foo) > > By this .emacs setting, the user probably hopes `old-foo' remains 123 > after loading bar.el, but actually it will be changed to 456. [...] > I think the programs like bar.el should be warned when running (and > byte-compiling, if possible). You can never have too many compilation warnings... Here is an attempt at this. Comments: 1) It gives a spurious warning in cases where the define-obsolete-variable-alias statement is autoloaded. One could simply reposition such statements anyway. 2) I never know when to use normal-call or keep-pending. It does reveal a couple of bugs in the current trunk. *** lisp/emacs-lisp/bytecomp.el 2010-09-15 15:30:43 +0000 --- lisp/emacs-lisp/bytecomp.el 2010-09-15 18:59:50 +0000 *************** *** 3874,3879 **** --- 3874,3892 ---- (byte-compile-set-symbol-position 'lambda) (error "`lambda' used as function name is invalid")) + (put 'define-obsolete-variable-alias 'byte-hunk-handler + 'byte-compile-define-obsolete-variable-alias) + ;; Gives a spurious warning if the d-o-v-a is autoloaded. + (defun byte-compile-define-obsolete-variable-alias (form) + (and (byte-compile-warning-enabled-p 'suspicious) + (eq (car-safe (nth 2 form)) 'quote) + (memq (car-safe (cdr (nth 2 form))) byte-compile-bound-variables) + (not (memq (cadr (nth 2 form)) byte-compile-const-variables)) + (byte-compile-warn "variable `%s' aliased after definition" + (cadr (nth 2 form)))) + (byte-compile-keep-pending form) + nil) + ;; Compile normally, but deal with warnings for the function being defined. (put 'defalias 'byte-hunk-handler 'byte-compile-file-form-defalias) (defun byte-compile-file-form-defalias (form) From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 15 20:42:31 2010 Received: (at 5950) by debbugs.gnu.org; 16 Sep 2010 00:42:31 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ow2YZ-00073a-5f for submit@debbugs.gnu.org; Wed, 15 Sep 2010 20:42:31 -0400 Received: from mail-pv0-f172.google.com ([74.125.83.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ow2YW-00073T-UE for 5950@debbugs.gnu.org; Wed, 15 Sep 2010 20:42:29 -0400 Received: by pvg7 with SMTP id 7so210628pvg.3 for <5950@debbugs.gnu.org>; Wed, 15 Sep 2010 17:44:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:date:message-id:from :to:cc:subject:in-reply-to:references:user-agent:mime-version :content-type; bh=xuoAmvYKLOOMk0gN2ivQqvJFpxU1fHt1buPZUX9pvkY=; b=PbC66tVpJTxnPORk2jdnqGiGnjcG+mjL5e1lJ/1dmVYBqamJ6OjsuxzOBPIGD8zf7C jDOA5L39WdFqs9/LTDhPD/89wmBgfRSugvsJ3ld/idoSPZvFb1R7dMZzZQwYej3iDvp7 Zqt5B4z7xujNtrsSlC90u/JlzQ5qPrK21jPi8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:date:message-id:from:to:cc:subject:in-reply-to:references :user-agent:mime-version:content-type; b=Eh8kUzcvzcoIvSoq4nR64YuuJ2zGeFH06yT8x5SLPvh2iPzWDwqm7cHj/ptQ1RryW5 /+gRuP+r9iSdgwtZ9U3QnDwJ5cDvFKPSY5aneovnfJAQm59QF1tV5h9SaN3R9Yrnn4zZ 2nr90iiZO72HAVuZhlVI+qqQBimp4Sk8R/Vs4= Received: by 10.142.90.10 with SMTP id n10mr2085320wfb.241.1284597886454; Wed, 15 Sep 2010 17:44:46 -0700 (PDT) Received: from piyo.gmail.com (EM114-51-144-173.pool.e-mobile.ne.jp [114.51.144.173]) by mx.google.com with ESMTPS id i20sm1361266wff.17.2010.09.15.17.44.43 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 15 Sep 2010 17:44:45 -0700 (PDT) Date: Thu, 16 Sep 2010 09:44:55 +0900 Message-ID: <87r5gu34ag.wl%irieshinsuke@yahoo.co.jp> From: IRIE Shinsuke To: Glenn Morris Subject: Re: bug#5950: defvaralias after defvar should be warned in runtime In-Reply-To: References: <4BC6A096.8030801@yahoo.co.jp> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?ISO-2022-JP-2?B?R29qGyQoRCtXGyhC?=) APEL/10.7 Emacs/23.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 5950 Cc: 5950@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) I think the byte-hunk-handler should be put to `defvaralias' rather than `define-obsolete-variable-alias'. `defvaralias' is a primitive function which causes the problem in `define-obsolete-variable-alias' macro. Thanks. IRIE Shinsuke From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 15 23:48:27 2010 Received: (at 5950) by debbugs.gnu.org; 16 Sep 2010 03:48:27 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ow5SV-0008Cm-4T for submit@debbugs.gnu.org; Wed, 15 Sep 2010 23:48:27 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ow5SS-0008Cg-Mm for 5950@debbugs.gnu.org; Wed, 15 Sep 2010 23:48:25 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1Ow5Uz-0006Ym-3u; Wed, 15 Sep 2010 23:51:01 -0400 To: IRIE Shinsuke Subject: Re: bug#5950: defvaralias after defvar should be warned in runtime References: <4BC6A096.8030801@yahoo.co.jp> <87r5gu34ag.wl%irieshinsuke@yahoo.co.jp> From: Glenn Morris X-Spook: encryption event security Firewalls computer terrorism X-Ran: _s%JdVWYpu9O~G+0@6e.a->YB&XX&9OxK4o\&jQSsO/%'DeEMBymhE|-Q>cs`AUW??x;f{ X-Hue: black X-Debbugs-No-Ack: yes X-Attribution: GM Date: Wed, 15 Sep 2010 23:51:00 -0400 In-Reply-To: <87r5gu34ag.wl%irieshinsuke@yahoo.co.jp> (IRIE Shinsuke's message of "Thu\, 16 Sep 2010 09\:44\:55 +0900") Message-ID: <3keicu1h3v.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.2 (------) X-Debbugs-Envelope-To: 5950 Cc: 5950@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.2 (------) IRIE Shinsuke wrote: > I think the byte-hunk-handler should be put to `defvaralias' rather than > `define-obsolete-variable-alias'. `defvaralias' is a primitive function > which causes the problem in `define-obsolete-variable-alias' macro. The issue _is_ with defvaralias, but it's only a problem for user options, things that might be set in .emacs before the associated alias definition is evaluated. It's hard to see why there should be non-obsolete aliases to user options, it just causes confusion. I think there would be false positives if the warning was associated with defvaralias, which is mostly used with non-user-options, I would think. The last time a similar issue came up, Stefan preferred that only define-obsolete-variable-alias be changed; see http://debbugs.gnu.org/cgi/bugreport.cgi?bug=4706#21 From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 16 05:25:45 2010 Received: (at 5950) by debbugs.gnu.org; 16 Sep 2010 09:25:45 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OwAiu-0002xk-VO for submit@debbugs.gnu.org; Thu, 16 Sep 2010 05:25:45 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OwAis-0002xc-U0 for 5950@debbugs.gnu.org; Thu, 16 Sep 2010 05:25:43 -0400 Received: from ceviche.home (vpn-132-204-232-36.acd.umontreal.ca [132.204.232.36]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id o8G9RwcC006544; Thu, 16 Sep 2010 05:27:59 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 91E5166289; Thu, 16 Sep 2010 11:27:57 +0200 (CEST) From: Stefan Monnier To: Glenn Morris Subject: Re: bug#5950: defvaralias after defvar should be warned in runtime Message-ID: References: <4BC6A096.8030801@yahoo.co.jp> <87r5gu34ag.wl%irieshinsuke@yahoo.co.jp> <3keicu1h3v.fsf@fencepost.gnu.org> Date: Thu, 16 Sep 2010 11:27:57 +0200 In-Reply-To: <3keicu1h3v.fsf@fencepost.gnu.org> (Glenn Morris's message of "Wed, 15 Sep 2010 23:51:00 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3623=0 X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: 5950 Cc: 5950@debbugs.gnu.org, IRIE Shinsuke X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.0 (--) >> I think the byte-hunk-handler should be put to `defvaralias' rather than >> `define-obsolete-variable-alias'. `defvaralias' is a primitive function >> which causes the problem in `define-obsolete-variable-alias' macro. > The issue _is_ with defvaralias, but it's only a problem for user > options, things that might be set in .emacs before the associated > alias definition is evaluated. It's hard to see why there should be > non-obsolete aliases to user options, it just causes confusion. I > think there would be false positives if the warning was associated > with defvaralias, which is mostly used with non-user-options, I would > think. > The last time a similar issue came up, Stefan preferred that only > define-obsolete-variable-alias be changed; see Well, in this case I'd rather check defvaralias, since the problem is there: if (defvaralias 'foo 'bar) is executed after both `foo' and `bar' have been given values, then it will necessarily have to drop one of the two, which is the source of the problem. Changing defvaralias to try and be more clever would definitely be wrong. But changing it to output a warning about the problematic situation would be OK and changing the byte-compiler to output a warning in cases that make such a situation more likely is also perfectly good. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat May 26 12:53:05 2018 Received: (at 5950) by debbugs.gnu.org; 26 May 2018 16:53:05 +0000 Received: from localhost ([127.0.0.1]:49854 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fMcRF-0005KX-5o for submit@debbugs.gnu.org; Sat, 26 May 2018 12:53:05 -0400 Received: from mail-it0-f45.google.com ([209.85.214.45]:35121) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fMcR6-0005Jc-Np; Sat, 26 May 2018 12:52:57 -0400 Received: by mail-it0-f45.google.com with SMTP id q72-v6so10404957itc.0; Sat, 26 May 2018 09:52:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=n7WH6n5kCUBo3p1RvNcsYMTIHbqGgF8CmT9vx4iZfOA=; b=J5RJtMNCHkQcA/F4WOL+GRimvV+MOREntrNOf4e1Nu7rkkeUn/5a7hV6JN9NbfjWpd OOUCOEJEUAWJyS4cAcZtZH7kcI+fqt2EWWrxbRitFE7xAe+qwDGl7Err3OLf5hjL34Cm 1gvsPEYaXVOtK+ccZ4/3vIxGyARQY3hlZfsFu39KxTFV98GQ5XQuDZU++/klarvO3NUH jY5aUW9V03I92uKdb2m/6oC26sRBG3VuAaBT/hBAbjG6mChiF82OSpBIhfq9XJmMo3ho vs7SNlN844SEZvgLhuWcgUP67LuR9j2hUo6rAZLm0Q9Thq2wGk+LoboyIWRU9vTNbiZn eNaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=n7WH6n5kCUBo3p1RvNcsYMTIHbqGgF8CmT9vx4iZfOA=; b=ijhVsFx1V6gQbkPp0tmIKMYU5xjG6NgehUVL4AjPw1pP0nkJ1I4SSDzb9J8RqP/GQU GT1ddTO547yy4fvA6yBRkeEtvtrYzHElJTklFwRII+cjGtJzE/rMngFFGauTnVAweNAO ZGifu8z5eAzQOMoaFCcj14ZNg3LTaawibHVaOPIW+cQv5xXd9P9rxhx8mfvpjQyUHhPl 0/vtq0VfiIaFIuqRmRhZSSt2Shp64OaxHmcezeJVjbpAVuxZr/daXM1cnltWft+hA6++ TVtYIWmO15G5o8bieNXB1qPw/h2iYj1JO0dfcSqUDDuRWunfx65/QZ8aL+BD26Qhqin1 tfOg== X-Gm-Message-State: ALKqPwfS8JwtHFunrYKYwQP2ZMh72cVKyvYXT4WI5X3KzFDdJiYbBKY+ rL8eidIyGqmV00TfuxoqpQ1GGg== X-Google-Smtp-Source: ADUXVKLr795IvXawabTKL0gMp1E1dD+NmMwNTmh5hlzZfx4OD6mk7dwb4TUEva/vCTRVbtd18Cn7SQ== X-Received: by 2002:a24:4a4c:: with SMTP id k73-v6mr6180582itb.126.1527353571103; Sat, 26 May 2018 09:52:51 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id e139-v6sm8232047ite.1.2018.05.26.09.52.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 26 May 2018 09:52:50 -0700 (PDT) From: Noam Postavsky To: Stefan Monnier Subject: Re: bug#5950: defvaralias after defvar should be warned in runtime References: <4BC6A096.8030801@yahoo.co.jp> <87r5gu34ag.wl%irieshinsuke@yahoo.co.jp> <3keicu1h3v.fsf@fencepost.gnu.org> Date: Sat, 26 May 2018 12:52:48 -0400 In-Reply-To: (Stefan Monnier's message of "Thu, 16 Sep 2010 11:27:57 +0200") Message-ID: <874liufjfj.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 5950 Cc: Glenn Morris , IRIE Shinsuke , 5950@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain tags 5950 + patch quit Stefan Monnier writes: > Changing defvaralias to try and be more clever would definitely > be wrong. But changing it to output a warning about the problematic > situation would be OK and changing the byte-compiler to output a warning > in cases that make such a situation more likely is also perfectly good. I see the byte-compiler side of this has been taken care of [1..4], but I still managed to make this mistake when I made a cross-file alias (Bug#31603). Here's a patch for the runtime warning. While writing it, I found that invoking `display-warning' failed during bootstrap, so the first commit works around that. In the end it's not strictly necessary, because I added a check to suppress the warning when the two variables have `eq' values, so no warnings are generated during bootstrap anyway. The bootstrap warnings were about cl-custom-print-functions, mail-dont-reply-to-names, and several flymake-proc-* variables all of which correctly have the alias before the definition. This makes me think I might be doing something wrong, but it seems to do the right thing in my tests. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=v1-0001-Let-display-warning-work-during-bootstrap.patch Content-Description: patch >From e039d38c653059716b68f64fdc7b395bf7593834 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Fri, 25 May 2018 21:37:17 -0400 Subject: [PATCH v1 1/2] Let display-warning work during bootstrap * lisp/emacs-lisp/warnings.el (display-warning): Only call `special-mode' and `newline' if they are `fbound'. --- lisp/emacs-lisp/warnings.el | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/lisp/emacs-lisp/warnings.el b/lisp/emacs-lisp/warnings.el index 665733181c..c4d97ceab0 100644 --- a/lisp/emacs-lisp/warnings.el +++ b/lisp/emacs-lisp/warnings.el @@ -241,11 +241,15 @@ display-warning (old (get-buffer buffer-name)) (buffer (or old (get-buffer-create buffer-name))) (level-info (assq level warning-levels)) + ;; `newline' may be unbound during bootstrap. + (newline (if (fboundp 'newline) #'newline + (lambda () (insert "\n")))) start end) (with-current-buffer buffer ;; If we created the buffer, disable undo. (unless old - (special-mode) + (when (fboundp 'special-mode) ; Undefined during bootstrap. + (special-mode)) (setq buffer-read-only t) (setq buffer-undo-list t)) (goto-char (point-max)) @@ -256,7 +260,7 @@ display-warning (funcall warning-series))))) (let ((inhibit-read-only t)) (unless (bolp) - (newline)) + (funcall newline)) (setq start (point)) (if warning-prefix-function (setq level-info (funcall warning-prefix-function @@ -264,7 +268,7 @@ display-warning (insert (format (nth 1 level-info) (format warning-type-format typename)) message) - (newline) + (funcall newline) (when (and warning-fill-prefix (not (string-match "\n" message))) (let ((fill-prefix warning-fill-prefix) (fill-column 78)) -- 2.11.0 --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=v1-0002-Give-warning-if-losing-value-to-defvaralias-Bug-5.patch Content-Description: patch >From 6fe5dee5f4ad0a6e18d73658d0392d4444ff1826 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Fri, 25 May 2018 08:40:55 -0400 Subject: [PATCH v1 2/2] Give warning if losing value to defvaralias (Bug#5950) * src/eval.c (Fdefvaralias): Call `display-warning' if the alias target has a non-eq value to the variable being aliased. * test/src/eval-tests.el (defvaralias-overwrite-warning): New test. --- src/eval.c | 10 ++++++++++ test/src/eval-tests.el | 22 ++++++++++++++++++++++ 2 files changed, 32 insertions(+) diff --git a/src/eval.c b/src/eval.c index 90d8c33518..354ab2c2d1 100644 --- a/src/eval.c +++ b/src/eval.c @@ -623,6 +623,16 @@ DEFUN ("defvaralias", Fdefvaralias, Sdefvaralias, 2, 3, 0, if (NILP (Fboundp (base_variable))) set_internal (base_variable, find_symbol_value (new_alias), Qnil, SET_INTERNAL_BIND); + else if (!NILP (Fboundp (new_alias)) + && !EQ (find_symbol_value (new_alias), + find_symbol_value (base_variable))) + call2 (intern ("display-warning"), + list3 (intern ("defvaralias"), intern ("losing-value"), new_alias), + CALLN (Fformat_message, + build_string + ("Overwriting value of `%s' by aliasing to `%s'"), + new_alias, base_variable)); + { union specbinding *p; diff --git a/test/src/eval-tests.el b/test/src/eval-tests.el index 319dd91c86..281d959b53 100644 --- a/test/src/eval-tests.el +++ b/test/src/eval-tests.el @@ -26,6 +26,7 @@ ;;; Code: (require 'ert) +(eval-when-compile (require 'cl-lib)) (ert-deftest eval-tests--bug24673 () "Check that Bug#24673 has been fixed." @@ -117,4 +118,25 @@ eval-tests--exceed-specbind-limit "Check that Bug#31072 is fixed." (should-error (eval '(defvar 1) t) :type 'wrong-type-argument)) +(ert-deftest defvaralias-overwrite-warning () + "Test for Bug#5950." + (defvar eval-tests--foo) + (setq eval-tests--foo 2) + (defvar eval-tests--foo-alias) + (setq eval-tests--foo-alias 1) + (cl-letf (((symbol-function 'display-warning) + (lambda (type &rest _) + (throw 'got-warning type)))) + ;; Warn if we lose a value through aliasing. + (should (equal + '(defvaralias losing-value eval-tests--foo-alias) + (catch 'got-warning + (defvaralias 'eval-tests--foo-alias 'eval-tests--foo)))) + ;; Don't warn if we don't. + (makunbound 'eval-tests--foo-alias) + (should (eq 'no-warning + (catch 'got-warning + (defvaralias 'eval-tests--foo-alias 'eval-tests--foo) + 'no-warning))))) + ;;; eval-tests.el ends here -- 2.11.0 --=-=-= Content-Type: text/plain [1: 495963cfaf]: 2018-04-20 17:22:47 -0400 * lisp/emacs-lisp/bytecomp.el (byte-compile-file-form-defvar-function): https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=495963cfaf535646350051f47c085b84319572f0 [2: 9c3eeba4db]: 2018-04-20 18:34:39 -0400 The tedious game of whack-a-mole with compiler warnings continues https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=9c3eeba4db26ddaeead100beea7a96f9fa640918 [3: 18de2ada24]: 2018-04-20 18:55:04 -0400 More alias-related tedium https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=18de2ada243653ece98b18044233e5d29eee5903 [4: 94e794c8d8]: 2018-04-20 19:02:16 -0400 Tweak recent bytecomp defvaralias change https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=94e794c8d8b93a1d6813742da12135f2746ef80b --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat May 26 15:46:08 2018 Received: (at 5950) by debbugs.gnu.org; 26 May 2018 19:46:08 +0000 Received: from localhost ([127.0.0.1]:49913 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fMf8i-0002sH-Bp for submit@debbugs.gnu.org; Sat, 26 May 2018 15:46:08 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:47859) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fMf8f-0002s8-U8 for 5950@debbugs.gnu.org; Sat, 26 May 2018 15:46:06 -0400 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w4QJk3ti016065; Sat, 26 May 2018 15:46:04 -0400 Received: by pastel.home (Postfix, from userid 20848) id 6E9AC6A368; Sat, 26 May 2018 15:46:03 -0400 (EDT) From: Stefan Monnier To: Noam Postavsky Subject: Re: bug#5950: defvaralias after defvar should be warned in runtime Message-ID: References: <4BC6A096.8030801@yahoo.co.jp> <87r5gu34ag.wl%irieshinsuke@yahoo.co.jp> <3keicu1h3v.fsf@fencepost.gnu.org> <874liufjfj.fsf@gmail.com> Date: Sat, 26 May 2018 15:46:03 -0400 In-Reply-To: <874liufjfj.fsf@gmail.com> (Noam Postavsky's message of "Sat, 26 May 2018 12:52:48 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6294=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6294> : inlines <6661> : streams <1787881> : uri <2647689> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 5950 Cc: Glenn Morris , IRIE Shinsuke , 5950@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > + else if (!NILP (Fboundp (new_alias)) > + && !EQ (find_symbol_value (new_alias), > + find_symbol_value (base_variable))) > + call2 (intern ("display-warning"), > + list3 (intern ("defvaralias"), intern ("losing-value"), new_alias), > + CALLN (Fformat_message, > + build_string > + ("Overwriting value of `%s' by aliasing to `%s'"), > + new_alias, base_variable)); I'd make it just a `message` rather than a `display-warning`. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat May 26 19:54:43 2018 Received: (at 5950) by debbugs.gnu.org; 26 May 2018 23:54:43 +0000 Received: from localhost ([127.0.0.1]:50015 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fMj1H-0008TA-6g for submit@debbugs.gnu.org; Sat, 26 May 2018 19:54:43 -0400 Received: from mail-io0-f172.google.com ([209.85.223.172]:46265) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fMj1G-0008Sy-FV for 5950@debbugs.gnu.org; Sat, 26 May 2018 19:54:42 -0400 Received: by mail-io0-f172.google.com with SMTP id f21-v6so10335708iob.13 for <5950@debbugs.gnu.org>; Sat, 26 May 2018 16:54:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=JQybYj71aEN0IceC4k/8rxQTGqFNblK7HjUAfyNPYEM=; b=WeHhMrO24gVd+VW4nyeT4ossjTcfEyXxZgqwgy1RxUGS4c2u0nEX3UrIcANN7Z4SBr DzWbfzRLumhj8FzSLmEFncJzNNsq4z8zeylqkxNTkxyt1B5RNqlzPeLzzNHvk75JlLZI M1ndAr/ZdwyXhl34SIAVolE/C6AOPbcmaVkZyBafb/AbiBBEH6Fjs/RvqSaxzm32l73k eiXJn/26nJOkhhtHn/pJTmt3+ajC2NTvi8EEdaFK0GSZUezgfftdlBHbQ4y/gk52bS4s 7fZxON74rW4A3mOFM4G/4bDIAfZeo5FXNl8hbO8ZSh3lDx9B+wPcd9zm4YdzCDWx/ka6 66Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=JQybYj71aEN0IceC4k/8rxQTGqFNblK7HjUAfyNPYEM=; b=VhLLO/h1UKr/KQnuGAnfm+p+tc7xXj2ZarS3MMbIS1Qsh2w2JtosDmww42yWdFtLA2 v0jqXo23LPGenopNWgaBd9fNf3KIlDLW9daG5sVQ0Rd1+FdgoCuXwAHpOdUMly4ijElW yA524GTNZWcwjTHAxLiU86ShOjzvAujFbLxVICw361YdBrQtg189LP/O/tQpN3qZ3lGh vVSPfxklxyFJvw3yh1uMd4+RQCZVXMywPvrdDi4HMc3L8OIp4SktQicH3f0GcEzVKz7t sBnH5YPzvvpEryAbQYv5Uc4rDk2wL/+h+rHMFkiPoJjNjL3Ele6bfdt73j+AmFE1ZsPM O2IA== X-Gm-Message-State: ALKqPwfw5wlbNpDVH/RXkAcukcvLSQtWvf2adMAJr2b4hlNJUASEXg4J uxLr6GxeVr2ETIyetu9vbAzwqQ== X-Google-Smtp-Source: ADUXVKLXULLX+SrherCaw1t1Gx2Ov9SWA1xyVHEJcDlvJQ9wcEWgibhOQqhqgPaA+37b6C0wxxUSuA== X-Received: by 2002:a5e:890d:: with SMTP id k13-v6mr7201517ioj.9.1527378876744; Sat, 26 May 2018 16:54:36 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id e18-v6sm5271162itc.3.2018.05.26.16.54.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 26 May 2018 16:54:35 -0700 (PDT) From: Noam Postavsky To: Stefan Monnier Subject: Re: bug#5950: defvaralias after defvar should be warned in runtime References: <4BC6A096.8030801@yahoo.co.jp> <87r5gu34ag.wl%irieshinsuke@yahoo.co.jp> <3keicu1h3v.fsf@fencepost.gnu.org> <874liufjfj.fsf@gmail.com> Date: Sat, 26 May 2018 19:54:34 -0400 In-Reply-To: <874liufjfj.fsf@gmail.com> (Noam Postavsky's message of "Sat, 26 May 2018 12:52:48 -0400") Message-ID: <871sdyezwl.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 5950 Cc: Glenn Morris , 5950@debbugs.gnu.org, IRIE Shinsuke X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> The bootstrap warnings were about cl-custom-print-functions, >> mail-dont-reply-to-names, Oh, it's because the definition gets into loaddefs.el, but the alias doesn't. >> and several flymake-proc-* variables all of >> which correctly have the alias before the definition. Not 100% sure about the flymake ones, but I guess it's some double loading during bootstrap. Stefan Monnier writes: > I'd make it just a `message` rather than a `display-warning`. Hmm, I think it's too easy to overlook that, I prefer the in-your-face nature of display-warning. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 12 07:48:53 2018 Received: (at 5950) by debbugs.gnu.org; 12 Jun 2018 11:48:53 +0000 Received: from localhost ([127.0.0.1]:44164 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fShnB-0002Jw-6G for submit@debbugs.gnu.org; Tue, 12 Jun 2018 07:48:53 -0400 Received: from mail-io0-f196.google.com ([209.85.223.196]:34794) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fShn7-0002Jc-8V; Tue, 12 Jun 2018 07:48:49 -0400 Received: by mail-io0-f196.google.com with SMTP id e15-v6so27676313iog.1; Tue, 12 Jun 2018 04:48:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=QX2pJV3NIHPPjimky1WzIA5K8XMg8jBLSd0PFXjBsFc=; b=opxC/jAhRenOJQTQLGaSAhQOmtYSMnFhcxEcn7yBIV63bjm6iy2GV0/vJmYb+XOAso mZ0/6ZvIDGeptXygG54H+zq3FTpE9oveCB7EQ4DAlWFC3liFOUlcBZrZe+HQzrjpBcbG 2ZQJq9SFy0ROtWPSJyLUEF5Tac27+J9eMInQIgLMkPALIsRsCjRg8yYzSZrBcyhfADbs srIzrlZ7D7I9Kmifc04kOaKigdZu71WGG+slB0XFliOmyoLaZiNQHV0xGw/fuV0JLK8O SRItdXOg/DdPTWpILRxs7wR8x1STX+QAUT0CkOxKPPKNmtrTDl2YFQxTyQpjf5RVnOy3 xjnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=QX2pJV3NIHPPjimky1WzIA5K8XMg8jBLSd0PFXjBsFc=; b=lOl3YlbHa5a3CotcuoZiSbcKEeaU8CD6zzHuxAhkoxdDwfIFtxQ0rXoiaIeTKp40ND KUIep/ITL0mOBszg6PytEY3F6o/pnUUgvhQoLw8dZIm6KXHm+7HIOjNn9cL0fJzpGIkO GQmJX4l8L7ektviR/LifsB1o53ZybyQwgCJ1pSGLYSlXoH44AzklEtjcS6fqQSzEN4N9 hOYP6TzYtTUewvxg/KPs8t8+MKzuNgp6GKTZUPiyOtA56a8TSRI1wyC5KZ+ruIqPWn1j Qetu+MZN8+7/Tvhb2UxzrI+fZzD3lJVVJqG1MRisptkWebaR/YhuhgvjxsoMpEVQ1ZdF dcdw== X-Gm-Message-State: APt69E1MJl+PIowfPvpV/nANNS8WxHTiW8NTNOsjQ+LTXfQOE/E8pz7V XIz+q5Xe8ZrFWkZ9WvvOV9JTlQ== X-Google-Smtp-Source: ADUXVKJfo2v9cSbgrAyw+SAOWfMs4+vfJ/dH+jSiRsPrlJY2VnvA3U/ykZUGs6/oK8YOBxs0y6aDEA== X-Received: by 2002:a6b:7114:: with SMTP id q20-v6mr31714iog.258.1528804123474; Tue, 12 Jun 2018 04:48:43 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id m31-v6sm80606iti.10.2018.06.12.04.48.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Jun 2018 04:48:42 -0700 (PDT) From: Noam Postavsky To: Stefan Monnier Subject: Re: bug#5950: defvaralias after defvar should be warned in runtime References: <4BC6A096.8030801@yahoo.co.jp> <87r5gu34ag.wl%irieshinsuke@yahoo.co.jp> <3keicu1h3v.fsf@fencepost.gnu.org> <874liufjfj.fsf@gmail.com> <871sdyezwl.fsf@gmail.com> Date: Tue, 12 Jun 2018 07:48:40 -0400 In-Reply-To: <871sdyezwl.fsf@gmail.com> (Noam Postavsky's message of "Sat, 26 May 2018 19:54:34 -0400") Message-ID: <87vaaoxm1z.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 5950 Cc: Glenn Morris , IRIE Shinsuke , 5950@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 5950 fixed close 5950 27.1 quit Noam Postavsky writes: > Stefan Monnier writes: > >> I'd make it just a `message` rather than a `display-warning`. > > Hmm, I think it's too easy to overlook that, I prefer the in-your-face > nature of display-warning. Pushed to master. [1: c912db0836]: 2018-06-12 07:40:33 -0400 Give warning if losing value to defvaralias (Bug#5950) https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=c912db0836f6975519dea57fb0a4adc2988da1b1 From unknown Tue Jun 24 06:58:00 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 11 Jul 2018 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 01 22:03:01 2018 Received: (at control) by debbugs.gnu.org; 2 Aug 2018 02:03:01 +0000 Received: from localhost ([127.0.0.1]:38093 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fl2xB-0003po-1V for submit@debbugs.gnu.org; Wed, 01 Aug 2018 22:03:01 -0400 Received: from mail-it0-f53.google.com ([209.85.214.53]:37967) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fl2x9-0003pZ-Aa for control@debbugs.gnu.org; Wed, 01 Aug 2018 22:02:59 -0400 Received: by mail-it0-f53.google.com with SMTP id v71-v6so1017719itb.3 for ; Wed, 01 Aug 2018 19:02:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=WLL9jzCPNzCxaaukBHfiiuM9AsIEXxi3L05pWRC1+q8=; b=Bl1Z2S78y+BEQvTiMSRsA79a/UkZIgiM8Q0c25UInrfsxzUuoz14WXzOGkxl0MwMH/ aSVrb09t9IExnYpZU44SyXvK0GOfjgQ2CIBKaAVDcC27roL6xXU36uXKgn/Boo7Us7bb YiFdLIa2iaKBwgucjmH6cXA8fZSXvNz2wtuQmicJVu5D2QoTan8VJLxZc8zoRNFaR3E+ tFfKH8BcIvxHEiMLRWQVlhLXD1zwIqSqYWCP7t+W0p2jEzELyFpbO6tHcZj5C7Ke9k00 /7kXQF9h/NpOLAEcNOX0u8B5RBccWFWZm4LJw+M0p3IgWbeH4SCyFO5bk+hNgNCEEi6h CMuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=WLL9jzCPNzCxaaukBHfiiuM9AsIEXxi3L05pWRC1+q8=; b=bpWSuZvDkRKr9523jvRrSdv4J8zMOinfn/fDZi8dB4WJ5r7KgOcz/ePnRAcgbL9hAF YFqRe14IWoPmr3ApLyGoxVO2jg3qOvsroclcCQO4mAMYXI6OBlfzdQYxX+r9xGiapKlr xzGcU8VuqfAfDmxvN/Y8oXcXCsj3u+angb9wsCCCcyzKy29F0xqv5JQGuBLcS4wtAAaB obURtDZ8u/tTXQ3WYTkWfnhAacA/rfBmNztSqICagzR6s/3nlt1ZB/mr4zOcgBClh6Q+ qYTS3Jr4KCBcL+SOCtwmZN9gLsme6oLGSF3INoMFhqnl0ljT2caQKrZTuxsAg9n/wSAL SCsw== X-Gm-Message-State: AOUpUlERgdKPI4XJzFDa1lWStnWytK4WnGx7hx2EGEGr8kTV61SF5QpP iZ9nFSj5fQT1p6PJL99EbNpNQoFl X-Google-Smtp-Source: AAOMgpetc/n8v6zOyxSFDWXjb7NDqV6LwX+uSQwWe630VmKFnEFosXkBgfrzoETo9Q7NU/+Zd6Xtpw== X-Received: by 2002:a02:9936:: with SMTP id r51-v6mr706075jaj.46.1533175373752; Wed, 01 Aug 2018 19:02:53 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id n142-v6sm246829itb.3.2018.08.01.19.02.53 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 01 Aug 2018 19:02:53 -0700 (PDT) From: Noam Postavsky To: control@debbugs.gnu.org Subject: control message for bug #5950 Date: Wed, 01 Aug 2018 22:02:52 -0400 Message-ID: <87va8tzfsj.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) unarchive 5950 quit From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 01 22:14:14 2018 Received: (at 5950) by debbugs.gnu.org; 2 Aug 2018 02:14:14 +0000 Received: from localhost ([127.0.0.1]:38104 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fl382-00046n-CH for submit@debbugs.gnu.org; Wed, 01 Aug 2018 22:14:14 -0400 Received: from mail-it0-f44.google.com ([209.85.214.44]:55197) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fl380-00046a-8e for 5950@debbugs.gnu.org; Wed, 01 Aug 2018 22:14:12 -0400 Received: by mail-it0-f44.google.com with SMTP id s7-v6so1078544itb.4 for <5950@debbugs.gnu.org>; Wed, 01 Aug 2018 19:14:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version; bh=2K/ni35GQot+cgB1iBIF2h+CQTT0nPOqaS7ryIveNcE=; b=EVVX265VebTg/6wtqUtWNzP0MqrFDKVukmtjrsbJhj3drtgrAjGGZJ/lRkbdQVkNZP BQwQEqdIRIeDaZc4DJqfBpgtSo/bRWRRRlXIyM51lJFG+FJaVqZeKUa8g/EN1jXFfZjj PAsr0yCWg81YQ3qTsu0IiQAPxHnwClgrwTJ2WouRdRYnvT6w0i0OlzpWEX0pgYy8EjA7 9cJN8f89aLkanKmPknPp4P2KCqqQJ0QkSxDFlimpszr/9iAVs4/xHTSD98XStOlMeWBm gaZbt6SSGf1TF85i51KjkUvKQpnr3HVsAkN2OpbP1vuq6ltzrLq63TykjMfdMOu0d3HK PlWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version; bh=2K/ni35GQot+cgB1iBIF2h+CQTT0nPOqaS7ryIveNcE=; b=DkP+MnGCnsO08g1l7oK0naUN766byIURAjDY4FOV5vK6WRG+tRMr+lm0QhpJM97qCC IigOgClx93rDuPBLDxJ0+FVwyegWvUcr0sLlYVPLZ9Pa+AZvP2x56B1cvxrLgs+dfF4J vOCN5SzDlUu1KQMAF+wzQ8ctNitEPBtFeAoNudbKLJgevbkmXtjh4pAIlumMGgKfN9gf d+iwsDKwDwEIwkNYZlbWtXS6HCzQ8SehoyxYlcvRzGMfvFAAnFjsPY2aqmCrJjMhuTpK LSp3VEF2N5JLlFcKFrw/oEpY308uh4kRO0Fd/dRCx7xHmxRXxUzPOTGswkrTT27aOGSE 2RNQ== X-Gm-Message-State: AOUpUlH5J5Fg2PQxqbn6HEMs3wy+gQ6NJbkySOZRYcjQwnv1SVDMezxD RiHK85ZXAyVYh8DRtdFNuoI= X-Google-Smtp-Source: AAOMgpfoTkmc15+nfz17hu4OR8XN2ByuOaNmXM1MtAAavgUNLKoKZS4cGDJ+kD5EtKU+Hz8mCuWzCg== X-Received: by 2002:a24:704f:: with SMTP id f76-v6mr918013itc.30.1533176046895; Wed, 01 Aug 2018 19:14:06 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id c18-v6sm198140ioi.3.2018.08.01.19.14.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 01 Aug 2018 19:14:06 -0700 (PDT) From: Noam Postavsky To: 5950@debbugs.gnu.org Subject: Re: bug#5950: defvaralias after defvar should be warned in runtime Date: Wed, 01 Aug 2018 22:14:05 -0400 Message-ID: <87sh3xzf9u.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 5950 Cc: =?utf-8?Q?Cl=C3=A9ment_Pit-Claudel?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain [forwarding to list, original didn't make it because bug was archived] --=-=-= Content-Type: message/rfc822 Content-Disposition: inline To: Noam Postavsky , Stefan Monnier References: <4BC6A096.8030801@yahoo.co.jp> <87r5gu34ag.wl%irieshinsuke@yahoo.co.jp> <3keicu1h3v.fsf@fencepost.gnu.org> <874liufjfj.fsf@gmail.com> <871sdyezwl.fsf@gmail.com> <87vaaoxm1z.fsf@gmail.com> From: =?utf-8?Q?Cl=C3=A9ment_Pit-Claudel?= Subject: Re: bug#5950: defvaralias after defvar should be warned in runtime Message-ID: Date: Wed, 1 Aug 2018 14:55:56 -0400 In-Reply-To: <87vaaoxm1z.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Noam, I just updated my Emacs and ran into this warning, but I have no idea what's wrong with the following code :) (defvaralias 'flycheck-python-pylint-executable 'python-shell-interpreter) (defvaralias 'flycheck-python-flake8-executable 'python-shell-interpreter) These two variables `flycheck-&-executable' are configuration knobs created by Flycheck, and I never want to set them individually; instead, I want them to have the same value as `python-shell-interpreter'. While the code above works, it also pops a "warning" buffer now: Warning (defvaralias): Overwriting value of =E2=80=98flycheck-python-pylint= -executable=E2=80=99 by aliasing to =E2=80=98python-shell-interpreter=E2=80= =99 Warning (defvaralias): Overwriting value of =E2=80=98flycheck-python-flake8= -executable=E2=80=99 by aliasing to =E2=80=98python-shell-interpreter=E2=80= =99 I've set warning-suppress-log-types to '(defvaralias losing-value) to work around this, but was the warning actually intended in this case? Cl=C3=A9ment. --=-=-= Content-Type: text/plain It's warning because you overwrite the original value of flycheck-python-pylint-executable when you call defvaralias. In this case you intended that, but usually it's a mistake. You could make the warning suppression more selective by adding (defvaralias losing-value flycheck-python-pylint-executable) and (defvaralias losing-value flycheck-python-flake8-executable) to warning-suppress-log-types. Alternatively, you could do (setq flycheck-python-pylint-executable python-shell-interpreter) (defvaralias 'flycheck-python-pylint-executable 'python-shell-interpreter) (setq flycheck-python-flake8-executable python-shell-interpreter) (defvaralias 'flycheck-python-flake8-executable 'python-shell-interpreter) (the warning doesn't trigger if the value being overwritten is `eq' to the new one). --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 02 09:08:39 2018 Received: (at 5950) by debbugs.gnu.org; 2 Aug 2018 13:08:40 +0000 Received: from localhost ([127.0.0.1]:38362 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flDLL-0007yZ-NY for submit@debbugs.gnu.org; Thu, 02 Aug 2018 09:08:39 -0400 Received: from mail-qt0-f170.google.com ([209.85.216.170]:39177) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flDLK-0007yJ-5Z for 5950@debbugs.gnu.org; Thu, 02 Aug 2018 09:08:38 -0400 Received: by mail-qt0-f170.google.com with SMTP id q12-v6so2152875qtp.6 for <5950@debbugs.gnu.org>; Thu, 02 Aug 2018 06:08:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=GPU1EVzi+Ocz8iOmZPvHpG4CEW7Hy3/ZDSt7B7KeEww=; b=hIm3f2eJZVa/4tsDJdo9e5iDqd39BvaI1SxieraXrAwj4jCZy2r+5qoDOtw2jQc2Uv QZ4PjC10wkYDHoA34V1TQQohCYs0vMm5kxpv254s8JZe/UMW0dhIudktDJrin3cNvh7M zggTfv7uF9HyIGDFXAtW2jwQP65QDeRuzy+lasn5lxRqqxqJhVbmHAREEaX3igRZ4MeZ si7uNQa4Jj6Igl+dgdXRI+8EaGffarxGKcZdPqbcoI+w+Q/zSNSGd/wjf764Jp9iMyjJ t6OlIQ4BkujnVYpCefsOvux3md38GG6e7pkEQReDPHNnHZRvSFfvTrbNf3X+PXibPGCS tnYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=GPU1EVzi+Ocz8iOmZPvHpG4CEW7Hy3/ZDSt7B7KeEww=; b=ciK8qRgOOkngVKzr2wQXyOuPmr5/v8zbc9WO9QghIve3U2sLRRUwj70xfsF6hqgz4Z XaxEUoRNfE/QNBt17NsuiDmu7cxWq5KPnZZIrTGmZXhZBpZRdKnaycoZ1pGRkrRdJtZx auA43+rMLJz7vyw0CSMTTrMdBm7shfw+RyM8y2OTuJdo8konGs98FLKI3uZtJmrjAaK/ AzSZFtG53blHCqjQWZqahpFMq+LqwPv0SJFUkQvgtg01gY7KQ01h2QrTu4aCdsWZry7X t5Xk/TjiT0TVmw1zEKEDaIJdhGTQT8uP3mHECK4nFvdQUX0ectxOT2YjvtxNAMPnTp7t JTUw== X-Gm-Message-State: AOUpUlETadCqZDlzjNlQkq4k3UHs054dUPqW2mygwc3sTkHSv7FLano+ QvvQyK9+7k6bB36aqyjo18YDB0NX X-Google-Smtp-Source: AAOMgpcJJj5Gr49m6hDVuun7h3cuF+IzZq4/3/MuiWrwediRWP9hTR+MoG2FkgRVqjYCN+isA/ZcNw== X-Received: by 2002:ac8:4588:: with SMTP id l8-v6mr2592312qtn.184.1533215312484; Thu, 02 Aug 2018 06:08:32 -0700 (PDT) Received: from [10.8.0.6] (c-73-126-99-55.hsd1.ma.comcast.net. [73.126.99.55]) by smtp.gmail.com with ESMTPSA id l22-v6sm1387516qkh.72.2018.08.02.06.08.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 Aug 2018 06:08:31 -0700 (PDT) Subject: Re: bug#5950: defvaralias after defvar should be warned in runtime To: Stefan Monnier References: <4BC6A096.8030801@yahoo.co.jp> <87r5gu34ag.wl%irieshinsuke@yahoo.co.jp> <3keicu1h3v.fsf@fencepost.gnu.org> <874liufjfj.fsf@gmail.com> <871sdyezwl.fsf@gmail.com> <87vaaoxm1z.fsf@gmail.com> From: =?UTF-8?Q?Cl=c3=a9ment_Pit-Claudel?= Message-ID: <8e11e15a-a806-777e-1b18-3db9000c77de@gmail.com> Date: Thu, 2 Aug 2018 09:08:30 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 5950 Cc: 5950@debbugs.gnu.org, IRIE Shinsuke , Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2018-08-01 17:46, Stefan Monnier wrote: >> Warning (defvaralias): Overwriting value of >> ‘flycheck-python-pylint-executable’ by aliasing to >> ‘python-shell-interpreter’ > > This warning tells you that the variable > `flycheck-python-pylint-executable` already had a value before the call > to `defvaralias`, and that this value is lost at this point. > > Usually the warning is due to the defvaralias call being performed after > the corresponding `defvar`s. Right. But why is that a problem? From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 02 09:29:00 2018 Received: (at 5950) by debbugs.gnu.org; 2 Aug 2018 13:29:00 +0000 Received: from localhost ([127.0.0.1]:38375 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flDf2-0008Rt-JS for submit@debbugs.gnu.org; Thu, 02 Aug 2018 09:29:00 -0400 Received: from mail-oi0-f42.google.com ([209.85.218.42]:43263) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flDf0-0008Rh-J9 for 5950@debbugs.gnu.org; Thu, 02 Aug 2018 09:28:58 -0400 Received: by mail-oi0-f42.google.com with SMTP id b15-v6so3920256oib.10 for <5950@debbugs.gnu.org>; Thu, 02 Aug 2018 06:28:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=i0+3GEBOHGd6cDvUtF4gpQmaqRHQ4pvTcT3r6wTSkEk=; b=gLXa1o6nk6blfjYlk7pXtJT/WyiTYunm+QG4IIo+VkrzkreUmdXJSA7whaidGG0sZ6 +Up2sfbWjyW6EH55BEgu7D3naXUqCUrByQKMb1C1RRPM3FrAJ9ic9gdNRrsftEVioNul j8nxRJ/0p8pk1VLAkJ7gVlCWJIX5jVu9Ycjbayq7srhZxXL4sdY80IKMEGs7beFwf50y Y7GC9QVCTBLWnWkwK37MkxY0DLUXiEkVENfrt6oF1YcRscROzX0+hTM9viAAqq3BLC2p qGP7mMJ3w0aumaw+BrfAdxm+aoQc3GjbhzOLKNXMylNVPZlaD6yc9E/LyABxv55L6rAf 585Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=i0+3GEBOHGd6cDvUtF4gpQmaqRHQ4pvTcT3r6wTSkEk=; b=XeoYt4Lgh7bTqxxXMWh8Tnlrno8WbCi4fF0KAQIjY/h5PQb7eE3r/caohnuUZRz1qL c2IKd4hx94+JcMFQlFQGIdzfJ9JEMvPaiOv/rq4SKudZg9vzvjQf1RFO3WxaPhax/jjN JHYOmN3DcvZp9fRk++O4vuO/tm4Y5x7P3oLD9RgPsGdm/zCbWJZTiUqUyo8dxbtteKon nALNANJngS87DAbSzwxrW37YF0oUy4jrhj5moPFO8edmcTvS9i3XorzG2eMjuWl1vR/i pCugyNKj+6TPRHjXFDBn6sPVF20SDSqxx4lQIBU4diVjr6sDfj1ApiJGjD11N0mPTm6D tYkQ== X-Gm-Message-State: AOUpUlEEOkGB+slK7cbnWCSRvOUwQNtl+labwKjiXzhjvWpFHlzQf1eo 2ZNZ+ZQ3h6W1ZOjbbJ+JSagt2I59IAC8T9UvJoA= X-Google-Smtp-Source: AAOMgpcbYp1LDfasmKR5cwStxGMvOvgmn/eoHDLwSJEB06zF/x3SrW6xybKMlFCPs11sK/50x6kurU+PXzzr0Ld4ZyI= X-Received: by 2002:aca:3c45:: with SMTP id j66-v6mr2595962oia.118.1533216532417; Thu, 02 Aug 2018 06:28:52 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a9d:3495:0:0:0:0:0 with HTTP; Thu, 2 Aug 2018 06:28:51 -0700 (PDT) In-Reply-To: <8e11e15a-a806-777e-1b18-3db9000c77de@gmail.com> References: <4BC6A096.8030801@yahoo.co.jp> <87r5gu34ag.wl%irieshinsuke@yahoo.co.jp> <3keicu1h3v.fsf@fencepost.gnu.org> <874liufjfj.fsf@gmail.com> <871sdyezwl.fsf@gmail.com> <87vaaoxm1z.fsf@gmail.com> <8e11e15a-a806-777e-1b18-3db9000c77de@gmail.com> From: Noam Postavsky Date: Thu, 2 Aug 2018 09:28:51 -0400 Message-ID: Subject: Re: bug#5950: defvaralias after defvar should be warned in runtime To: =?UTF-8?Q?Cl=C3=A9ment_Pit=2DClaudel?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 5950 Cc: 5950@debbugs.gnu.org, IRIE Shinsuke , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2 August 2018 at 09:08, Cl=C3=A9ment Pit-Claudel = wrote: >> Usually the warning is due to the defvaralias call being performed after >> the corresponding `defvar`s. > > Right. But why is that a problem? The typical failure case goes like this, user does this: (setq the-package-setting 'foo) (require 'the-package) And the-package.el does this: (defvar the-package-real-setting 'bar) ;; Oops! User's setting of `foo' is overwritten here: (defvaralias 'the-package-setting 'the-package-real-setting) See Bug#31603 for a real life example. https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D31603 From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 02 10:37:35 2018 Received: (at 5950) by debbugs.gnu.org; 2 Aug 2018 14:37:35 +0000 Received: from localhost ([127.0.0.1]:39085 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flEjP-0003ni-Cf for submit@debbugs.gnu.org; Thu, 02 Aug 2018 10:37:35 -0400 Received: from mail-qt0-f181.google.com ([209.85.216.181]:45880) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flEjO-0003nV-Ei for 5950@debbugs.gnu.org; Thu, 02 Aug 2018 10:37:34 -0400 Received: by mail-qt0-f181.google.com with SMTP id y5-v6so2485648qti.12 for <5950@debbugs.gnu.org>; Thu, 02 Aug 2018 07:37:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=l3AmT4Y8PKOZESQhox6owsskvypXX07BhN9BKObC98c=; b=QvSg0JaNK77v/ilyVzX0KHwjK4aD3XZI2ljeKRGtfeAd3vfNVRMEOlMJ+0VzJx8TBo iV8xVrj3YuFrRm2y3zsUUwuvutQC4a1SHJ0vSmJUr+HRL17cszHYuO9pp2T9BPk9CJkK Vu6RHQYV57xw+4W+rNEyMBj89siDT/E6xRFMw/D/lklIQadlraVYdwg5JCG81RtAd4sh OvI6hnDLyxWNxbo/CuTY9/uC6swjYjP01IXxSfoA8P5M6r+7I6VVg6JjzPeaW08HwhkC Hbn6ehuRC4+q6rydvqnfr/hoCuwhyABOyYPe7iNFaa3LuXC/7uFOGcK7dGGggN3yTa9z m5sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=l3AmT4Y8PKOZESQhox6owsskvypXX07BhN9BKObC98c=; b=jzrOn/KdrMkgqTrUgb3CW96J+TGaAThK0HqjxovkovQhOnZlwxS2t4aouQLdMnYFLn NFGnYmxnGXc6LhZCqYysU0SKBCRwlf4564Ocf9GvykNctbXzQZwIGKQghWr5eEztNPHw QaFo3ixgCK2jAXBItql0/KaJxZGPlm2ljsihW/aJH4QW6SSI9ikRWB2yt05iHzi9aCuB t1eQ66b2vRxPzYzSCglz2m0RKrUdyW4rNTxfYqtUKfXvfRxszp1z00kQyrQq/EIDn6lm dt/RaO6OlQozGbmngGJeu4E/ZWJ24MnMrCIZjJTuxHhkN1U3ms/ap3jE7XjlQW6lOn7i qqhw== X-Gm-Message-State: AOUpUlEVU2GHtpVcTSoSdVeJFd8sy9+P4LBE0LiTIZACUkNecetXgqGl p8U1QntEDXnZTZ5j2yOYeCFqnl1t X-Google-Smtp-Source: AAOMgper8indkD8lrrI4RswkMkWsf31EZ8q/XXMLtqoUMFbDXEI11kV0ptnMIgL/13KgMu4P07bSYQ== X-Received: by 2002:ac8:37b4:: with SMTP id d49-v6mr2926174qtc.369.1533220648642; Thu, 02 Aug 2018 07:37:28 -0700 (PDT) Received: from [10.8.0.6] (c-73-126-99-55.hsd1.ma.comcast.net. [73.126.99.55]) by smtp.gmail.com with ESMTPSA id h195-v6sm956111qke.58.2018.08.02.07.37.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 Aug 2018 07:37:27 -0700 (PDT) Subject: Re: bug#5950: defvaralias after defvar should be warned in runtime To: Noam Postavsky References: <4BC6A096.8030801@yahoo.co.jp> <87r5gu34ag.wl%irieshinsuke@yahoo.co.jp> <3keicu1h3v.fsf@fencepost.gnu.org> <874liufjfj.fsf@gmail.com> <871sdyezwl.fsf@gmail.com> <87vaaoxm1z.fsf@gmail.com> <8e11e15a-a806-777e-1b18-3db9000c77de@gmail.com> From: =?UTF-8?Q?Cl=c3=a9ment_Pit-Claudel?= Message-ID: <775d0859-cb89-3f35-0455-1357461128d0@gmail.com> Date: Thu, 2 Aug 2018 10:37:25 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 5950 Cc: 5950@debbugs.gnu.org, IRIE Shinsuke , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2018-08-02 09:28, Noam Postavsky wrote: > On 2 August 2018 at 09:08, Clément Pit-Claudel wrote: > >>> Usually the warning is due to the defvaralias call being performed after >>> the corresponding `defvar`s. >> >> Right. But why is that a problem? > > The typical failure case goes like this, user does this: > > (setq the-package-setting 'foo) > (require 'the-package) > > And the-package.el does this: > > (defvar the-package-real-setting 'bar) > ;; Oops! User's setting of `foo' is overwritten here: > (defvaralias 'the-package-setting 'the-package-real-setting) Thanks. Should the warning be disabled when both variables are already `defvar'd, then? Clément. From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 02 13:03:25 2018 Received: (at 5950) by debbugs.gnu.org; 2 Aug 2018 17:03:25 +0000 Received: from localhost ([127.0.0.1]:39211 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flH0X-00010X-0N for submit@debbugs.gnu.org; Thu, 02 Aug 2018 13:03:25 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:35413) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flH0V-00010N-6S for 5950@debbugs.gnu.org; Thu, 02 Aug 2018 13:03:24 -0400 Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w72H3LQR028073; Thu, 2 Aug 2018 13:03:21 -0400 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id E0C13AE11E; Thu, 2 Aug 2018 13:03:21 -0400 (EDT) From: Stefan Monnier To: =?windows-1252?Q?Cl=E9ment?= Pit-Claudel Subject: Re: bug#5950: defvaralias after defvar should be warned in runtime Message-ID: References: <4BC6A096.8030801@yahoo.co.jp> <87r5gu34ag.wl%irieshinsuke@yahoo.co.jp> <3keicu1h3v.fsf@fencepost.gnu.org> <874liufjfj.fsf@gmail.com> <871sdyezwl.fsf@gmail.com> <87vaaoxm1z.fsf@gmail.com> <8e11e15a-a806-777e-1b18-3db9000c77de@gmail.com> <775d0859-cb89-3f35-0455-1357461128d0@gmail.com> Date: Thu, 02 Aug 2018 13:03:21 -0400 In-Reply-To: <775d0859-cb89-3f35-0455-1357461128d0@gmail.com> (=?windows-1252?Q?=22Cl=E9ment?= Pit-Claudel"'s message of "Thu, 2 Aug 2018 10:37:25 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6343=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6343> : inlines <6795> : streams <1794349> : uri <2683015> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 5950 Cc: 5950@debbugs.gnu.org, IRIE Shinsuke , Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> The typical failure case goes like this, user does this: >> >> (setq the-package-setting 'foo) >> (require 'the-package) >> >> And the-package.el does this: >> >> (defvar the-package-real-setting 'bar) >> ;; Oops! User's setting of `foo' is overwritten here: >> (defvaralias 'the-package-setting 'the-package-real-setting) > > Thanks. Should the warning be disabled when both variables are > already `defvar'd, then? Why? Replace `setq` with `defvar` in the above scenario and you have the same problem. Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 02 23:33:49 2018 Received: (at 5950) by debbugs.gnu.org; 3 Aug 2018 03:33:49 +0000 Received: from localhost ([127.0.0.1]:39401 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flQqb-0007t1-C6 for submit@debbugs.gnu.org; Thu, 02 Aug 2018 23:33:49 -0400 Received: from mail-yw1-f49.google.com ([209.85.161.49]:39583) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flQqZ-0007sn-PP for 5950@debbugs.gnu.org; Thu, 02 Aug 2018 23:33:48 -0400 Received: by mail-yw1-f49.google.com with SMTP id r184-v6so475731ywg.6 for <5950@debbugs.gnu.org>; Thu, 02 Aug 2018 20:33:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=xtjGlSdkJHU/8uLi5KC6N89RVPLJO9wL64ItvG1/mno=; b=rcVRfQyAeyaRd7386dfGyUQwDm8+VEpWkGkpE3QX4oGMldRChhdW4N572uvMmOVLPj /jpWRv55khaYY7zE+jpEmblIrlek/R5DjuC7Zi3I7VKKUofD/VJ8smuHf0kxamHCiDrh eBE4m/UQdm95xakU+le7siIoDotC80dRo3cazIGnRxO/b/p4RyiSHzcQLUMhxshJrPOu Ap/JtOc9sU3P/VNHzVOZgUe1Rsvu5URWarSoqPcJaIaxnLm56vt2ZGtgHoOcnczE7UZC 4EUT0okqnplAbistfkhekbRXdXaNP/sSEqgsmzWGskgfYQzTQJGXlSacF2feRLyBmZwZ 2nJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xtjGlSdkJHU/8uLi5KC6N89RVPLJO9wL64ItvG1/mno=; b=e83GEVtGM4UgiNJI2eZ7ixToweuSG/FXKZnRIMJtnX8aRZci46EI3s9m6AehgUJfVN oEUwt8ZPoLPJNWz76nQrUKBpjVQLsexCPTdu0WW2kr8Gerv7aBuu+z/+vgvCLiOAmXyo zon1FBs85I+7IBHBfSMy2Fq7quJyJ1wC8hQnwrXboRIhhPknbE6IrfqGtgVyvVoxRJ5l SngVZJD1unHG6rH5a/OMn/Sgljsl44KRregJyS2N53DXuhWdVVg1rgY9mpEfG6ccmFYp AYhRK6QbwxnkR7m9xeOZUTBUVP6J1/AN/9/T/Uig+0tNtWEXSfdYDEJXwyAs6X/OpZYu z/Uw== X-Gm-Message-State: AOUpUlErJDeyGRgp+byJ1N1Rg2NEmT4XEzPTD4/NQxRaPH5IwNbwYEjX qAbPuf+n/EDef7n/KIMxmfn29rqC X-Google-Smtp-Source: AAOMgpesk8IlrUwaUrveUI8QEGQ24F2mUwgollGQg8RLjpQ63zLi80fY7rmSk8FID8sMjcSeaSJBvA== X-Received: by 2002:a81:1791:: with SMTP id 139-v6mr1158426ywx.354.1533267222053; Thu, 02 Aug 2018 20:33:42 -0700 (PDT) Received: from ?IPv6:2601:184:4180:66e7:6128:d6c2:8e05:f435? ([2601:184:4180:66e7:6128:d6c2:8e05:f435]) by smtp.gmail.com with ESMTPSA id g203-v6sm1284118ywb.69.2018.08.02.20.33.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 Aug 2018 20:33:41 -0700 (PDT) Subject: Re: bug#5950: defvaralias after defvar should be warned in runtime To: Stefan Monnier References: <4BC6A096.8030801@yahoo.co.jp> <87r5gu34ag.wl%irieshinsuke@yahoo.co.jp> <3keicu1h3v.fsf@fencepost.gnu.org> <874liufjfj.fsf@gmail.com> <871sdyezwl.fsf@gmail.com> <87vaaoxm1z.fsf@gmail.com> <8e11e15a-a806-777e-1b18-3db9000c77de@gmail.com> <775d0859-cb89-3f35-0455-1357461128d0@gmail.com> From: =?UTF-8?Q?Cl=c3=a9ment_Pit-Claudel?= Message-ID: <926a0bc8-e1c2-91bc-3a88-a16fd149f79b@gmail.com> Date: Thu, 2 Aug 2018 23:33:39 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 5950 Cc: 5950@debbugs.gnu.org, IRIE Shinsuke , Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2018-08-02 13:03, Stefan Monnier wrote: >>> The typical failure case goes like this, user does this: >>> >>> (setq the-package-setting 'foo) >>> (require 'the-package) >>> >>> And the-package.el does this: >>> >>> (defvar the-package-real-setting 'bar) >>> ;; Oops! User's setting of `foo' is overwritten here: >>> (defvaralias 'the-package-setting 'the-package-real-setting) >> >> Thanks. Should the warning be disabled when both variables are >> already `defvar'd, then? > > Why? Replace `setq` with `defvar` in the above scenario and you have > the same problem. Do you? I thought the problem was that you were overwriting a user setting… if you change the first setq into a defvar, where's the user setting that you're overwriting? From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 03 16:23:31 2018 Received: (at 5950) by debbugs.gnu.org; 3 Aug 2018 20:23:31 +0000 Received: from localhost ([127.0.0.1]:40226 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flgbi-0003Jc-UL for submit@debbugs.gnu.org; Fri, 03 Aug 2018 16:23:31 -0400 Received: from mail-oi0-f43.google.com ([209.85.218.43]:36618) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flgbh-0003J8-1l for 5950@debbugs.gnu.org; Fri, 03 Aug 2018 16:23:29 -0400 Received: by mail-oi0-f43.google.com with SMTP id n21-v6so12059544oig.3 for <5950@debbugs.gnu.org>; Fri, 03 Aug 2018 13:23:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=ieCS/OnKl1oMDfAT/gglWKx8+ZBkLJoEHRXh5Wd109k=; b=stoVDpIFH1K5aCn06Dz+UZJh7C8njxRZeIQ0wAPQ6NtQdcFFkU3tNEx8Jh+bSqcF+l l6sGOMQOwE6amyGFJFED3ukaDccWAKswhpkAbxuri0ek8XJuxKducqd6YtU1s3//Pj9x aU4DMB8i1D8DRwcLE00nHnIx2jJuFO4ttZR664gkuOru9Vq5W8b1DzpOmjusnWLk1TrY pBzCVVMVm6ZtwO8b72fPLu0gybBw2K0gH8jUd+IAgPorOrIsVPc2K1i0ntkSgpke5laQ +IpziLfn2H4oR4XBliLjvILvROxg20/CN34x0uZ5FyDyGQ8HWx02rUlU5ZDQ0uoc+A/x 2KwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ieCS/OnKl1oMDfAT/gglWKx8+ZBkLJoEHRXh5Wd109k=; b=kPK0/99KrbXGeMMZif7kGQb3wlQNJb6HRw9564D5+zotrNlLeyfbowd4l0ZVI2f+EL eEZAamo6dNsxO0Kc6UkAp3kpdkW7xdFY62ma6JfDhpbYFJ/fN2KeWnymYwKe2YF/HxX/ WaB91bmbTbSdLl27AXl+X4ga9+QbXWR39bIlSvJPhERwTWbYAoRavynRLl7dq+OMem5+ 6qsMAM7ZH4wr2to04C8tSW2w4P1X5EgrV26QRjmH2EanALOfQW1BMB3C079Xm/accwNv nFb8390E6LA0Hi3qVFccK2pySmVmQW/LlMT/bzDHJ1qvoGnrDP0YaHTDgMpNZ4wnDHLf H8Pw== X-Gm-Message-State: AOUpUlGeEOAnTbjSDkfqKqzhSlntw0AaK5XaTJaa3JE4CJWK3x90vCRT oafeVujScNRUu5wLEx87E/N3qrmAsriukjR+o4Q= X-Google-Smtp-Source: AAOMgpdfWs6BIoFdnhL0tRPSXSMUnIh1DEBwniLypSRvyvVzTW6f29LtXZX6jJhuS3/R6JsrJ1F0HQk+W9BhGttvDg4= X-Received: by 2002:aca:100f:: with SMTP id 15-v6mr4992784oiq.110.1533327803417; Fri, 03 Aug 2018 13:23:23 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a9d:3495:0:0:0:0:0 with HTTP; Fri, 3 Aug 2018 13:23:22 -0700 (PDT) In-Reply-To: <926a0bc8-e1c2-91bc-3a88-a16fd149f79b@gmail.com> References: <4BC6A096.8030801@yahoo.co.jp> <87r5gu34ag.wl%irieshinsuke@yahoo.co.jp> <3keicu1h3v.fsf@fencepost.gnu.org> <874liufjfj.fsf@gmail.com> <871sdyezwl.fsf@gmail.com> <87vaaoxm1z.fsf@gmail.com> <8e11e15a-a806-777e-1b18-3db9000c77de@gmail.com> <775d0859-cb89-3f35-0455-1357461128d0@gmail.com> <926a0bc8-e1c2-91bc-3a88-a16fd149f79b@gmail.com> From: Noam Postavsky Date: Fri, 3 Aug 2018 16:23:22 -0400 Message-ID: Subject: Re: bug#5950: defvaralias after defvar should be warned in runtime To: =?UTF-8?Q?Cl=C3=A9ment_Pit=2DClaudel?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 5950 Cc: 5950@debbugs.gnu.org, IRIE Shinsuke , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2 August 2018 at 23:33, Cl=C3=A9ment Pit-Claudel = wrote: > On 2018-08-02 13:03, Stefan Monnier wrote: >>>> The typical failure case goes like this, user does this: >>>> >>>> (setq the-package-setting 'foo) >>>> (require 'the-package) >>>> >>>> And the-package.el does this: >>>> >>>> (defvar the-package-real-setting 'bar) >>>> ;; Oops! User's setting of `foo' is overwritten here: >>>> (defvaralias 'the-package-setting 'the-package-real-setting) >>> >>> Thanks. Should the warning be disabled when both variables are >>> already `defvar'd, then? >> >> Why? Replace `setq` with `defvar` in the above scenario and you have >> the same problem. > > Do you? I thought the problem was that you were overwriting a user settin= g=E2=80=A6 if you change the first setq into a defvar, where's the user set= ting that you're overwriting? If the user writes defvar instead of setq, it has the exact same effect: they've set the-package-setting to foo, which will be overwritten to bar, same as before. From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 03 17:00:42 2018 Received: (at 5950) by debbugs.gnu.org; 3 Aug 2018 21:00:42 +0000 Received: from localhost ([127.0.0.1]:40242 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flhBh-0004Ut-Vq for submit@debbugs.gnu.org; Fri, 03 Aug 2018 17:00:42 -0400 Received: from mail-qk0-f182.google.com ([209.85.220.182]:44167) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flhBg-0004Ue-Gw for 5950@debbugs.gnu.org; Fri, 03 Aug 2018 17:00:40 -0400 Received: by mail-qk0-f182.google.com with SMTP id v17-v6so4969337qkb.11 for <5950@debbugs.gnu.org>; Fri, 03 Aug 2018 14:00:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=adjEX7PsOZa67V9/bNeFMvL4t1Vi/1qyF3/4JwQ+Fww=; b=uzkWXFuUi4kTot5zd0AUJTGBOPVM6yJy/GEUcWX2RYweI0oblq8LSe7pzUq2zQIUcJ qvqbktKsHZPgqzbexaHXevVFfmoUEbVAAC8B6kE3v8qWJN0fd0D89KpO1ZBPhAJAUS3F ue/Yfm89ACz4uuxxc3eK6qKKmo7AsoUrrjJz35a+0aHoNIc4JPuu2D4IPDsiYPlgTEal F/DfTwqJIQbAntHdW/jlwvIkg/nozOJLt9KdgnixKjoPtODBeE+eifqPcR3NUhdN6ugU /DMoI0hKNQchkKzIMRR6AI7bTFAA5cegQQzgGOO7PbGT6jPVTsv6BLhQm+pQhPsaWJj3 QiBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=adjEX7PsOZa67V9/bNeFMvL4t1Vi/1qyF3/4JwQ+Fww=; b=DN5kxRrNtoXqRsgO+TYHru/YWK2WVxBh7f4l5R4p9t/zCLdt+P/V5d1G9z+v7rRaSM ChVKnstWaWBWPsS6ViDyQLygJqZIqpyS0p5WhYE6AamSQK8W8aFiqVwK66joGgvd02MS 6DqcS4UucyWDGR/p1qcfqFx13ItPOwS2LKF1lXrGgR2oa/D6mGn3N1JNVP8qnzEp+Ob1 TdD/HngB/lqgOLrPUufM6qkEdbwoSGCErG5TD3kBoDS1aT+ME18gdIbUji15vGt4C2vp gfI3YvYtJAvvmBAO8r51x2qO536PPOKfRWLWDi0WJqdwFw6spe9mTuAwm8ZRyoEXBk7I qgdw== X-Gm-Message-State: AOUpUlGhz6QsToVgsmptJb7+RDd1vmR4ruN0KTBnAwqr3CM4QWPLjmNz USJYuzmIhVkCtW+Qb2gCYV7BW3JQ X-Google-Smtp-Source: AAOMgpcZMn517RQuJBmoDL4mI6nkTl4dN9y7tPJ2nZEKgHtEurs0apglpuToyyraJiNLlcPsA5fHqg== X-Received: by 2002:a37:50c3:: with SMTP id e186-v6mr5067589qkb.91.1533330034911; Fri, 03 Aug 2018 14:00:34 -0700 (PDT) Received: from [18.26.2.123] (26-2-123.dynamic.csail.mit.edu. [18.26.2.123]) by smtp.gmail.com with ESMTPSA id z18-v6sm5168152qtz.89.2018.08.03.14.00.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 03 Aug 2018 14:00:34 -0700 (PDT) Subject: Re: bug#5950: defvaralias after defvar should be warned in runtime To: Noam Postavsky References: <4BC6A096.8030801@yahoo.co.jp> <87r5gu34ag.wl%irieshinsuke@yahoo.co.jp> <3keicu1h3v.fsf@fencepost.gnu.org> <874liufjfj.fsf@gmail.com> <871sdyezwl.fsf@gmail.com> <87vaaoxm1z.fsf@gmail.com> <8e11e15a-a806-777e-1b18-3db9000c77de@gmail.com> <775d0859-cb89-3f35-0455-1357461128d0@gmail.com> <926a0bc8-e1c2-91bc-3a88-a16fd149f79b@gmail.com> From: =?UTF-8?Q?Cl=c3=a9ment_Pit-Claudel?= Message-ID: <294c0e22-7741-d1ff-bdbf-f1f96cf112a7@gmail.com> Date: Fri, 3 Aug 2018 17:00:33 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 5950 Cc: 5950@debbugs.gnu.org, IRIE Shinsuke , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2018-08-03 16:23, Noam Postavsky wrote: > On 2 August 2018 at 23:33, Clément Pit-Claudel wrote: >> On 2018-08-02 13:03, Stefan Monnier wrote: >>>>> The typical failure case goes like this, user does this: >>>>> >>>>> (setq the-package-setting 'foo) >>>>> (require 'the-package) >>>>> >>>>> And the-package.el does this: >>>>> >>>>> (defvar the-package-real-setting 'bar) >>>>> ;; Oops! User's setting of `foo' is overwritten here: >>>>> (defvaralias 'the-package-setting 'the-package-real-setting) >>>> >>>> Thanks. Should the warning be disabled when both variables are >>>> already `defvar'd, then? >>> >>> Why? Replace `setq` with `defvar` in the above scenario and you have >>> the same problem. >> >> Do you? I thought the problem was that you were overwriting a user setting… if you change the first setq into a defvar, where's the user setting that you're overwriting? > > If the user writes defvar instead of setq, it has the exact same > effect: they've set the-package-setting to foo, which will be > overwritten to bar, same as before. Right, I understand that. But why would a user write 'defvar' to set a user variable? I guess I'm just a bit confused by the warning. What's the proper way to resolve it? Should I create the alias before loading flycheck? From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 03 17:58:13 2018 Received: (at 5950) by debbugs.gnu.org; 3 Aug 2018 21:58:13 +0000 Received: from localhost ([127.0.0.1]:40255 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fli5N-0005xN-0e for submit@debbugs.gnu.org; Fri, 03 Aug 2018 17:58:13 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]:44264) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fli5L-0005xF-B6 for 5950@debbugs.gnu.org; Fri, 03 Aug 2018 17:58:12 -0400 Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w73Lw7CC032709; Fri, 3 Aug 2018 17:58:08 -0400 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 6B01AAE11E; Fri, 3 Aug 2018 17:58:06 -0400 (EDT) From: Stefan Monnier To: =?windows-1252?Q?Cl=E9ment?= Pit-Claudel Subject: Re: bug#5950: defvaralias after defvar should be warned in runtime Message-ID: References: <4BC6A096.8030801@yahoo.co.jp> <87r5gu34ag.wl%irieshinsuke@yahoo.co.jp> <3keicu1h3v.fsf@fencepost.gnu.org> <874liufjfj.fsf@gmail.com> <871sdyezwl.fsf@gmail.com> <87vaaoxm1z.fsf@gmail.com> <8e11e15a-a806-777e-1b18-3db9000c77de@gmail.com> <775d0859-cb89-3f35-0455-1357461128d0@gmail.com> <926a0bc8-e1c2-91bc-3a88-a16fd149f79b@gmail.com> Date: Fri, 03 Aug 2018 17:58:06 -0400 In-Reply-To: <926a0bc8-e1c2-91bc-3a88-a16fd149f79b@gmail.com> (=?windows-1252?Q?=22Cl=E9ment?= Pit-Claudel"'s message of "Thu, 2 Aug 2018 23:33:39 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.1 X-NAI-Spam-Rules: 3 Rules triggered GEN_SPAM_FEATRE=0.1, EDT_SA_DN_PASS=0, RV6344=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6344> : inlines <6797> : streams <1794464> : uri <2683588> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 5950 Cc: 5950@debbugs.gnu.org, IRIE Shinsuke , Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Do you? I thought the problem was that you were overwriting a user setti= ng=E2=80=A6 > if you change the first setq into a defvar, where's the user setting that > you're overwriting? No, the problem is that you have 2 conflicting settings. Whether one comes from the user doesn't really matter. Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 03 18:09:21 2018 Received: (at 5950) by debbugs.gnu.org; 3 Aug 2018 22:09:21 +0000 Received: from localhost ([127.0.0.1]:40260 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fliG9-0006EW-0j for submit@debbugs.gnu.org; Fri, 03 Aug 2018 18:09:21 -0400 Received: from mail-io0-f182.google.com ([209.85.223.182]:34226) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fliG7-0006EH-Q2 for 5950@debbugs.gnu.org; Fri, 03 Aug 2018 18:09:20 -0400 Received: by mail-io0-f182.google.com with SMTP id l7-v6so6272604ioj.1 for <5950@debbugs.gnu.org>; Fri, 03 Aug 2018 15:09:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=BJG0MVoC0Dz3I4Q7shakWqms5O5kY80tDgRuVMjxu/0=; b=jsNH47tv3eQiQwIKx1DDRw2/wz53eRY2NBJZOhTh2Iv4Su4alxDJajAjSoEIEmpj1r 23y4QC2xwNkF1ahuo9wa2s6oRZybu4BwEbSnzngMKUMug/gS4RuD923NS01yZjqvo6Qd FgwXWxB91+R/Cb5vayvSiT6GmoLJzts8MhvsCJs0CQXSG3B6nWvQCiHCk9nQ06Tdb95H MXmVA+PAXmOWO7AxqFJ69NYyyCnrjNsgl5NAw2OjTRbdNDCAN3R9rSQhFadKkQoZuzZQ ok/9ofEYUnITzXQ6Jj9ByXkIOO2Kvl71TE6Ucb/3t+70o6f7ik0zgta82QzNWm1RgkuD 6XQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=BJG0MVoC0Dz3I4Q7shakWqms5O5kY80tDgRuVMjxu/0=; b=NzeH/ZrIpUsDAvhsuSAWQFdlzBT6bx3ytxxTTKh6JpoG0RZqG1a7a/732Xo0OliasM h0v3GgVYN/tGMkDgde4LuH8Y5RGOebQcREn8jhk8bvWPW1cYblhkAOzwQ6zPRbb0Dmv3 Xvbobu4oNDoiyow6Qm55Gb1ljPpdLe1Gq6dQIMScDJHPhSMldfrtMcr6fS0juvagBvy6 P2xJ7CX+kse9xzzND+IinnfiwoL+wvrYSI9qgaH5seX0q6x5/hZ2q3loile+9GEVGTfx NmmkNRSDoG0A4nIiz6KfugVtISUy8iGNu7OZiHmiIt7O0otOwLIUbx9wd9UUH88JT5jN 5l5A== X-Gm-Message-State: AOUpUlHoIx6OKtx6F3RWzD8KKRDHDJkSBvD63H3HeIx7KBWWV2lrkbkN AD1dxv2QgyvxmWfMD+ZO72Y= X-Google-Smtp-Source: AA+uWPw9OF7Ig8U8hdYHqC2Wk9zk0e/UOuKwXLzzPtoIf9BQguH6M/CilfW3Q0NrJYa9JzhEqiFpRQ== X-Received: by 2002:a6b:9651:: with SMTP id y78-v6mr7876564iod.283.1533334154265; Fri, 03 Aug 2018 15:09:14 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id a133-v6sm1185598itg.1.2018.08.03.15.09.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 03 Aug 2018 15:09:13 -0700 (PDT) From: Noam Postavsky To: =?utf-8?Q?Cl=C3=A9ment?= Pit-Claudel Subject: Re: bug#5950: defvaralias after defvar should be warned in runtime References: <4BC6A096.8030801@yahoo.co.jp> <87r5gu34ag.wl%irieshinsuke@yahoo.co.jp> <3keicu1h3v.fsf@fencepost.gnu.org> <874liufjfj.fsf@gmail.com> <871sdyezwl.fsf@gmail.com> <87vaaoxm1z.fsf@gmail.com> <8e11e15a-a806-777e-1b18-3db9000c77de@gmail.com> <775d0859-cb89-3f35-0455-1357461128d0@gmail.com> <926a0bc8-e1c2-91bc-3a88-a16fd149f79b@gmail.com> <294c0e22-7741-d1ff-bdbf-f1f96cf112a7@gmail.com> Date: Fri, 03 Aug 2018 18:09:12 -0400 In-Reply-To: <294c0e22-7741-d1ff-bdbf-f1f96cf112a7@gmail.com> (=?utf-8?Q?=22Cl=C3=A9ment?= Pit-Claudel"'s message of "Fri, 3 Aug 2018 17:00:33 -0400") Message-ID: <87a7q3yuev.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 5950 Cc: IRIE Shinsuke , 5950@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Cl=C3=A9ment Pit-Claudel writes: > But why would a user write 'defvar' to set a user variable? I don't know, why would a user write 'defvaralias' to set a user variable? They're users, completely unpredictable! ;) > What's the proper way to resolve it? Should I create the alias before > loading flycheck? That would work too. I made a couple of other suggestions in https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D5950#42 Maybe we should add something like (defun defvaralias! (new-alias base-variable &optional docstring) (set new-alias (symbol-value base-variable)) (defvaralias new-alias base-variable docstring)) Which you could use to tell Emacs not to care about losing the original value of NEW-ALIAS. From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 03 18:24:58 2018 Received: (at 5950) by debbugs.gnu.org; 3 Aug 2018 22:24:59 +0000 Received: from localhost ([127.0.0.1]:40280 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fliVG-0006fT-Nv for submit@debbugs.gnu.org; Fri, 03 Aug 2018 18:24:58 -0400 Received: from mail-qt0-f174.google.com ([209.85.216.174]:46967) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fliVE-0006fH-NC for 5950@debbugs.gnu.org; Fri, 03 Aug 2018 18:24:57 -0400 Received: by mail-qt0-f174.google.com with SMTP id d4-v6so7818737qtn.13 for <5950@debbugs.gnu.org>; Fri, 03 Aug 2018 15:24:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ABW6X3NMye2oMkc2kX/m1M1okfR29tHQEmixi3sSO6E=; b=kRYDYAeA6oHWjOc+1ZoPqH3Lv3CQ5FBJn1kaB0aJOQeNvWa4qws0yNuGPk28fSOBXj 1tKgAhnaqmF0BAvpNEuunsvSf8Gqk9gxvhD3kgdZVXopER/4cfSh8pcwhZRZppRmZpgG LeObodKT4sLeJsecryc3vWe3gfssCp7YhrbdGHID7CxJ98PnadMXUP8mUxyPz1CQee5v GQx+J66gvUxUgVWyv+vPUu2QPNy4/43RyJkqRIeLKMHx40y9sUhk1LLj+KoXdoVi+S0F pwgO6NdVFzGWn15r3zzP4emYH0Wd21/asq893sWc6VgULd+TBXTZr4sJB0Ild0qAlvQs f12w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ABW6X3NMye2oMkc2kX/m1M1okfR29tHQEmixi3sSO6E=; b=p5fpfCetlR+9daSeAeMYQdzc1l9yU0XsYbS/aNhscdDIRjpTL9fHKSR5TPW4HE1u/C KOUvJZPCWZ/rcGbUElxTOeaK/HegAE6pzPeFl2zliRsUMJkA0+7+lbEy5AfEEo5s0nXC QJg5oa5u2JX6xMIChZtZu3TR+4yoIgZk7ea3EGPDtUarE89PhRmYb55I1L42kPUSlhie 6XEbOR0B/8aIuo2zMqW1JruUlAnu5mlXspjKnzR4kVvpohawiPT5OLEvWlU2Pojslue1 a3hsfx3iD5hDp3LzqYB54jOZ5tk4skMgzTQouUAfz3txdz1Ms6Ed5VW0aSw2A9hVjyzV NTqQ== X-Gm-Message-State: AOUpUlHo1dwfrG7IRo3PapbnhzNaRNt0xOB8Icj5kMY2TTBDcTzil82G 1Zd2ZTFJjjsEzGjAqmvXqM8= X-Google-Smtp-Source: AAOMgpfbExmc8nDkACPZ2t5eE+eUYu1tUIqWqnmC1GQFwJL7n9vHMN0g3IkQNUx3AIUxh7nXhjU16Q== X-Received: by 2002:ac8:25c4:: with SMTP id f4-v6mr5947742qtf.300.1533335091386; Fri, 03 Aug 2018 15:24:51 -0700 (PDT) Received: from [18.26.2.123] (26-2-123.dynamic.csail.mit.edu. [18.26.2.123]) by smtp.gmail.com with ESMTPSA id m15-v6sm5263252qki.44.2018.08.03.15.24.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 03 Aug 2018 15:24:50 -0700 (PDT) Subject: Re: bug#5950: defvaralias after defvar should be warned in runtime To: Noam Postavsky References: <4BC6A096.8030801@yahoo.co.jp> <87r5gu34ag.wl%irieshinsuke@yahoo.co.jp> <3keicu1h3v.fsf@fencepost.gnu.org> <874liufjfj.fsf@gmail.com> <871sdyezwl.fsf@gmail.com> <87vaaoxm1z.fsf@gmail.com> <8e11e15a-a806-777e-1b18-3db9000c77de@gmail.com> <775d0859-cb89-3f35-0455-1357461128d0@gmail.com> <926a0bc8-e1c2-91bc-3a88-a16fd149f79b@gmail.com> <294c0e22-7741-d1ff-bdbf-f1f96cf112a7@gmail.com> <87a7q3yuev.fsf@gmail.com> From: =?UTF-8?Q?Cl=c3=a9ment_Pit-Claudel?= Message-ID: <64854af9-5e3c-4a33-e879-aae30f5b8135@gmail.com> Date: Fri, 3 Aug 2018 18:24:50 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <87a7q3yuev.fsf@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 5950 Cc: IRIE Shinsuke , 5950@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2018-08-03 18:09, Noam Postavsky wrote: > That would work too. I made a couple of other suggestions in > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=5950#42 Thanks, I missed that reply :) Adding setq before the defalias works fine :) Thanks a lot! From unknown Tue Jun 24 06:58:00 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 01 Sep 2018 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator