GNU bug report logs - #59498
29.0.50; c++-ts-mode get wrong-type-argument error when enabled

Previous Next

Package: emacs;

Reported by: Eason Huang <aqua0210 <at> foxmail.com>

Date: Wed, 23 Nov 2022 02:26:02 UTC

Severity: normal

Tags: patch

Found in version 29.0.50

Fixed in version 29.1

Done: Yuan Fu <casouri <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Yuan Fu <casouri <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Randy Taylor <dev <at> rjt.dev>, 59498 <at> debbugs.gnu.org, aqua0210 <at> foxmail.com, Daniel Martín <mardani29 <at> yahoo.es>, Stefan Kangas <stefankangas <at> gmail.com>, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: bug#59498: 29.0.50; c++-ts-mode get wrong-type-argument error when enabled
Date: Sun, 18 Dec 2022 14:49:12 -0800

> On Dec 18, 2022, at 1:57 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
>> From: Stefan Kangas <stefankangas <at> gmail.com>
>> Date: Sun, 27 Nov 2022 16:24:07 -0800
>> Cc: dev <at> rjt.dev, aqua0210 <at> foxmail.com, 
>> 	Stefan Monnier <monnier <at> iro.umontreal.ca>, 59498 <at> debbugs.gnu.org, mardani29 <at> yahoo.es
>> 
>> Yuan Fu <casouri <at> gmail.com> writes:
>> 
>>>> OK, but do you agree that adding yet another pair of variables,
>>>> treesit-comment-start/end, is the opposite of what we want?
>>> 
>>> Yes. I removed them in d5dc1dbf7cb.
>> 
>> I also think some documentation updates might be needed:
>> 
>> admin/notes/tree-sitter/html-manual/Parser_002dbased-Indentation.html
>> 191: defined by regular expression <code>treesit-comment-end</code>
>> 192: (see <a href="Tree_002dsitter-major-modes.html">treesit-comment-end</a>).
>> 239: expression <code>treesit-comment-start</code> (see <a
>> href="Tree_002dsitter-major-modes.html">treesit-comment-start</a>).
>> This function assumes <var>parent</var> is
>> 248: <code>treesit-comment-start</code>.  This function assumes
>> <var>parent</var> is
>> 
>> doc/lispref/modes.texi
>> 4974: defined by regular expression @code{treesit-comment-end}
>> 4975: (@pxref{Tree-sitter major modes, treesit-comment-end}).
>> 5014: expression @code{treesit-comment-start} (@pxref{Tree-sitter major
>> 5015: modes, treesit-comment-start}).  This function assumes @var{parent} is
>> 5023: @code{treesit-comment-start}.  This function assumes @var{parent} is
>> 
>> doc/lispref/parsing.texi
>> 1733: @defvar treesit-comment-start
>> 1739: @defvar treesit-comment-end
>> 
>> lisp/treesit.el
>> 1180:     Matches if text after point matches `treesit-comment-end'.
>> 1215:     Returns the position after a match for `treesit-comment-start'.
> 
> Yuan, would you please update the above places to remove references to
> these two variables that no longer exist?
> 
> TIA

Ah, yes, sorry. I made the change.

Yuan



This bug report was last modified 2 years and 231 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.