GNU bug report logs - #59490
29.0.50; Add C# support

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 59490 in the body.
You can then email your comments to 59490 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Theodor Thornhill <theo <at> thornhill.no>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; Add C# support
Date: Tue, 22 Nov 2022 21:52:05 +0100

[Message part 1 (text/plain, inline)]

Hi Yuan, Jostein and others.

Added is support for C# in Emacs.  This is the original C# mode as found
on ELPA [0], as well as support for the new tree sitter mechanisms.

I made two new modes, 'csharp-cc-mode' and 'csharp-ts-mode'. The cc-mode
variant has that name as to not conflict with the ELPA package.

Please shoot comments at me, and I'll fix them.

Hope you like it,

Theodor

[0]: https://github.com/emacs-csharp/csharp-mode

[0001-Add-csharp-cc-ts-mode.patch (text/x-diff, attachment)]

Message #8 received at 59490 <at> debbugs.gnu.org (full text, mbox):

From: Theodor Thornhill <theo <at> thornhill.no>
To: 59490 <at> debbugs.gnu.org
Subject: 29.0.50; Add C# support
Date: Tue, 22 Nov 2022 22:25:56 +0100

Hmm, It seems I've made a mistake in the C# CC mode variant.  Just wait
a little, and let me find the problem :-)

Theo

Message #11 received at 59490 <at> debbugs.gnu.org (full text, mbox):

From: Theodor Thornhill <theo <at> thornhill.no>
To: 59490 <at> debbugs.gnu.org
Subject: 29.0.50; Add C# support
Date: Tue, 22 Nov 2022 22:47:12 +0100

[Message part 1 (text/plain, inline)]

Ok so this works.

Sorry for the mess.

What do you think?

Theo

[0001-Add-csharp-mode-and-csharp-ts-mode.patch (text/x-diff, attachment)]

Message #14 received at 59490 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Theodor Thornhill <theo <at> thornhill.no>
Cc: 59490 <at> debbugs.gnu.org
Subject: Re: bug#59490: 29.0.50; Add C# support
Date: Wed, 23 Nov 2022 14:16:05 +0200

> Date: Tue, 22 Nov 2022 22:47:12 +0100
> From:  Theodor Thornhill via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> Ok so this works.
> 
> Sorry for the mess.
> 
> What do you think?

LGTM, thanks.  I'll let Yuan review and install.

Message #17 received at 59490 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: theo <at> thornhill.no, 59490 <at> debbugs.gnu.org
Subject: Re: bug#59490: 29.0.50; Add C# support
Date: Wed, 23 Nov 2022 10:29:57 -0800

Eli Zaretskii <eliz <at> gnu.org> writes:

>> Date: Tue, 22 Nov 2022 22:47:12 +0100
>> From:  Theodor Thornhill via "Bug reports for GNU Emacs,
>>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
>> 
>> Ok so this works.
>> 
>> Sorry for the mess.
>> 
>> What do you think?
>
> LGTM, thanks.  I'll let Yuan review and install.

Thanks Theo! I’ve merged it. One general comment is that we should have
a "standard" list of features consistent across major modes. I think by
now we’ve worked on font-lock enough to know what those features should
be. I’ll start a discussion on the ML.

Yuan

Message #20 received at 59490 <at> debbugs.gnu.org (full text, mbox):

From: Theodor Thornhill <theo <at> thornhill.no>
To: Yuan Fu <casouri <at> gmail.com>, Eli Zaretskii <eliz <at> gnu.org>
Cc: 59490 <at> debbugs.gnu.org
Subject: Re: bug#59490: 29.0.50; Add C# support
Date: Wed, 23 Nov 2022 19:44:05 +0100

On 23 November 2022 19:29:57 CET, Yuan Fu <casouri <at> gmail.com> wrote:
>
>Eli Zaretskii <eliz <at> gnu.org> writes:
>
>>> Date: Tue, 22 Nov 2022 22:47:12 +0100
>>> From:  Theodor Thornhill via "Bug reports for GNU Emacs,
>>>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
>>> 
>>> Ok so this works.
>>> 
>>> Sorry for the mess.
>>> 
>>> What do you think?
>>
>> LGTM, thanks.  I'll let Yuan review and install.
>
>Thanks Theo! I’ve merged it. One general comment is that we should have
>a "standard" list of features consistent across major modes. I think by
>now we’ve worked on font-lock enough to know what those features should
>be. I’ll start a discussion on the ML.
>
>Yuan

I agree!

Message #23 received at 59490 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: theo <at> thornhill.no, 59490 <at> debbugs.gnu.org
Subject: Re: bug#59490: 29.0.50; Add C# support
Date: Wed, 23 Nov 2022 12:38:19 -0800

Yuan Fu <casouri <at> gmail.com> writes:

> Eli Zaretskii <eliz <at> gnu.org> writes:
>
>>> Date: Tue, 22 Nov 2022 22:47:12 +0100
>>> From:  Theodor Thornhill via "Bug reports for GNU Emacs,
>>>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
>>> 
>>> Ok so this works.
>>> 
>>> Sorry for the mess.
>>> 
>>> What do you think?
>>
>> LGTM, thanks.  I'll let Yuan review and install.
>
> Thanks Theo! I’ve merged it. One general comment is that we should have
> a "standard" list of features consistent across major modes. I think by
> now we’ve worked on font-lock enough to know what those features should
> be. I’ll start a discussion on the ML.

Actually, another thing: it seems the mode defined is still named
csharp-mode rather than csharp-cc-mode.

Yuan

Message #26 received at 59490 <at> debbugs.gnu.org (full text, mbox):

From: Theodor Thornhill <theo <at> thornhill.no>
To: Yuan Fu <casouri <at> gmail.com>, Eli Zaretskii <eliz <at> gnu.org>
Cc: 59490 <at> debbugs.gnu.org
Subject: Re: bug#59490: 29.0.50; Add C# support
Date: Wed, 23 Nov 2022 21:43:23 +0100

On 23 November 2022 21:38:19 CET, Yuan Fu <casouri <at> gmail.com> wrote:
>
>Yuan Fu <casouri <at> gmail.com> writes:
>
>> Eli Zaretskii <eliz <at> gnu.org> writes:
>>
>>>> Date: Tue, 22 Nov 2022 22:47:12 +0100
>>>> From:  Theodor Thornhill via "Bug reports for GNU Emacs,
>>>>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
>>>> 
>>>> Ok so this works.
>>>> 
>>>> Sorry for the mess.
>>>> 
>>>> What do you think?
>>>
>>> LGTM, thanks.  I'll let Yuan review and install.
>>
>> Thanks Theo! I’ve merged it. One general comment is that we should have
>> a "standard" list of features consistent across major modes. I think by
>> now we’ve worked on font-lock enough to know what those features should
>> be. I’ll start a discussion on the ML.
>
>Actually, another thing: it seems the mode defined is still named
>csharp-mode rather than csharp-cc-mode.
>
>Yuan

Yeah that's right. Imo that's ok, because it's unlikely there will be much new development on the cc mode variant. So it will be identical to the upstream one, and the upstream one will be marked as deprecated very soon.

What do you think?

Message #29 received at 59490 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Theodor Thornhill <theo <at> thornhill.no>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 59490 <at> debbugs.gnu.org
Subject: Re: bug#59490: 29.0.50; Add C# support
Date: Wed, 23 Nov 2022 13:19:21 -0800

> On Nov 23, 2022, at 12:43 PM, Theodor Thornhill <theo <at> thornhill.no> wrote:
> 
> 
> 
> On 23 November 2022 21:38:19 CET, Yuan Fu <casouri <at> gmail.com> wrote:
>> 
>> Yuan Fu <casouri <at> gmail.com> writes:
>> 
>>> Eli Zaretskii <eliz <at> gnu.org> writes:
>>> 
>>>>> Date: Tue, 22 Nov 2022 22:47:12 +0100
>>>>> From:  Theodor Thornhill via "Bug reports for GNU Emacs,
>>>>> the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
>>>>> 
>>>>> Ok so this works.
>>>>> 
>>>>> Sorry for the mess.
>>>>> 
>>>>> What do you think?
>>>> 
>>>> LGTM, thanks.  I'll let Yuan review and install.
>>> 
>>> Thanks Theo! I’ve merged it. One general comment is that we should have
>>> a "standard" list of features consistent across major modes. I think by
>>> now we’ve worked on font-lock enough to know what those features should
>>> be. I’ll start a discussion on the ML.
>> 
>> Actually, another thing: it seems the mode defined is still named
>> csharp-mode rather than csharp-cc-mode.
>> 
>> Yuan
> 
> Yeah that's right. Imo that's ok, because it's unlikely there will be much new development on the cc mode variant. So it will be identical to the upstream one, and the upstream one will be marked as deprecated very soon.
> 
> What do you think?

Yeah I was just confused because you said

> I made two new modes, 'csharp-cc-mode' and 'csharp-ts-mode'. The cc-mode
> variant has that name as to not conflict with the ELPA package.

And I only see csharp-mode.

So the mode we provide in Emacs are csharp-mode and csharp-ts-mode? Then I assume this line is a typo?

;;;###autoload
(add-to-list 'auto-mode-alist '("\\.cs\\'" . csharp-cc-mode))

Yuan

Message #32 received at 59490 <at> debbugs.gnu.org (full text, mbox):

From: Theodor Thornhill <theo <at> thornhill.no>
To: Yuan Fu <casouri <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 59490 <at> debbugs.gnu.org
Subject: Re: bug#59490: 29.0.50; Add C# support
Date: Wed, 23 Nov 2022 22:25:12 +0100

On 23 November 2022 22:19:21 CET, Yuan Fu <casouri <at> gmail.com> wrote:
>
>
>> On Nov 23, 2022, at 12:43 PM, Theodor Thornhill <theo <at> thornhill.no> wrote:
>> 
>> 
>> 
>> On 23 November 2022 21:38:19 CET, Yuan Fu <casouri <at> gmail.com> wrote:
>>> 
>>> Yuan Fu <casouri <at> gmail.com> writes:
>>> 
>>>> Eli Zaretskii <eliz <at> gnu.org> writes:
>>>> 
>>>>>> Date: Tue, 22 Nov 2022 22:47:12 +0100
>>>>>> From:  Theodor Thornhill via "Bug reports for GNU Emacs,
>>>>>> the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
>>>>>> 
>>>>>> Ok so this works.
>>>>>> 
>>>>>> Sorry for the mess.
>>>>>> 
>>>>>> What do you think?
>>>>> 
>>>>> LGTM, thanks.  I'll let Yuan review and install.
>>>> 
>>>> Thanks Theo! I’ve merged it. One general comment is that we should have
>>>> a "standard" list of features consistent across major modes. I think by
>>>> now we’ve worked on font-lock enough to know what those features should
>>>> be. I’ll start a discussion on the ML.
>>> 
>>> Actually, another thing: it seems the mode defined is still named
>>> csharp-mode rather than csharp-cc-mode.
>>> 
>>> Yuan
>> 
>> Yeah that's right. Imo that's ok, because it's unlikely there will be much new development on the cc mode variant. So it will be identical to the upstream one, and the upstream one will be marked as deprecated very soon.
>> 
>> What do you think?
>
>Yeah I was just confused because you said
>
>> I made two new modes, 'csharp-cc-mode' and 'csharp-ts-mode'. The cc-mode
>> variant has that name as to not conflict with the ELPA package.

Yep, that was unclear. I decided to skip it in the second patch :)

>
>And I only see csharp-mode.
>
>So the mode we provide in Emacs are csharp-mode and csharp-ts-mode? Then I assume this line is a typo?
>
>;;;###autoload
>(add-to-list 'auto-mode-alist '("\\.cs\\'" . csharp-cc-mode))
>
>Yuan
>

That's correct. That's a typo. My bad :) make it csharp-mode. You want a new patch?

Message #35 received at 59490 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Theodor Thornhill <theo <at> thornhill.no>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 59490 <at> debbugs.gnu.org
Subject: Re: bug#59490: 29.0.50; Add C# support
Date: Wed, 23 Nov 2022 15:03:53 -0800

> On Nov 23, 2022, at 1:25 PM, Theodor Thornhill <theo <at> thornhill.no> wrote:
> 
> 
> 
> On 23 November 2022 22:19:21 CET, Yuan Fu <casouri <at> gmail.com> wrote:
>> 
>> 
>>> On Nov 23, 2022, at 12:43 PM, Theodor Thornhill <theo <at> thornhill.no> wrote:
>>> 
>>> 
>>> 
>>> On 23 November 2022 21:38:19 CET, Yuan Fu <casouri <at> gmail.com> wrote:
>>>> 
>>>> Yuan Fu <casouri <at> gmail.com> writes:
>>>> 
>>>>> Eli Zaretskii <eliz <at> gnu.org> writes:
>>>>> 
>>>>>>> Date: Tue, 22 Nov 2022 22:47:12 +0100
>>>>>>> From:  Theodor Thornhill via "Bug reports for GNU Emacs,
>>>>>>> the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
>>>>>>> 
>>>>>>> Ok so this works.
>>>>>>> 
>>>>>>> Sorry for the mess.
>>>>>>> 
>>>>>>> What do you think?
>>>>>> 
>>>>>> LGTM, thanks.  I'll let Yuan review and install.
>>>>> 
>>>>> Thanks Theo! I’ve merged it. One general comment is that we should have
>>>>> a "standard" list of features consistent across major modes. I think by
>>>>> now we’ve worked on font-lock enough to know what those features should
>>>>> be. I’ll start a discussion on the ML.
>>>> 
>>>> Actually, another thing: it seems the mode defined is still named
>>>> csharp-mode rather than csharp-cc-mode.
>>>> 
>>>> Yuan
>>> 
>>> Yeah that's right. Imo that's ok, because it's unlikely there will be much new development on the cc mode variant. So it will be identical to the upstream one, and the upstream one will be marked as deprecated very soon.
>>> 
>>> What do you think?
>> 
>> Yeah I was just confused because you said
>> 
>>> I made two new modes, 'csharp-cc-mode' and 'csharp-ts-mode'. The cc-mode
>>> variant has that name as to not conflict with the ELPA package.
> 
> Yep, that was unclear. I decided to skip it in the second patch :)
> 
>> 
>> And I only see csharp-mode.
>> 
>> So the mode we provide in Emacs are csharp-mode and csharp-ts-mode? Then I assume this line is a typo?
>> 
>> ;;;###autoload
>> (add-to-list 'auto-mode-alist '("\\.cs\\'" . csharp-cc-mode))
>> 
>> Yuan
>> 
> 
> That's correct. That's a typo. My bad :) make it csharp-mode. You want a new patch?

I applied the patch with that change :-)

Yuan

Message #38 received at 59490 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Yuan Fu <casouri <at> gmail.com>
Cc: theo <at> thornhill.no, 59490 <at> debbugs.gnu.org
Subject: Re: bug#59490: 29.0.50; Add C# support
Date: Thu, 24 Nov 2022 08:25:51 +0200

> From: Yuan Fu <casouri <at> gmail.com>
> Date: Wed, 23 Nov 2022 12:38:19 -0800
> Cc: theo <at> thornhill.no,
>  59490 <at> debbugs.gnu.org
> 
> Actually, another thing: it seems the mode defined is still named
> csharp-mode rather than csharp-cc-mode.

I think it is better in general to keep the name of the existing mode for
which this one is supposed to be a replacement/continuation.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.