Subject: Re: Eglot does not advertise resolveSupport capabilities

From: Marcin Pajkowski <[email-masked]>
Date: Tue, 22 Nov 2022 21:24:39 +0100

Hi,

I added bug reference number to the commit message.

Marcin

pon., 21 lis 2022 o 22:04 Marcin Pajkowski <[email-masked]>
napisał(a):

> Hi Emacs developers,
>
> I recently found that Eglot does not receive
> completions with additional text edits from servers
> that expect such capability to be advertised by client.
>
> This advertisement is required by rust-analyzer server
> to provide completions for symbols that are not resolved
> but can be automatically imported.
>
> This patch fixes this issue.
>
> Marcin
>
From b290face2792b254ad9567d007205e715da48283 Mon Sep 17 00:00:00 2001
From: Marcin Pajkowski <[email-masked]>
Date: Sun, 20 Nov 2022 20:03:57 +0100
Subject: [PATCH] Eglot: Advertise completion.resolveSupport capabilities

Some servers avoid reporting completion items that require
"additionalTextEdits" capability. Actually eglot-completion-at-point
function supports such feature so it can be advertised to LSP server.

* lisp/progmodes/eglot.el
  (eglot-client-capabilities): Advertise resolveSupport.  (bug#59465)
---
 lisp/progmodes/eglot.el | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
index bbd902c1c7..fab3b1cac0 100644
--- a/lisp/progmodes/eglot.el
+++ b/lisp/progmodes/eglot.el
@@ -737,7 +737,10 @@ eglot-client-capabilities
                                            t
                                          :json-false)
                                       :deprecatedSupport t
+                                      :resolveSupport (:properties
+                                                       ["documentation"
+                                                        "details"
+                                                        "additionalTextEdits"])
                                       :tagSupport (:valueSet [1]))
                                     :contextSupport t)
              :hover              (list :dynamicRegistration :json-false
--
2.38.1