GNU bug report logs - #59459
29.0.50; Compilation warnings without tree-sitter

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Yuan Fu <casouri <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#59459: closed (29.0.50; Compilation warnings without tree-sitter)
Date: Tue, 22 Nov 2022 23:23:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 22 Nov 2022 15:22:10 -0800
with message-id <70E5913F-2B44-4053-A7A3-8DC713607EFB <at> gmail.com>
and subject line Re: bug#59459: 29.0.50; Compilation warnings without tree-sitter
has caused the debbugs.gnu.org bug report #59459,
regarding 29.0.50; Compilation warnings without tree-sitter
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
59459: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59459
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Yuan Fu <casouri <at> gmail.com>
To: Bug Report Emacs <bug-gnu-emacs <at> gnu.org>
Subject: 29.0.50; Compilation warnings without tree-sitter
Date: Mon, 21 Nov 2022 14:01:14 -0800

[Continuing from bug#59426]

Those warnings are due to no-tree-sitter build not having functions
defined in treesit.c. Eli fixed those warnings by adding
declare-function’s in every file using those functions. Can we make it a
bit nicer for lisp developers? Maybe defining those functions with
dummies with something like

(defun xxx
(error ’treesit "Tree-sitter not available"))

?

Yuan

[Message part 3 (message/rfc822, inline)]

From: Yuan Fu <casouri <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 59459 <at> debbugs.gnu.org, 59459-done <at> debbugs.gnu.org
Subject: Re: bug#59459: 29.0.50; Compilation warnings without tree-sitter
Date: Tue, 22 Nov 2022 15:22:10 -0800

> On Nov 22, 2022, at 4:21 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
>> From: Yuan Fu <casouri <at> gmail.com>
>> Date: Mon, 21 Nov 2022 14:01:14 -0800
>> 
>> [Continuing from bug#59426]
>> 
>> Those warnings are due to no-tree-sitter build not having functions
>> defined in treesit.c. Eli fixed those warnings by adding
>> declare-function’s in every file using those functions. Can we make it a
>> bit nicer for lisp developers? Maybe defining those functions with
>> dummies with something like
>> 
>> (defun xxx
>> (error ’treesit "Tree-sitter not available"))
>> 
>> ?
> 
> I'm not sure this is justified.  The cases where a build lacks a very large
> group of primitives references in *.el files are quite rare in our practice;
> about the only two examples I know of are xwidgets.el and treesit.el (plus
> modes which use tree-sitter).  It's easy enough (albeit annoying) to add a
> few declare-function's, so unless we are going to have more and more of
> these cases, adding a whole new infrastructure, let alone tricks like the
> above, which will raise a lot of brows, sound excessive to me.

If it cannot be easily done with existing tools, then I agree declare-function is good enough.

Thanks,
Yuan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.