From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 21 17:01:33 2022 Received: (at submit) by debbugs.gnu.org; 21 Nov 2022 22:01:33 +0000 Received: from localhost ([127.0.0.1]:49039 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxEr7-0001wG-56 for submit@debbugs.gnu.org; Mon, 21 Nov 2022 17:01:33 -0500 Received: from lists.gnu.org ([209.51.188.17]:46392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxEr3-0001w6-Au for submit@debbugs.gnu.org; Mon, 21 Nov 2022 17:01:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxEqu-0002Fj-B8 for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2022 17:01:25 -0500 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oxEqs-00066Q-CH for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2022 17:01:19 -0500 Received: by mail-pl1-x634.google.com with SMTP id w23so11791619ply.12 for ; Mon, 21 Nov 2022 14:01:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:date:message-id:subject:mime-version:content-transfer-encoding :from:from:to:cc:subject:date:message-id:reply-to; bh=D0DZxWqeRmO4Wc6vPYUqFUtXLcgiEa3tYLd7JsyYO8Y=; b=AnDSddwBC6jFBm+RvmYsYr4WHXn/XUpppPuvLVZKx6ARII0Eq/3oXgDqwaCEqTQ0Sb PBkpg6Dv4M3Kzon0kfzxuLzyZ9hD/0ltG1jfSRWmB+dhWrVm3CHUJPfKet+h+TjDJEhK fLUsrniiQbCPWRDvOYmHSvq7nqwO3WevG0OX/10420tc0E7LJBcRRm2Zcmt1FWz/cg6x 6R9nBR4fNt1G0Yk4PMCunIKqt3ElwgZ4uT3DpHQRRLb1dHSZdLF5XuRgYvrAW+7NAOxW GgKnsJLLexgD51NlIOUIM6X3Ux1D48kPr5P2Uljnena/2v2W/b60BOnZ25Z1p1uNmUUB 6QqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:date:message-id:subject:mime-version:content-transfer-encoding :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=D0DZxWqeRmO4Wc6vPYUqFUtXLcgiEa3tYLd7JsyYO8Y=; b=wWKrg0eaKPClFKwu9qT3UZvw4gZlsa5iDLeU76Pwf8oFOVd7GUNxzMZfrIzohzJZW1 IHJG05yrHI88Wj1FPqnKkbhFNVB1mCV/rUgdGmv9yoHMh0o3+j56E64XVnplWC5q60tO CrwhbRUCHb9Oz+6O+lbsr07pBwz7EWS+NC9NPXaSWJI1BsRmKUVVzBHYgbhhyVW5j8CT Zw/aWd6XoOKJJScs3TlLOWq+HV8KzWA6IddPY4aqNef369d37ixqjqfehDuep+MgfWae 48F/1ikA8de9+dTaloufPeRQX2O8fFtDHnsikkNhvFN6wFt6R+4lfU6RGfK5ra+Y9ylA tG4Q== X-Gm-Message-State: ANoB5pnq0SO+paVV2r9u5lIoUdhwjH1WeH8+faAqNT3VX992aLxiq+N3 U4girxdW5Ru2HANNpwlcXCqaA+6tIPk= X-Google-Smtp-Source: AA0mqf7SGQN0u+Ugb/SZrkIh5BXR5PT9CDfsaFvHXFWvBfISuarAfWbA8ltbI2BQrXiMOxTNllpbxw== X-Received: by 2002:a17:902:8d93:b0:17f:8042:7223 with SMTP id v19-20020a1709028d9300b0017f80427223mr5262234plo.38.1669068076071; Mon, 21 Nov 2022 14:01:16 -0800 (PST) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id u3-20020a170902714300b00188f07c9eedsm10187298plm.176.2022.11.21.14.01.15 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Nov 2022 14:01:15 -0800 (PST) From: Yuan Fu Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: 29.0.50; Compilation warnings without tree-sitter Message-Id: <9FA0FE0E-30D9-47DB-8263-F75567B6F228@gmail.com> Date: Mon, 21 Nov 2022 14:01:14 -0800 To: Bug Report Emacs X-Mailer: Apple Mail (2.3696.120.41.1.1) Received-SPF: pass client-ip=2607:f8b0:4864:20::634; envelope-from=casouri@gmail.com; helo=mail-pl1-x634.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) [Continuing from bug#59426] Those warnings are due to no-tree-sitter build not having functions defined in treesit.c. Eli fixed those warnings by adding declare-function=E2=80=99s in every file using those functions. Can we = make it a bit nicer for lisp developers? Maybe defining those functions with dummies with something like (defun xxx (error =E2=80=99treesit "Tree-sitter not available")) ? Yuan= From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 22 07:21:15 2022 Received: (at 59459) by debbugs.gnu.org; 22 Nov 2022 12:21:15 +0000 Received: from localhost ([127.0.0.1]:50108 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxSH4-0002yK-Uc for submit@debbugs.gnu.org; Tue, 22 Nov 2022 07:21:15 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34186) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxSH3-0002y8-7b for 59459@debbugs.gnu.org; Tue, 22 Nov 2022 07:21:14 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxSGx-0000bs-Uy; Tue, 22 Nov 2022 07:21:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=GLRVxus4BS82DXXry2nOuNZlTXUEm3mpDDQ/Z0oZnkE=; b=oQZh0ReytNaFoCLbg3dj Rf8N3MBu0zWs8VRC22CHFcnj6HQWGksXXqPtVF3tOJnx4N25S1xHXQOkXrBjTUq5R7QA4u0EVf982 9v0BhWoWxSEaR3tbsWEBiaGvLsLibIAQuGQKhGIYJoxT7PtrH8eqos071TLm3gXZHYEup1nnVltFx OO+S658PSchjFuXM8cyKk2rqpea5RAFA2XAckJcEyGlfjR0evOJ7+yuxuOQ/fA2/FHXBfXdRDChpP yh4/sSarL3t0yjiVEN66lAn+wD1u+DH3VuXtgjEAJHXUSLTNxMFMrZJaMIxKokZcqobFhwE25iGAK Qog49YQwCMdyag==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxSGk-0000FF-SA; Tue, 22 Nov 2022 07:21:07 -0500 Date: Tue, 22 Nov 2022 14:21:08 +0200 Message-Id: <83wn7n18p7.fsf@gnu.org> From: Eli Zaretskii To: Yuan Fu In-Reply-To: <9FA0FE0E-30D9-47DB-8263-F75567B6F228@gmail.com> (message from Yuan Fu on Mon, 21 Nov 2022 14:01:14 -0800) Subject: Re: bug#59459: 29.0.50; Compilation warnings without tree-sitter References: <9FA0FE0E-30D9-47DB-8263-F75567B6F228@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59459 Cc: 59459@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Yuan Fu > Date: Mon, 21 Nov 2022 14:01:14 -0800 > > [Continuing from bug#59426] > > Those warnings are due to no-tree-sitter build not having functions > defined in treesit.c. Eli fixed those warnings by adding > declare-function’s in every file using those functions. Can we make it a > bit nicer for lisp developers? Maybe defining those functions with > dummies with something like > > (defun xxx > (error ’treesit "Tree-sitter not available")) > > ? I'm not sure this is justified. The cases where a build lacks a very large group of primitives references in *.el files are quite rare in our practice; about the only two examples I know of are xwidgets.el and treesit.el (plus modes which use tree-sitter). It's easy enough (albeit annoying) to add a few declare-function's, so unless we are going to have more and more of these cases, adding a whole new infrastructure, let alone tricks like the above, which will raise a lot of brows, sound excessive to me. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 22 18:22:21 2022 Received: (at 59459) by debbugs.gnu.org; 22 Nov 2022 23:22:21 +0000 Received: from localhost ([127.0.0.1]:52857 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxcar-0001yS-8F for submit@debbugs.gnu.org; Tue, 22 Nov 2022 18:22:21 -0500 Received: from mail-pl1-f169.google.com ([209.85.214.169]:34313) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxcao-0001xp-7K; Tue, 22 Nov 2022 18:22:19 -0500 Received: by mail-pl1-f169.google.com with SMTP id w4so6313643plp.1; Tue, 22 Nov 2022 15:22:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ihDT6tjXHovJQvBwkPfdvNCm8y0OF9SvZ8n2r1N/qA4=; b=FjVwPqc9+Qw3F/noW4GQ3VzXsJErXwHZrJwclga7KmPnsAdAH6vEEyuJh/qb/MVx/c wtTxpzARjC4wV54oL9IDXi1OfCOqyJ+MDWibJ0miE0uZI+XJFxZ+QlQavONWfBP918u3 6GBMnddz3knmd0vIMk+AzSvfpX1K6btsugO9NBkkJp/YwcXOJm/JA9smaa/3RXAYckn3 Z6Liev0Z1VXKkWdOxHUgeJypS38eRJMeKQqkBusTxI5q/TySam5QB9rgyLQAWkqO7rrs 37sjenKHwisrGqSYq3lU6leB6pAP2Mdqng3WdJZJ1DEEwljIrlJlQVbfLFYJlG2NIiNS NeKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ihDT6tjXHovJQvBwkPfdvNCm8y0OF9SvZ8n2r1N/qA4=; b=10lhhSCe3zkhrxWSdkRg5+yEvN162OfAK4LcflWEaj9zVtRNirjaHtqnK/DFPzjJQC J/dYZDyIO02kiq15L4QvGQ2FTunl8gSsexJW3ri+IzdLOvQjWebxr2bIphVJNeNb0wzs z1zJVY7IqlrOD9WEJFa7zwfa+NfOUxP7nQeZooqh+XO99Chq1ZPz8xXc3weg4+5WsvfD h/9vaIuQ6DZn8M0dtoeNgr/LHgeHUb8r+JnJwttx2Wi9IeJouOiQj16R+S0/q7BSXjVA 7R2fEwNUegLxvVn2/429smN797j8q+I5D620YNn7P8e2qmdkvVdQOAB03DERUiYuDOFE DTWA== X-Gm-Message-State: ANoB5plQRueBJ1CiQ2mBdIeSQUyKLjSn7ePZUJ7l3+6oq1TjqnWMuJ4d yUV55daZguddEHbCc+NrnxoYi+AdQ14icA== X-Google-Smtp-Source: AA0mqf7LJGxHnTmZqJjk451YtjGC93icnhY5GPLKYqBsAWdjhe5/WO5X5G8rFW/Ufof6wMpoyLkFjQ== X-Received: by 2002:a17:902:e807:b0:186:fb90:5774 with SMTP id u7-20020a170902e80700b00186fb905774mr6915259plg.137.1669159332457; Tue, 22 Nov 2022 15:22:12 -0800 (PST) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id mj24-20020a17090b369800b00214247989dfsm100703pjb.13.2022.11.22.15.22.11 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Nov 2022 15:22:12 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: bug#59459: 29.0.50; Compilation warnings without tree-sitter From: Yuan Fu In-Reply-To: <83wn7n18p7.fsf@gnu.org> Date: Tue, 22 Nov 2022 15:22:10 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: <70E5913F-2B44-4053-A7A3-8DC713607EFB@gmail.com> References: <9FA0FE0E-30D9-47DB-8263-F75567B6F228@gmail.com> <83wn7n18p7.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59459 Cc: 59459@debbugs.gnu.org, 59459-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Nov 22, 2022, at 4:21 AM, Eli Zaretskii wrote: >=20 >> From: Yuan Fu >> Date: Mon, 21 Nov 2022 14:01:14 -0800 >>=20 >> [Continuing from bug#59426] >>=20 >> Those warnings are due to no-tree-sitter build not having functions >> defined in treesit.c. Eli fixed those warnings by adding >> declare-function=E2=80=99s in every file using those functions. Can = we make it a >> bit nicer for lisp developers? Maybe defining those functions with >> dummies with something like >>=20 >> (defun xxx >> (error =E2=80=99treesit "Tree-sitter not available")) >>=20 >> ? >=20 > I'm not sure this is justified. The cases where a build lacks a very = large > group of primitives references in *.el files are quite rare in our = practice; > about the only two examples I know of are xwidgets.el and treesit.el = (plus > modes which use tree-sitter). It's easy enough (albeit annoying) to = add a > few declare-function's, so unless we are going to have more and more = of > these cases, adding a whole new infrastructure, let alone tricks like = the > above, which will raise a lot of brows, sound excessive to me. If it cannot be easily done with existing tools, then I agree = declare-function is good enough. Thanks, Yuan= From unknown Sat Sep 20 08:01:13 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 21 Dec 2022 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator