GNU bug report logs - #59458
[PATCH] Fix tracing for advanced scoring

Previous Next

Full log

Message #25 received at 59458-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 59458-done <at> debbugs.gnu.org,
 Lars Ingebrigtsen <larsi <at> gnus.org>,
 Łukasz Stelmach <stlman <at> poczta.fm>
Subject: Re: bug#59458: [PATCH] Fix tracing for advanced scoring
Date: Mon, 11 Sep 2023 17:32:20 -0700

Version: 30.1

Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:

> On 09/07/23 14:07 PM, Stefan Kangas wrote:
>
>> Eric,
>>
>> It would be great if you could help review this.  Thanks in advance.
>
> I've taken a closer look, and I do think this is okay. The `when' after
> the `dolist' only fires if the rule matches, the `if' is only there to
> see if this article has been previously scored or not. So moving the
> "(when trace" up to the top-level of the containing `when' (ie, out of the
> `if') does look like the right thing to do.

Thanks.  Installed it on master as commit e25ad6e2a30.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.