GNU bug report logs - #59458
[PATCH] Fix tracing for advanced scoring

Previous Next

Full log

Message #17 received at 59458 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefankangas <at> gmail.com>, Andrew Cohen <cohen <at> bu.edu>
Cc: eric <at> ericabrahamsen.net, larsi <at> gnus.org, 59458 <at> debbugs.gnu.org,
 stlman <at> poczta.fm
Subject: Re: bug#59458: [PATCH] Fix tracing for advanced scoring
Date: Fri, 08 Sep 2023 09:04:52 +0300

> From: Stefan Kangas <stefankangas <at> gmail.com>
> Date: Thu, 7 Sep 2023 14:07:57 -0700
> Cc: Eli Zaretskii <eliz <at> gnu.org>, Lars Ingebrigtsen <larsi <at> gnus.org>, 59458 <at> debbugs.gnu.org, 
> 	Łukasz Stelmach <stlman <at> poczta.fm>
> 
> Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:
> 
> > Eli Zaretskii <eliz <at> gnu.org> writes:
> >
> >>> Cc: Łukasz Stelmach <stlman <at> poczta.fm>
> >>> From: Łukasz Stelmach <stlman <at> poczta.fm>
> >>> Date: Mon, 21 Nov 2022 22:30:55 +0100
> >>>
> >>> * lisp/gnus/gnus-logic.el (gnus-score-advanced): Move the tracing
> >>> code outside of if so it's executed for both branches.
> >
> > I'm not very familiar with this code (this is actually the first I'm
> > hearing of gnus-logic.el), so I hope Lars will chime in. It makes sense
> > that tracing should happen whether or not the rule matched? But what
> > about the sexp before that? Would we be pushing the mail-header-number
> > and new score to `gnus-newsgroup-score' only if the rule *wasn't*
> > successful?
> >
> > I think this one should wait for Lars. If we don't hear from him and
> > it's holding things up, I can look more closely.
> 
> Eric,
> 
> It would be great if you could help review this.  Thanks in advance.

Adding Andrew, in case he could have some ideas or comments.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.