GNU bug report logs - #59458
[PATCH] Fix tracing for advanced scoring

Previous Next

Full log

View this message in rfc822 format

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 59458 <at> debbugs.gnu.org, Łukasz Stelmach <stlman <at> poczta.fm>
Subject: bug#59458: [PATCH] Fix tracing for advanced scoring
Date: Thu, 24 Nov 2022 11:39:40 -0800

Eli Zaretskii <eliz <at> gnu.org> writes:

>> Cc: Łukasz Stelmach <stlman <at> poczta.fm>
>> From: Łukasz Stelmach <stlman <at> poczta.fm>
>> Date: Mon, 21 Nov 2022 22:30:55 +0100
>> 
>> * lisp/gnus/gnus-logic.el (gnus-score-advanced): Move the tracing
>> code outside of if so it's executed for both branches.

I'm not very familiar with this code (this is actually the first I'm
hearing of gnus-logic.el), so I hope Lars will chime in. It makes sense
that tracing should happen whether or not the rule matched? But what
about the sexp before that? Would we be pushing the mail-header-number
and new score to `gnus-newsgroup-score' only if the rule *wasn't*
successful?

I think this one should wait for Lars. If we don't hear from him and
it's holding things up, I can look more closely.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.