From unknown Sat Sep 20 07:50:42 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#59458 <59458@debbugs.gnu.org> To: bug#59458 <59458@debbugs.gnu.org> Subject: Status: [PATCH] Fix tracing for advanced scoring Reply-To: bug#59458 <59458@debbugs.gnu.org> Date: Sat, 20 Sep 2025 14:50:42 +0000 retitle 59458 [PATCH] Fix tracing for advanced scoring reassign 59458 emacs submitter 59458 =C5=81ukasz Stelmach severity 59458 normal tag 59458 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 21 16:31:32 2022 Received: (at submit) by debbugs.gnu.org; 21 Nov 2022 21:31:32 +0000 Received: from localhost ([127.0.0.1]:49013 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxEO4-0007QD-FZ for submit@debbugs.gnu.org; Mon, 21 Nov 2022 16:31:32 -0500 Received: from lists.gnu.org ([209.51.188.17]:39226) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxEO2-0007Q5-7C for submit@debbugs.gnu.org; Mon, 21 Nov 2022 16:31:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxEO1-0000Tc-VR for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2022 16:31:30 -0500 Received: from smtpo50.interia.pl ([217.74.67.50]) by eggs.gnu.org with esmtps (TLS1.2:RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oxENz-0000xG-3d for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2022 16:31:29 -0500 Received: from localhost (89-64-89-35.dynamic.chello.pl [89.64.89.35]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by www.poczta.fm (INTERIA.PL) with ESMTPSA; Mon, 21 Nov 2022 22:31:18 +0100 (CET) From: =?UTF-8?q?=C5=81ukasz=20Stelmach?= To: bug-gnu-emacs@gnu.org Subject: [PATCH] Fix tracing for advanced scoring Date: Mon, 21 Nov 2022 22:30:55 +0100 Message-Id: <20221121213055.2387178-1-stlman@poczta.fm> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=interia.pl; s=biztos; t=1669066280; bh=mUENPalVoUdYAl0MIPTQZeXEl4PSEqoIRADWgux7gIg=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=qf5t/1V3Ch4mhhvokDcb7e8DMJE21eY7LYur4+40DsNoSRjrxYHicXPDXlWs050r+ HNNQ8s0hXbeYgwRBsWDFvvzP7K5vysyVz3t34ACRoNjwtqZGHCa5hkjts9PIs/GJ22 GfISY3ltac1hQPy29k9Ecvgw9VE/S6j5qHkakxpo= Received-SPF: pass client-ip=217.74.67.50; envelope-from=stlman@poczta.fm; helo=smtpo50.interia.pl X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: =?UTF-8?q?=C5=81ukasz=20Stelmach?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) * lisp/gnus/gnus-logic.el (gnus-score-advanced): Move the tracing code outside of if so it's executed for both branches. --- lisp/gnus/gnus-logic.el | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lisp/gnus/gnus-logic.el b/lisp/gnus/gnus-logic.el index c1b559ba6f4..346d8a28910 100644 --- a/lisp/gnus/gnus-logic.el +++ b/lisp/gnus/gnus-logic.el @@ -71,11 +71,11 @@ (+ (cdr score) new-score)) (push (cons (mail-header-number gnus-advanced-headers) new-score) - gnus-newsgroup-scored) - (when trace - (push (cons "A file" rule) - ;; Must be synced with `gnus-score-edit-file-at-point'. - gnus-score-trace))))))) + gnus-newsgroup-scored)) + (when trace + (push (cons "A file" rule) + ;; Must be synced with `gnus-score-edit-file-at-point'. + gnus-score-trace)))))) (defun gnus-advanced-score-rule (rule) "Apply RULE to `gnus-advanced-headers'." -- 2.30.2 From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 24 04:24:37 2022 Received: (at 59458) by debbugs.gnu.org; 24 Nov 2022 09:24:38 +0000 Received: from localhost ([127.0.0.1]:57271 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oy8TF-0004k3-Hd for submit@debbugs.gnu.org; Thu, 24 Nov 2022 04:24:37 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49934) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oy8TD-0004jo-B4 for 59458@debbugs.gnu.org; Thu, 24 Nov 2022 04:24:36 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oy8T6-0001V3-LQ; Thu, 24 Nov 2022 04:24:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=yxghuoB3BLo2PyHuSfbJM3dv0wdAHfkd6K++8y+oLCs=; b=IX6OwdjcK61Wn09xDrzG TQJGc4dJUm0cZsXnqma6i9+r/zbRIeuyL9hFFcacpvfLb7X7xLLSrt6BNSPNImBe/wTpIlGMrEn7+ NFzi3KuT70audjj5jvgA+Pcd3i9ENdef9ZwYXJkv2cGHSHFQKt4jaOo0n3uXn6upWGAJBgZIn3TEI hAAc8dPBGe3102PHt0xnCuX54b+/IAUZlFQCJd9ovbG1G0U2mRGlbtkKtw9gvIEHJqMih6d4AY71G 0gMeN9sMOAgpZ0O912cqSGSkW+EjGZRwfFed1N3WktAW2h3aCZQAdwYGJhhEc2cUh9q+sf2GstsCs eSLacHRQqzCTuQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oy8T4-0004sm-NY; Thu, 24 Nov 2022 04:24:27 -0500 Date: Thu, 24 Nov 2022 11:24:44 +0200 Message-Id: <831qpsyaar.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?Q?=C5=81ukasz?= Stelmach , Lars Ingebrigtsen , Eric Abrahamsen In-Reply-To: <20221121213055.2387178-1-stlman@poczta.fm> (message from =?utf-8?Q?=C5=81ukasz?= Stelmach on Mon, 21 Nov 2022 22:30:55 +0100) Subject: Re: bug#59458: [PATCH] Fix tracing for advanced scoring References: <20221121213055.2387178-1-stlman@poczta.fm> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59458 Cc: 59458@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: Łukasz Stelmach > From: Łukasz Stelmach > Date: Mon, 21 Nov 2022 22:30:55 +0100 > > * lisp/gnus/gnus-logic.el (gnus-score-advanced): Move the tracing > code outside of if so it's executed for both branches. > --- > lisp/gnus/gnus-logic.el | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/lisp/gnus/gnus-logic.el b/lisp/gnus/gnus-logic.el > index c1b559ba6f4..346d8a28910 100644 > --- a/lisp/gnus/gnus-logic.el > +++ b/lisp/gnus/gnus-logic.el > @@ -71,11 +71,11 @@ > (+ (cdr score) new-score)) > (push (cons (mail-header-number gnus-advanced-headers) > new-score) > - gnus-newsgroup-scored) > - (when trace > - (push (cons "A file" rule) > - ;; Must be synced with `gnus-score-edit-file-at-point'. > - gnus-score-trace))))))) > + gnus-newsgroup-scored)) > + (when trace > + (push (cons "A file" rule) > + ;; Must be synced with `gnus-score-edit-file-at-point'. > + gnus-score-trace)))))) > > (defun gnus-advanced-score-rule (rule) > "Apply RULE to `gnus-advanced-headers'." > -- > 2.30.2 Lars, Eric, Any comments? Is this good to go in? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 24 14:39:50 2022 Received: (at 59458) by debbugs.gnu.org; 24 Nov 2022 19:39:50 +0000 Received: from localhost ([127.0.0.1]:60258 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyI4c-00010f-G2 for submit@debbugs.gnu.org; Thu, 24 Nov 2022 14:39:50 -0500 Received: from mail.ericabrahamsen.net ([52.70.2.18]:32938) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyI4a-00010R-0u for 59458@debbugs.gnu.org; Thu, 24 Nov 2022 14:39:48 -0500 Received: from localhost (c-71-197-232-41.hsd1.wa.comcast.net [71.197.232.41]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id A3EDAFA08D; Thu, 24 Nov 2022 19:39:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1669318782; bh=hyJLmwUPMi1URBnF1AU3DaZnNlVoIZeWb7I+sGHAWNY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=kqGYQwrX7YQM++8YwNAfGD2Mo12n88atUHmJCeLgtPkyQ4CzmBfq1Tr3J/tBv12x3 XQ4vEIRt8GJRsLKVgdMUs10L7jkm9L/45FQP3YyoRXrR32ikwNFRTe2rIe/o6YWbDh 9efuXS1UqikShfVV1VuBRvLKvzyhSbAuaUqke6Ek= From: Eric Abrahamsen To: Eli Zaretskii Subject: Re: bug#59458: [PATCH] Fix tracing for advanced scoring In-Reply-To: <831qpsyaar.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 24 Nov 2022 11:24:44 +0200") References: <20221121213055.2387178-1-stlman@poczta.fm> <831qpsyaar.fsf@gnu.org> Date: Thu, 24 Nov 2022 11:39:40 -0800 Message-ID: <877czkf8g3.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59458 Cc: Lars Ingebrigtsen , 59458@debbugs.gnu.org, =?utf-8?Q?=C5=81ukasz?= Stelmach X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: >> Cc: =C5=81ukasz Stelmach >> From: =C5=81ukasz Stelmach >> Date: Mon, 21 Nov 2022 22:30:55 +0100 >>=20 >> * lisp/gnus/gnus-logic.el (gnus-score-advanced): Move the tracing >> code outside of if so it's executed for both branches. I'm not very familiar with this code (this is actually the first I'm hearing of gnus-logic.el), so I hope Lars will chime in. It makes sense that tracing should happen whether or not the rule matched? But what about the sexp before that? Would we be pushing the mail-header-number and new score to `gnus-newsgroup-score' only if the rule *wasn't* successful? I think this one should wait for Lars. If we don't hear from him and it's holding things up, I can look more closely. From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 07 17:08:10 2023 Received: (at 59458) by debbugs.gnu.org; 7 Sep 2023 21:08:10 +0000 Received: from localhost ([127.0.0.1]:41523 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeMET-0007hY-Pq for submit@debbugs.gnu.org; Thu, 07 Sep 2023 17:08:10 -0400 Received: from mail-lf1-x129.google.com ([2a00:1450:4864:20::129]:47187) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeMEP-0007gi-IR for 59458@debbugs.gnu.org; Thu, 07 Sep 2023 17:08:08 -0400 Received: by mail-lf1-x129.google.com with SMTP id 2adb3069b0e04-5007f3d3235so2328546e87.2 for <59458@debbugs.gnu.org>; Thu, 07 Sep 2023 14:08:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694120878; x=1694725678; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=UWvvDK4mMdqcID08NZirGV4rxV+AvVAWoch+8bj4z44=; b=DzVJhoU1m+hcKiE1aeWLCB4O6LA22UTZiSSdk9wPU8zOlTYVyhkvLip3up4fiBFVsO JElRT/k43o6Vr8Cihe346LNOGhA6YJMjAwPAdEXno+wtgexn1tGxHCmiGQqb51/Qzvb2 kSFVcmTcQSqsYdDl835f1De6glqg2HgSWpSzKTTLeHYnEb1EvLd6kekmLls2hm4bP/mT 9DSduR+n8llA0U5Vnu6Gn+ufvH62T5kpX9KpEE17T2UTzcb+xmmMlnZO1rkO6WqfJ0+9 iknNsU7kPEi4dDW1J/92Mot6mr7HZ1PGljdXV/7FXWPfgLLnuKmBp3X6ZsZVM65AdWxx p7nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694120878; x=1694725678; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=UWvvDK4mMdqcID08NZirGV4rxV+AvVAWoch+8bj4z44=; b=qNt7qoByiUzlw8u0RMxfiKC//0w94Ul8sjk4vRtxpC3awjitrhm760+OWF0V/O53v3 qF9lwyh+IXttGnWKSTqAyquVnwrwn3MSdRXRU71AjZvqz7xZFRSO68TpaaoNP8VCAr0K z6J/jQNPrNOoi+k9U9bpaSDn8asYUMdyzySS9CA0wP847+XdYis1555HQ3fpuDHK9XN3 dGqhrdTwR6VRXs3PsbxnKJjaV2PGAcuI94btFr0r4ZMgG9H+lTmoJvWHVy0vxPAbcW3q cq7CGd+6h5rJBNbxTnyuubG6sRZXVEerjp4ImfOmiwKcMbU/I8e//Z3ZeuShu63kmuP4 pZJQ== X-Gm-Message-State: AOJu0YxllQXbjqWH7MIpGR/lSNsHQJ+76biUqfgPYqr1d1RA0gBQ+JLf Rck8/cQDzYFg58d66EXvxrT+7rcW4rkKC3s32OY= X-Google-Smtp-Source: AGHT+IFwpE51S2RGQM6wYIwcdRTAulKGdvw3kriRZSd7toYeX9rElP4HcMv7KIZUwlBS87IPSf7rga2tPEql9T/SXVE= X-Received: by 2002:a05:6512:238e:b0:500:91c1:9642 with SMTP id c14-20020a056512238e00b0050091c19642mr480188lfv.21.1694120877609; Thu, 07 Sep 2023 14:07:57 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 7 Sep 2023 14:07:57 -0700 From: Stefan Kangas In-Reply-To: <877czkf8g3.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Thu, 24 Nov 2022 11:39:40 -0800") References: <20221121213055.2387178-1-stlman@poczta.fm> <831qpsyaar.fsf@gnu.org> <877czkf8g3.fsf@ericabrahamsen.net> MIME-Version: 1.0 Date: Thu, 7 Sep 2023 14:07:57 -0700 Message-ID: Subject: Re: bug#59458: [PATCH] Fix tracing for advanced scoring To: Eric Abrahamsen Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59458 Cc: Eli Zaretskii , Lars Ingebrigtsen , 59458@debbugs.gnu.org, =?UTF-8?Q?=C5=81ukasz_Stelmach?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eric Abrahamsen writes: > Eli Zaretskii writes: > >>> Cc: =C5=81ukasz Stelmach >>> From: =C5=81ukasz Stelmach >>> Date: Mon, 21 Nov 2022 22:30:55 +0100 >>> >>> * lisp/gnus/gnus-logic.el (gnus-score-advanced): Move the tracing >>> code outside of if so it's executed for both branches. > > I'm not very familiar with this code (this is actually the first I'm > hearing of gnus-logic.el), so I hope Lars will chime in. It makes sense > that tracing should happen whether or not the rule matched? But what > about the sexp before that? Would we be pushing the mail-header-number > and new score to `gnus-newsgroup-score' only if the rule *wasn't* > successful? > > I think this one should wait for Lars. If we don't hear from him and > it's holding things up, I can look more closely. Eric, It would be great if you could help review this. Thanks in advance. From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 08 02:05:21 2023 Received: (at 59458) by debbugs.gnu.org; 8 Sep 2023 06:05:21 +0000 Received: from localhost ([127.0.0.1]:41980 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeUcL-0002Ik-BA for submit@debbugs.gnu.org; Fri, 08 Sep 2023 02:05:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41796) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeUcH-0002IU-1L for 59458@debbugs.gnu.org; Fri, 08 Sep 2023 02:05:19 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeUc6-0005Cl-Ch; Fri, 08 Sep 2023 02:05:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=ykT6oYKWRd+qTd6eiVl3aMLQOdpgU4RqJtRokTZAspQ=; b=Zhl8RTBfRrP0ErNp3aOH 6182Zacwn88G+4oA4t6e9RzqAkKT6mOLDVGCCHVCKGstnirMZkVo1bRTEKghfUWe6F0vvKrGnEZlp qT0M0wQHOwbw/NaSep5sofEIEB+ewQXKnloBKis6P9X+JjO2AjpPhIELXlQoKqJEffPsVTTtjnGRH FIgA0I1aJF3k5PBHabEkM03qWatNyGtA12d+rEBRoRbQ+saPk4RWlrmgKmEfZrv1p+BNNjJgqvA2l VGagx2bZqqiRetH3wbXWXhbU25VoFdTDTrB0qj4RySgdI1lwwKUq6Occ3eLTj6WMzS/PVWx5Q2zWH +sdQ/a4bXEqWiQ==; Date: Fri, 08 Sep 2023 09:04:52 +0300 Message-Id: <83o7idxksb.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas , Andrew Cohen In-Reply-To: (message from Stefan Kangas on Thu, 7 Sep 2023 14:07:57 -0700) Subject: Re: bug#59458: [PATCH] Fix tracing for advanced scoring References: <20221121213055.2387178-1-stlman@poczta.fm> <831qpsyaar.fsf@gnu.org> <877czkf8g3.fsf@ericabrahamsen.net> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59458 Cc: eric@ericabrahamsen.net, larsi@gnus.org, 59458@debbugs.gnu.org, stlman@poczta.fm X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Thu, 7 Sep 2023 14:07:57 -0700 > Cc: Eli Zaretskii , Lars Ingebrigtsen , 59458@debbugs.gnu.org, > Łukasz Stelmach > > Eric Abrahamsen writes: > > > Eli Zaretskii writes: > > > >>> Cc: Łukasz Stelmach > >>> From: Łukasz Stelmach > >>> Date: Mon, 21 Nov 2022 22:30:55 +0100 > >>> > >>> * lisp/gnus/gnus-logic.el (gnus-score-advanced): Move the tracing > >>> code outside of if so it's executed for both branches. > > > > I'm not very familiar with this code (this is actually the first I'm > > hearing of gnus-logic.el), so I hope Lars will chime in. It makes sense > > that tracing should happen whether or not the rule matched? But what > > about the sexp before that? Would we be pushing the mail-header-number > > and new score to `gnus-newsgroup-score' only if the rule *wasn't* > > successful? > > > > I think this one should wait for Lars. If we don't hear from him and > > it's holding things up, I can look more closely. > > Eric, > > It would be great if you could help review this. Thanks in advance. Adding Andrew, in case he could have some ideas or comments. From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 11 20:07:33 2023 Received: (at 59458) by debbugs.gnu.org; 12 Sep 2023 00:07:33 +0000 Received: from localhost ([127.0.0.1]:55335 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfqwH-0006X9-DJ for submit@debbugs.gnu.org; Mon, 11 Sep 2023 20:07:33 -0400 Received: from mail.ericabrahamsen.net ([52.70.2.18]:33250) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfqwD-0006Wu-9Z for 59458@debbugs.gnu.org; Mon, 11 Sep 2023 20:07:32 -0400 Received: from localhost (71-212-75-26.tukw.qwest.net [71.212.75.26]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 3C2A6FA0BA; Tue, 12 Sep 2023 00:07:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1694477238; bh=0S43JYvdQupgDdM246s+pq7WCQ6dIVQvTc4cp4YR/Ko=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=v+1lzs1/66QscE1H2hGDpZg0BHPTAQAeyWo+FLuAE2alaTgFIFoqjVhWCa6wr1eN6 PGtg49orbAhf/AXCR2tcX30G756tYT3mX38fBtnVCQ6e5jpXYf9KPtEDkN/54elMmm CdSQ7w7EoViXxoW5jRzzdS37ZgKTw4g0adbB4TNE= From: Eric Abrahamsen To: Stefan Kangas Subject: Re: bug#59458: [PATCH] Fix tracing for advanced scoring In-Reply-To: (Stefan Kangas's message of "Thu, 7 Sep 2023 14:07:57 -0700") References: <20221121213055.2387178-1-stlman@poczta.fm> <831qpsyaar.fsf@gnu.org> <877czkf8g3.fsf@ericabrahamsen.net> Date: Mon, 11 Sep 2023 17:07:16 -0700 Message-ID: <871qf4ntjf.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59458 Cc: Eli Zaretskii , Lars Ingebrigtsen , 59458@debbugs.gnu.org, =?utf-8?Q?=C5=81ukasz?= Stelmach X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 09/07/23 14:07 PM, Stefan Kangas wrote: > Eric Abrahamsen writes: > >> Eli Zaretskii writes: >> >>>> Cc: =C5=81ukasz Stelmach >>>> From: =C5=81ukasz Stelmach >>>> Date: Mon, 21 Nov 2022 22:30:55 +0100 >>>> >>>> * lisp/gnus/gnus-logic.el (gnus-score-advanced): Move the tracing >>>> code outside of if so it's executed for both branches. >> >> I'm not very familiar with this code (this is actually the first I'm >> hearing of gnus-logic.el), so I hope Lars will chime in. It makes sense >> that tracing should happen whether or not the rule matched? But what >> about the sexp before that? Would we be pushing the mail-header-number >> and new score to `gnus-newsgroup-score' only if the rule *wasn't* >> successful? >> >> I think this one should wait for Lars. If we don't hear from him and >> it's holding things up, I can look more closely. > > Eric, > > It would be great if you could help review this. Thanks in advance. I've taken a closer look, and I do think this is okay. The `when' after the `dolist' only fires if the rule matches, the `if' is only there to see if this article has been previously scored or not. So moving the "(when trace" up to the top-level of the containing `when' (ie, out of the `if') does look like the right thing to do. Eric From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 11 20:32:34 2023 Received: (at 59458-done) by debbugs.gnu.org; 12 Sep 2023 00:32:34 +0000 Received: from localhost ([127.0.0.1]:55414 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfrKU-00048a-CY for submit@debbugs.gnu.org; Mon, 11 Sep 2023 20:32:34 -0400 Received: from mail-lf1-x12a.google.com ([2a00:1450:4864:20::12a]:50266) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfrKR-00048M-Mt for 59458-done@debbugs.gnu.org; Mon, 11 Sep 2023 20:32:33 -0400 Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-5007abb15e9so8587206e87.0 for <59458-done@debbugs.gnu.org>; Mon, 11 Sep 2023 17:32:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694478741; x=1695083541; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=7I+YYxpOzy/7YSBZvw0gWI/ffyi1fWp2ST5A1FopA5Y=; b=hL2lLBbHIUHXmFHMK+yKDiDRcrxSKQNtbCTbdKhJUvrxMUw+HB3Lqt6oqqK6lgJwVA aO4gy1yDD1+6w3YyvBnwGTo5CnXjkOAz0m7m93+lh3BmLgoLmhvHysoEt9XwcKvZy2zF boNDhA9GIs9/9j7/+Bz3kDvjZg/R36S+0dT9B3QVw246Ber3pR1OtkQrtDCjNw+FPqng 3V5Clh3I0U4EuzCtfuYw5a+wCLeMNShKRRipKZdDAfntle0jPkQWPeryovriYfkpEWFs tCKTe39/qlzrBphTdQhR0xFMP9Zy3vpdH8BKtY/vDTKGBz5r30Z49KE4Yo/AHIyvYqHS 0HIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694478741; x=1695083541; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7I+YYxpOzy/7YSBZvw0gWI/ffyi1fWp2ST5A1FopA5Y=; b=E4m84HmNCqUk4SM5uIG+sSYnToIeWBaVNIl0hb04RDONrpPtwnJhs0hLbEL8ca4V7G nou6MvXOTEN/ozJYRMmAxKWiiElsp/JbwAUdx1Rt5zAc6kLST1eH/uRB2AdQBr/mEInJ S+GqHcYIc5XxCyVW0dvUzsFrCmTIb0iZ7fqiKL2NMIbxOBnPqCk8HPT3NAIY3uVnr/OH pw0yJRQwNKX9qeiMgQa4LwGq5k0g+W4W0PUoFVMJ04gbwBVr0xZorVEAI7RnXUj+IGzu +LN7gGxWbYiqsNhBb/egS6AylIvEM+NcyW261Fvw5rAVAT2RoaVFp+r1bQ1LCLY37yhT LGPQ== X-Gm-Message-State: AOJu0YzC5WsH5oBG6ON5n9yq5b/9T+VuWvFAW5X7PFOUTgZzre+ges6w fOp6pRFhlAWxGNADcODRZw6NTVY40Dte0kEgAUc= X-Google-Smtp-Source: AGHT+IHQ2LK8+0QYur986EKhuqsiXr8XM6BnPdkJImMXuTGmTBFkE4RHgLiUMqRSF2Zq7tfVc+UVvvL2enyqQPjgkOQ= X-Received: by 2002:a2e:8752:0:b0:2bd:1246:cdce with SMTP id q18-20020a2e8752000000b002bd1246cdcemr9391356ljj.10.1694478741236; Mon, 11 Sep 2023 17:32:21 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 11 Sep 2023 17:32:20 -0700 From: Stefan Kangas In-Reply-To: <871qf4ntjf.fsf@ericabrahamsen.net> References: <20221121213055.2387178-1-stlman@poczta.fm> <831qpsyaar.fsf@gnu.org> <877czkf8g3.fsf@ericabrahamsen.net> <871qf4ntjf.fsf@ericabrahamsen.net> MIME-Version: 1.0 Date: Mon, 11 Sep 2023 17:32:20 -0700 Message-ID: Subject: Re: bug#59458: [PATCH] Fix tracing for advanced scoring To: Eric Abrahamsen Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59458-done Cc: Eli Zaretskii , 59458-done@debbugs.gnu.org, Lars Ingebrigtsen , =?UTF-8?Q?=C5=81ukasz_Stelmach?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Version: 30.1 Eric Abrahamsen writes: > On 09/07/23 14:07 PM, Stefan Kangas wrote: > >> Eric, >> >> It would be great if you could help review this. Thanks in advance. > > I've taken a closer look, and I do think this is okay. The `when' after > the `dolist' only fires if the rule matches, the `if' is only there to > see if this article has been previously scored or not. So moving the > "(when trace" up to the top-level of the containing `when' (ie, out of the > `if') does look like the right thing to do. Thanks. Installed it on master as commit e25ad6e2a30. From unknown Sat Sep 20 07:50:42 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 10 Oct 2023 11:24:12 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator