GNU bug report logs - #5945
[PATCH] tests: avoid spurious failure of root-only ls/capability test

Previous Next

Full log

View this message in rfc822 format

From: Jim Meyering <jim <at> meyering.net>
To: 5945 <at> debbugs.gnu.org
Subject: bug#5945: [PATCH] tests: avoid spurious failure of root-only ls/capability test
Date: Wed, 14 Apr 2010 15:52:19 +0200

Hmm... you can tell I haven't been running the root-only tests
on capability-enabled systems.  This showed up as a root-only failure:

  $ sudo env PATH="$PATH" NON_ROOT_USERNAME=$USER make -k check-root
  PASS: chown/basic
  ...
  PASS: install/install-C-root
  FAIL: ls/capability           <<<<==== oops
  PASS: ls/nameless-uid
  ...
  PASS: touch/now-owned-by-other

Here's the fix:

From 05bee6f116d81084f5796b2ab1ec12135fb72fc2 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering <at> redhat.com>
Date: Wed, 14 Apr 2010 15:48:31 +0200
Subject: [PATCH] tests: avoid spurious failure of root-only ls/capability test

* tests/ls/capability: Adjust this test not to expect the no-op escape
sequence that was removed from all other tests by 2010-01-30 commit
5d43617e, "ls --color: don't emit a final no-op escape sequence".
---
 tests/ls/capability |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tests/ls/capability b/tests/ls/capability
index df91aa5..3997c73 100755
--- a/tests/ls/capability
+++ b/tests/ls/capability
@@ -59,7 +59,7 @@ for ex in '' ex=:; do
 dir:
 \e[${code}mcap_neg\e[0m
 cap_pos
-\e[m" > out_ok || framework_failure
+" > out_ok || framework_failure

   compare out out_ok || fail=1
 done
--
1.7.1.rc1.248.gcefbb

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.