From unknown Mon Aug 18 04:42:58 2025 X-Loop: help-debbugs@gnu.org Subject: bug#5945: [PATCH] tests: avoid spurious failure of root-only ls/capability test Resent-From: Jim Meyering Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Wed, 14 Apr 2010 13:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 5945 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: patch To: 5945@debbugs.gnu.org X-Debbugs-Original-To: bug-coreutils@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.12712531571411 (code B ref -1); Wed, 14 Apr 2010 13:53:01 +0000 Received: (at submit) by debbugs.gnu.org; 14 Apr 2010 13:52:37 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O231A-0000Mg-P8 for submit@debbugs.gnu.org; Wed, 14 Apr 2010 09:52:36 -0400 Received: from mx10.gnu.org ([199.232.76.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O2319-0000Ma-07 for submit@debbugs.gnu.org; Wed, 14 Apr 2010 09:52:35 -0400 Received: from lists.gnu.org ([199.232.76.165]:42921) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1O2314-0007Fj-0z for submit@debbugs.gnu.org; Wed, 14 Apr 2010 09:52:30 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O2313-0007F0-FW for bug-coreutils@gnu.org; Wed, 14 Apr 2010 09:52:29 -0400 Received: from [140.186.70.92] (port=36679 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O2311-0007Ec-St for bug-coreutils@gnu.org; Wed, 14 Apr 2010 09:52:28 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.0 (2010-01-18) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.0 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O2310-0007ub-4u for bug-coreutils@gnu.org; Wed, 14 Apr 2010 09:52:27 -0400 Received: from smtp3-g21.free.fr ([212.27.42.3]:46690) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O230z-0007uG-II for bug-coreutils@gnu.org; Wed, 14 Apr 2010 09:52:26 -0400 Received: from smtp3-g21.free.fr (localhost [127.0.0.1]) by smtp3-g21.free.fr (Postfix) with ESMTP id 47BCB818188 for ; Wed, 14 Apr 2010 15:52:21 +0200 (CEST) Received: from mx.meyering.net (mx.meyering.net [82.230.74.64]) by smtp3-g21.free.fr (Postfix) with ESMTP id 649F481803D for ; Wed, 14 Apr 2010 15:52:19 +0200 (CEST) Received: by rho.meyering.net (Acme Bit-Twister, from userid 1000) id 46F0BAF1; Wed, 14 Apr 2010 15:52:19 +0200 (CEST) From: Jim Meyering Date: Wed, 14 Apr 2010 15:52:19 +0200 Message-ID: <878w8qgmzw.fsf@meyering.net> Lines: 41 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -4.2 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.1 (-----) Hmm... you can tell I haven't been running the root-only tests on capability-enabled systems. This showed up as a root-only failure: $ sudo env PATH="$PATH" NON_ROOT_USERNAME=$USER make -k check-root PASS: chown/basic ... PASS: install/install-C-root FAIL: ls/capability <<<<==== oops PASS: ls/nameless-uid ... PASS: touch/now-owned-by-other Here's the fix: >From 05bee6f116d81084f5796b2ab1ec12135fb72fc2 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Wed, 14 Apr 2010 15:48:31 +0200 Subject: [PATCH] tests: avoid spurious failure of root-only ls/capability test * tests/ls/capability: Adjust this test not to expect the no-op escape sequence that was removed from all other tests by 2010-01-30 commit 5d43617e, "ls --color: don't emit a final no-op escape sequence". --- tests/ls/capability | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tests/ls/capability b/tests/ls/capability index df91aa5..3997c73 100755 --- a/tests/ls/capability +++ b/tests/ls/capability @@ -59,7 +59,7 @@ for ex in '' ex=:; do dir: \e[${code}mcap_neg\e[0m cap_pos -\e[m" > out_ok || framework_failure +" > out_ok || framework_failure compare out out_ok || fail=1 done -- 1.7.1.rc1.248.gcefbb From unknown Mon Aug 18 04:42:58 2025 X-Loop: help-debbugs@gnu.org Subject: bug#5945: [PATCH] tests: avoid spurious failure of root-only ls/capability test Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Wed, 14 Apr 2010 14:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 5945 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: patch To: Jim Meyering Cc: 5945@debbugs.gnu.org Received: via spool by 5945-submit@debbugs.gnu.org id=B5945.12712559132698 (code B ref 5945); Wed, 14 Apr 2010 14:39:02 +0000 Received: (at 5945) by debbugs.gnu.org; 14 Apr 2010 14:38:33 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O23jc-0000hT-Fl for submit@debbugs.gnu.org; Wed, 14 Apr 2010 10:38:32 -0400 Received: from mail1.slb.deg.dub.stisp.net ([84.203.253.98]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1O23ja-0000hO-Se for 5945@debbugs.gnu.org; Wed, 14 Apr 2010 10:38:31 -0400 Received: (qmail 87546 invoked from network); 14 Apr 2010 14:38:24 -0000 Received: from unknown (HELO ?192.168.2.25?) (84.203.137.218) by mail1.slb.deg.dub.stisp.net with SMTP; 14 Apr 2010 14:38:24 -0000 Message-ID: <4BC5D33E.7050007@draigBrady.com> Date: Wed, 14 Apr 2010 15:37:50 +0100 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.8) Gecko/20100227 Thunderbird/3.0.3 MIME-Version: 1.0 References: <878w8qgmzw.fsf@meyering.net> In-Reply-To: <878w8qgmzw.fsf@meyering.net> X-Enigmail-Version: 1.0.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Score: -3.3 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.3 (---) On 14/04/10 14:52, Jim Meyering wrote: > tests: avoid spurious failure of root-only ls/capability test Here's another ls test failure that happens on SELinux enabled systems. I'll push the following shortly. >From 2d9e9408f74f39f4c2817ea028a7a6ad64fb4b45 Mon Sep 17 00:00:00 2001 From: =?utf-8?q?P=C3=A1draig=20Brady?= Date: Wed, 14 Apr 2010 15:32:27 +0100 Subject: [PATCH] tests: avoid spurious failure of ls/color-norm test * tests/ls/color-norm: Ensure that the file size is output consistently as 1 block. Previously we used "empty" files which could have some space allocated depending on whether SELinux was enabled for example. --- tests/ls/color-norm | 38 ++++++++++++++++++++++---------------- 1 files changed, 22 insertions(+), 16 deletions(-) diff --git a/tests/ls/color-norm b/tests/ls/color-norm index 16ffa22..75c7b82 100755 --- a/tests/ls/color-norm +++ b/tests/ls/color-norm @@ -28,9 +28,15 @@ fi # Don't let a different umask perturb the results. umask 22 -touch exe || framework_failure +# Use a large block size so that file sizes (which are printed +# with "normal" formatting), are normalized to 1 block. +# Note we can't use 0 sized files as on some systems "empty" +# files can use some allocation (like with SELinux enabled for example). +export LS_BLOCK_SIZE=1048576 + +echo > exe || framework_failure chmod u+x exe || framework_failure -touch nocolor || framework_failure +echo > nocolor || framework_failure # Non coloured files inherit NORMAL attributes LS_COLORS=no=7 ls -s1U --color exe nocolor >> out || fail=1 @@ -58,21 +64,21 @@ cat -A out > out.display || framework_failure mv out.display out || framework_failure cat <<\EOF > exp || framework_failure -^[[0m^[[7m0 ^[[m^[[01;32mexe^[[0m$ -^[[7m0 nocolor^[[0m$ -^[[0m^[[7m0 ^[[m^[[01;32mexe^[[0m ^[[7m0 nocolor^[[0m$ -^[[0m^[[7m0 nocolor^[[0m$ -^[[7m0 ^[[m^[[01;32mexe^[[0m$ -^[[0m^[[7m0 nocolor^[[0m ^[[7m0 ^[[m^[[01;32mexe^[[0m$ -^[[0m^[[7m0 ^[[m^[[1mnocolor^[[0m$ -^[[7m0 ^[[m^[[01;32mexe^[[0m$ -^[[0m^[[7m0 ^[[m^[[mnocolor^[[0m$ -^[[7m0 ^[[m^[[01;32mexe^[[0m$ -^[[0m^[[7m0 ^[[m^[[0mnocolor^[[0m$ -^[[7m0 ^[[m^[[01;32mexe^[[0m$ +^[[0m^[[7m1 ^[[m^[[01;32mexe^[[0m$ +^[[7m1 nocolor^[[0m$ +^[[0m^[[7m1 ^[[m^[[01;32mexe^[[0m ^[[7m1 nocolor^[[0m$ +^[[0m^[[7m1 nocolor^[[0m$ +^[[7m1 ^[[m^[[01;32mexe^[[0m$ +^[[0m^[[7m1 nocolor^[[0m ^[[7m1 ^[[m^[[01;32mexe^[[0m$ +^[[0m^[[7m1 ^[[m^[[1mnocolor^[[0m$ +^[[7m1 ^[[m^[[01;32mexe^[[0m$ +^[[0m^[[7m1 ^[[m^[[mnocolor^[[0m$ +^[[7m1 ^[[m^[[01;32mexe^[[0m$ +^[[0m^[[7m1 ^[[m^[[0mnocolor^[[0m$ +^[[7m1 ^[[m^[[01;32mexe^[[0m$ ^[[0m^[[7mnocolor^[[0m, ^[[7m^[[m^[[01;32mexe^[[0m*$ -0 nocolor$ -0 exe$ +1 nocolor$ +1 exe$ EOF compare out exp || fail=1 -- 1.6.2.5 From unknown Mon Aug 18 04:42:58 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Jim Meyering Subject: bug#5945 closed by =?UTF-8?Q?P=C3=A1draig?= Brady (Re: bug#5945: [PATCH] tests: avoid spurious failure of root-only ls/capability test) Message-ID: References: <4BC7A670.6060608@draigBrady.com> <878w8qgmzw.fsf@meyering.net> X-Gnu-PR-Message: they-closed 5945 X-Gnu-PR-Package: coreutils X-Gnu-PR-Keywords: patch Reply-To: 5945@debbugs.gnu.org Date: Thu, 15 Apr 2010 23:52:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1271375522-2848-1" This is a multi-part message in MIME format... ------------=_1271375522-2848-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This is an automatic notification regarding your bug report which was filed against the coreutils package: #5945: [PATCH] tests: avoid spurious failure of root-only ls/capability test It has been closed by P=C3=A1draig Brady . Their explanation is attached below along with your original report. If this explanation is unsatisfactory and you have not received a better one in a separate message then please contact P=C3=A1draig Brady by replying to this email. --=20 5945: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D5945 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1271375522-2848-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 5945-done) by debbugs.gnu.org; 15 Apr 2010 23:52:01 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O2Yqn-0000ji-C1 for submit@debbugs.gnu.org; Thu, 15 Apr 2010 19:52:01 -0400 Received: from mail1.slb.deg.dub.stisp.net ([84.203.253.98]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1O2Yqk-0000jd-KP for 5945-done@debbugs.gnu.org; Thu, 15 Apr 2010 19:51:59 -0400 Received: (qmail 13436 invoked from network); 15 Apr 2010 23:51:53 -0000 Received: from unknown (HELO ?192.168.2.25?) (84.203.137.218) by mail1.slb.deg.dub.stisp.net with SMTP; 15 Apr 2010 23:51:53 -0000 Message-ID: <4BC7A670.6060608@draigBrady.com> Date: Fri, 16 Apr 2010 00:51:12 +0100 From: =?ISO-8859-1?Q?P=E1draig_Brady?= User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.8) Gecko/20100227 Thunderbird/3.0.3 MIME-Version: 1.0 To: 5945-done@debbugs.gnu.org Subject: Re: bug#5945: [PATCH] tests: avoid spurious failure of root-only ls/capability test References: <878w8qgmzw.fsf@meyering.net> <4BC5D33E.7050007@draigBrady.com> In-Reply-To: <4BC5D33E.7050007@draigBrady.com> X-Enigmail-Version: 1.0.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -3.2 (---) X-Debbugs-Envelope-To: 5945-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.2 (---) On 14/04/10 15:37, Pádraig Brady wrote: > On 14/04/10 14:52, Jim Meyering wrote: >> tests: avoid spurious failure of root-only ls/capability test > > Here's another ls test failure that happens on SELinux enabled systems. > I'll push the following shortly. > >>>From 2d9e9408f74f39f4c2817ea028a7a6ad64fb4b45 Mon Sep 17 00:00:00 2001 > From: =?utf-8?q?P=C3=A1draig=20Brady?= > Date: Wed, 14 Apr 2010 15:32:27 +0100 > Subject: [PATCH] tests: avoid spurious failure of ls/color-norm test > > * tests/ls/color-norm: Ensure that the file size is output > consistently as 1 block. Previously we used "empty" files which > could have some space allocated depending on whether SELinux was > enabled for example. I actually pused a different method to fix ls/color-norm since I was worried that a 1 byte file might not use extra allocation on some file systems. Instead I output a specific time string to test the normal style attribute. http://git.savannah.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=3a1595a3 I'm marking these ls test issues as done. cheers, Pádraig. ------------=_1271375522-2848-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 14 Apr 2010 13:52:37 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O231A-0000Mg-P8 for submit@debbugs.gnu.org; Wed, 14 Apr 2010 09:52:36 -0400 Received: from mx10.gnu.org ([199.232.76.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O2319-0000Ma-07 for submit@debbugs.gnu.org; Wed, 14 Apr 2010 09:52:35 -0400 Received: from lists.gnu.org ([199.232.76.165]:42921) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1O2314-0007Fj-0z for submit@debbugs.gnu.org; Wed, 14 Apr 2010 09:52:30 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O2313-0007F0-FW for bug-coreutils@gnu.org; Wed, 14 Apr 2010 09:52:29 -0400 Received: from [140.186.70.92] (port=36679 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O2311-0007Ec-St for bug-coreutils@gnu.org; Wed, 14 Apr 2010 09:52:28 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.0 (2010-01-18) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.0 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O2310-0007ub-4u for bug-coreutils@gnu.org; Wed, 14 Apr 2010 09:52:27 -0400 Received: from smtp3-g21.free.fr ([212.27.42.3]:46690) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O230z-0007uG-II for bug-coreutils@gnu.org; Wed, 14 Apr 2010 09:52:26 -0400 Received: from smtp3-g21.free.fr (localhost [127.0.0.1]) by smtp3-g21.free.fr (Postfix) with ESMTP id 47BCB818188 for ; Wed, 14 Apr 2010 15:52:21 +0200 (CEST) Received: from mx.meyering.net (mx.meyering.net [82.230.74.64]) by smtp3-g21.free.fr (Postfix) with ESMTP id 649F481803D for ; Wed, 14 Apr 2010 15:52:19 +0200 (CEST) Received: by rho.meyering.net (Acme Bit-Twister, from userid 1000) id 46F0BAF1; Wed, 14 Apr 2010 15:52:19 +0200 (CEST) From: Jim Meyering To: bug-coreutils@gnu.org Subject: [PATCH] tests: avoid spurious failure of root-only ls/capability test Date: Wed, 14 Apr 2010 15:52:19 +0200 Message-ID: <878w8qgmzw.fsf@meyering.net> Lines: 41 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.1 (-----) Hmm... you can tell I haven't been running the root-only tests on capability-enabled systems. This showed up as a root-only failure: $ sudo env PATH="$PATH" NON_ROOT_USERNAME=$USER make -k check-root PASS: chown/basic ... PASS: install/install-C-root FAIL: ls/capability <<<<==== oops PASS: ls/nameless-uid ... PASS: touch/now-owned-by-other Here's the fix: >From 05bee6f116d81084f5796b2ab1ec12135fb72fc2 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Wed, 14 Apr 2010 15:48:31 +0200 Subject: [PATCH] tests: avoid spurious failure of root-only ls/capability test * tests/ls/capability: Adjust this test not to expect the no-op escape sequence that was removed from all other tests by 2010-01-30 commit 5d43617e, "ls --color: don't emit a final no-op escape sequence". --- tests/ls/capability | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tests/ls/capability b/tests/ls/capability index df91aa5..3997c73 100755 --- a/tests/ls/capability +++ b/tests/ls/capability @@ -59,7 +59,7 @@ for ex in '' ex=:; do dir: \e[${code}mcap_neg\e[0m cap_pos -\e[m" > out_ok || framework_failure +" > out_ok || framework_failure compare out out_ok || fail=1 done -- 1.7.1.rc1.248.gcefbb ------------=_1271375522-2848-1--