From unknown Tue Aug 19 21:02:14 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#59444 <59444@debbugs.gnu.org> To: bug#59444 <59444@debbugs.gnu.org> Subject: Status: ADVICE-ON-FAILURE sed syntax error Reply-To: bug#59444 <59444@debbugs.gnu.org> Date: Wed, 20 Aug 2025 04:02:14 +0000 retitle 59444 ADVICE-ON-FAILURE sed syntax error reassign 59444 emacs submitter 59444 Mattias Engdeg=C3=A5rd severity 59444 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 21 06:51:18 2022 Received: (at submit) by debbugs.gnu.org; 21 Nov 2022 11:51:19 +0000 Received: from localhost ([127.0.0.1]:45585 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ox5KY-00021W-Jz for submit@debbugs.gnu.org; Mon, 21 Nov 2022 06:51:18 -0500 Received: from lists.gnu.org ([209.51.188.17]:37510) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ox5KW-00021N-7Z for submit@debbugs.gnu.org; Mon, 21 Nov 2022 06:51:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ox5KW-0004DD-24 for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2022 06:51:16 -0500 Received: from mail-lf1-x12f.google.com ([2a00:1450:4864:20::12f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ox5KU-0000hy-Ca for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2022 06:51:15 -0500 Received: by mail-lf1-x12f.google.com with SMTP id l12so18422036lfp.6 for ; Mon, 21 Nov 2022 03:51:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=sfxh97XRI/HMgkqlJJUBQo0ESmn176go8ujNsyL7A1k=; b=ItfVY7mkRYn9rlcerOeKDC56FKPRlpEyMiSEQU54/cIiiivdl80Yre31FNNEj4BNZs IQroQGaE3Qu1IfHincyUcnIqEvY9DrZm5kYS2Lftvm3L224F6JkWIF9oOVzlccjFHYwj wPrah4FYWqAyHTIPFNbBKbv/gFwGj1oLzacTlLhSkp4G3Tk/4nR6K9Cw925P3gcvlGRQ zJ9L3nATqDuCBZt0gwy4pmnj4TUIIilRcvezoUj7ZIxc3+Kn3O5olV2VcBKwLq/GAB7D ZIuu7ku+e+G7O5IoJ3H5oXzjLQSRtRa9WVyuU7zD/PurzvKD7Qze15sgPEDQHFfo0I2+ z10w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sfxh97XRI/HMgkqlJJUBQo0ESmn176go8ujNsyL7A1k=; b=vvDdRiYo6WdFfrKShZUy95rKZt2v1hYLqv79jJZ9dB8Y5o0G5iOx0jMOHE7c/ZpAVJ m9iBmVZa7Rn8agdQhZ3ShhwgYJWQRHsxqUGtE17NVXdZQVNU990Zaqhnem9gJ1/58FCu gdg2nwuory+9X9V8nv246+uyucwgnlPURsc7UMRBGPibp3JYHyXW7H6DY3GfzNqK+90w Dkg7MDkiY4YahMwYqEuNTFmjDFzK6UN0TZRpXG0rsY35o4CyLbzX99inEZOLUG4fzYlZ VXz06U7jEub1/tFWh+P9gM6Dq00ZFVhaKPGa6v+LeRauRXrquhRiDaiIzUb9UiSIBEhG OC0A== X-Gm-Message-State: ANoB5pnKaSi01f5qZRZpisIHgbCg6riT/n38bC/AnAK+9OK9/z6UToI0 GQxdP4O/nTDqLOiQ+Fw9suO6GciSW4o= X-Google-Smtp-Source: AA0mqf6ztGIDwZJ1Sk77kqL+M9d9qqOKsfvXOV3KG51KW3NxPaeYYzg+Vz01A1qmU/2t0wXFR4BykA== X-Received: by 2002:a05:6512:2a8d:b0:498:7c7:b98f with SMTP id dt13-20020a0565122a8d00b0049807c7b98fmr5487292lfb.625.1669031470799; Mon, 21 Nov 2022 03:51:10 -0800 (PST) Received: from smtpclient.apple (c188-150-171-209.bredband.tele2.se. [188.150.171.209]) by smtp.gmail.com with ESMTPSA id q21-20020a056512211500b004aa3d587c84sm2000868lfr.200.2022.11.21.03.51.10 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Nov 2022 03:51:10 -0800 (PST) From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Subject: ADVICE-ON-FAILURE sed syntax error Message-Id: Date: Mon, 21 Nov 2022 12:51:05 +0100 To: Emacs Bug Report X-Mailer: Apple Mail (2.3654.120.0.1.13) Received-SPF: pass client-ip=2a00:1450:4864:20::12f; envelope-from=mattias.engdegard@gmail.com; helo=mail-lf1-x12f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Gregory Heytings X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Right now on Emacs master (d9d8a2eba9), any build error results in *** *** "make all" failed with exit status 2. *** sed: 1: "/^# ADVICE-ON-FAILURE-B ...": extra characters at the end of q = command make[1]: *** [advice-on-failure] Error 1 make: *** [all] Error 2 which is less than helpful. (This is with macOS 11.7, system tools.) The bug is here somewhere (Makefile.in:413): sed -n '/^# ADVICE-ON-FAILURE-BEGIN:${make-target}/,$${p;/^# = ADVICE-ON-FAILURE-END:${make-target}/q};' Any reason why this isn't just written sed -n '/^# ADVICE-ON-FAILURE-BEGIN:${make-target}/,/^# = ADVICE-ON-FAILURE-END:${make-target}/p' ? The latter would work with any standard `sed`. From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 21 07:49:55 2022 Received: (at 59444-done) by debbugs.gnu.org; 21 Nov 2022 12:49:55 +0000 Received: from localhost ([127.0.0.1]:45700 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ox6FH-0005nd-IK for submit@debbugs.gnu.org; Mon, 21 Nov 2022 07:49:55 -0500 Received: from heytings.org ([95.142.160.155]:52844) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ox6FE-0005nT-DB for 59444-done@debbugs.gnu.org; Mon, 21 Nov 2022 07:49:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1669034990; bh=5xSIDjdvCxh5g+f4j6bIRMYMH+Ads6pwL9zqe33TA9w=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=dtGawsKCB1l+5psP3DyiqC0PtBrbu1GIfRkjqv8/fLXbpAWrPheRNaKqdOZLWuodD 6d+EjQ6rMUnmtw5st86d3SacXzXEoIMMH/DLCFY+GegLpIo9vgq1kDBFK9yvwyGY8i EKxC23PalU3vz29tXDeTemMPF5J0S60yE9ADpkXzux9Fam3Lr9sUhh0jxfrL7sqlls UpJM7VOQ1bURXJpxo0AR7unWLiMfBgqKvFECFwazDyRLbFTv+4jVfJrieDVAayUXwn MCKBzRab7p8RHA0JXdDFJlo5bhYfjpQU+P/ZMC3ZqyJGphwtYSh8s+TDCP/fFwq1sR pjuOpWtoI0S1A== Date: Mon, 21 Nov 2022 12:49:50 +0000 From: Gregory Heytings To: =?UTF-8?Q?Mattias_Engdeg=C3=A5rd?= Subject: Re: bug#59444: ADVICE-ON-FAILURE sed syntax error In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59444-done Cc: 59444-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Thanks for your bug report. > > Right now on Emacs master (d9d8a2eba9), any build error results in > Is this new? That part of the Makefile hasn't changed in the last two months, after it was introduced. > > The bug is here somewhere (Makefile.in:413): > > sed -n '/^# ADVICE-ON-FAILURE-BEGIN:${make-target}/,$${p;/^# ADVICE-ON-FAILURE-END:${make-target}/q};' > > Any reason why this isn't just written > > sed -n '/^# ADVICE-ON-FAILURE-BEGIN:${make-target}/,/^# ADVICE-ON-FAILURE-END:${make-target}/p' > > ? The latter would work with any standard `sed`. > Again I tested this with (GNU) sed with --posix, and it gave the expected result. The reason I chose the former expression instead of the latter is because it's how I usually write such patterns. After reading the POSIX standard, it turns out that a semicolon is required after the 'q'. Fixed (a3b654e069) and closing. From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 21 08:11:24 2022 Received: (at 59444) by debbugs.gnu.org; 21 Nov 2022 13:11:25 +0000 Received: from localhost ([127.0.0.1]:45736 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ox6a4-0006Lf-N0 for submit@debbugs.gnu.org; Mon, 21 Nov 2022 08:11:24 -0500 Received: from mail-lj1-f181.google.com ([209.85.208.181]:37604) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ox6a2-0006LS-Iv for 59444@debbugs.gnu.org; Mon, 21 Nov 2022 08:11:23 -0500 Received: by mail-lj1-f181.google.com with SMTP id z24so14456752ljn.4 for <59444@debbugs.gnu.org>; Mon, 21 Nov 2022 05:11:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=Fa4WdzrFmBBD/WxGEPQTiViPu+XlSmMR2MlEkro+wbI=; b=msZ9VrduejOSp2U5UAzuj+Fcjtsfw6bu6aqjfOu67cpkDy2fgHD/5WbE+J/35pOxEu hOhe01VfEuK4XHRBkdiCSU8fzkYZ2AFOC9ZRCzOA0mNW/D50ynHT43m1+7yoJxWt+qdk 0TNO/DbAmI791y0M0+t5XHQN0+F+7jkClHdRGYB5cYP5zYtnU1kW1CCZgPa78eqmHCPa Jeh8BPiV5GkFgdt9Ru5uXspqr+sv9muHRDSp9kGV9HMVveZVV94NCSc6gkU62IdU70xo ar88h4Q8HMO51eru3Cfs/ji2c5i61005gKMrBgxZWViHc7p/kaM7T9Xa+c6W0OTNT22t 1piw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Fa4WdzrFmBBD/WxGEPQTiViPu+XlSmMR2MlEkro+wbI=; b=0RKGi7aXoJUeXI1WKOr4gB0a5+Fjj8DAM2SZYfgm+nkrc2x7x3ZZro58CQaKQ0ZBko pG1F7hMMUDG/ommfZwAPeh3hgtV9jcbiKiOviGoLBMrZvjgi5Bj6CbsvYqqjYfBDFZIM KBY7x6iUga8vVF1UnYkh5EgzdmtRP6io95RdAfGxcURl7NiPnLZW+mdffWgSwALdXPYO JWbpc5qoUWdyK8UovjdfNw3Ya6+VkmKgkvFCbT8ysmd37rwq7VLq0RnxVodUJr8iO6Zf bjqtteC7oFmi/GoYpdlub3hyWp61d37XurgKe35mKBwlyj98DdHklJKmYYicZCDjVswA 8leQ== X-Gm-Message-State: ANoB5pnZqGg7BNWyT3puEBnrfimIO+N5Cvc5ZiXVRqFoyZxkA9NRwrwL 5eVuWwyvwuMY2xj5Hi8pDUls5WqPCEc= X-Google-Smtp-Source: AA0mqf657bdFeHd2WlBqFlYA1Gx7rhF6mnoi6a/4dwlbynGwXxAGuX/NbottuLvs8kVKbqXY/0zHUQ== X-Received: by 2002:a2e:a37c:0:b0:26e:93:980d with SMTP id i28-20020a2ea37c000000b0026e0093980dmr6138493ljn.488.1669036276388; Mon, 21 Nov 2022 05:11:16 -0800 (PST) Received: from smtpclient.apple (c188-150-171-209.bredband.tele2.se. [188.150.171.209]) by smtp.gmail.com with ESMTPSA id u2-20020a2eb802000000b0027718ee951dsm1450979ljo.37.2022.11.21.05.11.15 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Nov 2022 05:11:15 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Subject: Re: bug#59444: ADVICE-ON-FAILURE sed syntax error From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: Date: Mon, 21 Nov 2022 14:11:14 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: References: To: Gregory Heytings X-Mailer: Apple Mail (2.3654.120.0.1.13) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59444 Cc: 59444@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) 21 nov. 2022 kl. 13.49 skrev Gregory Heytings : > Again I tested this with (GNU) sed with --posix, and it gave the = expected result. Then what we should learn from this is that GNU sed --posix cannot be = trusted blindly to reject non-POSIX features. This is unsurprising -- it can be difficult to keep all extensions from = leaking past the gate. > The reason I chose the former expression instead of the latter is = because it's how I usually write such patterns. That doesn't answer the question. Why that roundabout way, rather than = the simpler direct approach? > Fixed (a3b654e069) and closing. That seems to work. Thank you! From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 21 08:17:51 2022 Received: (at 59444) by debbugs.gnu.org; 21 Nov 2022 13:17:51 +0000 Received: from localhost ([127.0.0.1]:45751 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ox6gJ-0000Iq-5U for submit@debbugs.gnu.org; Mon, 21 Nov 2022 08:17:51 -0500 Received: from heytings.org ([95.142.160.155]:52892) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ox6gH-0000Ii-D4 for 59444@debbugs.gnu.org; Mon, 21 Nov 2022 08:17:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1669036668; bh=sYnrsTLnZ+uJWcL6lXoyqBZDnTzGBVkAx8wpLehRIDk=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=yYBWqrt7Z9VMH/elr/LQgNgbi7neZKVVo1cDGELkaCMifwaBJVopf0By5bVg+OdTg 8sktUMH7JkviuKE/Fk/NkUZaUhW0+94Yo6MVCsx0kcrfujhApe/0CHMKWcMsPQbxhm fy6rNT/X/Vpb8vRAu8qVTDXEtg4oJd5y14Y2qbCIGNYDOEfeFUNlNL7veZ5sCATxfF RrIEj9cbcHuq6UttP/3fjTASA7+H6pG62dRxOIwzKJ/bkIU77RLIAcnhznmAOLtrs6 QqMLaAV0GxO6nltiBPlNgkivnLj+m7rG8PwT7FQJ2kpk/xrpTmsci81wwjYjJz1EFw E7D0oQmileCnQ== Date: Mon, 21 Nov 2022 13:17:47 +0000 From: Gregory Heytings To: =?UTF-8?Q?Mattias_Engdeg=C3=A5rd?= Subject: Re: bug#59444: ADVICE-ON-FAILURE sed syntax error In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59444 Cc: 59444@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> Again I tested this with (GNU) sed with --posix, and it gave the >> expected result. > > Then what we should learn from this is that GNU sed --posix cannot be > trusted blindly to reject non-POSIX features. This is unsurprising -- it > can be difficult to keep all extensions from leaking past the gate. > Do you know of any computer program that can be trusted blindly? ;-) >> The reason I chose the former expression instead of the latter is >> because it's how I usually write such patterns. > > That doesn't answer the question. Why that roundabout way, rather than > the simpler direct approach? > I write such expressions that way because with that expression only the first matching block is printed. Which is admittedly not important in this case, but habits being what they are... From unknown Tue Aug 19 21:02:14 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 20 Dec 2022 12:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator