GNU bug report logs - #59443
29.0.50; [PATCH] Allow goto-address-at-point to use secondary browser

Previous Next

Full log

Message #8 received at 59443 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Gabriel <gabriel376 <at> hotmail.com>, 59443 <at> debbugs.gnu.org
Subject: Re: bug#59443: 29.0.50; [PATCH] Allow goto-address-at-point to use
 secondary browser
Date: Mon, 21 Nov 2022 05:52:41 -0800

I didn't really study the patch or the issue, but here are two nits.

Gabriel <gabriel376 <at> hotmail.com> writes:

> * lisp/net/dictionary.el (goto-address-at-point): Call
>   `browse-url-button-open-url', so a prefix argument uses
>   `browse-url-secondary-browser-function'.
  ^^

We do not indent the commit message like this.  It should start at
column 0.


>  ;;;###autoload
>  (defun goto-address-at-point (&optional event)
> -  "Send to the e-mail address or load the URL at point.
> -Send mail to address at point.  See documentation for
> -`goto-address-find-address-at-point'.  If no address is found
> -there, then load the URL at or before point."
> +  "Compose a new message to the e-mail address or browse the URL at
> +point.

The first line of a docstring should be a complete sentence (for
e.g. eldoc and apropos).

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.