From unknown Tue Aug 19 23:15:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59443: 29.0.50; [PATCH] Allow goto-address-at-point to use secondary browser Resent-From: Gabriel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Nov 2022 11:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 59443 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 59443@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16690311437255 (code B ref -1); Mon, 21 Nov 2022 11:46:01 +0000 Received: (at submit) by debbugs.gnu.org; 21 Nov 2022 11:45:43 +0000 Received: from localhost ([127.0.0.1]:45578 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ox5F8-0001sx-Kl for submit@debbugs.gnu.org; Mon, 21 Nov 2022 06:45:43 -0500 Received: from lists.gnu.org ([209.51.188.17]:36676) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ox5F4-0001sm-6f for submit@debbugs.gnu.org; Mon, 21 Nov 2022 06:45:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ox5F3-0002w1-S8 for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2022 06:45:38 -0500 Received: from mail-bn8nam11olkn2010.outbound.protection.outlook.com ([40.92.20.10] helo=NAM11-BN8-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ox5F1-0007Uo-AS for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2022 06:45:37 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CmJyomdDw/OjcskHPRjgwRl5Mlg4217EDpMIovmNSzm92Bv+WGobW2u3qOLjmlTjU/9dhkiPyasBEGHodNq6aFrUE0wAfHTAvQXggqN9Qp51WalgyutVls8gR9nXrST9OKmYUU7BCIS25EnHX+ULXMQw+3INVO6nVzvsYQDGhmasRyuQe00nf5snzAbi1CCqRuAkqbY5li2rZyXn08ZJJR+FohHYfIGrxbLg2uBt65b6j9aQez6PwtRBMYl7EbgD0ae7B/Hn8BThI5Eyri62rsW0HTtNlvb/WGjcBYPf1cMh20B1zkWq0zFerZh7O03FVuFGOQdX3ILK/znoOSnH6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3moIPS1gvYnDXOMYdbWfeCrJMi+COtLBCXiHqUinnE4=; b=ccKsaXRJfTkGsMSEavXrdAJw+koDyiW3PLC2l11VMt82YO/16idKXwaiZm051GoyvsrM9NctWI2GdPzLRH/NpfJdOBxQFqFIgXxYzQFUFsOA9CzxRNCnIiItwMP4IjkMm2eS2NFIFLhKYv1ZfX+ZEfN4Aj2+wZFDV6xSXHA372TKSuVpZ+HRhukBpfrInp0c11DwOJRtqocAsks1CGj6CpI+hvtJtENIGSRK0AMxk+xTS/hLdYkbIGEph5t/oOkoh/NUBrUDH6c/O/RzF24P0DsJilvyIcS9PR4eK+BQZauCae0o7x7Gm/j7F9puqZxeV5EFsZtI7R+xQTUqxnuOEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3moIPS1gvYnDXOMYdbWfeCrJMi+COtLBCXiHqUinnE4=; b=p15a50aVwnqiM6ZV+Gft3rQtnv2I4CWXAhYqce05bzvhrNKDeN8Yqc6y35SY3HkgfJ1iRqvdXANCNsU2Fj6Hf+yg87D3eu8HpcOQQu9IHI4XZ8erMhwlGIauMY1/WjBSU/6AG1Ba9vjcdFx2DP5F7qw9S2Bqjx9UjFN/rDXcHt134V0HWAPnpgGMGNUxuhZmvsxqUyKmkoS7vyZkYLRAcgf596WXyqQYbxFDyHzPpiB5tBay8rzGnRPaSjFwrslaJ8dpNoJ54aD/hR5YJ5LLL1c/ePLWP8GDVkX/hPRGsTThsQ6ABaxo+BcdQuGzrdCfXKThU497njUGAtSDn0aVMA== Received: from SJ0PR06MB8609.namprd06.prod.outlook.com (2603:10b6:a03:40c::11) by BN6PR06MB3267.namprd06.prod.outlook.com (2603:10b6:405:46::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Mon, 21 Nov 2022 11:45:32 +0000 Received: from SJ0PR06MB8609.namprd06.prod.outlook.com ([fe80::33ae:d3a7:24ae:5c6f]) by SJ0PR06MB8609.namprd06.prod.outlook.com ([fe80::33ae:d3a7:24ae:5c6f%4]) with mapi id 15.20.5857.017; Mon, 21 Nov 2022 11:45:32 +0000 From: Gabriel Date: Mon, 21 Nov 2022 08:45:26 -0300 Message-ID: Content-Type: multipart/mixed; boundary="=-=-=" X-TMN: [F8zjMYbHI1xu1fuFqjgp1+VZPyp8VSofjxyJvIiKLmofFJL/wQxnCjaUEhDjWvhV] X-ClientProxiedBy: CPXP152CA0013.LAMP152.PROD.OUTLOOK.COM (2603:10d6:103::25) To SJ0PR06MB8609.namprd06.prod.outlook.com (2603:10b6:a03:40c::11) X-Microsoft-Original-Message-ID: <87pmdgttt5.fsf@hotmail.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR06MB8609:EE_|BN6PR06MB3267:EE_ X-MS-Office365-Filtering-Correlation-Id: 6e9df118-b0ca-4ad8-efd4-08dacbb5e508 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vdASrFPeHIMy8iZdN2UXNqTCLKv/+uYuok5WOGObxCmoTCQQ4xeo1CKjkJeIuarRzxkBjdnEKNeyp9tczDEW89Z05hRncrAt/MN+i3Ewt0Yirj7xonuWZ3ZoNeQVBtdfWexmuWL+Mdu40AHAutnZHuwTUu6Z81BWhmFnIFFlod7IT6OorrQTmjacDN3L4KLwdBCSyUen5q4OxH1yt+78ccp7lFs5G4pO/2C/1Wa5KHZr9BOMZjBEHXtlRb7ucv5nft8l1BBSvlRvKEgsrp2KmqGnCiymwDCQUjbI0ABU5Tz+OaG/QAukW7PKxpCawsKXUzXPUYF3LpFy6nzJDizNrLJcprolGSMqP73tO20nvjcO+/30NZAnFvsBpvGD+cILN+W10EcGogsNKhz7OM2B6UY9U9Z71tzMVzs+8AYriUQPN9CVfdM4wx884wX2hIYhdeRAY4dMwmX4oh1pv7H6Gkl1vjUv6e5o2kYdJzHourOPxj9HxHyvJYAjCCrXDqEUmvZhOz7e9d0k8nKScCJdqp/ED/bLMGq4smaHV85bXbK/9TY5ZrY2WWIt4+nuB0ZN6UBGnZqQwAl0AEtmLpNIVCiATk2YlBrfKy3W9QNmfNw= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Y7+rtuEwoax0sxo8itPzVgKr4i4kxAvxuv2eTTYkLz1t2GWmwZ6O7Oomw/JlUwhQBGRPqKTIng+nrdg6Wu/A7XFJuVLgD7NQdazAdfTOYcvSUwhVsixYuRHANOT2oVhJtBV3yp2zovn4s/faDaghxDD0J0RpN9VVnMM2CZLtQ2rVv0FQSj+FeVWohg2r3rIDcSkAcY5wrmv9zUbtRl6xRNkUE4sPATsoRCrDT35dnHHkunieUBKuBv8qknWM43/dW3aQ2fZwRm/n8+vlBL556NzXR8LsdAPXe3+N9JWKAo7Evbe5EH5n0oWf1kCoCSbPlNbYjtmTRXPeJ9yTJapEBTWtmZ26u7jX78m3lWsvyjiWocWs2QfUoK2H/wGz5Q/JLgSehfiVdR6xxT017fQ+HTkN+7jScIahwnW1wxgNI7O9L7Sxd2aW94LbTOaQvVNOw6na8gPfogqtwGjg/AfKvE0ehnLgpzF3LQoZ+Z3amUa9Nl+cSqxMS7h2hAP2YzD5x5qVAg0/RRzclrklHsbfiF4YKVqlijQYN7w2Q27Jy7tMzi/HB+POq0UBYSigcVLprNSRqoTSWl5c0SCWBYYl1Q9XGlgSaB8dUthDzptPbefQ59BBGTby7Aay9OWHx6iAQ5TOISeuWtr5CdzMC6VgjZNJHhoiSueMBh/owny0qGGgsybBEb53faTuDdAUt51PeJnzkdbGeo79LzCZIIWxCGEZAI4HvgQGfeGhzAEkXvYzwppL8JM9yj/QGT9mQ8+5Q21Ne0u83XwQV574FAi2Pqqy1zyYGIM4ZN5jgNsEipJV4IQxLn0KxGw7cC4faNJ5XAGN1685Ea2OGtvzZaeLDbPB5XThJABSTM4+hZSiRGw+G/6Lg7Um2Yljg+ou8bNhaVRNwv1Z5xCDBIizj1E8vidC9GpMrOBTG/+me20mZusygEHThpJoEICCw0MQDOEsx//FAMiqGgJ1950a+mshfQ1121pR7kZd6OGp6FaybzcHXsMAp3Ec7xs57yWIOfrClzLww7O1iLTUS+X+OBoH5z5E411lWGVhABvKHUAMsSXjuKuzCmNCTKgGqY8QYiqkltWUQuoUv5ZbrAYCGhua4sqJgVp0TCuLtnRLaFpJW3atsdG6h8CosMcr++FihtaiQIsqM2FCxcuVt31btTyy/5WX9/u5cnLWCrbDpVbA8DeV7cvjy1j8BhqN1VG6rDIjKR33BHA0FnTqru19/n35nkYDWBcAV3fwYWRvfadXCyLOnV7G3pARkx1ghpqnS6RCvjJ9MwZcBUxXpLBY4HOjTcBBuWn9Mx0HBc8m6ohaJYswsFhRIJ7hweXXJZSyYCko5j9uNYMc7l1ITTj2/5H7jA== X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-89723.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 6e9df118-b0ca-4ad8-efd4-08dacbb5e508 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR06MB8609.namprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 11:45:32.3735 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR06MB3267 Received-SPF: pass client-ip=40.92.20.10; envelope-from=gabriel376@hotmail.com; helo=NAM11-BN8-obe.outbound.protection.outlook.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) --=-=-= Content-Type: text/plain Description: When `goto-address-mode' is enabled, it's not possible to make "C-c RET" (`goto-address-at-point') open an URL with `browse-url-secondary-browser-function`. Steps: 1) emacs -Q (master "6b0179f7908c658342d1e642e5444e3d2e1cd997") 2) eval (progn (require 'browse-url) (setopt browse-url-browser-function #'eww-browse-url browse-url-secondary-browser-function #'browse-url-default-browser) (scratch-buffer) (goto-address-mode)) 3) Insert "https://www.gnu.org/software/emacs/" in the *scratch* buffer 4) Put point at URL and execute C-c RET (`goto-address-at-point') Result: `browse-url-browser-function' opens the URL with the default browser function. It's not possible to specify the use of the `browse-url-secondary-browser-function'. A proposed patch is attached. The prefix argument will not affect the argument CONTINUE of `compose-email'. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Allow-goto-address-at-point-to-use-secondary-browser.patch >From bfcd2ccb83a94fa1ba99db84cf55e88584fc25d1 Mon Sep 17 00:00:00 2001 From: Gabriel do Nascimento Ribeiro Date: Mon, 21 Nov 2022 08:08:52 -0300 Subject: [PATCH 1/1] Allow goto-address-at-point to use secondary browser * lisp/net/dictionary.el (goto-address-at-point): Call `browse-url-button-open-url', so a prefix argument uses `browse-url-secondary-browser-function'. --- lisp/net/goto-addr.el | 31 +++++++++++++++++-------------- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/lisp/net/goto-addr.el b/lisp/net/goto-addr.el index 86cf98004b..86b8fed362 100644 --- a/lisp/net/goto-addr.el +++ b/lisp/net/goto-addr.el @@ -222,25 +222,28 @@ goto-address-fontify-region ;;;###autoload (defun goto-address-at-point (&optional event) - "Send to the e-mail address or load the URL at point. -Send mail to address at point. See documentation for -`goto-address-find-address-at-point'. If no address is found -there, then load the URL at or before point." + "Compose a new message to the e-mail address or browse the URL at +point. + +If no e-mail address is found at point, use the URL at or before +point. See `goto-address-find-address-at-point'. + +With prefix argument, use the secondary browser to open the URL. +See `browse-url-button-open-url'." (interactive (list last-input-event)) (save-excursion (if event (posn-set-point (event-end event))) (let ((address (save-excursion (goto-address-find-address-at-point)))) (if (and address - (save-excursion - (goto-char (previous-single-char-property-change - (point) 'goto-address nil - (line-beginning-position))) - (not (looking-at goto-address-url-regexp)))) - (compose-mail address) - (let ((url (browse-url-url-at-point))) - (if url - (browse-url url) - (error "No e-mail address or URL found"))))))) + (save-excursion + (goto-char (previous-single-char-property-change + (point) 'goto-address nil + (line-beginning-position))) + (not (looking-at goto-address-url-regexp)))) + (compose-mail address) + (if-let ((url (browse-url-url-at-point))) + (browse-url-button-open-url url) + (error "No e-mail address or URL found")))))) (defun goto-address-find-address-at-point () "Find e-mail address around or before point. -- 2.34.1 --=-=-= Content-Type: text/plain --- Gabriel --=-=-=-- From unknown Tue Aug 19 23:15:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59443: 29.0.50; [PATCH] Allow goto-address-at-point to use secondary browser Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Nov 2022 13:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59443 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Gabriel , 59443@debbugs.gnu.org Received: via spool by 59443-submit@debbugs.gnu.org id=B59443.16690387724698 (code B ref 59443); Mon, 21 Nov 2022 13:53:02 +0000 Received: (at 59443) by debbugs.gnu.org; 21 Nov 2022 13:52:52 +0000 Received: from localhost ([127.0.0.1]:45827 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ox7EC-0001Dh-0D for submit@debbugs.gnu.org; Mon, 21 Nov 2022 08:52:52 -0500 Received: from mail-oi1-f180.google.com ([209.85.167.180]:39495) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ox7E7-0001DR-MP for 59443@debbugs.gnu.org; Mon, 21 Nov 2022 08:52:50 -0500 Received: by mail-oi1-f180.google.com with SMTP id m204so12568106oib.6 for <59443@debbugs.gnu.org>; Mon, 21 Nov 2022 05:52:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :from:to:cc:subject:date:message-id:reply-to; bh=oeENKQ4r2OzJDJvBFuXB+LEJdA9MHMqUbZgKN6wb068=; b=KkGBYBm1XHC7yD+VbPkuKNU5zi70eLOIq9wMopZjS8kzuyG9TjruZ5H9IDeExaRNLF eCq/KIu0CfxRLbd7fYdXv8WebpxAVNwIw43WsMysp0eEKARXz4eNbi2LHUGrkteFmbzC 9cVVyBCgKeq1jwyEvpoRlyZI382/oBM+SAYPvyYJSVPp9V3j0CZ76PZnHD4ZSp63v+K/ HWFs+JtfPNzLIt1GyE3kOABCyHzsZL/U4oearh6aopdN8hOrismZ4+0yU3At3ph67iYx nwYYQDogEmgUuC07Md5lLRcJEG9LV1RXJ9ueP8P8qi1qGwqO0xk6kvI9oRvkB+JLXfpj DCjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oeENKQ4r2OzJDJvBFuXB+LEJdA9MHMqUbZgKN6wb068=; b=tIkCoel0JKVlU6XlJqTNBGceBlM6xTa6VoKMZoErH7filwarrSPAcqabSC41HzopQK T6FN2yJAYrpGPUssEC6U8zPcyHcDIfmKcbOYnJeRDEebNXko44ImcwEX0JbJrNUqw0jv k/B5n3iHy67+++6tJnhkY2/5yeRwSej5oPNEWMl8Esx1lnmEOg3FWh82Hk5oZYUhmHHe EVg4Qy7nablC+Xher8sg5gPmKlhrxqzJ3A7iWJvNOsgQkLyT0oB3JSvX+6zgdW54V3xZ w7dktVB7knhqCWu98UHvTHidGcnfwh/5D+ju7fSLu+mu5wo67xSPRxjrO9xnxhwm06RJ /xOg== X-Gm-Message-State: ANoB5pk8XzbNGBPlkWcrFL0Nsz+jo3pMJ1/MPKGzkI7m0Yb4ChL+R3DP 5WfqRxAR3ia4BS6I9u+G/GNfDjxeBd95SFjVmGQ= X-Google-Smtp-Source: AA0mqf5rkNnViFNnWL2fJaGSS8NVuVIUw1nSZKO7dbDOc8a4eeWWDCzYlwHYti5yGj9fHHAsu3+eNyJuxL8/xt+05tI= X-Received: by 2002:a05:6808:1287:b0:359:dc32:4f9e with SMTP id a7-20020a056808128700b00359dc324f9emr1002834oiw.92.1669038761784; Mon, 21 Nov 2022 05:52:41 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 21 Nov 2022 05:52:41 -0800 From: Stefan Kangas In-Reply-To: References: X-Hashcash: 1:20:221121:gabriel376@hotmail.com::qK5u74PyiLBAxhIn:6Hsa MIME-Version: 1.0 Date: Mon, 21 Nov 2022 05:52:41 -0800 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) I didn't really study the patch or the issue, but here are two nits. Gabriel writes: > * lisp/net/dictionary.el (goto-address-at-point): Call > `browse-url-button-open-url', so a prefix argument uses > `browse-url-secondary-browser-function'. ^^ We do not indent the commit message like this. It should start at column 0. > ;;;###autoload > (defun goto-address-at-point (&optional event) > - "Send to the e-mail address or load the URL at point. > -Send mail to address at point. See documentation for > -`goto-address-find-address-at-point'. If no address is found > -there, then load the URL at or before point." > + "Compose a new message to the e-mail address or browse the URL at > +point. The first line of a docstring should be a complete sentence (for e.g. eldoc and apropos). From unknown Tue Aug 19 23:15:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59443: 29.0.50; [PATCH] Allow goto-address-at-point to use secondary browser Resent-From: Gabriel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Nov 2022 15:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59443 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 59443@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.166904307131857 (code B ref -1); Mon, 21 Nov 2022 15:05:01 +0000 Received: (at submit) by debbugs.gnu.org; 21 Nov 2022 15:04:31 +0000 Received: from localhost ([127.0.0.1]:48457 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ox8LW-0008Hl-HA for submit@debbugs.gnu.org; Mon, 21 Nov 2022 10:04:30 -0500 Received: from lists.gnu.org ([209.51.188.17]:40640) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ox8LT-0008Ha-C8 for submit@debbugs.gnu.org; Mon, 21 Nov 2022 10:04:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ox8LE-00013H-I7 for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2022 10:04:26 -0500 Received: from mail-co1nam11olkn2013.outbound.protection.outlook.com ([40.92.18.13] helo=NAM11-CO1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ox8L9-0001eV-9L for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2022 10:04:10 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CXs47BeqZNRN8qK7y3cEfgdEds1+8uPu/sPV79+gratMYEgEjIyImwr+Wycd3jpp3lZy6bMIcfBQNaPuNFFCgkiryN8HviD/ikpD1K2IZp5fBFhYofLLRvTthOCfOua2R29a7N6aaeNurFMw7uDNURWyVLuLl6ov6+WcbcgwQ5qezocCtW/YujMEdJzzh1Q/fZC2EhwohLtn5a+cM9I4niwlf5eGgQ5jQr34+EeLYDdQqrQIIu2rqRvWkhj2dfixM9iYsR95InMRVjgyHYgRqHwmkv2EG41FBql5dK9A4bvQLm6uPnaBe70KouuLyrVzvynv18ss9mHqmUy743+ejw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ThEiJ8ywqgkFgoExG2fs0AMH4gCPzfkSlqQojRrd7gw=; b=BGLrSWnO7gTRyGqI7RFAvKU95CRKkbkAPamMa0xHyfuHf8SQ84TNKrRAVDu9AYDg3WzOYK0Sl8Ti2gCBpX7BqHKWWDNDPJjLRx4yPzRyrhWydvCZfLB0Tzejke41neTdgc+qkmNjJ5C4W+5MR0kPvVArzEcnKXVo5GWY/gmu01zS/dpP5pbjfo6ZTt9oOi89kQ1iVnpDqBiZf8Gw4vkabtDplnGvLU+BdFUCdze8FN9O07TG8jzKRwfw/OccSW5gw8p8oo6VByRH6vF7gEk0Gph9UwaAMT9u1P57BS2/qGmqU7Go/SDJfahpjLmnMDMqDZ3k2Ac2KYSssBN5g2rYOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ThEiJ8ywqgkFgoExG2fs0AMH4gCPzfkSlqQojRrd7gw=; b=dqzsu3bYuVqHZQsgcFXHO3qcfKeKUXtk646Yq9ufQBEO7CCFMWcVam5fZli9IRWh0f6cvlS/W/mEqyFiU+5UdN63TWd6GSpweIcov3tWGIFR7R3xlbz/GN2B/foO23MceIufBvWhynqnn7+T17ANdUZuRuZsmP2FNkBHliib2StXeKpCcPrRjBr5yykjTsd+dFRnrTNkvAkCCmBg9AJwLs3owsiWcejELhn4Z6dh3nGG3xkYvuYIGVLYkj5r+ji6Rp8fhidRta/gOhK3Mhsqam9MatHCoYkCN1Dane5r2ETL29SSe1CRwobCVi4YnPM3t56tsHv4h2oviKALjQNe1Q== Received: from SJ0PR06MB8609.namprd06.prod.outlook.com (2603:10b6:a03:40c::11) by MWHPR06MB2749.namprd06.prod.outlook.com (2603:10b6:300:40::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.8; Mon, 21 Nov 2022 15:04:03 +0000 Received: from SJ0PR06MB8609.namprd06.prod.outlook.com ([fe80::33ae:d3a7:24ae:5c6f]) by SJ0PR06MB8609.namprd06.prod.outlook.com ([fe80::33ae:d3a7:24ae:5c6f%4]) with mapi id 15.20.5857.017; Mon, 21 Nov 2022 15:04:03 +0000 From: Gabriel In-Reply-To: (Stefan Kangas's message of "Mon, 21 Nov 2022 05:52:41 -0800") References: Date: Mon, 21 Nov 2022 12:03:56 -0300 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Content-Type: multipart/mixed; boundary="=-=-=" X-TMN: [gACXGFSEjghSzMZwcgEFUODK7IMDR5OFKOR+6E5RDBw22TC8nYiu7z+Y2wz91tMx] X-ClientProxiedBy: CPYP284CA0040.BRAP284.PROD.OUTLOOK.COM (2603:10d6:103:81::9) To SJ0PR06MB8609.namprd06.prod.outlook.com (2603:10b6:a03:40c::11) X-Microsoft-Original-Message-ID: <87leo48i3n.fsf@hotmail.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR06MB8609:EE_|MWHPR06MB2749:EE_ X-MS-Office365-Filtering-Correlation-Id: 30c2f32a-9cde-4f9d-ae87-08dacbd1a095 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9q5lywZIg4I/bbqxe1WudPmCLJy6QSK5YC7ebTpJ6Hmf6m5pqS67U57OrqT4Y2uJ5OwuvyuHBmw1WW7QLx7ID2nUlRCaT8H90QfRZiUTGxOtwwf0sP+3cS6fcD6aNfK6oqDGTCDstSsNya8G4qH24Fm5sBYNLE0ewfA25gcIzUcHMMJieDDtw9efEQjYk2n5PWWKJ3RkaWYXIPcq8SD+X8MsGbMUG297YmzSfYKR0F0zuhM0m0qdfaWeD1CBbbIomqzRv4KcptQE7qXZL0gOqFlzX4zuxU4ZHawLGuNKQBSVG5OXYtA+tMxNEc410dqednYAIoWpilWOpKeoPkYG8DHHtyGm3xvA7J5kaoEK16fe72j3Ede/7mWl+6VcYQ8UOo1DogQrvTKdOylA9A0RXyrjxyM7iiesNvr8gdeJbxya+uHpXo8XnoZAJ7szmYZmMGPQ19bSuoIKtibC6BY9jDjUMPyYSwN10rXpTqYld2vlDTt7kNp58MGDEVztXOnyAJjDzSrWmHfBAmp1gwtnQEPKEcNwsMt0Koc7p/UGN6u81pp4g8/uBLieaWX99mSxlG7F77KBUVGPVmRaYfovNuReqvY6XIUyDSuG22NY20YhfwxYXv/wJzN0TsqBHgxq3BxgeXNHZPx047euUEe31g== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: RPrShfMJEHJqdsgzmb77PCzKeoEjGBD3314WBsfzPyQpy7gObVUVVol0CjtbXI/pupCL+HzDB149XbtylazUn0912rXeYtnvWE/YSdn8a0xeVqwqg+tdgkgO6hSA6zIlhQ2rj3zXtcwoWsrdfg4wFQMgi6dR8KEPImVqmdgpEwqDqPwwdoO8BlrBDva2USvS9FqnqvDonj0UFH0E/3L+Oejti35OnrIDfmP/ul0swC0KuCLZn7dAXCPgzOZLv+/9mzPujp9ZkbcvCujzvYoXlTdU4TCnKv7n9Rmbh2lKHjjjrYJNGq0lON+ReypUY7doX6/fih+fDmnu7bB/g81ApqCHJ6Gi2CYOIfr/Z20GLS9Ib4iMc4igfHoCgH24JC7meeFTITzLDuWeSJwzhmbEgRo2pNI2x6rIeQ0kPV9rGm/jneWO7aXMiRw/Lw7eCyerLNsayd5XXkoVytcFCmqINYiJa+5VUMlwwk2DDBzYpKndrfL1gPX9HDqkSXf1GgSK6QjyVjFKXpUV+Id1jFlKIBf8blD/o12nkb9ahhU7WorQqjUmJQgcOjHQfbdemYhrws6kI2T4ecprNAr88IbkRfKqZD9m7lzmIKESxdt+ZEH283ZSegNXczmuQoEup/L0Qzxrx6ph86ETUmq0gByW3YfmOf/q9Kf5n40bROsOWxYmNmK9SFJQw/+htlPR08o1lEONgz6AMx05oHc3iTfK/COXj+9hdnZ8uGQrdXn9MPsCTZ8S5nYjKzin8JWuq1VyFRt4ZUUkmfLwkzmj+3oTMZMx61K+6jJ+8CTO5Cwd53doZ65mIh2UlvtEVcywx4LUbhZrgoI/kfYUspheWh+DNZZskdH7IuwqPhXYgfHJqmobWvJIrFf8qKOqJNW5XcWX95tH+Bb5N+zV0+3b0RpCUai61OkFj8il/3ro8gORrvnHaZ2/IgvFSRo229MnSURoe18Avmaq2XSSeC8QmPSYGBOFaNaUDxtczrLxaxYVSnwag9uFyVvUUXvO+MZAckiMGOkuMqVxy/hB7UPTmIIU3F9p8CoPs8+dZjn3lyfnZfFlsREzoNxGk4l0NEtYGfY6Q8ptHEovaXKoRdpYuVLQ45zTwBb5EywnGX6kls/Qbl4M1Oc3thR/61IBB9FucohL9MyqqoFDx7hHVNuAGtOiynfBP3xFCO05hrlBeDYakizECs1RMPtvIdm7D0+9EsLcrrKe3x4Wkyq7NvNU6hJi/gtqI/GtjNb7Bmtm6CMTSas9TCirE5Zkv/Fgdw9M9fakbziTK5l/kueus4Gp4uq7SDM3HjWqxB7UPBKYLR37k9KtLdiRTidg5pcaTcClUs1S34YK2X8IPbwjUaSlFuF+GA== X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-89723.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 30c2f32a-9cde-4f9d-ae87-08dacbd1a095 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR06MB8609.namprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 15:04:03.5050 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR06MB2749 Received-SPF: pass client-ip=40.92.18.13; envelope-from=gabriel376@hotmail.com; helo=NAM11-CO1-obe.outbound.protection.outlook.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) --=-=-= Content-Type: text/plain Stefan Kangas writes: > I didn't really study the patch or the issue, but here are two nits. > > Gabriel writes: > >> * lisp/net/dictionary.el (goto-address-at-point): Call >> `browse-url-button-open-url', so a prefix argument uses >> `browse-url-secondary-browser-function'. > ^^ > > We do not indent the commit message like this. It should start at > column 0. > > >> ;;;###autoload >> (defun goto-address-at-point (&optional event) >> - "Send to the e-mail address or load the URL at point. >> -Send mail to address at point. See documentation for >> -`goto-address-find-address-at-point'. If no address is found >> -there, then load the URL at or before point." >> + "Compose a new message to the e-mail address or browse the URL at >> +point. > > The first line of a docstring should be a complete sentence (for > e.g. eldoc and apropos). Thanks for the quick review, Stefan. Please find attached an updated patch. I fixed the commit message indent and rephrased the first line of docstring to be a complete sentence (based on the docstring's of `compose-mail' and `browse-url-button-open-url'). --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Allow-goto-address-at-point-to-use-secondary-browser.patch >From 2151f92bf5d07106d7f322ea69bfc745b0bf1d28 Mon Sep 17 00:00:00 2001 From: Gabriel do Nascimento Ribeiro Date: Mon, 21 Nov 2022 08:08:52 -0300 Subject: [PATCH 1/1] Allow goto-address-at-point to use secondary browser * lisp/net/dictionary.el (goto-address-at-point): Call `browse-url-button-open-url', so a prefix argument uses `browse-url-secondary-browser-function'. --- lisp/net/goto-addr.el | 31 +++++++++++++++++-------------- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/lisp/net/goto-addr.el b/lisp/net/goto-addr.el index 86cf98004b..03e14c9268 100644 --- a/lisp/net/goto-addr.el +++ b/lisp/net/goto-addr.el @@ -222,25 +222,28 @@ goto-address-fontify-region ;;;###autoload (defun goto-address-at-point (&optional event) - "Send to the e-mail address or load the URL at point. -Send mail to address at point. See documentation for -`goto-address-find-address-at-point'. If no address is found -there, then load the URL at or before point." + "Start composing a new message to the e-mail address at point or +open URL at point. + +If no e-mail address is found at point, use the URL at or before +point. See `goto-address-find-address-at-point'. + +With prefix argument, use the secondary browser to open the URL. +See `browse-url-button-open-url'." (interactive (list last-input-event)) (save-excursion (if event (posn-set-point (event-end event))) (let ((address (save-excursion (goto-address-find-address-at-point)))) (if (and address - (save-excursion - (goto-char (previous-single-char-property-change - (point) 'goto-address nil - (line-beginning-position))) - (not (looking-at goto-address-url-regexp)))) - (compose-mail address) - (let ((url (browse-url-url-at-point))) - (if url - (browse-url url) - (error "No e-mail address or URL found"))))))) + (save-excursion + (goto-char (previous-single-char-property-change + (point) 'goto-address nil + (line-beginning-position))) + (not (looking-at goto-address-url-regexp)))) + (compose-mail address) + (if-let ((url (browse-url-url-at-point))) + (browse-url-button-open-url url) + (error "No e-mail address or URL found")))))) (defun goto-address-find-address-at-point () "Find e-mail address around or before point. -- 2.34.1 --=-=-= Content-Type: text/plain --- Gabriel --=-=-=-- From unknown Tue Aug 19 23:15:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59443: 29.0.50; [PATCH] Allow goto-address-at-point to use secondary browser Resent-From: Visuwesh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Nov 2022 16:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59443 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Gabriel Cc: 59443@debbugs.gnu.org Received: via spool by 59443-submit@debbugs.gnu.org id=B59443.166904950120433 (code B ref 59443); Mon, 21 Nov 2022 16:52:02 +0000 Received: (at 59443) by debbugs.gnu.org; 21 Nov 2022 16:51:41 +0000 Received: from localhost ([127.0.0.1]:48625 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxA1E-0005JU-Vu for submit@debbugs.gnu.org; Mon, 21 Nov 2022 11:51:41 -0500 Received: from mail-pg1-f193.google.com ([209.85.215.193]:44591) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxA1D-0005JE-BS for 59443@debbugs.gnu.org; Mon, 21 Nov 2022 11:51:39 -0500 Received: by mail-pg1-f193.google.com with SMTP id q1so11664452pgl.11 for <59443@debbugs.gnu.org>; Mon, 21 Nov 2022 08:51:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=F7A9JanYS5c96rKEClemkMHzh5FBLkhketZoNr97r6U=; b=YT6WVgUztj/o3DbG25H1tXea4hg0AnENfb3dOmyFI8tKHz5LRqY5SMIZSSZwN+rbML ZiHx56Cf4SuiP/xqovdeShfiGpp39TJ84zpQHDCLJYBwb/3bDxchbYU4NyMvy+7JkOG+ j0/2W3QDwxFBoWe01jbqLvfCm0hR48ZbxrZNIHFGuy+g4AuxAeaxIZm3XqYKLxgn+RwD mLZcmcEHkmEgemrgcc6vMI2uwg/9r7Fi5Wn5n06wChHjIb6ISPwXg6+JOIJosz3bMivW 66VCnDd5atDKW7cOLzeDDwwVI68MP/WD9UsVOf0T6NMAhu49r1YN0QceSMPadg63WJdQ yYHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=F7A9JanYS5c96rKEClemkMHzh5FBLkhketZoNr97r6U=; b=lOb4BxAP4JLl2UsZoJjfVa9agj2exXHR/IuzQMiqlpQm5osrSzh03jXbQiq+nq7Lf+ EVGbKWKGlsKT5OujpoH515PIYxnSuexaX+lhuz4dDsxnGUjm4VDk0Q/A+ThIroSUcWjC m8qfYL6Cb510/Q4E1SzSlEBlaPlrSJBI2uuEIvAEWtNunh9fs1JBUrJGft8003NfRgAo v+c0MMtFFav05K1XZK7G2sk11WmU6DZEg187z2haHPc/StEn0Y2Jowv2RBafd6jonbMw w8pI6YZY9bX1ikuGoVwT4mOoYpl4RxwNx9j71E44vaFOIoxeyqxRGxJf/M9I/EPrcKcI HlTQ== X-Gm-Message-State: ANoB5pm4YvU8NIpNelr9CcE9PA3cT6B657pq4vkflMthi3STibE/bKYv dq1LJwcOp7pUm9HQUtupj+Y= X-Google-Smtp-Source: AA0mqf53Qaf0zCwSxtJrdFp2Bsq/8fF+qNJqnWQs6NXEuq917rJMcI39m7nDRANULzQP8e+B1GoI5Q== X-Received: by 2002:a63:f5a:0:b0:43c:428d:1701 with SMTP id 26-20020a630f5a000000b0043c428d1701mr8208733pgp.307.1669049493398; Mon, 21 Nov 2022 08:51:33 -0800 (PST) Received: from localhost ([118.185.152.162]) by smtp.gmail.com with ESMTPSA id n20-20020a170902d0d400b0016d72804664sm2251191pln.205.2022.11.21.08.51.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Nov 2022 08:51:32 -0800 (PST) From: Visuwesh In-Reply-To: (Gabriel's message of "Mon, 21 Nov 2022 12:03:56 -0300") References: Date: Mon, 21 Nov 2022 22:21:29 +0530 Message-ID: <87v8n8dze6.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) [=E0=AE=A4=E0=AE=BF=E0=AE=99=E0=AF=8D=E0=AE=95=E0=AE=B3=E0=AF=8D =E0=AE=A8= =E0=AE=B5=E0=AE=AE=E0=AF=8D=E0=AE=AA=E0=AE=B0=E0=AF=8D 21, 2022] Gabriel wr= ote: > [...] > From 2151f92bf5d07106d7f322ea69bfc745b0bf1d28 Mon Sep 17 00:00:00 2001 > From: Gabriel do Nascimento Ribeiro > Date: Mon, 21 Nov 2022 08:08:52 -0300 > Subject: [PATCH 1/1] Allow goto-address-at-point to use secondary browser > > * lisp/net/dictionary.el (goto-address-at-point): Call ^^^^^^^^^^^^^^^^^^^^^^ Hmm, the patch touches lisp/net/goto-addr.el but the commit message refers to another file. > `browse-url-button-open-url', so a prefix argument uses > `browse-url-secondary-browser-function'. > --- > lisp/net/goto-addr.el | 31 +++++++++++++++++-------------- > 1 file changed, 17 insertions(+), 14 deletions(-) > > diff --git a/lisp/net/goto-addr.el b/lisp/net/goto-addr.el > index 86cf98004b..03e14c9268 100644 > --- a/lisp/net/goto-addr.el > +++ b/lisp/net/goto-addr.el > [...] From unknown Tue Aug 19 23:15:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59443: 29.0.50; [PATCH] Allow goto-address-at-point to use secondary browser Resent-From: Gabriel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Nov 2022 18:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59443 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 59443@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.166905549232678 (code B ref -1); Mon, 21 Nov 2022 18:32:02 +0000 Received: (at submit) by debbugs.gnu.org; 21 Nov 2022 18:31:32 +0000 Received: from localhost ([127.0.0.1]:48811 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxBZr-0008Uy-FP for submit@debbugs.gnu.org; Mon, 21 Nov 2022 13:31:32 -0500 Received: from lists.gnu.org ([209.51.188.17]:32988) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxBZo-0008Up-TX for submit@debbugs.gnu.org; Mon, 21 Nov 2022 13:31:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxBZn-0004qn-Oq for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2022 13:31:27 -0500 Received: from mail-dm6nam11olkn2059.outbound.protection.outlook.com ([40.92.19.59] helo=NAM11-DM6-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxBZj-00005U-NV for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2022 13:31:27 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VILcKcKrypjIicCotBN81ntNnl31nTaLwMm4GarUyC/w39lsqqxECm2esjSkR4yuvVYFl2EbCscx9s4Jf7yXaSd2YOrQRiG1iCt3a9QTujaBA6o5OifkTPeIs/eEnjhwwLsM1kOyj5OfMXNbNJ/xTnBnAsXEtoY6428cegY9QiJS5oH5NnH+SfiANhD/uUdovuIZS9gAWKNyvYIQSZhRWdUd+Eht3QWV4EwK3szwR5RHos/1tbx7ToO5TDxNN0IOUeH+eBDaaoFdmils6jhCKeU8r0yM3POyK+NiJrjkLrK0pcZbfOB/Fv9hSrmGVRWIwN/mA1C8+uBPvF1tggL/nA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vVI0CrwWGwsh067PwIb0dfY2A5BkMoHEY2OGK2HGgh4=; b=V1fibTfnCwwYelig8JbUdtzjmP0aw2p8vc1cm9w+FwXbdyp4YjwafvxADIovSl5vrfWHjEyHY0JC0OuNrXxj472MB4/THEsbZmQhbt/LXp7uXiW15TuhQtgbEXa5jKrF9TnEtifTJnPQqZOywvBjmac4hkLKm4yJ5uSJdaPoU4dYoOnFFU7LmLlpwq0rtnObxEu86LCXMSQNvKVt9TDwnIJZI6Ck81HtF4z9NIe4AKiO2xW+C0TjULOnfUBBe6umhs51BrOdxM4c5tS/qMpTg3aVHYnud9kQHkwJc7S7QK6mb2Rfy8+Ks9OEx5bGBrhHVCT/jzpWtpXwnQdxciq/1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vVI0CrwWGwsh067PwIb0dfY2A5BkMoHEY2OGK2HGgh4=; b=UqfthVQNGTQ5DGFkbcWGIuq878ta9A8938QgjEW5htXAEnrQw/gURmqXuukB5+FYpNgw4I1yROprDRmbK/IElGuDiDzsj6tdp/eRtHOWEgb85mTvC+9qHzI4Agnf80GLzvZPx/ffr4i8UlgWnR67O042+BCNdUz28GKVCMMlAIVL5y1Qnahaaldy/lO+HyFJEO/xG7pKtEdYtEvMvPQQi++Fd4l/WGTmDBoRowPp2hk9EUEketNVgw+nk+lFX/08kNYl4056kV5jZNQ3zTVkMsZjTUm3ZYYhl2tn0H2/HqvvVA4LJQ3zFg3i8iZr1WEb0hK/rqSlkopMbeDDTciFOg== Received: from SJ0PR06MB8609.namprd06.prod.outlook.com (2603:10b6:a03:40c::11) by BN6PR06MB2450.namprd06.prod.outlook.com (2603:10b6:404:2a::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.13; Mon, 21 Nov 2022 18:31:20 +0000 Received: from SJ0PR06MB8609.namprd06.prod.outlook.com ([fe80::33ae:d3a7:24ae:5c6f]) by SJ0PR06MB8609.namprd06.prod.outlook.com ([fe80::33ae:d3a7:24ae:5c6f%4]) with mapi id 15.20.5857.017; Mon, 21 Nov 2022 18:31:20 +0000 From: Gabriel In-Reply-To: <87v8n8dze6.fsf@gmail.com> (Visuwesh's message of "Mon, 21 Nov 2022 22:21:29 +0530") References: <87v8n8dze6.fsf@gmail.com> Date: Mon, 21 Nov 2022 15:31:13 -0300 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Content-Type: multipart/mixed; boundary="=-=-=" X-TMN: [A0bUOgrpzB1YpsZkMyB/VXp95Zv1D25B0/AZb8sbYUS6aZGvDAOvdF6Tgq4+q4dM] X-ClientProxiedBy: CP4P284CA0015.BRAP284.PROD.OUTLOOK.COM (2603:10d6:103:128::12) To SJ0PR06MB8609.namprd06.prod.outlook.com (2603:10b6:a03:40c::11) X-Microsoft-Original-Message-ID: <87y1s488i6.fsf@hotmail.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR06MB8609:EE_|BN6PR06MB2450:EE_ X-MS-Office365-Filtering-Correlation-Id: f12974af-6f1f-469b-96b4-08dacbee9522 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: g5+YfZmEX97Swcrqu34PPToh+BVdl06l0VErYuRT3kErA4CqSOosDgRj+OwY6aFqPA9PPhXrseqE6pvX0nSsTkW0n1RbMlGV48qmKcs1i+HjmXhgn5N+rNWmfDjxHzXjdFAktt4H0olisAnrg71k3TT3NzHtQEg817u0+Pl+yKskSsbMjMtosyS2py7oEy2F+5m8mNC4Xgjx7pKzotqZB3MXiniLX2TxkqLVSS71ARuE2lrZPRl+w+vNVhxO4F4esjBsv2JBhL0vXVQiFTfQiMkUqGK+HuXh3tjbFIpFxfGkWu3h2G2YKxJtZrLtFsQejUoNkOo28KJT/en+QHB2GZfwA2r8YHt4CF6fhR4BCfymgM/lY13MamXJoE/ftQzCowJ0QKShot/sdatHqEiL6TCRRONX+WNqY18/AD2MpCZvXQ8Z55rlTdATcfs9VpCnvYo3GKKZmIIVw4FMPMJD+8GKIk+v+iM6Gn2WGZA2VCuzRiSIunft/7fZYPkzXf3RMjpiXFHR5Bs0p+uDQJ9PW3YcIzbeUUOFzPIWTrMPYx6M5kWEQCnoLupnFVjwj4KdNIZyGoaK7fkrmvid0nwz7XGviGIrDpfM34vNnMCFBBEtQixxguUk4MfID5NGtV6ksDXkM8ixvpH8xjqRvsEwN0H456kWI9qtGkT1LojzXEM= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: GvfwdQ554pm535R+nBn8/+uUcuXooZtGdBTHzycPxFxSjMCD3w7T07W6mg4bCMGUuu+Xq+Rf0n0brZYwbBVBHl7lYyk5ewVf0KLyGoKIZjKPO/Ro+bcYjAZcZEeGWOkaJ490xu9SSOrP0RGvKYAnWa6oZNjS3eb6NZSPc4aqJrVT5l0rsS99LL2bh4SXhcpdVOPKLtwPxK7UYzF2O84EyyRr1XYjiQzrf9mGTJnSDwj0mXaeLiq5ggpR9+3bnndgPsTycgj1Tgb7XyHt8+JfXRmS4xXbz96CJmJElVo/Kdc3/QJfttFcqbSHIBCgab1MLMh6+PpARnJ3QEiH/OcEHfqyeR6IchRmRXU29vvzMSdQPRjGpCLkFcZ39T4QtDEQwG+dyDH36M/MY+Txd2y3ftAqmFm9Ic4vk5bvdMdDGMsqAOvr6EL//JOENLR/xE+kvMerLQEdyv6oHMjyBmNKIke8GK0GAmx2Gh3xOGqQkR0R2uQuiZ7zZ6m7+iTIRgPltwpSZNYyFbJ3I+Vl//TWmrKZS5wS5RUdhg05ngnLOSwuwm561H3dO1B1+jfeRgtd7BVQCEkmsTaiZPqw/6lIYyzqICr4IdGPFo/Ltz//eHJt51NpxHVImi4LTvFPnzq560yDnz1YxL+1Kw5/7ZPVaFwj+7s5y58ePqueqJ5ucXgE4PQrMCrAmhTbeLn9jBNqWtK2SvQlsBPmLDgfLXfC/LtJeAf/4NZ7iCl3dht9WoKBGX5BTztC5G4uq8HqUkZypTfu/mXXgkci0iFptVlyLpsCoCUEklN9NM+t7hzmYIXoOOBPMh5Dxx/FZ9Vf4B8Jp4DKjCMyCJfWuCjmz71F2gmFXTdupAZoViIPkBOZVuQKweGFQUO7JRd2Vd8w1C0Og5l4Pfrduwu9ceBsBsyAFC0moUXlIKOWAKw6FrTSwSp/kyy6Ffbm624HM/XVVwDrHxnWxlVlKxuAOLaDKRVdeTbYqPon9FWcIAIcd/TMbwPAEeUlGX68nnPS5n+e4Cvj5qAXk7QmJEBTWrzMjIbKpzW44FWYO2iCDy51WGaJT1iU6APPXkXaAJZxQVB2/JD3G0iVhpJ+VR5KURAfQyLVVlZcJ+HI3RAsoI7+3YBGn80y/Mnzy1F9nYK+2DL6rOVsOBeljV/QwEDD6gNmEN7Uky3Jp1vs5ibIqgsnrZcjlr65+8ovIQHBRrkxEzUu2p/JreSyk6vNbNylEQtifmPXVm0uU5lAUWxZQJdMJlMkbymg+oiA/TRBw1ApUAC+MKrEKTj4Pg5ZXjE7PSMdSlTECH+6VUqDU3FrhPBmNxzSM5Jw29a63tCYETsMZTNEzDn8ZKc0GJaYFgjgR7EVyFQ3yQ== X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-89723.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: f12974af-6f1f-469b-96b4-08dacbee9522 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR06MB8609.namprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 18:31:20.3570 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR06MB2450 Received-SPF: pass client-ip=40.92.19.59; envelope-from=gabriel376@hotmail.com; helo=NAM11-DM6-obe.outbound.protection.outlook.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Visuwesh writes: > [=E0=AE=A4=E0=AE=BF=E0=AE=99=E0=AF=8D=E0=AE=95=E0=AE=B3=E0=AF=8D =E0=AE= =A8=E0=AE=B5=E0=AE=AE=E0=AF=8D=E0=AE=AA=E0=AE=B0=E0=AF=8D 21, 2022] Gabriel= wrote: > >> [...] >> From 2151f92bf5d07106d7f322ea69bfc745b0bf1d28 Mon Sep 17 00:00:00 2001 >> From: Gabriel do Nascimento Ribeiro >> Date: Mon, 21 Nov 2022 08:08:52 -0300 >> Subject: [PATCH 1/1] Allow goto-address-at-point to use secondary browse= r >> >> * lisp/net/dictionary.el (goto-address-at-point): Call > ^^^^^^^^^^^^^^^^^^^^^^ > Hmm, the patch touches lisp/net/goto-addr.el but the commit message > refers to another file. > Thanks, fixed. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Allow-goto-address-at-point-to-use-secondary-browser.patch >>From 2151f92bf5d07106d7f322ea69bfc745b0bf1d28 Mon Sep 17 00:00:00 2001 From: Gabriel do Nascimento Ribeiro Date: Mon, 21 Nov 2022 08:08:52 -0300 Subject: [PATCH 1/1] Allow goto-address-at-point to use secondary browser * lisp/net/goto-addr.el (goto-address-at-point): Call `browse-url-button-open-url', so a prefix argument uses `browse-url-secondary-browser-function'. --- lisp/net/goto-addr.el | 31 +++++++++++++++++-------------- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/lisp/net/goto-addr.el b/lisp/net/goto-addr.el index 86cf98004b..03e14c9268 100644 --- a/lisp/net/goto-addr.el +++ b/lisp/net/goto-addr.el @@ -222,25 +222,28 @@ goto-address-fontify-region ;;;###autoload (defun goto-address-at-point (&optional event) - "Send to the e-mail address or load the URL at point. -Send mail to address at point. See documentation for -`goto-address-find-address-at-point'. If no address is found -there, then load the URL at or before point." + "Start composing a new message to the e-mail address at point or +open URL at point. + +If no e-mail address is found at point, use the URL at or before +point. See `goto-address-find-address-at-point'. + +With prefix argument, use the secondary browser to open the URL. +See `browse-url-button-open-url'." (interactive (list last-input-event)) (save-excursion (if event (posn-set-point (event-end event))) (let ((address (save-excursion (goto-address-find-address-at-point)))) (if (and address - (save-excursion - (goto-char (previous-single-char-property-change - (point) 'goto-address nil - (line-beginning-position))) - (not (looking-at goto-address-url-regexp)))) - (compose-mail address) - (let ((url (browse-url-url-at-point))) - (if url - (browse-url url) - (error "No e-mail address or URL found"))))))) + (save-excursion + (goto-char (previous-single-char-property-change + (point) 'goto-address nil + (line-beginning-position))) + (not (looking-at goto-address-url-regexp)))) + (compose-mail address) + (if-let ((url (browse-url-url-at-point))) + (browse-url-button-open-url url) + (error "No e-mail address or URL found")))))) (defun goto-address-find-address-at-point () "Find e-mail address around or before point. -- 2.34.1 --=-=-= Content-Type: text/plain --- Gabriel --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 24 13:26:48 2022 Received: (at control) by debbugs.gnu.org; 24 Nov 2022 18:26:48 +0000 Received: from localhost ([127.0.0.1]:60004 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyGvw-0006nQ-Aj for submit@debbugs.gnu.org; Thu, 24 Nov 2022 13:26:48 -0500 Received: from mail-oi1-f172.google.com ([209.85.167.172]:34341) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyGvu-0006nC-NH for control@debbugs.gnu.org; Thu, 24 Nov 2022 13:26:47 -0500 Received: by mail-oi1-f172.google.com with SMTP id n205so2310365oib.1 for ; Thu, 24 Nov 2022 10:26:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=8Gz6AJmHIlDaw9rlP2q+aEoMyzEHbukOINPbzbiF8rQ=; b=m4+FUh5GweGSEtgi9emKWTVeQUk0DOpSLOVBm4JSls7xP1bnZG88XmurXL35YTv07I O/0rORH9cr7xyLu1fhXWBNfhpT74qu4fKDd12+bc04t3HAONSQr6BL36IVGE+Kb0R2n6 9LF83Hipwu6/6MEeQLySFDt9Q/oj10xboI30vmSZx+1QMi2mWn8tFocyn12C1Hk0vIOb nvcvzNUmMv9MfSjfi2907KOffy94tUGsz5uX5z0TFQ/S2//ekm2nCCLvaMesgSWaK/WJ bsIH7BMLzr6pMTPcfViqFLdnr9mVW+LgTdowJafVnB+nNYO+5QHlyeoF2ZJbzEx57dg7 a3qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=8Gz6AJmHIlDaw9rlP2q+aEoMyzEHbukOINPbzbiF8rQ=; b=rXomF9zFM/OdAiZ6eT45fvdGkfQKOJJ8zTPT3CsQxs8nYZthv4PwKncsYlrPw6FRAK OCVn6Yt5ndwAf2ZgC6qkDeAeHSYWQQ37I4G/3nmDBj/b9zJuZNQCDauNr7N6Oc2jOOfG 8C3lr44uEYH6hgIeHexwEG+dFgIvZ6q6gDe/iu4T/qm5PME5bjt1/mZDvQe3eV7nVB9C +2dVBpeJuDrDkzCUZFTBwD3zQuIy5NsyEQdHx88RNcmQmS/l2e9mWQamEdHgYcWJN87C HDKfQCpSMiqaEVIrTCDe8Unv5Xub0lRiD177xeuQNQcz6ML0WupxxgdiME2Qxkio2eN2 Z+Hg== X-Gm-Message-State: ANoB5pk6Z5WX6Dba9OijJJby6AL0m+GCabAnFH/r4paxc2QHZivbCXyR I8PtJKt9T1zg+154ASPgjqHaaAYhtJP8RfmczAf/VOZS X-Google-Smtp-Source: AA0mqf7tjuNozzwVRlMPGteXYieN+HAouIG3li3XNTWhRJo7GORR1WEZBIz84/9O+gIGcMoXiFf4cE7sYUPGw5rOa3s= X-Received: by 2002:a05:6808:2229:b0:35b:2b17:af81 with SMTP id bd41-20020a056808222900b0035b2b17af81mr7451948oib.199.1669314401128; Thu, 24 Nov 2022 10:26:41 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 24 Nov 2022 10:26:40 -0800 From: Stefan Kangas X-Hashcash: 1:20:221124:control@debbugs.gnu.org::BdJkDhUkASVFhA/m:15cN MIME-Version: 1.0 Date: Thu, 24 Nov 2022 10:26:40 -0800 Message-ID: Subject: control message for bug #59443 To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) severity 59443 wishlist quit From unknown Tue Aug 19 23:15:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59443: 29.0.50; [PATCH] Allow goto-address-at-point to use secondary browser Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Nov 2022 00:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59443 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Gabriel Cc: 59443@debbugs.gnu.org Received: via spool by 59443-submit@debbugs.gnu.org id=B59443.166933647211034 (code B ref 59443); Fri, 25 Nov 2022 00:35:01 +0000 Received: (at 59443) by debbugs.gnu.org; 25 Nov 2022 00:34:32 +0000 Received: from localhost ([127.0.0.1]:60597 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyMfn-0002rt-MZ for submit@debbugs.gnu.org; Thu, 24 Nov 2022 19:34:31 -0500 Received: from mail-oa1-f52.google.com ([209.85.160.52]:41939) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyMfm-0002rb-T3 for 59443@debbugs.gnu.org; Thu, 24 Nov 2022 19:34:31 -0500 Received: by mail-oa1-f52.google.com with SMTP id 586e51a60fabf-14279410bf4so3498791fac.8 for <59443@debbugs.gnu.org>; Thu, 24 Nov 2022 16:34:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=mp/CSlZFBk0oDqreD1iFVGmVDc8m6QrsF3CpLk6ERX8=; b=XM9YXLbDqJRTKISVHVLTb1BUjAO//1AzByheRx2mZqfZh8X8TPK13z/LsQwiwGvXg1 CBX72mmNED+dO6TNCZMlOOPBOuuFyro/wJfZONJGJTZKG9khQKJ4mWAI4lRbAaaj4L3n DdOygtUe6SCc+0TpgXYRe7K3d1WW924KCGlGQ2IGHwupyuILFlJSfar4uCvcnNsNuCdV YnU6KHGN7gMYjS9x7Kgwp4D4bNkRnAFVjXsRKX3bSXUWThMyyvaxWmkLQAwufaLSutA1 3j4EfxyckVQuGaG0FjRqJLUyF/onzvJFBoGBzOHj0+pelCpzTyq8GlvEdns+4qJFPiTX v4zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=mp/CSlZFBk0oDqreD1iFVGmVDc8m6QrsF3CpLk6ERX8=; b=YTDBNdQQlGNbIhLgCg/WyKrO5Ia6Wcz2eNnck38upzGfZkeDEfBWXVOeHnhTJmQqIs AxdZdROTaHZGWNDiJ72oGwmiO/pOMk0x5qQwb52XAC5YwAnvewPO8AOOG4Z4IbPTnYuO EKfTAJ/eQGQ2vFkmUl/2EGQqvXQC8/kkEA70xXd6puHp2VjmEErty5r1Ea29kDhh4J2u LROeZx2YLzAPmAWsFPVV5kEKWnIPqrafEK5tx5YrdYyPvhsVncGJ0BHU+Y2JcXPokNEs x8cZUEb4EdWRWeJnEhVzZ4NsvP9+ZElRsyHUwzoM5pteqF2v4OKDtufc2EckAD5HrlTs xyiw== X-Gm-Message-State: ANoB5pmEYNYvLmUG1n6tsdo41JRmnxODGji+/5jB1xuGrQW3Kc32OgLG 1v/buoFZh27wmha/stItFhd5hyXzOsUMVtptV+w= X-Google-Smtp-Source: AA0mqf6DqyMoMXq7cVmlu24o0NE5nQWTYKA350LLRD4UxaDhtmNAgI3Y/EjC0eLcOoTO+jKgXsNKCWT1NDNCLeyPS+c= X-Received: by 2002:a05:6870:cc89:b0:12b:fbe7:b793 with SMTP id ot9-20020a056870cc8900b0012bfbe7b793mr21849076oab.92.1669336465240; Thu, 24 Nov 2022 16:34:25 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 24 Nov 2022 16:34:24 -0800 From: Stefan Kangas In-Reply-To: (Gabriel's message of "Mon, 21 Nov 2022 15:31:13 -0300") References: <87v8n8dze6.fsf@gmail.com> X-Hashcash: 1:20:221125:59443@debbugs.gnu.org::j4xa2TdMu4MgJ2DK:7S9d MIME-Version: 1.0 Date: Thu, 24 Nov 2022 16:34:24 -0800 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 59443 29.1 thanks Gabriel writes: > Visuwesh writes: > >> [=E0=AE=A4=E0=AE=BF=E0=AE=99=E0=AF=8D=E0=AE=95=E0=AE=B3=E0=AF=8D =E0=AE= =A8=E0=AE=B5=E0=AE=AE=E0=AF=8D=E0=AE=AA=E0=AE=B0=E0=AF=8D 21, 2022] Gabriel= wrote: >> >>> [...] >>> From 2151f92bf5d07106d7f322ea69bfc745b0bf1d28 Mon Sep 17 00:00:00 2001 >>> From: Gabriel do Nascimento Ribeiro >>> Date: Mon, 21 Nov 2022 08:08:52 -0300 >>> Subject: [PATCH 1/1] Allow goto-address-at-point to use secondary brows= er >>> >>> * lisp/net/dictionary.el (goto-address-at-point): Call >> ^^^^^^^^^^^^^^^^^^^^^^ >> Hmm, the patch touches lisp/net/goto-addr.el but the commit message >> refers to another file. >> > > Thanks, fixed. Thanks, the commit looks good to me so I pushed it to master (commit 29a262bfa7). See also the documentation fixes I made in a followup patch (commit 60354fcf49).