GNU bug report logs - #59422
[PATCH] * src/emacs.c (usage_message): Add missing --init-directory entry

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 59422 in the body.
You can then email your comments to 59422 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] * src/emacs.c (usage_message): Add missing --init-directory
 entry
Date: Sun, 20 Nov 2022 21:52:09 +0000

[Message part 1 (text/plain, inline)]

Tags: patch


It appears this was not documented via --help when added.


In GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
 3.24.34, cairo version 1.16.0) of 2022-11-19 built on quetzal
Repository revision: db3ff76dc7d3184e51cb7ed17c78ef76babb9032
Repository branch: master
System Description: Debian GNU/Linux bookworm/sid

Configured using:
 'configure --with-pgtk --with-imagemagick'

[0001-src-emacs.c-usage_message-Add-missing-init-directory.patch (text/patch, attachment)]

Message #8 received at 59422 <at> debbugs.gnu.org (full text, mbox):

From: Visuwesh <visuweshm <at> gmail.com>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: 59422 <at> debbugs.gnu.org
Subject: Re: bug#59422: [PATCH] * src/emacs.c (usage_message): Add missing
 --init-directory entry
Date: Mon, 21 Nov 2022 13:57:25 +0530

[ஞாயிறு நவம்பர் 20, 2022] Philip Kaludercic wrote:

> Tags: patch
>
>
> It appears this was not documented via --help when added.
>
> [...]
>
> diff --git a/src/emacs.c b/src/emacs.c
> index 85102acd28..bbcd0be74c 100644
> --- a/src/emacs.c
> +++ b/src/emacs.c
> @@ -291,6 +291,7 @@ #define MAIN_PROGRAM
>  --no-site-lisp, -nsl        do not add site-lisp directories to load-path\n\
>  --no-splash                 do not display a splash screen on startup\n\
>  --no-window-system, -nw     do not communicate with X, ignoring $DISPLAY\n\
> +--init-directory=DIR        use DIR to use when looking for the Emacs init files.\n\
                               ^^^^^^^^^^^^^^
                               there appears to be a typo here.
>  ",
>      "\
>  --quick, -Q                 equivalent to:\n\

Message #11 received at 59422 <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: Visuwesh <visuweshm <at> gmail.com>
Cc: 59422 <at> debbugs.gnu.org
Subject: Re: bug#59422: [PATCH] * src/emacs.c (usage_message): Add missing
 --init-directory entry
Date: Mon, 21 Nov 2022 18:33:17 +0000

Visuwesh <visuweshm <at> gmail.com> writes:

> [ஞாயிறு நவம்பர் 20, 2022] Philip Kaludercic wrote:
>
>> Tags: patch
>>
>>
>> It appears this was not documented via --help when added.
>>
>> [...]
>>
>> diff --git a/src/emacs.c b/src/emacs.c
>> index 85102acd28..bbcd0be74c 100644
>> --- a/src/emacs.c
>> +++ b/src/emacs.c
>> @@ -291,6 +291,7 @@ #define MAIN_PROGRAM
>>  --no-site-lisp, -nsl        do not add site-lisp directories to load-path\n\
>>  --no-splash                 do not display a splash screen on startup\n\
>>  --no-window-system, -nw     do not communicate with X, ignoring $DISPLAY\n\
>> +--init-directory=DIR        use DIR to use when looking for the Emacs init files.\n\
>                                ^^^^^^^^^^^^^^
>                                there appears to be a typo here.

You are absolutely right, will change locally.

>>  ",
>>      "\
>>  --quick, -Q                 equivalent to:\n\

Message #14 received at 59422 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: 59422 <at> debbugs.gnu.org, Visuwesh <visuweshm <at> gmail.com>
Subject: Re: bug#59422: [PATCH] * src/emacs.c (usage_message): Add missing
 --init-directory entry
Date: Thu, 24 Nov 2022 10:27:13 -0800

Philip Kaludercic <philipk <at> posteo.net> writes:

>>> diff --git a/src/emacs.c b/src/emacs.c
>>> index 85102acd28..bbcd0be74c 100644
>>> --- a/src/emacs.c
>>> +++ b/src/emacs.c
>>> @@ -291,6 +291,7 @@ #define MAIN_PROGRAM
>>>  --no-site-lisp, -nsl        do not add site-lisp directories to load-path\n\
>>>  --no-splash                 do not display a splash screen on startup\n\
>>>  --no-window-system, -nw     do not communicate with X, ignoring $DISPLAY\n\
>>> +--init-directory=DIR        use DIR to use when looking for the Emacs init files.\n\
>>                                ^^^^^^^^^^^^^^
>>                                there appears to be a typo here.
>
> You are absolutely right, will change locally.

Could you please also double check that the text in the doc/man/emacs.1
is up-to-date and makes sense too?

Other than that, LGTM with the above fix.  Thanks.

Message #19 received at 59422 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: philipk <at> posteo.net, 59422 <at> debbugs.gnu.org, visuweshm <at> gmail.com
Subject: Re: bug#59422: [PATCH] * src/emacs.c (usage_message): Add missing
 --init-directory entry
Date: Thu, 24 Nov 2022 20:40:24 +0200

> Cc: 59422 <at> debbugs.gnu.org, Visuwesh <visuweshm <at> gmail.com>
> From: Stefan Kangas <stefankangas <at> gmail.com>
> Date: Thu, 24 Nov 2022 10:27:13 -0800
> 
> Could you please also double check that the text in the doc/man/emacs.1
> is up-to-date and makes sense too?

I already did: it is and it does.

Message #22 received at 59422 <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: visuweshm <at> gmail.com, Stefan Kangas <stefankangas <at> gmail.com>,
 59422 <at> debbugs.gnu.org
Subject: Re: bug#59422: [PATCH] * src/emacs.c (usage_message): Add missing
 --init-directory entry
Date: Thu, 24 Nov 2022 18:51:12 +0000

Eli Zaretskii <eliz <at> gnu.org> writes:

>> Cc: 59422 <at> debbugs.gnu.org, Visuwesh <visuweshm <at> gmail.com>
>> From: Stefan Kangas <stefankangas <at> gmail.com>
>> Date: Thu, 24 Nov 2022 10:27:13 -0800
>> 
>> Could you please also double check that the text in the doc/man/emacs.1
>> is up-to-date and makes sense too?
>
> I already did: it is and it does.

I've pushed the change.  And the flag was added in bug#55839.

Message #27 received at 59422-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 59422-done <at> debbugs.gnu.org,
 visuweshm <at> gmail.com
Subject: Re: bug#59422: [PATCH] * src/emacs.c (usage_message): Add missing
 --init-directory entry
Date: Thu, 24 Nov 2022 15:38:06 -0800

Philip Kaludercic <philipk <at> posteo.net> writes:

> I've pushed the change.  And the flag was added in bug#55839.

Thanks, so I'm closing this bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.