GNU bug report logs - #59399
[PATCH] gnu: Add hebcal.

Previous Next

Full log

Message #23 received at 59399 <at> debbugs.gnu.org (full text, mbox):

From: "(" <paren <at> disroot.org>
To: "Felix Lechner" <felix.lechner <at> lease-up.com>, <59399 <at> debbugs.gnu.org>
Subject: Re: [PATCH 1/4] gnu: Add go-github-com-nathan-osman-go-sunrise.
Date: Sun, 20 Nov 2022 13:53:28 +0000

Heya,

Thanks for splitting them! A few remarks:

On Sun Nov 20, 2022 at 1:47 PM GMT, Felix Lechner wrote:
> * gnu/packages/golang.scm
>   (go-github-com-nathan-osman-go-sunrise): New variable.

Indentation for this should look something like:

  * gnu/packages/golang.scm (go-github-com-nathan-osman-go-sunrise):
    New variable.

> --- a/gnu/packages/golang.scm
> +++ b/gnu/packages/golang.scm

> @@ -2485,6 +2485,33 @@ (define-public go-gopkg-in-go-playground-validator-v9

> +      (arguments
> +       '(#:import-path "github.com/nathan-osman/go-sunrise"))

Please use

  (list #:import-path ...)

instead.

> +      (synopsis "Calculates the sunrise and sunset times for a given location")

Maybe change this to:

  (synopsis "Calculate sunrise and sunset times in Go")

> +      (description
> +       "To calculate the sunrise and sunset times, you will need the date of your
> +observation and the geographical coordinates in latitude and longitude for the
> +location.")

How about this:

  (description
   "This package provides a Go library for calculating sunrise and
sunset times from geographical coordinates and a date.")

    -- (

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.