GNU bug report logs - #59386
[PATCH staging 00/11] Update vulkan-sdk packages to sdk-1.3.231.1.

Previous Next

Full log

Message #50 received at 59386 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <marius <at> gnu.org>
To: dan <i <at> dan.games>, 59386 <at> debbugs.gnu.org
Subject: Re: [bug#59386] [PATCH 11/11] gnu: Add vulkan-memory-allocator.
Date: Sun, 20 Nov 2022 09:24:40 +0100

[Message part 1 (text/plain, inline)]

dan <i <at> dan.games> skriver:

> * gnu/packages/vulkan.scm (vulkan-memory-allocator): New variable.

[...]

> +(define-public vulkan-memory-allocator
> +  (package
> +    (name "vulkan-memory-allocator")
> +    (version "3.0.1")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "https://github.com/GPUOpen-LibrariesAndSDKs/VulkanMemoryAllocator"
> +                    "/archive/refs/tags/v" version ".tar.gz"))

The GitHub "/archive" URLs are not stable: the tarballs are generated on
demand and cached; when the cache expires they get regenerated with
different time stamps.

Use git-fetch instead.

> +    (build-system cmake-build-system)
> +    (arguments
> +     ; no test
> +     `(#:tests? #f))
> +    (inputs
> +     (list vulkan-loader
> +           vulkan-headers))

Please run './pre-inst-env guix style vulkan-memory-allocator'.  :-)

> +    (synopsis "Easy to integrate Vulkan memory allocation library")

Just 'Vulkan memory allocation library' is sufficient.

> +    (description "Easy to integrate Vulkan memory allocation library.")

Can you turn this into a full sentence, i.e. "vulkan-memory-allocator is
an easy to integrate ...", ideally with some information about what that
means for potential users?

Can you send an updated patch?

TIA!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.