GNU bug report logs - #59372
[PATCH] gnu: peek: Add missing input.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: 宋文武 <iyzsong <at> envs.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#59372: closed ([PATCH] gnu: peek: Add missing input.)
Date: Sun, 29 Jan 2023 06:03:03 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 29 Jan 2023 14:02:12 +0800
with message-id <87o7qhj2u3.fsf_-_ <at> envs.net>
and subject line Re: bug#59372: [PATCH] gnu: peek: Add missing input.
has caused the debbugs.gnu.org bug report #59372,
regarding [PATCH] gnu: peek: Add missing input.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
59372: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59372
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: jgart <jgart <at> dismail.de>
To: guix-patches <at> gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: [PATCH] gnu: peek: Add missing input.
Date: Fri, 18 Nov 2022 19:27:46 -0600

* gnu/packages/video.scm (peek): Add missing input.
[inputs]: Add ffmpeg so that Peek will not fail to run on a foreign
distro.

hi, peek fails to run on a foreign distro without ffmpeg as an input.

this patch fixes that.

all best,

jgart
---
 gnu/packages/video.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index c394c65442..4f38d4432c 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -5369,6 +5369,8 @@ (define-public peek
     (arguments '(#:glib-or-gtk? #t))
     (inputs
      `(("gtk+" ,gtk+)
+       ;; Peek fails to run on a foreign distro without ffmpeg.
+       ("ffmpeg" ,ffmpeg)
        ("python" ,python-wrapper)))
     (native-inputs
      `(("desktop-file-utils" ,desktop-file-utils) ; for update-desktop-database
-- 
2.38.1

[Message part 3 (message/rfc822, inline)]

From: 宋文武 <iyzsong <at> envs.net>
To: jgart <jgart <at> dismail.de>
Cc: paren <at> disroot.org, Tobias Geerinckx-Rice <me <at> tobias.gr>,
 59372-done <at> debbugs.gnu.org
Subject: Re: bug#59372: [PATCH] gnu: peek: Add missing input.
Date: Sun, 29 Jan 2023 14:02:12 +0800

jgart <jgart <at> dismail.de> writes:

> On Mon, 21 Nov 2022 21:18:32 +0100 Tobias Geerinckx-Rice <me <at> tobias.gr> wrote:
>> Does it not show that window on a foreign distribution?
>
> Yup, it does show that window on a foreign distro.
>
> So, we should just have the user install ffmpeg along with peek in their profile?
>
> Should this ticket be closed then? https://issues.guix.gnu.org/issue/51202#3

Yes, I think it's expected to install ffmpeg yourself for peek when not
in gnome shell.  Close now.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.