Subject: bug#59372: closed (Re: bug#59372: [PATCH] gnu: peek: Add missing input.)

From: [email-masked] (GNU bug Tracking System)
Date: Sun, 29 Jan 2023 06:03:03 +0000

Your bug report

#59372: [PATCH] gnu: peek: Add missing input.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
59372: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59372
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#59372: [PATCH] gnu: peek: Add missing input.
From: 宋文武 <[email-masked]>
To: jgart <[email-masked]>
Cc: [email-masked], Tobias Geerinckx-Rice <[email-masked]>, [email-masked]
Date: Sun, 29 Jan 2023 14:02:12 +0800
List-Id: <debbugs-submit.debbugs.gnu.org>

jgart <[email-masked]> writes:

> On Mon, 21 Nov 2022 21:18:32 +0100 Tobias Geerinckx-Rice <[email-masked]> wrote:
>> Does it not show that window on a foreign distribution?
>
> Yup, it does show that window on a foreign distro.
>
> So, we should just have the user install ffmpeg along with peek in their profile?
>
> Should this ticket be closed then? https://issues.guix.gnu.org/issue/51202#3

Yes, I think it's expected to install ffmpeg yourself for peek when not
in gnome shell.  Close now.

Subject: [PATCH] gnu: peek: Add missing input.
From: jgart <[email-masked]>
To: [email-masked]
Cc: jgart <[email-masked]>
Date: Fri, 18 Nov 2022 19:27:46 -0600
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/video.scm (peek): Add missing input.
[inputs]: Add ffmpeg so that Peek will not fail to run on a foreign
distro.

hi, peek fails to run on a foreign distro without ffmpeg as an input.

this patch fixes that.

all best,

jgart
---
 gnu/packages/video.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index c394c65442..4f38d4432c 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -5369,6 +5369,8 @@ (define-public peek
     (arguments '(#:glib-or-gtk? #t))
     (inputs
      `(("gtk+" ,gtk+)
+       ;; Peek fails to run on a foreign distro without ffmpeg.
+       ("ffmpeg" ,ffmpeg)
        ("python" ,python-wrapper)))
     (native-inputs
      `(("desktop-file-utils" ,desktop-file-utils) ; for update-desktop-database
-- 
2.38.1