From unknown Sat Aug 16 00:32:03 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#5936 <5936@debbugs.gnu.org> To: bug#5936 <5936@debbugs.gnu.org> Subject: Status: 23.1.95; fix a bug in abbrev--before-point Reply-To: bug#5936 <5936@debbugs.gnu.org> Date: Sat, 16 Aug 2025 07:32:03 +0000 retitle 5936 23.1.95; fix a bug in abbrev--before-point reassign 5936 emacs submitter 5936 Leo severity 5936 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 12 11:19:48 2010 Received: (at submit) by debbugs.gnu.org; 12 Apr 2010 15:19:48 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O1LQS-0007ew-8m for submit@debbugs.gnu.org; Mon, 12 Apr 2010 11:19:48 -0400 Received: from mx10.gnu.org ([199.232.76.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O1LQQ-0007eq-BI for submit@debbugs.gnu.org; Mon, 12 Apr 2010 11:19:46 -0400 Received: from lists.gnu.org ([199.232.76.165]:35450) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1O1LQL-0005oY-6C for submit@debbugs.gnu.org; Mon, 12 Apr 2010 11:19:41 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O1LQK-0007s0-9c for bug-gnu-emacs@gnu.org; Mon, 12 Apr 2010 11:19:40 -0400 Received: from [140.186.70.92] (port=50844 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O1LQI-0007qy-Nt for bug-gnu-emacs@gnu.org; Mon, 12 Apr 2010 11:19:39 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.0 (2010-01-18) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_MED,T_RP_MATCHES_RCVD,T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.0 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O1LQH-0006B7-6R for bug-gnu-emacs@gnu.org; Mon, 12 Apr 2010 11:19:38 -0400 Received: from ppsw-31.csi.cam.ac.uk ([131.111.8.131]:52529 helo=ppsw-1.csi.cam.ac.uk) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O1LQH-0006Ax-0t for bug-gnu-emacs@gnu.org; Mon, 12 Apr 2010 11:19:37 -0400 X-Cam-AntiVirus: no malware found X-Cam-SpamDetails: not scanned X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Received: from wlan-gw.st-edmunds.cam.ac.uk ([131.111.223.101]:52055 helo=Victoria.local) by ppsw-1.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.151]:587) with esmtpsa (PLAIN:sl392) (TLSv1:DHE-RSA-AES128-SHA:128) id 1O1LQG-0008Vw-58 (Exim 4.70) for bug-gnu-emacs@gnu.org (return-path ); Mon, 12 Apr 2010 16:19:36 +0100 From: Leo To: bug-gnu-emacs@gnu.org Subject: 23.1.95; fix a bug in abbrev--before-point Date: Mon, 12 Apr 2010 16:19:37 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.4 (------) If you use the :regexp property in an abbrev table, all abbrevs in that table will fail except those with only one char. This is because of a regexp match in abbrev--before-point which only looks back one char. BTW, the doc string of looking-back seems irrelevant if by default it only looks back one char, that can't be slower than looking-at. diff --git a/lisp/abbrev.el b/lisp/abbrev.el index b72bdbb..d3b95cb 100644 --- a/lisp/abbrev.el +++ b/lisp/abbrev.el @@ -681,7 +681,7 @@ then ABBREV is looked up in that table only." (setq start (point)) (forward-word 1) (setq end (min (point) lim))) - (when (looking-back re (line-beginning-position)) + (when (looking-back re (line-beginning-position) t) (setq start (match-beginning 1)) (setq end (match-end 1))))) (setq name (buffer-substring start end)) From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 12 14:25:23 2010 Received: (at 5936) by debbugs.gnu.org; 12 Apr 2010 18:25:23 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O1OK3-0000Vv-MH for submit@debbugs.gnu.org; Mon, 12 Apr 2010 14:25:23 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O1OK1-0000Vq-8e for 5936@debbugs.gnu.org; Mon, 12 Apr 2010 14:25:22 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEANMCw0tMCqWu/2dsb2JhbACbOnK8e4UMBItG X-IronPort-AV: E=Sophos;i="4.52,192,1270440000"; d="scan'208";a="60693726" Received: from 76-10-165-174.dsl.teksavvy.com (HELO pastel.home) ([76.10.165.174]) by ironport2-out.pppoe.ca with ESMTP; 12 Apr 2010 14:25:16 -0400 Received: by pastel.home (Postfix, from userid 20848) id 7CC347F1B; Mon, 12 Apr 2010 14:25:16 -0400 (EDT) From: Stefan Monnier To: Leo Subject: Re: bug#5936: 23.1.95; fix a bug in abbrev--before-point Message-ID: References: Date: Mon, 12 Apr 2010 14:25:16 -0400 In-Reply-To: (Leo's message of "Mon, 12 Apr 2010 16:19:37 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 5936 Cc: 5936@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > If you use the :regexp property in an abbrev table, all abbrevs in that > table will fail except those with only one char. Not at all. But you may get such a result if you use a naive regexp, yes. > This is because of a regexp match in abbrev--before-point which only > looks back one char. No, this is because the regexp you have to use must match part of the text *before* the abbrev. That's why the doc for define-abbrev-table gives as example \<\(\w+\)\W* rather than just \(\w+\)\W*. Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 14 11:39:01 2010 Received: (at control) by debbugs.gnu.org; 14 Apr 2010 15:39:01 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O24g9-00019S-BH for submit@debbugs.gnu.org; Wed, 14 Apr 2010 11:39:01 -0400 Received: from pantheon-po17.its.yale.edu ([130.132.50.73]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O24g7-00019J-2o for control@debbugs.gnu.org; Wed, 14 Apr 2010 11:38:59 -0400 Received: from furry (dhcp128036014140.central.yale.edu [128.36.14.140]) (authenticated bits=0) by pantheon-po17.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o3EFcshM009578 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Wed, 14 Apr 2010 11:38:54 -0400 Received: by furry (Postfix, from userid 1000) id 6ED45C055; Wed, 14 Apr 2010 11:38:54 -0400 (EDT) From: Chong Yidong To: control@debbugs.gnu.org Subject: close 5936 Date: Wed, 14 Apr 2010 11:38:54 -0400 Message-ID: <87bpdm3uy9.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.8 (--) close 5936 thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 15 06:15:18 2010 Received: (at 5936) by debbugs.gnu.org; 15 Apr 2010 10:15:18 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O2M6Q-0001Zw-CW for submit@debbugs.gnu.org; Thu, 15 Apr 2010 06:15:18 -0400 Received: from ppsw-32.csi.cam.ac.uk ([131.111.8.132]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O2M6O-0001Zn-5G for 5936@debbugs.gnu.org; Thu, 15 Apr 2010 06:15:16 -0400 X-Cam-AntiVirus: no malware found X-Cam-SpamDetails: not scanned X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Received: from smaug.linux.pwf.cam.ac.uk ([193.60.95.72]:49845) by ppsw-32.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.158]:587) with esmtpsa (LOGIN:sl392) (TLSv1:DHE-RSA-AES128-SHA:128) id 1O2M6K-0005GR-Ab (Exim 4.70) (return-path ); Thu, 15 Apr 2010 11:15:12 +0100 From: Leo To: Stefan Monnier Subject: Re: bug#5936: 23.1.95; fix a bug in abbrev--before-point References: Date: Thu, 15 Apr 2010 11:15:11 +0100 In-Reply-To: (Stefan Monnier's message of "Mon, 12 Apr 2010 14:25:16 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: 5936 Cc: 5936@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.3 (------) On 2010-04-12 19:25 +0100, Stefan Monnier wrote: >> If you use the :regexp property in an abbrev table, all abbrevs in that >> table will fail except those with only one char. > > Not at all. But you may get such a result if you use a naive regexp, yes. > >> This is because of a regexp match in abbrev--before-point which only >> looks back one char. > > No, this is because the regexp you have to use must match part of the > text *before* the abbrev. That's why the doc for define-abbrev-table > gives as example \<\(\w+\)\W* rather than just \(\w+\)\W*. Thank you for the clarification. The bug can be closed. > Stefan Leo From unknown Sat Aug 16 00:32:03 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 13 May 2010 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator