GNU bug report logs - #5936
23.1.95; fix a bug in abbrev--before-point

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 5936 in the body.
You can then email your comments to 5936 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 23.1.95; fix a bug in abbrev--before-point
Date: Mon, 12 Apr 2010 16:19:37 +0100

If you use the :regexp property in an abbrev table, all abbrevs in that
table will fail except those with only one char. This is because of a
regexp match in abbrev--before-point which only looks back one char.

BTW, the doc string of looking-back seems irrelevant if by default it
only looks back one char, that can't be slower than looking-at.

diff --git a/lisp/abbrev.el b/lisp/abbrev.el
index b72bdbb..d3b95cb 100644
--- a/lisp/abbrev.el
+++ b/lisp/abbrev.el
@@ -681,7 +681,7 @@ then ABBREV is looked up in that table only."
                              (setq start (point))
                              (forward-word 1)
                              (setq end (min (point) lim)))
-                         (when (looking-back re (line-beginning-position))
+                         (when (looking-back re (line-beginning-position) t)
                            (setq start (match-beginning 1))
                            (setq end   (match-end 1)))))
                      (setq name  (buffer-substring start end))

Message #8 received at 5936 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Leo <sdl.web <at> gmail.com>
Cc: 5936 <at> debbugs.gnu.org
Subject: Re: bug#5936: 23.1.95; fix a bug in abbrev--before-point
Date: Mon, 12 Apr 2010 14:25:16 -0400

> If you use the :regexp property in an abbrev table, all abbrevs in that
> table will fail except those with only one char.

Not at all.  But you may get such a result if you use a naive regexp, yes.

> This is because of a regexp match in abbrev--before-point which only
> looks back one char.

No, this is because the regexp you have to use must match part of the
text *before* the abbrev.  That's why the doc for define-abbrev-table
gives as example \<\(\w+\)\W* rather than just \(\w+\)\W*.


        Stefan

Message #13 received at 5936 <at> debbugs.gnu.org (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 5936 <at> debbugs.gnu.org
Subject: Re: bug#5936: 23.1.95; fix a bug in abbrev--before-point
Date: Thu, 15 Apr 2010 11:15:11 +0100

On 2010-04-12 19:25 +0100, Stefan Monnier wrote:
>> If you use the :regexp property in an abbrev table, all abbrevs in that
>> table will fail except those with only one char.
>
> Not at all.  But you may get such a result if you use a naive regexp, yes.
>
>> This is because of a regexp match in abbrev--before-point which only
>> looks back one char.
>
> No, this is because the regexp you have to use must match part of the
> text *before* the abbrev.  That's why the doc for define-abbrev-table
> gives as example \<\(\w+\)\W* rather than just \(\w+\)\W*.

Thank you for the clarification.

The bug can be closed.

>         Stefan

Leo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.