Subject: Re: [bug#59354] [PATCH] gnu: Add texlive-mathdots.

From: "yarl baudig" <[email-masked]>
Date: Sat, 19 Nov 2022 16:02:10 +0100 (CET)

Hello,

> Thank you. Some comments follow.
> 
> > +  (package
> > +    (inherit (simple-texlive-package
> > +	      "texlive-mathdots"
> 
> Indentation looks wrong here.
I am not sure how it's wrong. Path will follow. Is it better?

> 
> > +              (list "doc/generic/mathdots/"
> > +                    "source/generic/mathdots/"
> > +                    "tex/generic/mathdots/")
> > +              (base32
> > +               "1jaffj343p1chdxs2g7s6lpckvihk0jfw22nw0vmijyjxfiy9yg0")
> > +	      #:trivial? #t))
> 
> This doesn't look like a trivial package since it contains a ".ins"
> file. You need to generate the ".tex" and ".sty" files from it.
> 
I think it is, "tex/generic/mathdots/" in tug repo contains ".tex" and ".sty" and if I compile, they are here.
First texlive package I package. I tried `guix import texlive mathdots` then amended by looking at other texlive packages. Please show me if I am wrong.

> > +   (home-page "https://ctan.org/macros/generic/mathdots")
> > +   (synopsis "Commands to produce dots in math that respect font size")
> > +   (description
> > +    "Redefines \\ddots and \\vdots, and defines \\iddots.  The dots 
> produced by \\iddots
> 
> The first sentence should contain a subject. Also \\ddots ->
> @code{\\dots}
> 
> Could you send an updated patch?
> 
> Regards,
> -- 
> Nicolas Goaziou
> 

Patch is coming, please tell me if it good.