GNU bug report logs - #59354
[PATCH] gnu: Add texlive-mathdots.

Previous Next

Package: guix-patches;

Reported by: Yarl Baudig <yarl-baudig <at> mailoo.org>

Date: Fri, 18 Nov 2022 10:21:02 UTC

Severity: normal

Tags: moreinfo, patch

Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 59354 in the body.
You can then email your comments to 59354 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#59354; Package guix-patches. (Fri, 18 Nov 2022 10:21:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Yarl Baudig <yarl-baudig <at> mailoo.org>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Fri, 18 Nov 2022 10:21:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Yarl Baudig <yarl-baudig <at> mailoo.org>
To: guix-patches <at> gnu.org
Cc: Yarl Baudig <yarl-baudig <at> mailoo.org>
Subject: [PATCH] gnu: Add texlive-mathdots.
Date: Fri, 18 Nov 2022 11:20:10 +0100
* gnu/packages/tex.scm (texlive-mathdots): New variable.
---
 gnu/packages/tex.scm | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/gnu/packages/tex.scm b/gnu/packages/tex.scm
index 81f74f17df..f901d80bf8 100644
--- a/gnu/packages/tex.scm
+++ b/gnu/packages/tex.scm
@@ -3993,6 +3993,25 @@ (define-public texlive-amsmath
 
 (define-deprecated-package texlive-latex-amsmath texlive-amsmath)
 
+(define-public texlive-mathdots
+  (package
+    (inherit (simple-texlive-package
+	      "texlive-mathdots"
+              (list "doc/generic/mathdots/"
+                    "source/generic/mathdots/"
+                    "tex/generic/mathdots/")
+              (base32
+               "1jaffj343p1chdxs2g7s6lpckvihk0jfw22nw0vmijyjxfiy9yg0")
+	      #:trivial? #t))
+   (home-page "https://ctan.org/macros/generic/mathdots")
+   (synopsis "Commands to produce dots in math that respect font size")
+   (description
+    "Redefines \\ddots and \\vdots, and defines \\iddots.  The dots produced by \\iddots
+slant in the opposite direction to \\ddots.  All the commands are designed to
+change size appropriately in scripts, as well as in response to LaTeX size
+changing commands.  The commands may also be used in plain TeX.")
+   (license license:lppl)))
+
 (define-public texlive-amscls
   (let ((template (simple-texlive-package
                    "texlive-amscls"

base-commit: 1bea5d38a26755b84437623c0f48915a77899b57
-- 
2.38.1







Information forwarded to guix-patches <at> gnu.org:
bug#59354; Package guix-patches. (Sat, 19 Nov 2022 09:33:01 GMT) Full text and rfc822 format available.

Message #8 received at 59354 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Yarl Baudig <yarl-baudig <at> mailoo.org>
Cc: 59354 <at> debbugs.gnu.org
Subject: Re: [bug#59354] [PATCH] gnu: Add texlive-mathdots.
Date: Sat, 19 Nov 2022 10:32:07 +0100
Hello,

Yarl Baudig <yarl-baudig <at> mailoo.org> writes:

> * gnu/packages/tex.scm (texlive-mathdots): New variable.

Thank you. Some comments follow.

> +  (package
> +    (inherit (simple-texlive-package
> +	      "texlive-mathdots"

Indentation looks wrong here.

> +              (list "doc/generic/mathdots/"
> +                    "source/generic/mathdots/"
> +                    "tex/generic/mathdots/")
> +              (base32
> +               "1jaffj343p1chdxs2g7s6lpckvihk0jfw22nw0vmijyjxfiy9yg0")
> +	      #:trivial? #t))

This doesn't look like a trivial package since it contains a ".ins"
file. You need to generate the ".tex" and ".sty" files from it.

> +   (home-page "https://ctan.org/macros/generic/mathdots")
> +   (synopsis "Commands to produce dots in math that respect font size")
> +   (description
> +    "Redefines \\ddots and \\vdots, and defines \\iddots.  The dots produced by \\iddots

The first sentence should contain a subject. Also \\ddots ->
@code{\\dots}

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou




Information forwarded to guix-patches <at> gnu.org:
bug#59354; Package guix-patches. (Sat, 19 Nov 2022 15:03:01 GMT) Full text and rfc822 format available.

Message #11 received at 59354 <at> debbugs.gnu.org (full text, mbox):

From: "yarl baudig" <yarl-baudig <at> mailoo.org>
To: mail <at> nicolasgoaziou.fr
Cc: 59354 <at> debbugs.gnu.org
Subject: Re: [bug#59354] [PATCH] gnu: Add texlive-mathdots.
Date: Sat, 19 Nov 2022 16:02:10 +0100 (CET)
Hello,

> Thank you. Some comments follow.
> 
> > +  (package
> > +    (inherit (simple-texlive-package
> > +	      "texlive-mathdots"
> 
> Indentation looks wrong here.
I am not sure how it's wrong. Path will follow. Is it better?

> 
> > +              (list "doc/generic/mathdots/"
> > +                    "source/generic/mathdots/"
> > +                    "tex/generic/mathdots/")
> > +              (base32
> > +               "1jaffj343p1chdxs2g7s6lpckvihk0jfw22nw0vmijyjxfiy9yg0")
> > +	      #:trivial? #t))
> 
> This doesn't look like a trivial package since it contains a ".ins"
> file. You need to generate the ".tex" and ".sty" files from it.
> 
I think it is, "tex/generic/mathdots/" in tug repo contains ".tex" and ".sty" and if I compile, they are here.
First texlive package I package. I tried `guix import texlive mathdots` then amended by looking at other texlive packages. Please show me if I am wrong.

> > +   (home-page "https://ctan.org/macros/generic/mathdots")
> > +   (synopsis "Commands to produce dots in math that respect font size")
> > +   (description
> > +    "Redefines \\ddots and \\vdots, and defines \\iddots.  The dots 
> produced by \\iddots
> 
> The first sentence should contain a subject. Also \\ddots ->
> @code{\\dots}
> 
> Could you send an updated patch?
> 
> Regards,
> -- 
> Nicolas Goaziou
> 

Patch is coming, please tell me if it good.







Information forwarded to guix-patches <at> gnu.org:
bug#59354; Package guix-patches. (Sat, 19 Nov 2022 15:03:02 GMT) Full text and rfc822 format available.

Message #14 received at 59354 <at> debbugs.gnu.org (full text, mbox):

From: "yarl baudig" <yarl-baudig <at> mailoo.org>
To: mail <at> nicolasgoaziou.fr
Cc: 59354 <at> debbugs.gnu.org
Subject: Re: [bug#59354] [PATCH] gnu: Add texlive-mathdots.
Date: Sat, 19 Nov 2022 16:02:43 +0100 (CET)
* gnu/packages/tex.scm (texlive-mathdots): New variable.
---
 gnu/packages/tex.scm | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/gnu/packages/tex.scm b/gnu/packages/tex.scm
index 81f74f17df..e973b30ee0 100644
--- a/gnu/packages/tex.scm
+++ b/gnu/packages/tex.scm
@@ -3993,6 +3993,26 @@ (define-public texlive-amsmath
 
 (define-deprecated-package texlive-latex-amsmath texlive-amsmath)
 
+(define-public texlive-mathdots
+  (package
+    (inherit (simple-texlive-package
+              "texlive-mathdots"
+              (list "doc/generic/mathdots/"
+                    "source/generic/mathdots/"
+                    "tex/generic/mathdots/")
+              (base32
+               "1jaffj343p1chdxs2g7s6lpckvihk0jfw22nw0vmijyjxfiy9yg0")
+              #:trivial? #t))
+    (home-page "https://ctan.org/macros/generic/mathdots")
+    (synopsis "Commands to produce dots in math that respect font size")
+    (description
+     "Mathdots redefines @code{\\ddots} and @code{\\vdots}, and defines
+@code{\\iddots}.  The dots produced by @code{\\iddots} slant in the opposite
+direction to @code{\\ddots}.  All the commands are designed to change size
+appropriately in scripts, as well as in response to LaTeX size changing
+commands.  The commands may also be used in plain TeX.")
+    (license license:lppl)))
+
 (define-public texlive-amscls
   (let ((template (simple-texlive-package
                    "texlive-amscls"

base-commit: 1bea5d38a26755b84437623c0f48915a77899b57
-- 
2.38.1







Information forwarded to guix-patches <at> gnu.org:
bug#59354; Package guix-patches. (Sun, 20 Nov 2022 15:48:02 GMT) Full text and rfc822 format available.

Message #17 received at 59354 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: "yarl baudig" <yarl-baudig <at> mailoo.org>
Cc: 59354 <at> debbugs.gnu.org
Subject: Re: [bug#59354] [PATCH] gnu: Add texlive-mathdots.
Date: Sun, 20 Nov 2022 16:47:39 +0100
Hello,

"yarl baudig" <yarl-baudig <at> mailoo.org> writes:

> I am not sure how it's wrong. Path will follow. Is it better?

It is. Thanks.

>> This doesn't look like a trivial package since it contains a ".ins"
>> file. You need to generate the ".tex" and ".sty" files from it.
>> 
> I think it is, "tex/generic/mathdots/" in tug repo contains ".tex" and ".sty" and if I compile, they are here.
> First texlive package I package. I tried `guix import texlive
> mathdots` then amended by looking at other texlive packages. Please
> show me if I am wrong.

"guix import texlive mathdots" output doesn't include "#:trivial? #t"
for a reason. You need to take a longer path and generate runfiles from
the ".ins" file ; see e.g., "texlive-capt-of".

Regards,
-- 
Nicolas Goaziou




Information forwarded to guix-patches <at> gnu.org:
bug#59354; Package guix-patches. (Sun, 20 Nov 2022 16:25:01 GMT) Full text and rfc822 format available.

Message #20 received at 59354 <at> debbugs.gnu.org (full text, mbox):

From: "yarl baudig" <yarl-baudig <at> mailoo.org>
To: mail <at> nicolasgoaziou.fr
Cc: 59354 <at> debbugs.gnu.org
Subject: Re: [bug#59354] [PATCH] gnu: Add texlive-mathdots.
Date: Sun, 20 Nov 2022 17:24:18 +0100 (CET)
> >> This doesn't look like a trivial package since it contains a ".ins"
> >> file. You need to generate the ".tex" and ".sty" files from it.
> >> 
> > I think it is, "tex/generic/mathdots/" in tug repo contains ".tex" and 
> ".sty" and if I compile, they are here.
> > First texlive package I package. I tried `guix import texlive
> > mathdots` then amended by looking at other texlive packages. Please
> > show me if I am wrong.
> 
> "guix import texlive mathdots" output doesn't include "#:trivial? #t"
> for a reason. You need to take a longer path and generate runfiles from
> the ".ins" file ; see e.g., "texlive-capt-of".
> 
> Regards,
> -- 
> Nicolas Goaziou
> 

Thank you.
I saw that "guix import texlive mathdots" doesn't include "#:trivial? #t" But I still don't see why it is not effectively a trivial package. As I told you, the ".tex" and ".sty" are already in the TUG repo. And with the package as I defined it (as trivial), when you build it, you get the "mathdots.sty" and "mathdots.tex". No need to compile because, whereas there is a ".ins" file,  ".sty" and ".tex" are already compiled and distributed, along the ".ins". Right?







Information forwarded to guix-patches <at> gnu.org:
bug#59354; Package guix-patches. (Sun, 20 Nov 2022 16:48:02 GMT) Full text and rfc822 format available.

Message #23 received at 59354 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: "yarl baudig" <yarl-baudig <at> mailoo.org>
Cc: 59354 <at> debbugs.gnu.org
Subject: Re: [bug#59354] [PATCH] gnu: Add texlive-mathdots.
Date: Sun, 20 Nov 2022 17:46:52 +0100
"yarl baudig" <yarl-baudig <at> mailoo.org> writes:

> I saw that "guix import texlive mathdots" doesn't include "#:trivial?
> #t" But I still don't see why it is not effectively a trivial package.
> As I told you, the ".tex" and ".sty" are already in the TUG repo. And
> with the package as I defined it (as trivial), when you build it, you
> get the "mathdots.sty" and "mathdots.tex". No need to compile because,
> whereas there is a ".ins" file, ".sty" and ".tex" are already compiled
> and distributed, along the ".ins". Right?

Whenever possible, Guix builds packages from source, and avoids using
pre-compiled files. In this case, we can generate ".sty" and ".tex"
files, so let's do that. Does that make sense?




Information forwarded to guix-patches <at> gnu.org:
bug#59354; Package guix-patches. (Sun, 20 Nov 2022 17:17:01 GMT) Full text and rfc822 format available.

Message #26 received at 59354 <at> debbugs.gnu.org (full text, mbox):

From: "yarl baudig" <yarl-baudig <at> mailoo.org>
To: mail <at> nicolasgoaziou.fr
Cc: 59354 <at> debbugs.gnu.org
Subject: Re: [bug#59354] [PATCH] gnu: Add texlive-mathdots.
Date: Sun, 20 Nov 2022 18:16:17 +0100 (CET)
> Whenever possible, Guix builds packages from source, and avoids using
> pre-compiled files. In this case, we can generate ".sty" and ".tex"
> files, so let's do that. Does that make sense?
> 

Yes it does! Thank you. I will try :).







Added tag(s) moreinfo. Request was from Christopher Baines <mail <at> cbaines.net> to control <at> debbugs.gnu.org. (Mon, 21 Nov 2022 13:56:02 GMT) Full text and rfc822 format available.

Information forwarded to guix-patches <at> gnu.org:
bug#59354; Package guix-patches. (Mon, 21 Nov 2022 14:17:02 GMT) Full text and rfc822 format available.

Message #31 received at 59354 <at> debbugs.gnu.org (full text, mbox):

From: Yarl Baudig <yarl-baudig <at> mailoo.org>
To: 59354 <at> debbugs.gnu.org,
	mail <at> nicolasgoaziou.fr
Cc: Yarl Baudig <yarl-baudig <at> mailoo.org>
Subject: [PATCH] gnu: Add texlive-mathdots.
Date: Mon, 21 Nov 2022 15:16:27 +0100
* gnu/packages/tex.scm (texlive-mathdots): New variable.
---
 gnu/packages/tex.scm | 41 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/gnu/packages/tex.scm b/gnu/packages/tex.scm
index 81f74f17df..a600bcae58 100644
--- a/gnu/packages/tex.scm
+++ b/gnu/packages/tex.scm
@@ -3993,6 +3993,47 @@ (define-public texlive-amsmath
 
 (define-deprecated-package texlive-latex-amsmath texlive-amsmath)
 
+(define-public texlive-mathdots
+  (let ((template
+         (simple-texlive-package
+          "texlive-mathdots"
+          (list "doc/generic/mathdots/"
+                "source/generic/mathdots/"
+                "tex/generic/mathdots/")
+          (base32"1jaffj343p1chdxs2g7s6lpckvihk0jfw22nw0vmijyjxfiy9yg0"))))
+    (package
+      (inherit template)
+      (outputs '("out" "doc"))
+      (arguments
+       (substitute-keyword-arguments (package-arguments template)
+         ((#:tex-directory _ '())
+          "generic/mathdots")
+         ((#:build-targets _ '())
+          '(list "mathdots.ins"))
+         ((#:phases phases)
+          #~(modify-phases #$phases
+              (add-after 'unpack 'chdir
+                (lambda _
+                  (chdir "source/generic/mathdots")))
+              (replace 'copy-files
+                (lambda* (#:key inputs outputs #:allow-other-keys)
+                  (let ((origin (assoc-ref inputs "source"))
+                        (source (string-append (assoc-ref outputs "out")
+                                               "/share/texmf-dist/source"))
+                        (doc (string-append (assoc-ref outputs "doc")
+                                            "/share/texmf-dist/doc")))
+                    (copy-recursively (string-append origin "/source") source)
+                    (copy-recursively (string-append origin "/doc") doc))))))))
+      (home-page "https://ctan.org/macros/generic/mathdots")
+      (synopsis "Commands to produce dots in math that respect font size")
+      (description
+       "Mathdots redefines @code{\\ddots} and @code{\\vdots}, and defines
+@code{\\iddots}.  The dots produced by @code{\\iddots} slant in the opposite
+direction to @code{\\ddots}.  All the commands are designed to change size
+appropriately in scripts, as well as in response to LaTeX size changing
+commands.  The commands may also be used in plain TeX.")
+      (license license:lppl))))
+
 (define-public texlive-amscls
   (let ((template (simple-texlive-package
                    "texlive-amscls"

base-commit: 1bea5d38a26755b84437623c0f48915a77899b57
-- 
2.38.1







Reply sent to Nicolas Goaziou <mail <at> nicolasgoaziou.fr>:
You have taken responsibility. (Mon, 21 Nov 2022 22:22:01 GMT) Full text and rfc822 format available.

Notification sent to Yarl Baudig <yarl-baudig <at> mailoo.org>:
bug acknowledged by developer. (Mon, 21 Nov 2022 22:22:02 GMT) Full text and rfc822 format available.

Message #36 received at 59354-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Yarl Baudig <yarl-baudig <at> mailoo.org>
Cc: 59354-done <at> debbugs.gnu.org
Subject: Re: [bug#59354] [PATCH] gnu: Add texlive-mathdots.
Date: Mon, 21 Nov 2022 23:21:33 +0100
Hello,

Yarl Baudig <yarl-baudig <at> mailoo.org> writes:

> * gnu/packages/tex.scm (texlive-mathdots): New variable.

Perfect. Applied. Thank you.

Regards,
-- 
Nicolas Goaziou




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 20 Dec 2022 12:24:12 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 260 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.