GNU bug report logs - #59352
[PATCH] gnu: Add emacs-org-tree-slide.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Sergiu Ivanov <sivanov <at> colimite.fr>
Subject: bug#59352: closed (Re: [bug#59352] [PATCH] gnu: Add
 emacs-org-tree-slide.)
Date: Sat, 19 Nov 2022 09:39:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#59352: [PATCH] gnu: Add emacs-org-tree-slide.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 59352 <at> debbugs.gnu.org.

-- 
59352: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59352
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Sergiu Ivanov <sivanov <at> colimite.fr>
Cc: 59352-done <at> debbugs.gnu.org
Subject: Re: [bug#59352] [PATCH] gnu: Add emacs-org-tree-slide.
Date: Sat, 19 Nov 2022 10:38:00 +0100

Hello,

Sergiu Ivanov <sivanov <at> colimite.fr> writes:

> So, I decided to update the existing definition and improve it according
> to your suggestions.  I attach the new patch.

Great! I applied it with a minor twist explained below.

> Subject: [PATCH] gnu: emacs-org-tree-slide: Update to 2.8.18.
>
> * gnu/packages/emacs-xyz.scm (emacs-org-tree-slide): Update to 2.8.18.

You're updating to the latest commit, which is not exactly "2.8.18", to
"2.8.18-0.d6529bc".

Also, the commit message must include changes you made to synopsis and
description, which could arguably have been done in a subsequent commit,
but that's fine.

> ---
>  gnu/packages/emacs-xyz.scm | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index fe0d9f1dc9..f827107b29 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -18644,11 +18644,11 @@ (define-public emacs-kotlin-mode
>        (license license:gpl3+))))
>  
>  (define-public emacs-org-tree-slide
> -  (let ((commit "036a36eec1cf712d3db155572aed325daa372eb5")
> -        (revision "2"))
> +  (let ((commit "d6529bc2df727d09014e0e56abf4f15a8e8fc20f")
> +        (revision "3"))

The revision is reset to "0" since you bumped the base version. Revision
is here to ensure monotonic growth between version bumps because commit
hashes cannot ensure this. Therefore, it is only useful to increase the
revision number within the same base version.

Thank you!

Regards,
-- 
Nicolas Goaziou

[Message part 3 (message/rfc822, inline)]

From: Sergiu Ivanov <sivanov <at> colimite.fr>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add emacs-org-tree-slide.
Date: Fri, 18 Nov 2022 10:15:02 +0100

[Message part 4 (text/plain, inline)]

Hello,

Here's a patch adding emacs-org-tree-slide.

It's my second Guix package ever, and I actually enjoyed following the
instructions from the manual for building, linting and styling it. Tell
me if I got it right :D

-
Sergiu

[0001-gnu-Add-emacs-org-tree-slide.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.