Subject: bug#59352: closed (Re: [bug#59352] [PATCH] gnu: Add emacs-org-tree-slide.)

From: [email-masked] (GNU bug Tracking System)
Date: Sat, 19 Nov 2022 09:39:02 +0000

Your bug report

#59352: [PATCH] gnu: Add emacs-org-tree-slide.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
59352: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59352
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#59352] [PATCH] gnu: Add emacs-org-tree-slide.
From: Nicolas Goaziou <[email-masked]>
To: Sergiu Ivanov <[email-masked]>
Cc: [email-masked]
Date: Sat, 19 Nov 2022 10:38:00 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello,

Sergiu Ivanov <[email-masked]> writes:

> So, I decided to update the existing definition and improve it according
> to your suggestions.  I attach the new patch.

Great! I applied it with a minor twist explained below.

> Subject: [PATCH] gnu: emacs-org-tree-slide: Update to 2.8.18.
>
> * gnu/packages/emacs-xyz.scm (emacs-org-tree-slide): Update to 2.8.18.

You're updating to the latest commit, which is not exactly "2.8.18", to
"2.8.18-0.d6529bc".

Also, the commit message must include changes you made to synopsis and
description, which could arguably have been done in a subsequent commit,
but that's fine.

> ---
>  gnu/packages/emacs-xyz.scm | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index fe0d9f1dc9..f827107b29 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -18644,11 +18644,11 @@ (define-public emacs-kotlin-mode
>        (license license:gpl3+))))
>  
>  (define-public emacs-org-tree-slide
> -  (let ((commit "036a36eec1cf712d3db155572aed325daa372eb5")
> -        (revision "2"))
> +  (let ((commit "d6529bc2df727d09014e0e56abf4f15a8e8fc20f")
> +        (revision "3"))

The revision is reset to "0" since you bumped the base version. Revision
is here to ensure monotonic growth between version bumps because commit
hashes cannot ensure this. Therefore, it is only useful to increase the
revision number within the same base version.

Thank you!

Regards,
-- 
Nicolas Goaziou

Subject: [PATCH] gnu: Add emacs-org-tree-slide.
From: Sergiu Ivanov <[email-masked]>
To: [email-masked]
Date: Fri, 18 Nov 2022 10:15:02 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello,

Here's a patch adding emacs-org-tree-slide.

It's my second Guix package ever, and I actually enjoyed following the
instructions from the manual for building, linting and styling it. Tell
me if I got it right :D

-
Sergiu
>From 6f53bc504923028c9cae3619192db976a25af4a4 Mon Sep 17 00:00:00 2001
From: Sergiu Ivanov <[email-masked]>
Date: Fri, 18 Nov 2022 10:11:53 +0100
Subject: [PATCH] gnu: Add emacs-org-tree-slide.

---
 gnu/packages/emacs-xyz.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index fe0d9f1dc9..33158f54eb 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -118,6 +118,7 @@
 ;;; Copyright © 2022 Hilton Chain <[email-masked]>
 ;;; Copyright © 2022 Nicolas Graves <[email-masked]>
 ;;; Copyright © 2022 Thiago Jung Bauermann <[email-masked]>
+;;; Copyright © 2022 Sergiu Ivanov <[email-masked]>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -5900,6 +5901,27 @@ (define-public emacs-stripe-buffer
 tables.")
     (license license:gpl2+)))
 
+(define-public emacs-org-tree-slide
+  (package
+    (name "emacs-org-tree-slide")
+    (version "20221016.1623")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://melpa.org/packages/org-tree-slide-"
+                           version ".el"))
+       (sha256
+        (base32 "0pzq43l80i7p1w0ph5az1nxpwpl50ahmi7ql22ai31x7rh1a44fi"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/takaxp/org-tree-slide")
+    (synopsis "Emacs minor mode for giving presentations with Org-mode")
+    (description
+     "This package provides the Org minor mode @code{org-tree-slide} which
+allows for using an Org-mode document in presentations by
+progressively revealing individual subtrees of the document.
+org-tree-slide shows and hides parts of the Org buffer by narrowing.")
+    (license license:gpl3)))
+
 (define-public emacs-org-beautify-theme
   ;; Latest release (0.4) is not tagged, use commit hash.
   (let ((commit "df6a1114fda313e1689363e196c8284fbe2a2738")
-- 
2.38.1